Skip to contentSkip to conversation

samples/bpf: drop unnecessary fallthrough

PATCH In review Andrii Nakryiko 2 participants 2 messages May 16, 2023 BPF

lore
Share & tools
lore

Andrii Nakryiko

author maintainer
#0 lore raw

PATCH v2 1/1 samples/bpf: drop unnecessary fallthrough

__fallthrough is now not supported. Instead of renaming it to now-canonical ([0]) fallthrough pseudo-keyword, just get rid of it and equate 'h' case to default case, as both emit usage information and succeed.

[0] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

---
 samples/bpf/hbm.c | 1 -
 1 file changed, 1 deletion(-)
samples/bpf/hbm.c +0 -1
index 6448b7826107..bf66277115e2 100644
@@ -498,7 +498,6 @@ int main(int argc, char **argv)
 					"Option -%c requires an argument.\n\n",
 					optopt);
 		case 'h':
-			__fallthrough;
 		default:
 			Usage();
 			return 0;
Signature · 1 line
2.34.1
Acked-by on v2 1/1
#1 lore raw
Quoted 8 lines · Andrii Nakryiko

__fallthrough is now not supported. Instead of renaming it to now-canonical ([0]) fallthrough pseudo-keyword, just get rid of it and equate 'h' case to default case, as both emit usage information and succeed.

[0] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through