dt-bindings: hwmon: add MAX31827
Subsystems (3)
PATCH v9 1/2 dt-bindings: hwmon: add MAX31827
MAX31827 is a low-power temperature switch with I2C interface.
The device is a ±1°C accuracy from -40°C to +125°C (12 bits) local temperature switch and sensor with I2C/SM- Bus interface. The combination of small 6-bump wafer-lev- el package (WLP) and high accuracy makes this temper- ature sensor/switch ideal for a wide range of applications.
---
v8 -> v9: Removed the '--base' option when using 'git format-patch'
I really hope it will be ok this way...
.../bindings/hwmon/adi,max31827.yaml | 54 +++++++++++++++++++
MAINTAINERS | 7 +++ 2 files changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
Documentation/devicetree/bindings/hwmon/adi,max31827.yaml new file +54 -0
@@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/adi,max31827.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices MAX31827, MAX31828, MAX31829 Low-Power Temperature Switch + +maintainers: + - Daniel Matyas <[email protected]> + +description: | + Analog Devices MAX31827, MAX31828, MAX31829 Low-Power Temperature Switch with + I2C Interface + https://www.analog.com/media/en/technical-documentation/data-sheets/MAX31827-MAX31829.pdf + +properties: + compatible: + oneOf: + - const: adi,max31827 + - items: + - enum: + - adi,max31828 + - adi,max31829 + - const: adi,max31827 + + reg: + maxItems: 1 + + vref-supply: + description: + Must have values in the interval (1.6V; 3.6V) in order for the device to + function correctly. + +required: + - compatible + - reg + - vref-supply + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + temperature-sensor@42 { + compatible = "adi,max31827"; + reg = <0x42>; + vref-supply = <®_vdd>; + }; + }; +...
MAINTAINERS +7 -0
@@ -12617,6 +12617,13 @@ F: Documentation/userspace-api/media/drivers/max2175.rst F: drivers/media/i2c/max2175* F: include/uapi/linux/max2175.h +MAX31827 TEMPERATURE SWITCH DRIVER +M: Daniel Matyas <[email protected]> +L: [email protected] +S: Supported +W: http://ez.analog.com/community/linux-device-drivers +F: Documentation/devicetree/bindings/hwmon/adi,max31827.yaml + MAX6650 HARDWARE MONITOR AND FAN CONTROLLER DRIVER L: [email protected] S: Orphan
Signature · 1 line
2.34.1
PATCH v9 2/2 hwmon: max31827: add MAX31827 driver
MAX31827 is a low-power temperature switch with I2C interface.
The device is a ±1°C accuracy from -40°C to +125°C (12 bits) local temperature switch and sensor with I2C/SM- Bus interface. The combination of small 6-bump wafer-lev- el package (WLP) and high accuracy makes this temper- ature sensor/switch ideal for a wide range of applications.
--- Documentation/hwmon/index.rst | 1 + Documentation/hwmon/max31827.rst | 90 ++++++ MAINTAINERS | 2 + drivers/hwmon/Kconfig | 11 + drivers/hwmon/Makefile | 2 +- drivers/hwmon/max31827.c | 466 +++++++++++++++++++++++++++++++ 6 files changed, 571 insertions(+), 1 deletion(-) create mode 100644 Documentation/hwmon/max31827.rst create mode 100644 drivers/hwmon/max31827.c
Documentation/hwmon/index.rst +1 -0
@@ -140,6 +140,7 @@ Hardware Monitoring Kernel Drivers max31760 max31785 max31790 + max31827 max34440 max6620 max6639
Documentation/hwmon/max31827.rst new file +90 -0
90 lines not on this page · raw message
MAINTAINERS +2 -0
@@ -12623,6 +12623,8 @@ L: [email protected] S: Supported W: http://ez.analog.com/community/linux-device-drivers F: Documentation/devicetree/bindings/hwmon/adi,max31827.yaml +F: Documentation/hwmon/max31827.rst +F: drivers/hwmon/max31827.c MAX6650 HARDWARE MONITOR AND FAN CONTROLLER DRIVER L: [email protected]
drivers/hwmon/Kconfig +11 -0
@@ -1097,6 +1097,17 @@ config SENSORS_MAX31760 This driver can also be built as a module. If so, the module will be called max31760. +config MAX31827 + tristate "MAX31827 low-power temperature switch and similar devices" + depends on I2C + select REGMAP_I2C + help + If you say yes here you get support for MAX31827, MAX31828 and + MAX31829 low-power temperature switches and sensors connected with I2C. + + This driver can also be built as a module. If so, the module + will be called max31827. + config SENSORS_MAX6620 tristate "Maxim MAX6620 fan controller" depends on I2C
drivers/hwmon/Makefile +1 -1
@@ -149,6 +149,7 @@ obj-$(CONFIG_SENSORS_MAX6642) += max6642.o obj-$(CONFIG_SENSORS_MAX6650) += max6650.o obj-$(CONFIG_SENSORS_MAX6697) += max6697.o obj-$(CONFIG_SENSORS_MAX31790) += max31790.o +obj-$(CONFIG_MAX31827) += max31827.o obj-$(CONFIG_SENSORS_MC13783_ADC)+= mc13783-adc.o obj-$(CONFIG_SENSORS_MC34VR500) += mc34vr500.o obj-$(CONFIG_SENSORS_MCP3021) += mcp3021.o
@@ -224,4 +225,3 @@ obj-$(CONFIG_SENSORS_PECI) += peci/ obj-$(CONFIG_PMBUS) += pmbus/ ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG -
drivers/hwmon/max31827.c new file +466 -0
466 lines not on this page · raw message
Signature · 1 line
2.34.1
Guenter Roeck
maintainerRe: [PATCH v9 2/2] hwmon: max31827: add MAX31827 driver
Quoted 8 lines · Daniel Matyas
MAX31827 is a low-power temperature switch with I2C interface.
The device is a ±1°C accuracy from -40°C to +125°C (12 bits) local temperature switch and sensor with I2C/SM- Bus interface. The combination of small 6-bump wafer-lev- el package (WLP) and high accuracy makes this temper- ature sensor/switch ideal for a wide range of applications.
Quoted 4 lines
Signed-off-by Daniel Matyas <[email protected]>Reported-by kernel test robot <[email protected]>---
Change log goes here. Without it, I'll have to manually re-review and compare against previous versions and look up comments to ensure that all feedback has been addressed. That will take time, which is always
scarce. don't have right now. My apologies, but that means that
review and acceptance of your driver will be delayed.
Guenter
RE: [PATCH v9 2/2] hwmon: max31827: add MAX31827 driver
-----Original Message-----
From: Guenter Roeck <[email protected]> On Behalf Of Guenter Roeck
Sent: Monday, May 22, 2023 4:25 PM
To: Matyas, Daniel <[email protected]>
Cc: kernel test robot <[email protected]>; Jean Delvare <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; Jonathan Corbet <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v9 2/2] hwmon: max31827: add MAX31827 driver
[External]
Quoted 8 lines · Daniel Matyas
MAX31827 is a low-power temperature switch with I2C interface.
The device is a ±1°C accuracy from -40°C to +125°C
(12 bits) local temperature switch and sensor with I2C/SM- Bus interface. The combination of small 6-bump wafer-lev- el package (WLP) and high accuracy makes this temper- ature sensor/switch ideal for a wide range of applications.
Quoted 7 lines
Signed-off-by Daniel Matyas <[email protected]>Reported-by kernel test robot <[email protected]>Link:
https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/2023
[email protected]/__;!!A3Ni8CS0y2Y!5SeqSdRyCHcgA6Se6U-EN I_MJfRPgB-FEVkuwWyb944DQypaZ5XQAS6N3aZiVDd1LZDGK45xp7KJHH8RSzw$
---
Change log goes here. Without it, I'll have to manually re-review and compare against previous versions and look up comments to ensure that all feedback has been addressed. That will take time, which is always
scarce. don't have right now. My apologies, but that means that
review and acceptance of your driver will be delayed.
Guenter
Dear Guenter,
I didn't write a changelog, because I changed literally nothing in the code. I sent a new patch, because in the previous Krzysztof Kozlowski asked me to remove the '--base' when using 'git format-patch'. I wrote this to commit 1/2, but consider it necessary to write the same thing again in patch 2/2.
I have the Reported-by flag, because I forgot to add it in patch v8.
I am sorry for the confusion!
Best regards,
Daniel Matyas
Guenter Roeck
maintainerRe: [PATCH v9 2/2] hwmon: max31827: add MAX31827 driver
Quoted 32 lines · Daniel
-----Original Message-----
From: Guenter Roeck <[email protected]> On Behalf Of Guenter Roeck
Sent: Monday, May 22, 2023 4:25 PM
To: Matyas, Daniel <[email protected]>
Cc: kernel test robot <[email protected]>; Jean Delvare <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; Jonathan Corbet <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v9 2/2] hwmon: max31827: add MAX31827 driver[External]
Quoted 8 lines · Daniel Matyas
MAX31827 is a low-power temperature switch with I2C interface.
The device is a ±1°C accuracy from -40°C to +125°C
(12 bits) local temperature switch and sensor with I2C/SM- Bus interface. The combination of small 6-bump wafer-lev- el package (WLP) and high accuracy makes this temper- ature sensor/switch ideal for a wide range of applications.Quoted 7 lines
Signed-off-by Daniel Matyas <[email protected]>Reported-by kernel test robot <[email protected]>Link:
https://urldefense.com/v3/__https://lore.kernel.org/oe-kbuild-all/2023
[email protected]/__;!!A3Ni8CS0y2Y!5SeqSdRyCHcgA6Se6U-EN I_MJfRPgB-FEVkuwWyb944DQypaZ5XQAS6N3aZiVDd1LZDGK45xp7KJHH8RSzw$
---Change log goes here. Without it, I'll have to manually re-review and compare against previous versions and look up comments to ensure that all feedback has been addressed. That will take time, which is always
scarce. don't have right now. My apologies, but that means that
review and acceptance of your driver will be delayed.
Quoted 7 lines
Guenter
Dear Guenter,
I didn't write a changelog, because I changed literally nothing in the code. I sent a new patch, because in the previous Krzysztof Kozlowski asked me to remove the '--base' when using 'git format-patch'. I wrote this to commit 1/2, but consider it necessary to write the same thing again in patch 2/2.
In that case the appropriate change log would have been "no change against v8", or "unchanged". Also, the change log should really include all changes since v1, separated for each version.
v9: No change
v8: xxx
v7: yyy
...
Guenter
Quoted 6 lines
I have the Reported-by flag, because I forgot to add it in patch v8.
I am sorry for the confusion!
Best regards,
Daniel Matyas