irqchip: ftintc010: mark all function static
Subsystems (3)
PATCH 1/5 irqchip: ftintc010: mark all function static
From: Arnd Bergmann <[email protected]>
Two functions were always global but never had any callers outside of this file:
drivers/irqchip/irq-ftintc010.c:128:39: error: no previous prototype for 'ft010_irqchip_handle_irq' drivers/irqchip/irq-ftintc010.c:165:12: error: no previous prototype for 'ft010_of_init_irq'
--- drivers/irqchip/irq-ftintc010.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/irqchip/irq-ftintc010.c +2 -2
@@ -125,7 +125,7 @@ static struct irq_chip ft010_irq_chip = {/* Local static for the IRQ entry call */ static struct ft010_irq_data firq; -asmlinkage void __exception_irq_entry ft010_irqchip_handle_irq(struct pt_regs *regs) +static asmlinkage void __exception_irq_entry ft010_irqchip_handle_irq(struct pt_regs *regs) {struct ft010_irq_data *f = &firq;int irq;
@@ -162,7 +162,7 @@ static const struct irq_domain_ops ft010_irqdomain_ops = { .xlate = irq_domain_xlate_onetwocell, }; -int __init ft010_of_init_irq (struct device_node *node, +static int __init ft010_of_init_irq (struct device_node *node,struct device_node *parent) {struct ft010_irq_data *f = &firq;
Signature · 1 line
2.39.2
PATCH 2/5 irqchip: mmp: remove non-DT codepath
From: Arnd Bergmann <[email protected]>
Building with "W=1" warns about missing declarations for two functions in the mmp irqchip driver:
drivers/irqchip/irq-mmp.c:248:13: error: no previous prototype for 'icu_init_irq' drivers/irqchip/irq-mmp.c:271:13: error: no previous prototype for 'mmp2_init_icu'
The declarations are present in an unused header, but since there is no caller, it's best to just remove the functions and the header completely, making the driver DT-only to match the state of the platform.
--- drivers/irqchip/irq-mmp.c | 127 ------------------------------------ include/linux/irqchip/mmp.h | 10 --- 2 files changed, 137 deletions(-) delete mode 100644 include/linux/irqchip/mmp.h
drivers/irqchip/irq-mmp.c +0 -127
@@ -244,132 +244,6 @@ static void __exception_irq_entry mmp2_handle_irq(struct pt_regs *regs)generic_handle_domain_irq (icu_data[0 ].domain, hwirq); } -/* MMP (ARMv5) */ -void __init icu_init_irq (void ) -{ -int irq; - - max_icu_nr =1 ; - mmp_icu_base =ioremap (0xd4282000 ,0x1000 ); - icu_data[0 ].conf_enable = mmp_conf.conf_enable; - icu_data[0 ].conf_disable = mmp_conf.conf_disable; - icu_data[0 ].conf_mask = mmp_conf.conf_mask; - icu_data[0 ].nr_irqs =64 ; - icu_data[0 ].virq_base =0 ; - icu_data[0 ].domain =irq_domain_add_legacy (NULL ,64 ,0 ,0 , - &irq_domain_simple_ops, - &icu_data[0 ]); -for (irq =0 ; irq <64 ; irq++) { -icu_mask_irq (irq_get_irq_data (irq)); -irq_set_chip_and_handler (irq, &icu_irq_chip, handle_level_irq); - } -irq_set_default_host (icu_data[0 ].domain); -set_handle_irq (mmp_handle_irq); -} - -/* MMP2 (ARMv7) */ -void __init mmp2_init_icu (void ) -{ -int irq, end; - - max_icu_nr =8 ; - mmp_icu_base =ioremap (0xd4282000 ,0x1000 ); - icu_data[0 ].conf_enable = mmp2_conf.conf_enable; - icu_data[0 ].conf_disable = mmp2_conf.conf_disable; - icu_data[0 ].conf_mask = mmp2_conf.conf_mask; - icu_data[0 ].nr_irqs =64 ; - icu_data[0 ].virq_base =0 ; - icu_data[0 ].domain =irq_domain_add_legacy (NULL ,64 ,0 ,0 , - &irq_domain_simple_ops, - &icu_data[0 ]); - icu_data[1 ].reg_status = mmp_icu_base +0x150 ; - icu_data[1 ].reg_mask = mmp_icu_base +0x168 ; - icu_data[1 ].clr_mfp_irq_base = icu_data[0 ].virq_base + - icu_data[0 ].nr_irqs; - icu_data[1 ].clr_mfp_hwirq =1 ;/* offset to IRQ_MMP2_PMIC_BASE */ - icu_data[1 ].nr_irqs =2 ; - icu_data[1 ].cascade_irq =4 ; - icu_data[1 ].virq_base = icu_data[0 ].virq_base + icu_data[0 ].nr_irqs; - icu_data[1 ].domain =irq_domain_add_legacy (NULL , icu_data[1 ].nr_irqs, - icu_data[1 ].virq_base,0 , - &irq_domain_simple_ops, - &icu_data[1 ]); - icu_data[2 ].reg_status = mmp_icu_base +0x154 ; - icu_data[2 ].reg_mask = mmp_icu_base +0x16c ; - icu_data[2 ].nr_irqs =2 ; - icu_data[2 ].cascade_irq =5 ; - icu_data[2 ].virq_base = icu_data[1 ].virq_base + icu_data[1 ].nr_irqs; - icu_data[2 ].domain =irq_domain_add_legacy (NULL , icu_data[2 ].nr_irqs, - icu_data[2 ].virq_base,0 , - &irq_domain_simple_ops, - &icu_data[2 ]); - icu_data[3 ].reg_status = mmp_icu_base +0x180 ; - icu_data[3 ].reg_mask = mmp_icu_base +0x17c ; - icu_data[3 ].nr_irqs =3 ; - icu_data[3 ].cascade_irq =9 ; - icu_data[3 ].virq_base = icu_data[2 ].virq_base + icu_data[2 ].nr_irqs; - icu_data[3 ].domain =irq_domain_add_legacy (NULL , icu_data[3 ].nr_irqs, - icu_data[3 ].virq_base,0 , - &irq_domain_simple_ops, - &icu_data[3 ]); - icu_data[4 ].reg_status = mmp_icu_base +0x158 ; - icu_data[4 ].reg_mask = mmp_icu_base +0x170 ; - icu_data[4 ].nr_irqs =5 ; - icu_data[4 ].cascade_irq =17 ; - icu_data[4 ].virq_base = icu_data[3 ].virq_base + icu_data[3 ].nr_irqs; - icu_data[4 ].domain =irq_domain_add_legacy (NULL , icu_data[4 ].nr_irqs, - icu_data[4 ].virq_base,0 , - &irq_domain_simple_ops, - &icu_data[4 ]); - icu_data[5 ].reg_status = mmp_icu_base +0x15c ; - icu_data[5 ].reg_mask = mmp_icu_base +0x174 ; - icu_data[5 ].nr_irqs =15 ; - icu_data[5 ].cascade_irq =35 ; - icu_data[5 ].virq_base = icu_data[4 ].virq_base + icu_data[4 ].nr_irqs; - icu_data[5 ].domain =irq_domain_add_legacy (NULL , icu_data[5 ].nr_irqs, - icu_data[5 ].virq_base,0 , - &irq_domain_simple_ops, - &icu_data[5 ]); - icu_data[6 ].reg_status = mmp_icu_base +0x160 ; - icu_data[6 ].reg_mask = mmp_icu_base +0x178 ; - icu_data[6 ].nr_irqs =2 ; - icu_data[6 ].cascade_irq =51 ; - icu_data[6 ].virq_base = icu_data[5 ].virq_base + icu_data[5 ].nr_irqs; - icu_data[6 ].domain =irq_domain_add_legacy (NULL , icu_data[6 ].nr_irqs, - icu_data[6 ].virq_base,0 , - &irq_domain_simple_ops, - &icu_data[6 ]); - icu_data[7 ].reg_status = mmp_icu_base +0x188 ; - icu_data[7 ].reg_mask = mmp_icu_base +0x184 ; - icu_data[7 ].nr_irqs =2 ; - icu_data[7 ].cascade_irq =55 ; - icu_data[7 ].virq_base = icu_data[6 ].virq_base + icu_data[6 ].nr_irqs; - icu_data[7 ].domain =irq_domain_add_legacy (NULL , icu_data[7 ].nr_irqs, - icu_data[7 ].virq_base,0 , - &irq_domain_simple_ops, - &icu_data[7 ]); - end = icu_data[7 ].virq_base + icu_data[7 ].nr_irqs; -for (irq =0 ; irq < end; irq++) { -icu_mask_irq (irq_get_irq_data (irq)); -if (irq == icu_data[1 ].cascade_irq || - irq == icu_data[2 ].cascade_irq || - irq == icu_data[3 ].cascade_irq || - irq == icu_data[4 ].cascade_irq || - irq == icu_data[5 ].cascade_irq || - irq == icu_data[6 ].cascade_irq || - irq == icu_data[7 ].cascade_irq) { -irq_set_chip (irq, &icu_irq_chip); -irq_set_chained_handler (irq, icu_mux_irq_demux); - }else { -irq_set_chip_and_handler (irq, &icu_irq_chip, - handle_level_irq); - } - } -irq_set_default_host (icu_data[0 ].domain); -set_handle_irq (mmp2_handle_irq); -} - -#ifdef CONFIG_OF static int __init mmp_init_bases (struct device_node *node) {int ret, nr_irqs, irq, i =0 ;
@@ -548,4 +422,3 @@ static int __init mmp2_mux_of_init(struct device_node *node,return -EINVAL ; }IRQCHIP_DECLARE (mmp2_mux_intc,"mrvl,mmp2-mux-intc" , mmp2_mux_of_init); -#endif
include/linux/irqchip/mmp.h deleted +0 -10
@@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#ifndef __IRQCHIP_MMP_H -#define __IRQCHIP_MMP_H - -extern struct irq_chip icu_irq_chip; - -extern void icu_init_irq (void ); -extern void mmp2_init_icu (void ); - -#endif /* __IRQCHIP_MMP_H */
Signature · 1 line
2.39.2
[irqchip: irq/irqchip-next] irqchip/mmp: Remove non-DT codepath
The following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: f1771b85e3086c9506c3de81e993330bca568ba5 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/f1771b85e3086c9506c3de81e993330bca568ba5 Author: Arnd Bergmann <[email protected]> AuthorDate: Tue, 16 May 2023 22:05:05 +02:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Sat, 17 Jun 2023 07:21:02 +01:00
irqchip/mmp: Remove non-DT codepath
Building with "W=1" warns about missing declarations for two functions in the mmp irqchip driver:
drivers/irqchip/irq-mmp.c:248:13: error: no previous prototype for 'icu_init_irq' drivers/irqchip/irq-mmp.c:271:13: error: no previous prototype for 'mmp2_init_icu'
The declarations are present in an unused header, but since there is no caller, it's best to just remove the functions and the header completely, making the driver DT-only to match the state of the platform.
--- drivers/irqchip/irq-mmp.c | 127 +----------------------------------- include/linux/irqchip/mmp.h | 10 +--- 2 files changed, 137 deletions(-) delete mode 100644 include/linux/irqchip/mmp.h
drivers/irqchip/irq-mmp.c +0 -127
@@ -244,132 +244,6 @@ static void __exception_irq_entry mmp2_handle_irq(struct pt_regs *regs)generic_handle_domain_irq (icu_data[0 ].domain, hwirq); } -/* MMP (ARMv5) */ -void __init icu_init_irq (void ) -{ -int irq; - - max_icu_nr =1 ; - mmp_icu_base =ioremap (0xd4282000 ,0x1000 ); - icu_data[0 ].conf_enable = mmp_conf.conf_enable; - icu_data[0 ].conf_disable = mmp_conf.conf_disable; - icu_data[0 ].conf_mask = mmp_conf.conf_mask; - icu_data[0 ].nr_irqs =64 ; - icu_data[0 ].virq_base =0 ; - icu_data[0 ].domain =irq_domain_add_legacy (NULL ,64 ,0 ,0 , - &irq_domain_simple_ops, - &icu_data[0 ]); -for (irq =0 ; irq <64 ; irq++) { -icu_mask_irq (irq_get_irq_data (irq)); -irq_set_chip_and_handler (irq, &icu_irq_chip, handle_level_irq); - } -irq_set_default_host (icu_data[0 ].domain); -set_handle_irq (mmp_handle_irq); -} - -/* MMP2 (ARMv7) */ -void __init mmp2_init_icu (void ) -{ -int irq, end; - - max_icu_nr =8 ; - mmp_icu_base =ioremap (0xd4282000 ,0x1000 ); - icu_data[0 ].conf_enable = mmp2_conf.conf_enable; - icu_data[0 ].conf_disable = mmp2_conf.conf_disable; - icu_data[0 ].conf_mask = mmp2_conf.conf_mask; - icu_data[0 ].nr_irqs =64 ; - icu_data[0 ].virq_base =0 ; - icu_data[0 ].domain =irq_domain_add_legacy (NULL ,64 ,0 ,0 , - &irq_domain_simple_ops, - &icu_data[0 ]); - icu_data[1 ].reg_status = mmp_icu_base +0x150 ; - icu_data[1 ].reg_mask = mmp_icu_base +0x168 ; - icu_data[1 ].clr_mfp_irq_base = icu_data[0 ].virq_base + - icu_data[0 ].nr_irqs; - icu_data[1 ].clr_mfp_hwirq =1 ;/* offset to IRQ_MMP2_PMIC_BASE */ - icu_data[1 ].nr_irqs =2 ; - icu_data[1 ].cascade_irq =4 ; - icu_data[1 ].virq_base = icu_data[0 ].virq_base + icu_data[0 ].nr_irqs; - icu_data[1 ].domain =irq_domain_add_legacy (NULL , icu_data[1 ].nr_irqs, - icu_data[1 ].virq_base,0 , - &irq_domain_simple_ops, - &icu_data[1 ]); - icu_data[2 ].reg_status = mmp_icu_base +0x154 ; - icu_data[2 ].reg_mask = mmp_icu_base +0x16c ; - icu_data[2 ].nr_irqs =2 ; - icu_data[2 ].cascade_irq =5 ; - icu_data[2 ].virq_base = icu_data[1 ].virq_base + icu_data[1 ].nr_irqs; - icu_data[2 ].domain =irq_domain_add_legacy (NULL , icu_data[2 ].nr_irqs, - icu_data[2 ].virq_base,0 , - &irq_domain_simple_ops, - &icu_data[2 ]); - icu_data[3 ].reg_status = mmp_icu_base +0x180 ; - icu_data[3 ].reg_mask = mmp_icu_base +0x17c ; - icu_data[3 ].nr_irqs =3 ; - icu_data[3 ].cascade_irq =9 ; - icu_data[3 ].virq_base = icu_data[2 ].virq_base + icu_data[2 ].nr_irqs; - icu_data[3 ].domain =irq_domain_add_legacy (NULL , icu_data[3 ].nr_irqs, - icu_data[3 ].virq_base,0 , - &irq_domain_simple_ops, - &icu_data[3 ]); - icu_data[4 ].reg_status = mmp_icu_base +0x158 ; - icu_data[4 ].reg_mask = mmp_icu_base +0x170 ; - icu_data[4 ].nr_irqs =5 ; - icu_data[4 ].cascade_irq =17 ; - icu_data[4 ].virq_base = icu_data[3 ].virq_base + icu_data[3 ].nr_irqs; - icu_data[4 ].domain =irq_domain_add_legacy (NULL , icu_data[4 ].nr_irqs, - icu_data[4 ].virq_base,0 , - &irq_domain_simple_ops, - &icu_data[4 ]); - icu_data[5 ].reg_status = mmp_icu_base +0x15c ; - icu_data[5 ].reg_mask = mmp_icu_base +0x174 ; - icu_data[5 ].nr_irqs =15 ; - icu_data[5 ].cascade_irq =35 ; - icu_data[5 ].virq_base = icu_data[4 ].virq_base + icu_data[4 ].nr_irqs; - icu_data[5 ].domain =irq_domain_add_legacy (NULL , icu_data[5 ].nr_irqs, - icu_data[5 ].virq_base,0 , - &irq_domain_simple_ops, - &icu_data[5 ]); - icu_data[6 ].reg_status = mmp_icu_base +0x160 ; - icu_data[6 ].reg_mask = mmp_icu_base +0x178 ; - icu_data[6 ].nr_irqs =2 ; - icu_data[6 ].cascade_irq =51 ; - icu_data[6 ].virq_base = icu_data[5 ].virq_base + icu_data[5 ].nr_irqs; - icu_data[6 ].domain =irq_domain_add_legacy (NULL , icu_data[6 ].nr_irqs, - icu_data[6 ].virq_base,0 , - &irq_domain_simple_ops, - &icu_data[6 ]); - icu_data[7 ].reg_status = mmp_icu_base +0x188 ; - icu_data[7 ].reg_mask = mmp_icu_base +0x184 ; - icu_data[7 ].nr_irqs =2 ; - icu_data[7 ].cascade_irq =55 ; - icu_data[7 ].virq_base = icu_data[6 ].virq_base + icu_data[6 ].nr_irqs; - icu_data[7 ].domain =irq_domain_add_legacy (NULL , icu_data[7 ].nr_irqs, - icu_data[7 ].virq_base,0 , - &irq_domain_simple_ops, - &icu_data[7 ]); - end = icu_data[7 ].virq_base + icu_data[7 ].nr_irqs; -for (irq =0 ; irq < end; irq++) { -icu_mask_irq (irq_get_irq_data (irq)); -if (irq == icu_data[1 ].cascade_irq || - irq == icu_data[2 ].cascade_irq || - irq == icu_data[3 ].cascade_irq || - irq == icu_data[4 ].cascade_irq || - irq == icu_data[5 ].cascade_irq || - irq == icu_data[6 ].cascade_irq || - irq == icu_data[7 ].cascade_irq) { -irq_set_chip (irq, &icu_irq_chip); -irq_set_chained_handler (irq, icu_mux_irq_demux); - }else { -irq_set_chip_and_handler (irq, &icu_irq_chip, - handle_level_irq); - } - } -irq_set_default_host (icu_data[0 ].domain); -set_handle_irq (mmp2_handle_irq); -} - -#ifdef CONFIG_OF static int __init mmp_init_bases (struct device_node *node) {int ret, nr_irqs, irq, i =0 ;
@@ -548,4 +422,3 @@ err:return -EINVAL ; }IRQCHIP_DECLARE (mmp2_mux_intc,"mrvl,mmp2-mux-intc" , mmp2_mux_of_init); -#endif
include/linux/irqchip/mmp.h deleted +0 -10
@@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ -#ifndef __IRQCHIP_MMP_H -#define __IRQCHIP_MMP_H - -extern struct irq_chip icu_irq_chip; - -extern void icu_init_irq (void ); -extern void mmp2_init_icu (void ); - -#endif /* __IRQCHIP_MMP_H */
PATCH 3/5 irqchip: clps711x: remove unused clps711x_intc_init() function
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
This function has no caller or declaration any more:
drivers/irqchip/irq-clps711x.c:215:13: error: no previous prototype for 'clps711x_intc_init'
The #ifdef check around clps711x_intc_init_dt() is also not needed since the file is only built when that is enabled.
--- drivers/irqchip/irq-clps711x.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/irqchip/irq-clps711x.c +0 -7
@@ -212,12 +212,6 @@ static int __init _clps711x_intc_init(struct device_node *np,return err; } -void __init clps711x_intc_init (phys_addr_t base,resource_size_t size) -{ -BUG_ON (_clps711x_intc_init (NULL , base, size)); -} - -#ifdef CONFIG_IRQCHIP static int __init clps711x_intc_init_dt (struct device_node *np,struct device_node *parent) {
@@ -231,4 +225,3 @@ static int __init clps711x_intc_init_dt(struct device_node *np,return _clps711x_intc_init (np, res.start,resource_size (&res)); }IRQCHIP_DECLARE (clps711x,"cirrus,ep7209-intc" , clps711x_intc_init_dt); -#endif
Signature · 1 line
2.39.2
[irqchip: irq/irqchip-next] irqchip/clps711x: Remove unused clps711x_intc_init() function
The following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: eee284fe8f326719fed1963e0851cbb2185076f8 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/eee284fe8f326719fed1963e0851cbb2185076f8 Author: Arnd Bergmann <[email protected]> AuthorDate: Tue, 16 May 2023 22:05:06 +02:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Sat, 17 Jun 2023 07:21:08 +01:00
irqchip/clps711x: Remove unused clps711x_intc_init() function
This function has no caller or declaration any more:
drivers/irqchip/irq-clps711x.c:215:13: error: no previous prototype for 'clps711x_intc_init'
The #ifdef check around clps711x_intc_init_dt() is also not needed since the file is only built when that is enabled.
--- drivers/irqchip/irq-clps711x.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/irqchip/irq-clps711x.c +0 -7
@@ -212,12 +212,6 @@ out_kfree:return err; } -void __init clps711x_intc_init (phys_addr_t base,resource_size_t size) -{ -BUG_ON (_clps711x_intc_init (NULL , base, size)); -} - -#ifdef CONFIG_IRQCHIP static int __init clps711x_intc_init_dt (struct device_node *np,struct device_node *parent) {
@@ -231,4 +225,3 @@ static int __init clps711x_intc_init_dt(struct device_node *np,return _clps711x_intc_init (np, res.start,resource_size (&res)); }IRQCHIP_DECLARE (clps711x,"cirrus,ep7209-intc" , clps711x_intc_init_dt); -#endif
PATCH 4/5 irqchip: mxs: include linux/irqchip/mxs.h
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
This header contains the definition for icoll_handle_irq(), which is used in arch/arm/mach-mxs/mach-mxs.c, without this we get a warning about a missing prototype when building with W=1.
--- drivers/irqchip/irq-mxs.c | 1 + 1 file changed, 1 insertion(+)
drivers/irqchip/irq-mxs.c +1 -0
@@ -9,6 +9,7 @@#include <linux/init.h> #include <linux/irq.h> #include <linux/irqchip.h> +#include <linux/irqchip/mxs.h> #include <linux/irqdomain.h> #include <linux/io.h> #include <linux/of.h>
Signature · 1 line
2.39.2
Re: [PATCH 4/5] irqchip: mxs: include linux/irqchip/mxs.h
Quoted 7 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
This header contains the definition for
icoll_handle_irq(), which is used inarch/arm/mach-mxs/mach-mxs.c, without this we get a warning about a missing prototype when building with W=1.Signed-off-by Arnd Bergmann <[email protected]>
Quoted 19 lines
--- drivers/irqchip/irq-mxs.c | 1 + 1 file changed, 1 insertion(+)drivers/irqchip/irq-mxs.c +1
-0@@ -9,6 +9,7 @@#include <linux/init.h> #include <linux/irq.h> #include <linux/irqchip.h> +#include <linux/irqchip/mxs.h> #include <linux/irqdomain.h> #include <linux/io.h> #include <linux/of.h> Signature · 1 line
2.39.2
[irqchip: irq/irqchip-next] irqchip/mxs: Include linux/irqchip/mxs.h
In reply to Arnd BergmannThe following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 5b7e5676209120814dbb9fec8bc3769f0f7a7958 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/5b7e5676209120814dbb9fec8bc3769f0f7a7958 Author: Arnd Bergmann <[email protected]> AuthorDate: Tue, 16 May 2023 22:05:07 +02:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Sat, 17 Jun 2023 07:21:15 +01:00
irqchip/mxs: Include linux/irqchip/mxs.h
This header contains the definition for icoll_handle_irq(), which is used in arch/arm/mach-mxs/mach-mxs.c, without this we get a warning about a missing prototype when building with W=1.
--- drivers/irqchip/irq-mxs.c | 1 + 1 file changed, 1 insertion(+)
drivers/irqchip/irq-mxs.c +1 -0
@@ -9,6 +9,7 @@#include <linux/init.h> #include <linux/irq.h> #include <linux/irqchip.h> +#include <linux/irqchip/mxs.h> #include <linux/irqdomain.h> #include <linux/io.h> #include <linux/of.h>
PATCH 5/5 irqchip: gicv3: add a iort_pmsi_get_dev_id() prototype
In reply to Arnd BergmannFrom: Arnd Bergmann <[email protected]>
iort_pmsi_get_dev_id() has a __weak definition in the driver, and an override in arm64 specific code, but the declaration is conditional and not always seen when the copy in the driver gets built:
drivers/irqchip/irq-gic-v3-its-platform-msi.c:41:12: error: no previous prototype for 'iort_pmsi_get_dev_id' [-Werror=missing-prototypes]
Move the existing declaration out of the #ifdef block to ensure it can be seen in all configurations.
--- include/linux/acpi_iort.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
include/linux/acpi_iort.h +2 -1
@@ -26,13 +26,14 @@ int iort_register_domain_token(int trans_id, phys_addr_t base, struct fwnode_handle *fw_node);void iort_deregister_domain_token (int trans_id);struct fwnode_handle *iort_find_domain_token (int trans_id); +int iort_pmsi_get_dev_id (struct device *dev,u32 *dev_id); +#ifdef CONFIG_ACPI_IORT void acpi_iort_init (void );u32 iort_msi_map_id (struct device *dev,u32 id);struct irq_domain *iort_get_device_domain (struct device *dev,u32 id,enum irq_domain_bus_token bus_token);void acpi_configure_pmsi_domain (struct device *dev); -int iort_pmsi_get_dev_id (struct device *dev,u32 *dev_id);void iort_get_rmr_sids (struct fwnode_handle *iommu_fwnode,struct list_head *head); void iort_put_rmr_sids(struct fwnode_handle *iommu_fwnode,
Signature · 1 line
2.39.2
Re: [PATCH 5/5] irqchip: gicv3: add a iort_pmsi_get_dev_id() prototype
Quoted 26 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
iort_pmsi_get_dev_id()has a__weakdefinition in the driver, and an override in arm64 specific code, but the declaration is conditional and not always seen when the copy in the driver gets built:
drivers/irqchip/irq-gic-v3-its-platform-msi.c:41:12: error: no previous prototype for 'iort_pmsi_get_dev_id' [-Werror=missing-prototypes]Move the existing declaration out of the #ifdef block to ensure it can be seen in all configurations.
Signed-off-by Arnd Bergmann <[email protected]>--- include/linux/acpi_iort.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)include/linux/acpi_iort.h +2
-0@@ -26,13 +26,14 @@ int iort_register_domain_token(int trans_id, phys_addr_t base, struct fwnode_handle *fw_node);void iort_deregister_domain_token (int trans_id);struct fwnode_handle *iort_find_domain_token (int trans_id); +int iort_pmsi_get_dev_id (struct device *dev,u32 *dev_id); +
include/linux/acpi_iort.h int iort_register_domain_token(int trans_id, phys_addr_t base, · line 39
Quoted 10 lines
include/linux/acpi_iort.h +0
-1#ifdef CONFIG_ACPI_IORT void acpi_iort_init (void );u32 iort_msi_map_id (struct device *dev,u32 id);struct irq_domain *iort_get_device_domain (struct device *dev,u32 id,enum irq_domain_bus_token bus_token);void acpi_configure_pmsi_domain (struct device *dev); -int iort_pmsi_get_dev_id (struct device *dev,u32 *dev_id);void iort_get_rmr_sids (struct fwnode_handle *iommu_fwnode,struct list_head *head); void iort_put_rmr_sids(struct fwnode_handle *iommu_fwnode,
Thanks
Hanjun
[irqchip: irq/irqchip-next] irqchip/gicv3: Add a iort_pmsi_get_dev_id() prototype
In reply to Arnd BergmannThe following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 415e84294798d1cb041c902168393054cc4ad211 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/415e84294798d1cb041c902168393054cc4ad211 Author: Arnd Bergmann <[email protected]> AuthorDate: Tue, 16 May 2023 22:05:08 +02:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Sat, 17 Jun 2023 07:21:24 +01:00
irqchip/gicv3: Add a iort_pmsi_get_dev_id() prototype
iort_pmsi_get_dev_id() has a __weak definition in the driver, and an override in arm64 specific code, but the declaration is conditional and not always seen when the copy in the driver gets built:
drivers/irqchip/irq-gic-v3-its-platform-msi.c:41:12: error: no previous prototype for 'iort_pmsi_get_dev_id' [-Werror=missing-prototypes]
Move the existing declaration out of the #ifdef block to ensure it can be seen in all configurations.
--- include/linux/acpi_iort.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
include/linux/acpi_iort.h +2 -1
@@ -26,13 +26,14 @@ int iort_register_domain_token(int trans_id, phys_addr_t base, struct fwnode_handle *fw_node);void iort_deregister_domain_token (int trans_id);struct fwnode_handle *iort_find_domain_token (int trans_id); +int iort_pmsi_get_dev_id (struct device *dev,u32 *dev_id); +#ifdef CONFIG_ACPI_IORT void acpi_iort_init (void );u32 iort_msi_map_id (struct device *dev,u32 id);struct irq_domain *iort_get_device_domain (struct device *dev,u32 id,enum irq_domain_bus_token bus_token);void acpi_configure_pmsi_domain (struct device *dev); -int iort_pmsi_get_dev_id (struct device *dev,u32 *dev_id);void iort_get_rmr_sids (struct fwnode_handle *iommu_fwnode,struct list_head *head); void iort_put_rmr_sids(struct fwnode_handle *iommu_fwnode,
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Two functions were always global but never had any callers outside of this file:
drivers/irqchip/irq-ftintc010.c:128:39: error: no previous prototype for 'ft010_irqchip_handle_irq'drivers/irqchip/irq-ftintc010.c:165:12: error: no previous prototype for 'ft010_of_init_irq'Fixes b4d3053c8ce9 ("irqchip: Add a driver for Cortina Gemini")Signed-off-by Arnd Bergmann <[email protected]>
It's a leftover from when this was called from boardfile code.
Yours,
Linus Walleij
[irqchip: irq/irqchip-next] irqchip/ftintc010: Mark all function static
In reply to Arnd BergmannThe following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 97bb0f8e847c0ea6bf926c4e3b7633dd6acfabf2 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/97bb0f8e847c0ea6bf926c4e3b7633dd6acfabf2 Author: Arnd Bergmann <[email protected]> AuthorDate: Tue, 16 May 2023 22:05:04 +02:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Sat, 17 Jun 2023 07:20:52 +01:00
irqchip/ftintc010: Mark all function static
Two functions were always global but never had any callers outside of this file:
drivers/irqchip/irq-ftintc010.c:128:39: error: no previous prototype for 'ft010_irqchip_handle_irq' drivers/irqchip/irq-ftintc010.c:165:12: error: no previous prototype for 'ft010_of_init_irq'
--- drivers/irqchip/irq-ftintc010.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/irqchip/irq-ftintc010.c +2 -2
@@ -125,7 +125,7 @@ static struct irq_chip ft010_irq_chip = {/* Local static for the IRQ entry call */ static struct ft010_irq_data firq; -asmlinkage void __exception_irq_entry ft010_irqchip_handle_irq(struct pt_regs *regs) +static asmlinkage void __exception_irq_entry ft010_irqchip_handle_irq(struct pt_regs *regs) {struct ft010_irq_data *f = &firq;int irq;
@@ -162,7 +162,7 @@ static const struct irq_domain_ops ft010_irqdomain_ops = { .xlate = irq_domain_xlate_onetwocell, }; -int __init ft010_of_init_irq (struct device_node *node, +static int __init ft010_of_init_irq (struct device_node *node,struct device_node *parent) {struct ft010_irq_data *f = &firq;