Skip to contentSkip to conversation

mm/hugetlb: remove hugetlb_page_subpool()

PATCH Applied Sidhartha Kumar 3 participants 3 messages May 16, 2023 – May 17, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/hugetlb: remove hugetlb_page_subpool()

All users of hugetlb_page_subpool() have been converted to use the folio equivalent. This function can be safely removed.

---
 include/linux/hugetlb.h | 13 -------------
 1 file changed, 13 deletions(-)
include/linux/hugetlb.h +0 -13
index b2b698f9a2ecb..21f942025fecd 100644
@@ -755,14 +755,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
 	return folio->_hugetlb_subpool;
 }
 
-/*
- * hugetlb page subpool pointer located in hpage[2].hugetlb_subpool
- */
-static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
-{
-	return hugetlb_folio_subpool(page_folio(hpage));
-}
-
 static inline void hugetlb_set_folio_subpool(struct folio *folio,
 					struct hugepage_subpool *subpool)
 {
@@ -1029,11 +1021,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
 	return NULL;
 }
 
-static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
-{
-	return NULL;
-}
-
 static inline int isolate_or_dissolve_huge_page(struct page *page,
 						struct list_head *list)
 {
Signature · 1 line
2.40.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Sidhartha Kumar

All users of hugetlb_page_subpool() have been converted to use the folio equivalent. This function can be safely removed.

---
 include/linux/hugetlb.h | 13 -------------
 1 file changed, 13 deletions(-)

Thanks!

Signature · 1 line
Mike Kravetz
Quoted 35 lines
include/linux/hugetlb.h +0 -13
index b2b698f9a2ecb..21f942025fecd 100644
@@ -755,14 +755,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
 	return folio->_hugetlb_subpool;
 }
 
-/*
- * hugetlb page subpool pointer located in hpage[2].hugetlb_subpool
- */
-static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
-{
-	return hugetlb_folio_subpool(page_folio(hpage));
-}
-
 static inline void hugetlb_set_folio_subpool(struct folio *folio,
 					struct hugepage_subpool *subpool)
 {
@@ -1029,11 +1021,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
 	return NULL;
 }
 
-static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
-{
-	return NULL;
-}
-
 static inline int isolate_or_dissolve_huge_page(struct page *page,
 						struct list_head *list)
 {
Signature · 1 line
2.40.1
Reviewed-by on v1 1/1
#2 lore raw
In reply to Sidhartha Kumar
Quoted 29 lines · Sidhartha Kumar

All users of hugetlb_page_subpool() have been converted to use the folio equivalent. This function can be safely removed.

---
  include/linux/hugetlb.h | 13 -------------
  1 file changed, 13 deletions(-)
include/linux/hugetlb.h +0 -8
index b2b698f9a2ecb..21f942025fecd 100644
@@ -755,14 +755,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
  	return folio->_hugetlb_subpool;
  }
 
-/*
- * hugetlb page subpool pointer located in hpage[2].hugetlb_subpool
- */
-static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
-{
-	return hugetlb_folio_subpool(page_folio(hpage));
-}
-
  static inline void hugetlb_set_folio_subpool(struct folio *folio,
  					struct hugepage_subpool *subpool)
  {
@@ -1029,11 +1021,6 @@ static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio
  	return NULL;

include/linux/hugetlb.h static inline struct hugepage_subpool *hugetlb_folio_subpool(struct folio *folio · line 1026

Quoted 10 lines
include/linux/hugetlb.h +0 -5
  }
 
-static inline struct hugepage_subpool *hugetlb_page_subpool(struct page *hpage)
-{
-	return NULL;
-}
-
  static inline int isolate_or_dissolve_huge_page(struct page *page,
  						struct list_head *list)
  {
Signature · 3 lines
Thanks,

David / dhildenb