Skip to contentSkip to conversation

gpio: sa1100: include <mach/generic.h>

PATCH In review Arnd Bergmann 2 participants 2 messages May 17, 2023 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 gpio: sa1100: include <mach/generic.h>

From: Arnd Bergmann <[email protected]>

sa1100_init_gpio() is declared in a machine specific header so it can be called from platform code, but the definition is in the device driver, which causes a warning:

drivers/gpio/gpio-sa1100.c:310:13: error: no previous prototype for 'sa1100_init_gpio' [-Werror=missing-prototypes]

It's already possible to include mach/generic.h from drivers, so add this one here as well.

---
v2: rebase back on mainline tree

---
 drivers/gpio/gpio-sa1100.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-sa1100.c +1 -0
index edff5e81489f..242dad763ac4 100644
@@ -12,6 +12,7 @@
 #include <soc/sa1100/pwer.h>
 #include <mach/hardware.h>
 #include <mach/irqs.h>
+#include <mach/generic.h>
 
 struct sa1100_gpio_chip {
 	struct gpio_chip chip;
Signature · 1 line
2.39.2
#1 lore raw
Quoted 32 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

sa1100_init_gpio() is declared in a machine specific header so it can be called from platform code, but the definition is in the device driver, which causes a warning:

drivers/gpio/gpio-sa1100.c:310:13: error: no previous prototype for 'sa1100_init_gpio' [-Werror=missing-prototypes]

It's already possible to include mach/generic.h from drivers, so add this one here as well.

---
v2: rebase back on mainline tree

---
 drivers/gpio/gpio-sa1100.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-sa1100.c +1 -1
index edff5e81489f..242dad763ac4 100644
@@ -12,6 +12,7 @@
 #include <soc/sa1100/pwer.h>
 #include <mach/hardware.h>
 #include <mach/irqs.h>
+#include <mach/generic.h>
 
 struct sa1100_gpio_chip {
        struct gpio_chip chip;
--
Quoted 2 lines

2.39.2

Now applied, thanks!

Bart