scsi: aacraid: Replace all non-returning strlcpy with strscpy
Subsystems (2)
PATCH 1/1 scsi: aacraid: Replace all non-returning strlcpy with strscpy
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
--- drivers/scsi/aacraid/aachba.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/aacraid/aachba.c +1 -1
@@ -3289,7 +3289,7 @@ static int query_disk(struct aac_dev *dev, void __user *arg)else qd.unmapped =0 ; -strlcpy (qd.name, fsa_dev_ptr[qd.cnum].devname, +strscpy (qd.name, fsa_dev_ptr[qd.cnum].devname,min (sizeof (qd.name),sizeof (fsa_dev_ptr[qd.cnum].devname) +1 ));if (copy_to_user (arg, &qd,sizeof (struct aac_query_disk )))
Quoted 8 lines · Azeem Shaikh
strlcpy()reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to removestrlcpy()completely [2], replacestrlcpy()here withstrscpy().
No return values were used, so direct replacement is safe.
Quoted 4 lines
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89Signed-off-by Azeem Shaikh <[email protected]>
Signature · 1 line
Kees Cook
Kees Cook
AppliedQuoted 9 lines · Azeem Shaikh
strlcpy()reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to removestrlcpy()completely [2], replacestrlcpy()here withstrscpy().
No return values were used, so direct replacement is safe.[...]
Applied to for-next/hardening, thanks!
[1/1] scsi: aacraid: Replace all non-returning strlcpy with strscpy
https://git.kernel.org/kees/c/d966a54946cc
Signature · 1 line
Kees Cook