Skip to contentSkip to conversation

Mystery dtb check errors with ti,x-plate-ohms with txt only binding

DISCUSSION Tony Lindgren 2 participants 3 messages May 19, 2023 – May 23, 2023

lore
Share & tools
lore
#0 lore raw

Hi,

Somehow the ti,x-plate-ohms property produces errors for nodes with the compatible only in a txt binding that still uses /bits/ 16 value:

ti,x-plate-ohms: size (2) error for type uint32-array

For the yaml bindings, we have ti,xplate-ohms so far only defined in Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml.

So for example, compatible = "ti,tsc2046" that only has a txt binding in Documentation/devicetree/bindings/input/touchscreen/ads7846.txt still produces warnings somehow based on the ti,tsc2005.yaml?

Any ideas why this is happening?

Regards,

Tony

#1 lore raw

Hi,

Quoted 5 lines · Tony Lindgren

Somehow the ti,x-plate-ohms property produces errors for nodes with the compatible only in a txt binding that still uses /bits/ 16 value:

ti,x-plate-ohms: size (2) error for type uint32-array

Quoted 8 lines

For the yaml bindings, we have ti,xplate-ohms so far only defined in Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml.

So for example, compatible = "ti,tsc2046" that only has a txt binding in Documentation/devicetree/bindings/input/touchscreen/ads7846.txt still produces warnings somehow based on the ti,tsc2005.yaml?

Any ideas why this is happening?

-ohms is a standard unit suffix and thus the property gets the type auto-assigned:

https://github.com/robherring/dt-schema/blob/master/schemas/property-units.yaml#L64

-- Sebastian

#2 lore raw
Quoted 15 lines · Sebastian Reichel

Hi,

Quoted 12 lines · Tony Lindgren

Somehow the ti,x-plate-ohms property produces errors for nodes with the compatible only in a txt binding that still uses /bits/ 16 value:

ti,x-plate-ohms: size (2) error for type uint32-array

For the yaml bindings, we have ti,xplate-ohms so far only defined in Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml.

So for example, compatible = "ti,tsc2046" that only has a txt binding in Documentation/devicetree/bindings/input/touchscreen/ads7846.txt still produces warnings somehow based on the ti,tsc2005.yaml?

Quoted 6 lines
Quoted 1 line

Any ideas why this is happening?

-ohms is a standard unit suffix and thus the property gets the type auto-assigned:

https://github.com/robherring/dt-schema/blob/master/schemas/property-units.yaml#L64

OK thanks makes sense. Seems like the drivers should be fixed to just parse uint32, then the bindings should be updated to use yaml.

Regards,

Tony