nvme-pci : redundancies in nvme_alloc_queue and nvme_init_queue
PATCH 1/1 nvme-pci : redundancies in nvme_alloc_queue and nvme_init_queue
--- drivers/nvme/host/pci.c | 3 --- 1 file changed, 3 deletions(-)
drivers/nvme/host/pci.c +0 -3
@@ -1533,9 +1533,6 @@ static int nvme_alloc_queue(struct nvme_dev *dev, int qid, int depth) nvmeq->dev = dev;spin_lock_init (&nvmeq->sq_lock);spin_lock_init (&nvmeq->cq_poll_lock); - nvmeq->cq_head =0 ; - nvmeq->cq_phase =1 ; - nvmeq->q_db = &dev->dbs[qid *2 * dev->db_stride]; nvmeq->qid = qid; dev->ctrl.queue_count++;
Signature · 1 line
2.39.2
Jens Axboe
maintainerQuoted 10 lines · Irvin Cote
Signed-off-by Irvin Cote <[email protected]>--- drivers/nvme/host/pci.c | 3 --- 1 file changed, 3 deletions(-)drivers/nvme/host/pci.c +0
-0
drivers/nvme/host/pci.c static int nvme_alloc_queue(struct nvme_dev *dev, int qid, int depth) · line 1537
Quoted 8 lines
drivers/nvme/host/pci.c +0
-3@@ -1533,9 +1533,6 @@ static int nvme_alloc_queue(struct nvme_dev *dev, int qid, int depth) nvmeq->dev = dev;spin_lock_init (&nvmeq->sq_lock);spin_lock_init (&nvmeq->cq_poll_lock); - nvmeq->cq_head =0 ; - nvmeq->cq_phase =1 ; - nvmeq->q_db = &dev->dbs[qid *2 * dev->db_stride]; nvmeq->qid = qid; dev->ctrl.queue_count++;
Please put an actual commit message in here, any commit should have an explanation of WHY the change is being made. Your subject line is NOT enough, detail exactly why this is redundant.
From a quick look the patch does look fine, but I'm not going to ack a patch that doesn't have a good commit message.
Signature · 1 line
Jens Axboe
Hi, I am really confused I had written one and apparently it didn't go through, my apologies.
I will resend it
Quoted 32 lines · Jens Axboe
Quoted 10 lines · Irvin Cote
Signed-off-by Irvin Cote <[email protected]>--- drivers/nvme/host/pci.c | 3 --- 1 file changed, 3 deletions(-)drivers/nvme/host/pci.c +0
-0drivers/nvme/host/pci.c static int nvme_alloc_queue(struct nvme_dev *dev, int qid, int depth) · line 1537
Quoted 8 lines
drivers/nvme/host/pci.c +0
-3@@ -1533,9 +1533,6 @@ static int nvme_alloc_queue(struct nvme_dev *dev, int qid, int depth) nvmeq->dev = dev;spin_lock_init (&nvmeq->sq_lock);spin_lock_init (&nvmeq->cq_poll_lock); - nvmeq->cq_head =0 ; - nvmeq->cq_phase =1 ; - nvmeq->q_db = &dev->dbs[qid *2 * dev->db_stride]; nvmeq->qid = qid; dev->ctrl.queue_count++;Please put an actual commit message in here, any commit should have an explanation of WHY the change is being made. Your subject line is NOT enough, detail exactly why this is redundant.
From a quick look the patch does look fine, but I'm not going to ack a patch that doesn't have a good commit message.
--
Jens Axboe