Skip to contentSkip to conversation

mtd: spi-nor: Initialize n_banks for spi_nor_generic_flash

PATCH In review Mika Westerberg 2 participants 2 messages May 23, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: spi-nor: Initialize n_banks for spi_nor_generic_flash

If the flash chip in question is using spi_nor_generic_flash for flash_info this results a division by zero during spi_nor_scan() because its n_banks is 0.

Fix this by initializing n_banks for spi_nor_generic_flash to 1.

Fixes 9d6c5d64f028 ("mtd: spi-nor: Introduce the concept of bank")
---
 drivers/mtd/spi-nor/core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/spi-nor/core.c +1 -0
index 0bb0ad14a2fc..94fc4f6d0844 100644
@@ -2024,6 +2024,7 @@ static const struct flash_info spi_nor_generic_flash = {
 	 */
 	.page_size = 256,
 	.parse_sfdp = true,
+	.n_banks = 1,
 };
 
 static const struct flash_info *spi_nor_match_id(struct spi_nor *nor,
Signature · 6 lines
2.39.2


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
#1 lore raw

Thanks, Mika,

Miquel already queued a similar fix:
https://lore.kernel.org/linux-mtd/[email protected]/T/#m2d00f6d6bfb6298a6e8d81a4795d69db1e3c9505
cheers,
ta

Quoted 18 lines · Mika Westerberg

If the flash chip in question is using spi_nor_generic_flash for flash_info this results a division by zero during spi_nor_scan() because its n_banks is 0.

Fix this by initializing n_banks for spi_nor_generic_flash to 1.

Fixes 9d6c5d64f028 ("mtd: spi-nor: Introduce the concept of bank")
---
 drivers/mtd/spi-nor/core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/spi-nor/core.c +0 -0
index 0bb0ad14a2fc..94fc4f6d0844 100644

drivers/mtd/spi-nor/core.c static const struct flash_info spi_nor_generic_flash = { · line 2030

Quoted 7 lines
drivers/mtd/spi-nor/core.c +1 -0
@@ -2024,6 +2024,7 @@ static const struct flash_info spi_nor_generic_flash = {
 	 */
 	.page_size = 256,
 	.parse_sfdp = true,
+	.n_banks = 1,
 };
 
 static const struct flash_info *spi_nor_match_id(struct spi_nor *nor,

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/