i915: Move display identification/probing under display/
Subsystems (3)
v3 cover i915: Move display identification/probing under display/
Since i915's display code will soon be shared by two DRM drivers (i915 and Xe), it makes sense for the display code itself to be responsible for recognizing the platform it's running on rather than relying on the making the top-level DRM driver handle this. This also becomes more important for all platforms MTL and beyond where we're not really supposed to identify platform behavior by PCI device ID anymore, but rather by the hardware IP version reported by the device through the GMD_ID register.
This series creates a more well-defined split between display and non-display deviceinfo/runtimeinfo and then moves the definition of the display-specific feature flags under the display/ code. Finally, it switches MTL (and all future platforms), to select the display feature flags based on the hardware's GMD_ID identification.
v2:
- Move DISPLAY_INFO() definition one patch earlier. (Andrzej)
- Rename display's runtime default structure to __runtime_defaults to make it more clear what the purpose is. (Andrzej)
- Simplify copy of runtime defaults to per-device runtime data. (Andrzej)
- Fix uninitialized ptr use on error path during device probe. (lkp)
- Add extra patch moving display-specific feature test macros to display/intel_display_device.h
v3:
- Use DISPLAY_INFO() in a few more places. (Andrzej)
- Redefine INTEL_VGA_DEVICE/INTEL_QUANTA_DEVICE in display probe to simplify code.
- Minor style cleanups (empty struct init syntax, explicit memcpy rather than "=," pass drm_i915_private instead of drm_device, whitespace/alignment tweaks, etc).
Matt Roper (6):
drm/i915/display: Move display device info to header under display/ drm/i915: Convert INTEL_INFO()->display to a pointer drm/i915/display: Move display runtime info to display structure drm/i915/display: Make display responsible for probing its own IP drm/i915/display: Handle GMD_ID identification in display code drm/i915/display: Move feature test macros to intel_display_device.h
drivers/gpu/drm/i915/Makefile | 2 + drivers/gpu/drm/i915/display/intel_color.c | 31 +- drivers/gpu/drm/i915/display/intel_crtc.c | 2 +- drivers/gpu/drm/i915/display/intel_cursor.c | 4 +- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_display.h | 10 +- .../drm/i915/display/intel_display_device.c | 775 ++++++++++++++++++ .../drm/i915/display/intel_display_device.h | 128 +++ .../drm/i915/display/intel_display_power.c | 6 +- .../drm/i915/display/intel_display_reg_defs.h | 14 +- drivers/gpu/drm/i915/display/intel_fb_pin.c | 2 +- drivers/gpu/drm/i915/display/intel_fbc.c | 6 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- drivers/gpu/drm/i915/display/intel_hti.c | 2 +- .../drm/i915/display/skl_universal_plane.c | 2 +- drivers/gpu/drm/i915/display/skl_watermark.c | 8 +- drivers/gpu/drm/i915/i915_driver.c | 17 +- drivers/gpu/drm/i915/i915_drv.h | 65 +- drivers/gpu/drm/i915/i915_pci.c | 382 +-------- drivers/gpu/drm/i915/i915_reg.h | 33 - drivers/gpu/drm/i915/intel_device_info.c | 116 +-- drivers/gpu/drm/i915/intel_device_info.h | 67 +- drivers/gpu/drm/i915/intel_step.c | 8 +- 23 files changed, 1043 insertions(+), 641 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_display_device.c create mode 100644 drivers/gpu/drm/i915/display/intel_display_device.h
Signature · 1 line
2.40.1
PATCH v3 1/6 drm/i915/display: Move display device info to header under display/
Moving display-specific substructure definitions will help keep display more self-contained and make it easier to re-use in other drivers (i.e., Xe) in the future.
--- .../drm/i915/display/intel_display_device.h | 60 +++++++++++++++++++ drivers/gpu/drm/i915/intel_device_info.h | 49 +-------------- 2 files changed, 62 insertions(+), 47 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_display_device.h
drivers/gpu/drm/i915/display/intel_display_device.h new file +60 -0
@@ -0,0 +1,60 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2023 Intel Corporation +*/ + +#ifndef __INTEL_DISPLAY_DEVICE_H__ +#define __INTEL_DISPLAY_DEVICE_H__ + +#include <linux/types.h> + +#include "display/intel_display_limits.h" + +#define DEV_INFO_DISPLAY_FOR_EACH_FLAG (func) \ +/* Keep in alphabetical order */ \ + func(cursor_needs_physical); \ + func(has_cdclk_crawl); \ + func(has_cdclk_squash); \ + func(has_ddi); \ + func(has_dp_mst); \ + func(has_dsb); \ + func(has_fpga_dbg); \ + func(has_gmch); \ + func(has_hotplug); \ + func(has_hti); \ + func(has_ipc); \ + func(has_overlay); \ + func(has_psr); \ + func(has_psr_hw_tracking); \ + func(overlay_needs_physical); \ + func(supports_tv); + +struct intel_display_device_info { +u8 abox_mask; + +struct { +u16 size;/* in blocks */ +u8 slice_mask; + } dbuf; + +#define DEFINE_FLAG (name) u8 name:1 +DEV_INFO_DISPLAY_FOR_EACH_FLAG (DEFINE_FLAG); +#undef DEFINE_FLAG + +/* Global register offset for the display engine */ +u32 mmio_offset; + +/* Register offsets for the various display pipes and transcoders */ +u32 pipe_offsets[I915_MAX_TRANSCODERS ]; +u32 trans_offsets[I915_MAX_TRANSCODERS ]; +u32 cursor_offsets[I915_MAX_PIPES ]; + +struct { +u32 degamma_lut_size; +u32 gamma_lut_size; +u32 degamma_lut_tests; +u32 gamma_lut_tests; + } color; +}; + +#endif
drivers/gpu/drm/i915/intel_device_info.h +2 -47
67 lines not on this page · raw message
Signature · 1 line
2.40.1
PATCH v3 2/6 drm/i915: Convert INTEL_INFO()->display to a pointer
In reply to Matt RoperRather than embeddeding the display's device info within the main device info structure, just provide a pointer to the display-specific structure. This is in preparation for moving the display device info definitions into the display code itself and for eventually allowing the pointer to be assigned at runtime on platforms that use GMD_ID for device identification.
In the future, this will also eventually allow the same display device info structures to be used outside the current i915 code (e.g., from the Xe driver).
v2:
- Move introduction of DISPLAY_INFO() to this patch. (Andrzej)
v3:
- Also use DISPLAY_INFO() in intel_display_reg_defs.h. (Andrzej)
- Use "{}" instead of "{ 0 }" for empty struct init. (Jani)
--- drivers/gpu/drm/i915/display/intel_color.c | 31 +- drivers/gpu/drm/i915/display/intel_cursor.c | 2 +- drivers/gpu/drm/i915/display/intel_display.h | 2 +- .../drm/i915/display/intel_display_power.c | 6 +- .../drm/i915/display/intel_display_reg_defs.h | 14 +- drivers/gpu/drm/i915/display/intel_fb_pin.c | 2 +- drivers/gpu/drm/i915/display/intel_hti.c | 2 +- drivers/gpu/drm/i915/display/skl_watermark.c | 8 +- drivers/gpu/drm/i915/i915_drv.h | 29 +- drivers/gpu/drm/i915/i915_pci.c | 579 ++++++++++++------ drivers/gpu/drm/i915/intel_device_info.c | 6 +- drivers/gpu/drm/i915/intel_device_info.h | 2 +- 12 files changed, 452 insertions(+), 231 deletions(-)
drivers/gpu/drm/i915/display/intel_color.c +16 -15
@@ -1824,14 +1824,14 @@ static u32 intel_gamma_lut_tests(const struct intel_crtc_state *crtc_state)if (lut_is_legacy (gamma_lut))return 0 ; -return INTEL_INFO (i915)->display.color.gamma_lut_tests; +return DISPLAY_INFO (i915)->color.gamma_lut_tests; }static u32 intel_degamma_lut_tests (const struct intel_crtc_state *crtc_state) {struct drm_i915_private *i915 =to_i915 (crtc_state->uapi.crtc->dev); -return INTEL_INFO (i915)->display.color.degamma_lut_tests; +return DISPLAY_INFO (i915)->color.degamma_lut_tests; }static int intel_gamma_lut_size (const struct intel_crtc_state *crtc_state)
@@ -1842,14 +1842,14 @@ static int intel_gamma_lut_size(const struct intel_crtc_state *crtc_state)if (lut_is_legacy (gamma_lut))return LEGACY_LUT_LENGTH ; -return INTEL_INFO (i915)->display.color.gamma_lut_size; +return DISPLAY_INFO (i915)->color.gamma_lut_size; }static u32 intel_degamma_lut_size (const struct intel_crtc_state *crtc_state) {struct drm_i915_private *i915 =to_i915 (crtc_state->uapi.crtc->dev); -return INTEL_INFO (i915)->display.color.degamma_lut_size; +return DISPLAY_INFO (i915)->color.degamma_lut_size; }static int check_lut_size (const struct drm_property_blob *lut,int expected)
@@ -2321,7 +2321,7 @@ static int glk_assign_luts(struct intel_crtc_state *crtc_state)struct drm_property_blob *gamma_lut; gamma_lut =create_resized_lut (i915, crtc_state->hw.gamma_lut, -INTEL_INFO (i915)->display.color.degamma_lut_size, +DISPLAY_INFO (i915)->color.degamma_lut_size, false);if (IS_ERR (gamma_lut))return PTR_ERR (gamma_lut);
@@ -2855,7 +2855,7 @@ static struct drm_property_blob *i9xx_read_lut_8(struct intel_crtc *crtc)static struct drm_property_blob *i9xx_read_lut_10 (struct intel_crtc *crtc) {struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); -u32 lut_size =INTEL_INFO (dev_priv)->display.color.gamma_lut_size; +u32 lut_size =DISPLAY_INFO (dev_priv)->color.gamma_lut_size;enum pipe pipe = crtc->pipe;struct drm_property_blob *blob;struct drm_color_lut *lut;
@@ -2904,7 +2904,7 @@ static void i9xx_read_luts(struct intel_crtc_state *crtc_state)static struct drm_property_blob *i965_read_lut_10p6 (struct intel_crtc *crtc) {struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); -int i, lut_size =INTEL_INFO (dev_priv)->display.color.gamma_lut_size; +int i, lut_size =DISPLAY_INFO (dev_priv)->color.gamma_lut_size;enum pipe pipe = crtc->pipe;struct drm_property_blob *blob;struct drm_color_lut *lut;
@@ -2954,7 +2954,7 @@ static void i965_read_luts(struct intel_crtc_state *crtc_state)static struct drm_property_blob *chv_read_cgm_degamma (struct intel_crtc *crtc) {struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); -int i, lut_size =INTEL_INFO (dev_priv)->display.color.degamma_lut_size; +int i, lut_size =DISPLAY_INFO (dev_priv)->color.degamma_lut_size;enum pipe pipe = crtc->pipe;struct drm_property_blob *blob;struct drm_color_lut *lut;
@@ -2980,7 +2980,7 @@ static struct drm_property_blob *chv_read_cgm_degamma(struct intel_crtc *crtc)static struct drm_property_blob *chv_read_cgm_gamma (struct intel_crtc *crtc) {struct drm_i915_private *i915 =to_i915 (crtc->base.dev); -int i, lut_size =INTEL_INFO (i915)->display.color.gamma_lut_size; +int i, lut_size =DISPLAY_INFO (i915)->color.gamma_lut_size;enum pipe pipe = crtc->pipe;struct drm_property_blob *blob;struct drm_color_lut *lut;
@@ -3044,7 +3044,7 @@ static struct drm_property_blob *ilk_read_lut_8(struct intel_crtc *crtc)static struct drm_property_blob *ilk_read_lut_10 (struct intel_crtc *crtc) {struct drm_i915_private *i915 =to_i915 (crtc->base.dev); -int i, lut_size =INTEL_INFO (i915)->display.color.gamma_lut_size; +int i, lut_size =DISPLAY_INFO (i915)->color.gamma_lut_size;enum pipe pipe = crtc->pipe;struct drm_property_blob *blob;struct drm_color_lut *lut;
@@ -3228,7 +3228,7 @@ static void bdw_read_luts(struct intel_crtc_state *crtc_state)static struct drm_property_blob *glk_read_degamma_lut (struct intel_crtc *crtc) {struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); -int i, lut_size =INTEL_INFO (dev_priv)->display.color.degamma_lut_size; +int i, lut_size =DISPLAY_INFO (dev_priv)->color.degamma_lut_size;enum pipe pipe = crtc->pipe;struct drm_property_blob *blob;struct drm_color_lut *lut;
@@ -3293,7 +3293,7 @@ static struct drm_property_blob * icl_read_lut_multi_segment(struct intel_crtc *crtc) {struct drm_i915_private *i915 =to_i915 (crtc->base.dev); -int i, lut_size =INTEL_INFO (i915)->display.color.gamma_lut_size; +int i, lut_size =DISPLAY_INFO (i915)->color.gamma_lut_size;enum pipe pipe = crtc->pipe;struct drm_property_blob *blob;struct drm_color_lut *lut;
@@ -3471,8 +3471,8 @@ void intel_color_crtc_init(struct intel_crtc *crtc)drm_mode_crtc_set_gamma_size (&crtc->base,256 ); - gamma_lut_size =INTEL_INFO (i915)->display.color.gamma_lut_size; - degamma_lut_size =INTEL_INFO (i915)->display.color.degamma_lut_size; + gamma_lut_size =DISPLAY_INFO (i915)->color.gamma_lut_size; + degamma_lut_size =DISPLAY_INFO (i915)->color.degamma_lut_size; has_ctm = degamma_lut_size !=0 ;/*
@@ -3497,7 +3497,8 @@ int intel_color_init(struct drm_i915_private *i915)if (DISPLAY_VER (i915) !=10 )return 0 ; - blob =create_linear_lut (i915,INTEL_INFO (i915)->display.color.degamma_lut_size); + blob =create_linear_lut (i915, +DISPLAY_INFO (i915)->color.degamma_lut_size);if (IS_ERR (blob))return PTR_ERR (blob);
drivers/gpu/drm/i915/display/intel_cursor.c +1 -1
@@ -36,7 +36,7 @@ static u32 intel_cursor_base(const struct intel_plane_state *plane_state)const struct drm_i915_gem_object *obj =intel_fb_obj (fb);u32 base; -if (INTEL_INFO (dev_priv)->display.cursor_needs_physical) +if (DISPLAY_INFO (dev_priv)->cursor_needs_physical) base =sg_dma_address (obj->mm.pages->sgl);else base =intel_plane_ggtt_offset (plane_state);
drivers/gpu/drm/i915/display/intel_display.h +1 -1
@@ -113,7 +113,7 @@ enum i9xx_plane_id {#define for_each_dbuf_slice (__dev_priv, __slice) \ for ((__slice) = DBUF_S1; (__slice) < I915_MAX_DBUF_SLICES; (__slice)++) \ - for_each_if(INTEL_INFO(__dev_priv)->display.dbuf.slice_mask & BIT(__slice)) + for_each_if(INTEL_INFO(__dev_priv)->display->dbuf.slice_mask & BIT(__slice))#define for_each_dbuf_slice_in_mask (__dev_priv, __slice, __mask) \ for_each_dbuf_slice((__dev_priv), (__slice)) \
drivers/gpu/drm/i915/display/intel_display_power.c +3 -3
@@ -1053,7 +1053,7 @@ void gen9_dbuf_slices_update(struct drm_i915_private *dev_priv, u8 req_slices) {struct i915_power_domains *power_domains = &dev_priv->display.power.domains; -u8 slice_mask =INTEL_INFO (dev_priv)->display.dbuf.slice_mask; +u8 slice_mask =DISPLAY_INFO (dev_priv)->dbuf.slice_mask;enum dbuf_slice slice; drm_WARN(&dev_priv->drm, req_slices & ~slice_mask,
@@ -1113,7 +1113,7 @@ static void gen12_dbuf_slices_config(struct drm_i915_private *dev_priv)static void icl_mbus_init (struct drm_i915_private *dev_priv) { -unsigned long abox_regs =INTEL_INFO (dev_priv)->display.abox_mask; +unsigned long abox_regs =DISPLAY_INFO (dev_priv)->abox_mask;u32 mask, val, i;if (IS_ALDERLAKE_P (dev_priv) ||DISPLAY_VER (dev_priv) >=14 )
@@ -1568,7 +1568,7 @@ static void tgl_bw_buddy_init(struct drm_i915_private *dev_priv)enum intel_dram_type type = dev_priv->dram_info.type;u8 num_channels = dev_priv->dram_info.num_channels;const struct buddy_page_mask *table; -unsigned long abox_mask =INTEL_INFO (dev_priv)->display.abox_mask; +unsigned long abox_mask =DISPLAY_INFO (dev_priv)->abox_mask;int config, i;/* BW_BUDDY registers are not used on dgpu's beyond DG1 */
drivers/gpu/drm/i915/display/intel_display_reg_defs.h +7 -7
@@ -8,7 +8,7 @@#include "i915_reg_defs.h" -#define DISPLAY_MMIO_BASE (dev_priv) (INTEL_INFO(dev_priv)->display.mmio_offset) +#define DISPLAY_MMIO_BASE (dev_priv) (DISPLAY_INFO(dev_priv)->mmio_offset)#define VLV_DISPLAY_BASE 0x180000
@@ -36,14 +36,14 @@* Device info offset array based helpers for groups of registers with unevenly * spaced base offsets. */ -#define _MMIO_PIPE2 (pipe, reg) _MMIO(INTEL_INFO(dev_priv)->display.pipe_offsets[(pipe)] - \ - INTEL_INFO(dev_priv)->display.pipe_offsets[PIPE_A] + \ +#define _MMIO_PIPE2 (pipe, reg) _MMIO(DISPLAY_INFO(dev_priv)->pipe_offsets[(pipe)] - \ + DISPLAY_INFO(dev_priv)->pipe_offsets[PIPE_A] + \ DISPLAY_MMIO_BASE(dev_priv) + (reg)) -#define _MMIO_TRANS2 (tran, reg) _MMIO(INTEL_INFO(dev_priv)->display.trans_offsets[(tran)] - \ - INTEL_INFO(dev_priv)->display.trans_offsets[TRANSCODER_A] + \ +#define _MMIO_TRANS2 (tran, reg) _MMIO(DISPLAY_INFO(dev_priv)->trans_offsets[(tran)] - \ + DISPLAY_INFO(dev_priv)->trans_offsets[TRANSCODER_A] + \ DISPLAY_MMIO_BASE(dev_priv) + (reg)) -#define _MMIO_CURSOR2 (pipe, reg) _MMIO(INTEL_INFO(dev_priv)->display.cursor_offsets[(pipe)] - \ - INTEL_INFO(dev_priv)->display.cursor_offsets[PIPE_A] + \ +#define _MMIO_CURSOR2 (pipe, reg) _MMIO(DISPLAY_INFO(dev_priv)->cursor_offsets[(pipe)] - \ + DISPLAY_INFO(dev_priv)->cursor_offsets[PIPE_A] + \ DISPLAY_MMIO_BASE(dev_priv) + (reg))#endif /* __INTEL_DISPLAY_REG_DEFS_H__ */
drivers/gpu/drm/i915/display/intel_fb_pin.c +1 -1
@@ -243,7 +243,7 @@ int intel_plane_pin_fb(struct intel_plane_state *plane_state)struct i915_vma *vma;bool phys_cursor = plane->id ==PLANE_CURSOR && -INTEL_INFO (dev_priv)->display.cursor_needs_physical; +DISPLAY_INFO (dev_priv)->cursor_needs_physical;if (!intel_fb_uses_dpt (fb)) { vma = intel_pin_and_fence_fb_obj(fb, phys_cursor,
drivers/gpu/drm/i915/display/intel_hti.c +1 -1
@@ -15,7 +15,7 @@ void intel_hti_init(struct drm_i915_private *i915)* If the platform has HTI, we need to find out whether it has reserved * any display resources before we create our display outputs. */ -if (INTEL_INFO (i915)->display.has_hti) +if (DISPLAY_INFO (i915)->has_hti) i915->display.hti.state =intel_de_read (i915,HDPORT_STATE ); }
drivers/gpu/drm/i915/display/skl_watermark.c +4 -4
@@ -507,8 +507,8 @@ static u16 skl_ddb_entry_init(struct skl_ddb_entry *entry,static int intel_dbuf_slice_size (struct drm_i915_private *i915) { -return INTEL_INFO (i915)->display.dbuf.size / -hweight8 (INTEL_INFO (i915)->display.dbuf.slice_mask); +return DISPLAY_INFO (i915)->dbuf.size / +hweight8 (DISPLAY_INFO (i915)->dbuf.slice_mask); } static void
@@ -527,7 +527,7 @@ skl_ddb_entry_for_slices(struct drm_i915_private *i915, u8 slice_mask, ddb->end =fls (slice_mask) * slice_size;WARN_ON (ddb->start >= ddb->end); -WARN_ON (ddb->end >INTEL_INFO (i915)->display.dbuf.size); +WARN_ON (ddb->end >DISPLAY_INFO (i915)->dbuf.size); }static unsigned int mbus_ddb_offset (struct drm_i915_private *i915,u8 slice_mask)
@@ -2625,7 +2625,7 @@ skl_compute_ddb(struct intel_atomic_state *state)"Enabled dbuf slices 0x%x -> 0x%x (total dbuf slices 0x%x), mbus joined? %s->%s\n" , old_dbuf_state->enabled_slices, new_dbuf_state->enabled_slices, -INTEL_INFO (i915)->display.dbuf.slice_mask, +DISPLAY_INFO (i915)->dbuf.slice_mask,str_yes_no (old_dbuf_state->joined_mbus), str_yes_no(new_dbuf_state->joined_mbus)); }
drivers/gpu/drm/i915/i915_drv.h +15 -14
@@ -408,6 +408,7 @@ static inline struct intel_gt *to_gt(struct drm_i915_private *i915) (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))#define INTEL_INFO (i915) (&(i915)->__info) +#define DISPLAY_INFO (i915) (INTEL_INFO(i915)->display)#define RUNTIME_INFO (i915) (&(i915)->__runtime)#define DRIVER_CAPS (i915) (&(i915)->caps)
@@ -782,9 +783,9 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, ((sizes) & ~RUNTIME_INFO (i915)->page_sizes) ==0 ; \ }) -#define HAS_OVERLAY (i915) (INTEL_INFO(i915)->display.has_overlay) +#define HAS_OVERLAY (i915) (DISPLAY_INFO(i915)->has_overlay)#define OVERLAY_NEEDS_PHYSICAL (i915) \ - (INTEL_INFO(i915)->display.overlay_needs_physical) + (DISPLAY_INFO(i915)->overlay_needs_physical)/* Early gen2 have a totally busted CS tlb and require pinned batches. */ #define HAS_BROKEN_CS_TLB (i915) (IS_I830(i915) || IS_I845G(i915))
@@ -806,8 +807,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,*/ #define HAS_128_BYTE_Y_TILING (i915) (GRAPHICS_VER(i915) != 2 && \ !(IS_I915G(i915) || IS_I915GM(i915))) -#define SUPPORTS_TV (i915) (INTEL_INFO(i915)->display.supports_tv) -#define I915_HAS_HOTPLUG (i915) (INTEL_INFO(i915)->display.has_hotplug) +#define SUPPORTS_TV (i915) (DISPLAY_INFO(i915)->supports_tv) +#define I915_HAS_HOTPLUG (i915) (DISPLAY_INFO(i915)->has_hotplug)#define HAS_FW_BLC (i915) (DISPLAY_VER(i915) > 2)#define HAS_FBC (i915) (RUNTIME_INFO(i915)->fbc_mask != 0)
@@ -817,18 +818,18 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define HAS_IPS (i915) (IS_HSW_ULT(i915) || IS_BROADWELL(i915)) -#define HAS_DP_MST (i915) (INTEL_INFO(i915)->display.has_dp_mst) +#define HAS_DP_MST (i915) (DISPLAY_INFO(i915)->has_dp_mst)#define HAS_DP20 (i915) (IS_DG2(i915) || DISPLAY_VER(i915) >= 14)#define HAS_DOUBLE_BUFFERED_M_N (i915) (DISPLAY_VER(i915) >= 9 || IS_BROADWELL(i915)) -#define HAS_CDCLK_CRAWL (i915) (INTEL_INFO(i915)->display.has_cdclk_crawl) -#define HAS_CDCLK_SQUASH (i915) (INTEL_INFO(i915)->display.has_cdclk_squash) -#define HAS_DDI (i915) (INTEL_INFO(i915)->display.has_ddi) -#define HAS_FPGA_DBG_UNCLAIMED (i915) (INTEL_INFO(i915)->display.has_fpga_dbg) -#define HAS_PSR (i915) (INTEL_INFO(i915)->display.has_psr) +#define HAS_CDCLK_CRAWL (i915) (DISPLAY_INFO(i915)->has_cdclk_crawl) +#define HAS_CDCLK_SQUASH (i915) (DISPLAY_INFO(i915)->has_cdclk_squash) +#define HAS_DDI (i915) (DISPLAY_INFO(i915)->has_ddi) +#define HAS_FPGA_DBG_UNCLAIMED (i915) (DISPLAY_INFO(i915)->has_fpga_dbg) +#define HAS_PSR (i915) (DISPLAY_INFO(i915)->has_psr)#define HAS_PSR_HW_TRACKING (i915) \ - (INTEL_INFO(i915)->display.has_psr_hw_tracking) + (DISPLAY_INFO(i915)->has_psr_hw_tracking)#define HAS_PSR2_SEL_FETCH (i915) (DISPLAY_VER(i915) >= 12)#define HAS_TRANSCODER (i915, trans) ((RUNTIME_INFO(i915)->cpu_transcoder_mask & BIT(trans)) != 0)
@@ -839,7 +840,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define HAS_RPS (i915) (INTEL_INFO(i915)->has_rps)#define HAS_DMC (i915) (RUNTIME_INFO(i915)->has_dmc) -#define HAS_DSB (i915) (INTEL_INFO(i915)->display.has_dsb) +#define HAS_DSB (i915) (DISPLAY_INFO(i915)->has_dsb)#define HAS_DSC (__i915) (RUNTIME_INFO(__i915)->has_dsc)#define HAS_HW_SAGV_WM (i915) (DISPLAY_VER(i915) >= 13 && !IS_DGFX(i915))
@@ -869,7 +870,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,*/ #define HAS_64K_PAGES (i915) (INTEL_INFO(i915)->has_64k_pages) -#define HAS_IPC (i915) (INTEL_INFO(i915)->display.has_ipc) +#define HAS_IPC (i915) (DISPLAY_INFO(i915)->has_ipc)#define HAS_SAGV (i915) (DISPLAY_VER(i915) >= 9 && !IS_LP(i915))#define HAS_REGION (i915, i) (RUNTIME_INFO(i915)->memory_regions & (i))
@@ -889,7 +890,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define HAS_GLOBAL_MOCS_REGISTERS (i915) (INTEL_INFO(i915)->has_global_mocs) -#define HAS_GMCH (i915) (INTEL_INFO(i915)->display.has_gmch) +#define HAS_GMCH (i915) (DISPLAY_INFO(i915)->has_gmch)#define HAS_GMD_ID (i915) (INTEL_INFO(i915)->has_gmd_id)
drivers/gpu/drm/i915/i915_pci.c +398 -181
1,276 lines not on this page · raw message
drivers/gpu/drm/i915/intel_device_info.c +4 -2
@@ -138,7 +138,7 @@ void intel_device_info_print(const struct intel_device_info *info,drm_printf (p,"has_pooled_eu: %s\n" ,str_yes_no (runtime->has_pooled_eu)); -#define PRINT_FLAG (name) drm_printf(p, "%s: %s\n", #name, str_yes_no(info->display.name)) +#define PRINT_FLAG (name) drm_printf(p, "%s: %s\n", #name, str_yes_no(info->display->name))DEV_INFO_DISPLAY_FOR_EACH_FLAG (PRINT_FLAG );#undef PRINT_FLAG
@@ -388,6 +388,8 @@ mkwrite_device_info(struct drm_i915_private *i915)return (struct intel_device_info *)INTEL_INFO (i915); } +static const struct intel_display_device_info no_display = {}; +/** * intel_device_info_runtime_init - initialize runtime info * @dev_priv: the i915 device
@@ -538,7 +540,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)if (!HAS_DISPLAY (dev_priv)) { dev_priv->drm.driver_features &= ~(DRIVER_MODESET |DRIVER_ATOMIC ); -memset (&info->display,0 ,sizeof (info->display)); + info->display = &no_display; runtime->cpu_transcoder_mask =0 ;memset (runtime->num_sprites,0 ,sizeof (runtime->num_sprites));
drivers/gpu/drm/i915/intel_device_info.h +1 -1
@@ -259,7 +259,7 @@ struct intel_device_info {DEV_INFO_FOR_EACH_FLAG (DEFINE_FLAG );#undef DEFINE_FLAG -struct intel_display_device_info display; +const struct intel_display_device_info *display;/* * Initial runtime info. Do not access outside of i915_driver_create().
Signature · 1 line
2.40.1
PATCH v3 3/6 drm/i915/display: Move display runtime info to display structure
In reply to Matt RoperMove the runtime info specific to display into display-specific structures as has already been done with the constant display info.
v2:
- Rename __runtime to __runtime_defaults for more clarity on the purpose. (Andrzej)
- Move introduction of DISPLAY_INFO() to previous patch. (Andrzej)
- Drop NO_DISPLAY macro. (Andrzej)
v3:
- Use "{}" instead of "{ 0 }" for empty struct init. (Jani)
--- drivers/gpu/drm/i915/display/intel_crtc.c | 2 +- drivers/gpu/drm/i915/display/intel_cursor.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c | 2 +- drivers/gpu/drm/i915/display/intel_display.h | 8 +- .../drm/i915/display/intel_display_device.h | 23 ++ drivers/gpu/drm/i915/display/intel_fbc.c | 6 +- drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +- .../drm/i915/display/skl_universal_plane.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 16 +- drivers/gpu/drm/i915/i915_pci.c | 252 +++++++++++------- drivers/gpu/drm/i915/intel_device_info.c | 101 +++---- drivers/gpu/drm/i915/intel_device_info.h | 18 -- drivers/gpu/drm/i915/intel_step.c | 8 +- 13 files changed, 267 insertions(+), 175 deletions(-)
drivers/gpu/drm/i915/display/intel_crtc.c +1 -1
@@ -306,7 +306,7 @@ int intel_crtc_init(struct drm_i915_private *dev_priv, enum pipe pipe)return PTR_ERR (crtc); crtc->pipe = pipe; - crtc->num_scalers =RUNTIME_INFO (dev_priv)->num_scalers[pipe]; + crtc->num_scalers =DISPLAY_RUNTIME_INFO (dev_priv)->num_scalers[pipe];if (DISPLAY_VER (dev_priv) >=9 ) primary = skl_universal_plane_create(dev_priv, pipe,
drivers/gpu/drm/i915/display/intel_cursor.c +1 -1
@@ -814,7 +814,7 @@ intel_cursor_plane_create(struct drm_i915_private *dev_priv,DRM_MODE_ROTATE_0 | DRM_MODE_ROTATE_180); - zpos =RUNTIME_INFO (dev_priv)->num_sprites[pipe] +1 ; + zpos =DISPLAY_RUNTIME_INFO (dev_priv)->num_sprites[pipe] +1 ;drm_plane_create_zpos_immutable_property (&cursor->base, zpos);if (DISPLAY_VER (dev_priv) >=12 )
drivers/gpu/drm/i915/display/intel_display.c +1 -1
@@ -3366,7 +3366,7 @@ static u8 bigjoiner_pipes(struct drm_i915_private *i915)else pipes =0 ; -return pipes &RUNTIME_INFO (i915)->pipe_mask; +return pipes &DISPLAY_RUNTIME_INFO (i915)->pipe_mask; } static bool transcoder_ddi_func_is_enabled(struct drm_i915_private *dev_priv,
drivers/gpu/drm/i915/display/intel_display.h +4 -4
@@ -105,7 +105,7 @@ enum i9xx_plane_id { };#define plane_name (p) ((p) + 'A') -#define sprite_name (p, s) ((p) * RUNTIME_INFO(dev_priv)->num_sprites[(p)] + (s) + 'A') +#define sprite_name (p, s) ((p) * DISPLAY_RUNTIME_INFO(dev_priv)->num_sprites[(p)] + (s) + 'A')#define for_each_plane_id_on_crtc (__crtc, __p) \ for ((__p) = PLANE_PRIMARY; (__p) < I915_MAX_PLANES; (__p)++) \
@@ -221,7 +221,7 @@ enum phy_fia {#define for_each_pipe (__dev_priv, __p) \ for ((__p) = 0; (__p) < I915_MAX_PIPES; (__p)++) \ - for_each_if(RUNTIME_INFO(__dev_priv)->pipe_mask & BIT(__p)) + for_each_if(DISPLAY_RUNTIME_INFO(__dev_priv)->pipe_mask & BIT(__p))#define for_each_pipe_masked (__dev_priv, __p, __mask) \ for_each_pipe(__dev_priv, __p) \
@@ -229,7 +229,7 @@ enum phy_fia {#define for_each_cpu_transcoder (__dev_priv, __t) \ for ((__t) = 0; (__t) < I915_MAX_TRANSCODERS; (__t)++) \ - for_each_if (RUNTIME_INFO(__dev_priv)->cpu_transcoder_mask & BIT(__t)) + for_each_if (DISPLAY_RUNTIME_INFO(__dev_priv)->cpu_transcoder_mask & BIT(__t))#define for_each_cpu_transcoder_masked (__dev_priv, __t, __mask) \ for_each_cpu_transcoder(__dev_priv, __t) \
@@ -237,7 +237,7 @@ enum phy_fia {#define for_each_sprite (__dev_priv, __p, __s) \ for ((__s) = 0; \ - (__s) < RUNTIME_INFO(__dev_priv)->num_sprites[(__p)]; \ + (__s) < DISPLAY_RUNTIME_INFO(__dev_priv)->num_sprites[(__p)]; \ (__s)++)#define for_each_port (__port) \
drivers/gpu/drm/i915/display/intel_display_device.h +23 -0
@@ -29,7 +29,30 @@func (overlay_needs_physical); \func (supports_tv); +struct intel_display_runtime_info { +struct { +u16 ver; +u16 rel; +u16 step; + } ip; + +u8 pipe_mask; +u8 cpu_transcoder_mask; + +u8 num_sprites[I915_MAX_PIPES ]; +u8 num_scalers[I915_MAX_PIPES ]; + +u8 fbc_mask; + +bool has_hdcp; +bool has_dmc; +bool has_dsc; +}; +struct intel_display_device_info { +/* Initial runtime info. */ +const struct intel_display_runtime_info __runtime_defaults; +u8 abox_mask;struct {
drivers/gpu/drm/i915/display/intel_fbc.c +3 -3
@@ -56,7 +56,7 @@#define for_each_fbc_id (__dev_priv, __fbc_id) \ for ((__fbc_id) = INTEL_FBC_A; (__fbc_id) < I915_MAX_FBCS; (__fbc_id)++) \ - for_each_if(RUNTIME_INFO(__dev_priv)->fbc_mask & BIT(__fbc_id)) + for_each_if(DISPLAY_RUNTIME_INFO(__dev_priv)->fbc_mask & BIT(__fbc_id))#define for_each_intel_fbc (__dev_priv, __fbc, __fbc_id) \ for_each_fbc_id((__dev_priv), (__fbc_id)) \
@@ -1708,10 +1708,10 @@ void intel_fbc_init(struct drm_i915_private *i915)enum intel_fbc_id fbc_id;if (!drm_mm_initialized (&i915->mm.stolen)) -RUNTIME_INFO (i915)->fbc_mask =0 ; +DISPLAY_RUNTIME_INFO (i915)->fbc_mask =0 ;if (need_fbc_vtd_wa (i915)) -RUNTIME_INFO (i915)->fbc_mask =0 ; +DISPLAY_RUNTIME_INFO (i915)->fbc_mask =0 ; i915->params.enable_fbc =intel_sanitize_fbc_option (i915); drm_dbg_kms(&i915->drm, "Sanitized enable_fbc value: %d\n",
drivers/gpu/drm/i915/display/intel_hdcp.c +1 -1
@@ -1103,7 +1103,7 @@ static void intel_hdcp_prop_work(struct work_struct *work)bool is_hdcp_supported (struct drm_i915_private *dev_priv,enum port port) { -return RUNTIME_INFO (dev_priv)->has_hdcp && +return DISPLAY_RUNTIME_INFO (dev_priv)->has_hdcp && (DISPLAY_VER (dev_priv) >=12 || port <PORT_E ); }
drivers/gpu/drm/i915/display/skl_universal_plane.c +1 -1
@@ -1944,7 +1944,7 @@ static enum intel_fbc_id skl_fbc_id_for_pipe(enum pipe pipe)static bool skl_plane_has_fbc (struct drm_i915_private *dev_priv,enum intel_fbc_id fbc_id,enum plane_id plane_id) { -if ((RUNTIME_INFO (dev_priv)->fbc_mask &BIT (fbc_id)) ==0 ) +if ((DISPLAY_RUNTIME_INFO (dev_priv)->fbc_mask &BIT (fbc_id)) ==0 )return false;return plane_id ==PLANE_PRIMARY ;
drivers/gpu/drm/i915/i915_drv.h +9 -7
@@ -205,6 +205,7 @@ struct drm_i915_private {const struct intel_device_info __info;/* Use INTEL_INFO() to access. */ struct intel_runtime_info __runtime;/* Use RUNTIME_INFO() to access. */ +struct intel_display_runtime_info __display_runtime;/* Access with DISPLAY_RUNTIME_INFO() */ struct intel_driver_caps caps;struct i915_dsm dsm;
@@ -410,6 +411,7 @@ static inline struct intel_gt *to_gt(struct drm_i915_private *i915)#define INTEL_INFO (i915) (&(i915)->__info)#define DISPLAY_INFO (i915) (INTEL_INFO(i915)->display)#define RUNTIME_INFO (i915) (&(i915)->__runtime) +#define DISPLAY_RUNTIME_INFO (i915) (&(i915)->__display_runtime)#define DRIVER_CAPS (i915) (&(i915)->caps)#define INTEL_DEVID (i915) (RUNTIME_INFO(i915)->device_id)
@@ -428,7 +430,7 @@ static inline struct intel_gt *to_gt(struct drm_i915_private *i915)#define IS_MEDIA_VER (i915, from, until) \ (MEDIA_VER(i915) >= (from) && MEDIA_VER(i915) <= (until)) -#define DISPLAY_VER (i915) (RUNTIME_INFO(i915)->display.ip.ver) +#define DISPLAY_VER (i915) (DISPLAY_RUNTIME_INFO(i915)->ip.ver)#define IS_DISPLAY_VER (i915, from, until) \ (DISPLAY_VER(i915) >= (from) && DISPLAY_VER(i915) <= (until))
@@ -811,7 +813,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define I915_HAS_HOTPLUG (i915) (DISPLAY_INFO(i915)->has_hotplug)#define HAS_FW_BLC (i915) (DISPLAY_VER(i915) > 2) -#define HAS_FBC (i915) (RUNTIME_INFO(i915)->fbc_mask != 0) +#define HAS_FBC (i915) (DISPLAY_RUNTIME_INFO(i915)->fbc_mask != 0)#define HAS_CUR_FBC (i915) (!HAS_GMCH(i915) && DISPLAY_VER(i915) >= 7)#define HAS_DPT (i915) (DISPLAY_VER(i915) >= 13)
@@ -831,7 +833,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define HAS_PSR_HW_TRACKING (i915) \ (DISPLAY_INFO(i915)->has_psr_hw_tracking)#define HAS_PSR2_SEL_FETCH (i915) (DISPLAY_VER(i915) >= 12) -#define HAS_TRANSCODER (i915, trans) ((RUNTIME_INFO(i915)->cpu_transcoder_mask & BIT(trans)) != 0) +#define HAS_TRANSCODER (i915, trans) ((DISPLAY_RUNTIME_INFO(i915)->cpu_transcoder_mask & BIT(trans)) != 0)#define HAS_RC6 (i915) (INTEL_INFO(i915)->has_rc6)#define HAS_RC6p (i915) (INTEL_INFO(i915)->has_rc6p)
@@ -839,9 +841,9 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define HAS_RPS (i915) (INTEL_INFO(i915)->has_rps) -#define HAS_DMC (i915) (RUNTIME_INFO(i915)->has_dmc) +#define HAS_DMC (i915) (DISPLAY_RUNTIME_INFO(i915)->has_dmc)#define HAS_DSB (i915) (DISPLAY_INFO(i915)->has_dsb) -#define HAS_DSC (__i915) (RUNTIME_INFO(__i915)->has_dsc) +#define HAS_DSC (__i915) (DISPLAY_RUNTIME_INFO(__i915)->has_dsc)#define HAS_HW_SAGV_WM (i915) (DISPLAY_VER(i915) >= 13 && !IS_DGFX(i915))#define HAS_HECI_PXP (i915) \
@@ -903,9 +905,9 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define NUM_L3_SLICES (i915) (IS_HSW_GT3(i915) ? \ 2 : HAS_L3_DPF(i915)) -#define INTEL_NUM_PIPES (i915) (hweight8(RUNTIME_INFO(i915)->pipe_mask)) +#define INTEL_NUM_PIPES (i915) (hweight8(DISPLAY_RUNTIME_INFO(i915)->pipe_mask)) -#define HAS_DISPLAY (i915) (RUNTIME_INFO(i915)->pipe_mask != 0) +#define HAS_DISPLAY (i915) (DISPLAY_RUNTIME_INFO(i915)->pipe_mask != 0)#define HAS_VRR (i915) (DISPLAY_VER(i915) >= 11)
drivers/gpu/drm/i915/i915_pci.c +161 -91
617 lines not on this page · raw message
drivers/gpu/drm/i915/intel_device_info.c +56 -45
223 lines not on this page · raw message
drivers/gpu/drm/i915/intel_device_info.h +0 -18
@@ -199,9 +199,6 @@ struct intel_runtime_info {struct {struct intel_ip_version ip; } media; -struct { -struct intel_ip_version ip; - } display;/* * Platform mask is used for optimizing or-ed IS_PLATFORM calls into
@@ -229,21 +226,6 @@ struct intel_runtime_info {u32 memory_regions;/* regions supported by the HW */ bool has_pooled_eu; - -/* display */ -struct { -u8 pipe_mask; -u8 cpu_transcoder_mask; - -u8 num_sprites[I915_MAX_PIPES ]; -u8 num_scalers[I915_MAX_PIPES ]; - -u8 fbc_mask; - -bool has_hdcp; -bool has_dmc; -bool has_dsc; - }; };struct intel_device_info {
drivers/gpu/drm/i915/intel_step.c +6 -2
@@ -166,8 +166,12 @@ void intel_step_init(struct drm_i915_private *i915) &RUNTIME_INFO(i915)->graphics.ip); step.media_step =gmd_to_intel_step (i915, &RUNTIME_INFO (i915)->media.ip); - step.display_step =gmd_to_intel_step (i915, - &RUNTIME_INFO (i915)->display.ip); + step.display_step =STEP_A0 +DISPLAY_RUNTIME_INFO (i915)->ip.step; +if (step.display_step >=STEP_FUTURE ) { +drm_dbg (&i915->drm,"Using future display steppings\n" ); + step.display_step =STEP_FUTURE ; + } +RUNTIME_INFO (i915)->step = step;return ;
Signature · 1 line
2.40.1
PATCH v3 4/6 drm/i915/display: Make display responsible for probing its own IP
In reply to Matt RoperRather than selecting the display IP and feature flags at the same time the general PCI probing happens, move this step into the display code itself so that it can be more easily re-used outside of i915 (i.e., by the Xe driver).
v2:
- Make intel_display_device_probe() always return a non-NULL pointer and simplify copying of runtime_defaults. (Andrzej)
v3:
- Redefine INTEL_VGA_DEVICE/INTEL_QUANTA_DEVICE to eliminate a cast and an include of linux/mod_devicetable.h. (Jani)
- Keep explicit memcpy for runtime defaults. (Jani)
--- drivers/gpu/drm/i915/Makefile | 2 + .../drm/i915/display/intel_display_device.c | 718 ++++++++++++++++++ .../drm/i915/display/intel_display_device.h | 3 + drivers/gpu/drm/i915/i915_pci.c | 665 ---------------- drivers/gpu/drm/i915/i915_reg.h | 33 - drivers/gpu/drm/i915/intel_device_info.c | 10 +- 6 files changed, 729 insertions(+), 702 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_display_device.c
drivers/gpu/drm/i915/Makefile +2 -0
@@ -25,6 +25,7 @@ subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror # Fine grained warnings disable CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init) +CFLAGS_display/intel_display_device.o = $(call cc-disable-warning, override-init) CFLAGS_display/intel_fbdev.o = $(call cc-disable-warning, override-init) subdir-ccflags-y += -I$(srctree)/$(src)
@@ -308,6 +309,7 @@ i915-y += \ display/intel_cx0_phy.o \ display/intel_ddi.o \ display/intel_ddi_buf_trans.o \ + display/intel_display_device.o \ display/intel_display_trace.o \ display/intel_dkl_phy.o \ display/intel_dp.o \
drivers/gpu/drm/i915/display/intel_display_device.c new file +718 -0
718 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display_device.h +3 -0
@@ -80,4 +80,7 @@ struct intel_display_device_info { } color; }; +const struct intel_display_device_info * +intel_display_device_probe (u16 pci_devid); +#endif
drivers/gpu/drm/i915/i915_pci.c +0 -665
1,086 lines not on this page · raw message
drivers/gpu/drm/i915/i915_reg.h +0 -33
@@ -1966,15 +1966,6 @@#define _TRANS_VSYNC_DSI1 0x6b814#define _TRANS_VSYNCSHIFT_DSI1 0x6b828 -#define TRANSCODER_A_OFFSET 0x60000 -#define TRANSCODER_B_OFFSET 0x61000 -#define TRANSCODER_C_OFFSET 0x62000 -#define CHV_TRANSCODER_C_OFFSET 0x63000 -#define TRANSCODER_D_OFFSET 0x63000 -#define TRANSCODER_EDP_OFFSET 0x6f000 -#define TRANSCODER_DSI0_OFFSET 0x6b000 -#define TRANSCODER_DSI1_OFFSET 0x6b800 -#define TRANS_HTOTAL (trans) _MMIO_TRANS2((trans), _TRANS_HTOTAL_A)#define TRANS_HBLANK (trans) _MMIO_TRANS2((trans), _TRANS_HBLANK_A)#define TRANS_HSYNC (trans) _MMIO_TRANS2((trans), _TRANS_HSYNC_A)
@@ -2622,23 +2613,6 @@#define PIPESTAT_INT_ENABLE_MASK 0x7fff0000#define PIPESTAT_INT_STATUS_MASK 0x0000ffff -#define PIPE_A_OFFSET 0x70000 -#define PIPE_B_OFFSET 0x71000 -#define PIPE_C_OFFSET 0x72000 -#define PIPE_D_OFFSET 0x73000 -#define CHV_PIPE_C_OFFSET 0x74000 -/* -* There's actually no pipe EDP. Some pipe registers have -* simply shifted from the pipe to the transcoder, while -* keeping their original offset. Thus we need PIPE_EDP_OFFSET -* to access such registers in transcoder EDP. -*/ -#define PIPE_EDP_OFFSET 0x7f000 - -/* ICL DSI 0 and 1 */ -#define PIPE_DSI0_OFFSET 0x7b000 -#define PIPE_DSI1_OFFSET 0x7b800 -#define TRANSCONF (trans) _MMIO_PIPE2((trans), _TRANSACONF)#define PIPEDSL (pipe) _MMIO_PIPE2(pipe, _PIPEADSL)#define PIPEFRAME (pipe) _MMIO_PIPE2(pipe, _PIPEAFRAMEHIGH)
@@ -3099,13 +3073,6 @@#define CUR_CHICKEN (pipe) _MMIO_CURSOR2(pipe, _CUR_CHICKEN_A)#define CURSURFLIVE (pipe) _MMIO_CURSOR2(pipe, _CURASURFLIVE) -#define CURSOR_A_OFFSET 0x70080 -#define CURSOR_B_OFFSET 0x700c0 -#define CHV_CURSOR_C_OFFSET 0x700e0 -#define IVB_CURSOR_B_OFFSET 0x71080 -#define IVB_CURSOR_C_OFFSET 0x72080 -#define TGL_CURSOR_D_OFFSET 0x73080 -/* Display A control */ #define _DSPAADDR_VLV 0x7017C/* vlv/chv */ #define _DSPACNTR 0x70180
drivers/gpu/drm/i915/intel_device_info.c +6 -4
@@ -574,7 +574,6 @@ void intel_device_info_driver_create(struct drm_i915_private *i915, {struct intel_device_info *info;struct intel_runtime_info *runtime; -struct intel_display_runtime_info *display_runtime;/* Setup the write-once "constant" device info */ info =mkwrite_device_info (i915);
@@ -583,9 +582,12 @@ void intel_device_info_driver_create(struct drm_i915_private *i915,/* Initialize initial runtime info from static const data and pdev. */ runtime =RUNTIME_INFO (i915);memcpy (runtime, &INTEL_INFO (i915)->__runtime,sizeof (*runtime)); - display_runtime =DISPLAY_RUNTIME_INFO (i915); -memcpy (display_runtime, &DISPLAY_INFO (i915)->__runtime_defaults, -sizeof (*display_runtime)); + +/* Probe display support */ + info->display =intel_display_device_probe (device_id); +memcpy (DISPLAY_RUNTIME_INFO (i915), + &DISPLAY_INFO (i915)->__runtime_defaults, +sizeof (*DISPLAY_RUNTIME_INFO (i915))); runtime->device_id = device_id; }
Signature · 1 line
2.40.1
PATCH v3 5/6 drm/i915/display: Handle GMD_ID identification in display code
In reply to Matt RoperFor platforms with GMD_ID support (i.e., everything MTL and beyond), identification of the display IP present should be based on the contents of the GMD_ID register rather than a PCI devid match.
Note that since GMD_ID readout requires access to the PCI BAR, a slight change to the driver init sequence is needed --- pci_enable_device() is now called before i915_driver_create().
v2:
- Fix use of uninitialized i915 pointer in error path if pci_enable_device() fails before the i915 device is created. (lkp)
- Use drm_device parameter to intel_display_device_probe. This goes against i915 conventions, but since the primary goal here is to make it easy to call this function from other drivers (like Xe) and since we don't need anything from the i915 structure, this seems like an exception where drm_device is a more natural fit.
v3:
- Go back do drm_i915_private for intel_display_device_probe. (Jani)
- Move forward decl to top of header. (Jani)
--- .../drm/i915/display/intel_display_device.c | 65 +++++++++++++++++-- .../drm/i915/display/intel_display_device.h | 5 +- drivers/gpu/drm/i915/i915_driver.c | 17 +++-- drivers/gpu/drm/i915/intel_device_info.c | 13 ++-- 4 files changed, 84 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/display/intel_display_device.c +61 -4
@@ -5,7 +5,10 @@#include <drm/i915_pciids.h> #include <drm/drm_color_mgmt.h> +#include <linux/pci.h> +#include "i915_drv.h" +#include "i915_reg.h" #include "intel_display_device.h" #include "intel_display_power.h" #include "intel_display_reg_defs.h"
@@ -700,19 +703,73 @@ static const struct { INTEL_RPLP_IDS(&xe_lpd_display), INTEL_DG2_IDS(&xe_hpd_display), -/* FIXME: Replace this with a GMD_ID lookup */ - INTEL_MTL_IDS(&xe_lpdp_display), +/* +* Do not add any GMD_ID-based platforms to this list. They will +* be probed automatically based on the IP version reported by +* the hardware. +*/ }; +static const struct { +u16 ver; +u16 rel; +const struct intel_display_device_info *display; +} gmdid_display_map[] = { + {14 ,0 , &xe_lpdp_display }, +}; + +static const struct intel_display_device_info * +probe_gmdid_display (struct drm_i915_private *i915,u16 *ver,u16 *rel,u16 *step) +{ +struct pci_dev *pdev =to_pci_dev (i915->drm.dev); +void __iomem *addr; +u32 val; +int i; + + addr =pci_iomap_range (pdev,0 ,i915_mmio_reg_offset (GMD_ID_DISPLAY ),sizeof (u32)); +if (!addr) { +drm_err (&i915->drm,"Cannot map MMIO BAR to read display GMD_ID\n" ); +return &no_display; + } + + val =ioread32 (addr); +pci_iounmap (pdev, addr); + +if (val ==0 ) +/* Platform doesn't have display */ +return &no_display; + + *ver =REG_FIELD_GET (GMD_ID_ARCH_MASK , val); + *rel =REG_FIELD_GET (GMD_ID_RELEASE_MASK , val); + *step =REG_FIELD_GET (GMD_ID_STEP , val); + +for (i =0 ; i <ARRAY_SIZE (gmdid_display_map); i++) +if (*ver == gmdid_display_map[i].ver && + *rel == gmdid_display_map[i].rel) +return gmdid_display_map[i].display; + +drm_err (&i915->drm,"Unrecognized display IP version %d.%02d; disabling display.\n" , + *ver, *rel); +return &no_display; +} +const struct intel_display_device_info * -intel_display_device_probe (u16 pci_devid) +intel_display_device_probe (struct drm_i915_private *i915,bool has_gmdid, +u16 *gmdid_ver,u16 *gmdid_rel,u16 *gmdid_step) { +struct pci_dev *pdev =to_pci_dev (i915->drm.dev);int i; +if (has_gmdid) +return probe_gmdid_display (i915, gmdid_ver, gmdid_rel, gmdid_step); +for (i =0 ; i <ARRAY_SIZE (intel_display_ids); i++) { -if (intel_display_ids[i].devid == pci_devid) +if (intel_display_ids[i].devid == pdev->device)return intel_display_ids[i].info; } +drm_dbg (&i915->drm,"No display ID found for device ID %04x; disabling display.\n" , + pdev->device); +return &no_display; }
drivers/gpu/drm/i915/display/intel_display_device.h +4 -1
@@ -10,6 +10,8 @@#include "display/intel_display_limits.h" +struct drm_i915_private ; +#define DEV_INFO_DISPLAY_FOR_EACH_FLAG (func) \/* Keep in alphabetical order */ \ func(cursor_needs_physical); \
@@ -81,6 +83,7 @@ struct intel_display_device_info { };const struct intel_display_device_info * -intel_display_device_probe (u16 pci_devid); +intel_display_device_probe (struct drm_i915_private *i915,bool has_gmdid, +u16 *ver,u16 *rel,u16 *step);#endif
drivers/gpu/drm/i915/i915_driver.c +10 -7
@@ -754,13 +754,17 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)struct drm_i915_private *i915;int ret; - i915 =i915_driver_create (pdev, ent); -if (IS_ERR (i915)) -return PTR_ERR (i915); - ret =pci_enable_device (pdev); -if (ret) - goto out_fini; +if (ret) { +pr_err ("Failed to enable graphics device: %pe\n" ,ERR_PTR (ret)); +return ret; + } + + i915 =i915_driver_create (pdev, ent); +if (IS_ERR (i915)) { + ret =PTR_ERR (i915); + goto out_pci_disable; + } ret =i915_driver_early_probe (i915);if (ret <0 )
@@ -843,7 +847,6 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)i915_driver_late_release (i915); out_pci_disable:pci_disable_device (pdev); -out_fini:i915_probe_error (i915,"Device initialization failed (%d)\n" , ret);return ret; }
drivers/gpu/drm/i915/intel_device_info.c +9 -4
@@ -345,7 +345,6 @@ static void ip_ver_read(struct drm_i915_private *i915, u32 offset, struct intel_static void intel_ipver_early_init (struct drm_i915_private *i915) {struct intel_runtime_info *runtime =RUNTIME_INFO (i915); -struct intel_display_runtime_info *display_runtime =DISPLAY_RUNTIME_INFO (i915);if (!HAS_GMD_ID (i915)) {drm_WARN_ON (&i915->drm,RUNTIME_INFO (i915)->graphics.ip.ver >12 );
@@ -366,8 +365,6 @@ static void intel_ipver_early_init(struct drm_i915_private *i915)RUNTIME_INFO (i915)->graphics.ip.ver =12 ;RUNTIME_INFO (i915)->graphics.ip.rel =70 ; } -ip_ver_read (i915,i915_mmio_reg_offset (GMD_ID_DISPLAY ), - (struct intel_ip_version *)&display_runtime->ip);ip_ver_read (i915,i915_mmio_reg_offset (GMD_ID_MEDIA ), &runtime->media.ip); }
@@ -574,6 +571,7 @@ void intel_device_info_driver_create(struct drm_i915_private *i915, {struct intel_device_info *info;struct intel_runtime_info *runtime; +u16 ver, rel, step;/* Setup the write-once "constant" device info */ info =mkwrite_device_info (i915);
@@ -584,11 +582,18 @@ void intel_device_info_driver_create(struct drm_i915_private *i915,memcpy (runtime, &INTEL_INFO (i915)->__runtime,sizeof (*runtime));/* Probe display support */ - info->display =intel_display_device_probe (device_id); + info->display =intel_display_device_probe (i915, info->has_gmd_id, + &ver, &rel, &step);memcpy (DISPLAY_RUNTIME_INFO (i915), &DISPLAY_INFO (i915)->__runtime_defaults,sizeof (*DISPLAY_RUNTIME_INFO (i915))); +if (info->has_gmd_id) { +DISPLAY_RUNTIME_INFO (i915)->ip.ver = ver; +DISPLAY_RUNTIME_INFO (i915)->ip.rel = rel; +DISPLAY_RUNTIME_INFO (i915)->ip.step = step; + } + runtime->device_id = device_id; }
Signature · 1 line
2.40.1
PATCH v3 6/6 drm/i915/display: Move feature test macros to intel_display_device.h
In reply to Matt RoperIt makes sense to keep the display feature test macros centralized within the display code.
--- .../drm/i915/display/intel_display_device.h | 39 ++++++++++++ drivers/gpu/drm/i915/i915_drv.h | 60 ------------------- 2 files changed, 39 insertions(+), 60 deletions(-)
drivers/gpu/drm/i915/display/intel_display_device.h +39 -0
@@ -31,6 +31,45 @@ struct drm_i915_private;func (overlay_needs_physical); \func (supports_tv); +#define HAS_ASYNC_FLIPS (i915) (DISPLAY_VER(i915) >= 5) +#define HAS_CDCLK_CRAWL (i915) (DISPLAY_INFO(i915)->has_cdclk_crawl) +#define HAS_CDCLK_SQUASH (i915) (DISPLAY_INFO(i915)->has_cdclk_squash) +#define HAS_CUR_FBC (i915) (!HAS_GMCH(i915) && DISPLAY_VER(i915) >= 7) +#define HAS_D12_PLANE_MINIMIZATION (i915) (IS_ROCKETLAKE(i915) || IS_ALDERLAKE_S(i915)) +#define HAS_DDI (i915) (DISPLAY_INFO(i915)->has_ddi) +#define HAS_DISPLAY (i915) (DISPLAY_RUNTIME_INFO(i915)->pipe_mask != 0) +#define HAS_DMC (i915) (DISPLAY_RUNTIME_INFO(i915)->has_dmc) +#define HAS_DOUBLE_BUFFERED_M_N (i915) (DISPLAY_VER(i915) >= 9 || IS_BROADWELL(i915)) +#define HAS_DP_MST (i915) (DISPLAY_INFO(i915)->has_dp_mst) +#define HAS_DP20 (i915) (IS_DG2(i915) || DISPLAY_VER(i915) >= 14) +#define HAS_DPT (i915) (DISPLAY_VER(i915) >= 13) +#define HAS_DSB (i915) (DISPLAY_INFO(i915)->has_dsb) +#define HAS_DSC (__i915) (DISPLAY_RUNTIME_INFO(__i915)->has_dsc) +#define HAS_FBC (i915) (DISPLAY_RUNTIME_INFO(i915)->fbc_mask != 0) +#define HAS_FPGA_DBG_UNCLAIMED (i915) (DISPLAY_INFO(i915)->has_fpga_dbg) +#define HAS_FW_BLC (i915) (DISPLAY_VER(i915) > 2) +#define HAS_GMBUS_IRQ (i915) (DISPLAY_VER(i915) >= 4) +#define HAS_GMBUS_BURST_READ (i915) (DISPLAY_VER(i915) >= 10 || IS_KABYLAKE(i915)) +#define HAS_GMCH (i915) (DISPLAY_INFO(i915)->has_gmch) +#define HAS_HW_SAGV_WM (i915) (DISPLAY_VER(i915) >= 13 && !IS_DGFX(i915)) +#define HAS_IPC (i915) (DISPLAY_INFO(i915)->has_ipc) +#define HAS_IPS (i915) (IS_HSW_ULT(i915) || IS_BROADWELL(i915)) +#define HAS_LSPCON (i915) (IS_DISPLAY_VER(i915, 9, 10)) +#define HAS_MBUS_JOINING (i915) (IS_ALDERLAKE_P(i915) || DISPLAY_VER(i915) >= 14) +#define HAS_MSO (i915) (DISPLAY_VER(i915) >= 12) +#define HAS_OVERLAY (i915) (DISPLAY_INFO(i915)->has_overlay) +#define HAS_PSR (i915) (DISPLAY_INFO(i915)->has_psr) +#define HAS_PSR_HW_TRACKING (i915) (DISPLAY_INFO(i915)->has_psr_hw_tracking) +#define HAS_PSR2_SEL_FETCH (i915) (DISPLAY_VER(i915) >= 12) +#define HAS_SAGV (i915) (DISPLAY_VER(i915) >= 9 && !IS_LP(i915)) +#define HAS_TRANSCODER (i915, trans) ((DISPLAY_RUNTIME_INFO(i915)->cpu_transcoder_mask & \ + BIT(trans)) != 0) +#define HAS_VRR (i915) (DISPLAY_VER(i915) >= 11) +#define INTEL_NUM_PIPES (i915) (hweight8(DISPLAY_RUNTIME_INFO(i915)->pipe_mask)) +#define I915_HAS_HOTPLUG (i915) (DISPLAY_INFO(i915)->has_hotplug) +#define OVERLAY_NEEDS_PHYSICAL (i915) (DISPLAY_INFO(i915)->overlay_needs_physical) +#define SUPPORTS_TV (i915) (DISPLAY_INFO(i915)->supports_tv) + struct intel_display_runtime_info { struct { u16 ver;
drivers/gpu/drm/i915/i915_drv.h +0 -60
116 lines not on this page · raw message
Signature · 1 line
2.40.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Move display identification/probing under display/ (rev3)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: i915: Move display identification/probing under display/ (rev3)
URL : https://patchwork.freedesktop.org/series/117931/
State : warning
== Summary ==
Error: dim checkpatch failedd9e8003baa3d drm/i915/display: Move display device info to header under display/ Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:16: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #16:
new file mode 100644
-:33: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #33: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:13:
+#define DEV_INFO_DISPLAY_FOR_EACH_FLAG(func) \
+ /* Keep in alphabetical order */ \
+ func(cursor_needs_physical); \
+ func(has_cdclk_crawl); \
+ func(has_cdclk_squash); \
+ func(has_ddi); \
+ func(has_dp_mst); \
+ func(has_dsb); \
+ func(has_fpga_dbg); \
+ func(has_gmch); \
+ func(has_hotplug); \
+ func(has_hti); \
+ func(has_ipc); \
+ func(has_overlay); \
+ func(has_psr); \
+ func(has_psr_hw_tracking); \
+ func(overlay_needs_physical); \
+ func(supports_tv);
-:33: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects? #33: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:13:
+#define DEV_INFO_DISPLAY_FOR_EACH_FLAG(func) \
+ /* Keep in alphabetical order */ \
+ func(cursor_needs_physical); \
+ func(has_cdclk_crawl); \
+ func(has_cdclk_squash); \
+ func(has_ddi); \
+ func(has_dp_mst); \
+ func(has_dsb); \
+ func(has_fpga_dbg); \
+ func(has_gmch); \
+ func(has_hotplug); \
+ func(has_hti); \
+ func(has_ipc); \
+ func(has_overlay); \
+ func(has_psr); \
+ func(has_psr_hw_tracking); \
+ func(overlay_needs_physical); \
+ func(supports_tv);
-:33: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #33: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:13:
+#define DEV_INFO_DISPLAY_FOR_EACH_FLAG(func) \
+ /* Keep in alphabetical order */ \
+ func(cursor_needs_physical); \
+ func(has_cdclk_crawl); \
+ func(has_cdclk_squash); \
+ func(has_ddi); \
+ func(has_dp_mst); \
+ func(has_dsb); \
+ func(has_fpga_dbg); \
+ func(has_gmch); \
+ func(has_hotplug); \
+ func(has_hti); \
+ func(has_ipc); \
+ func(has_overlay); \
+ func(has_psr); \
+ func(has_psr_hw_tracking); \
+ func(overlay_needs_physical); \
+ func(supports_tv);
total: 1 errors, 2 warnings, 1 checks, 127 lines checked 8935a63f121f drm/i915: Convert INTEL_INFO()->display to a pointer -:241: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #241: FILE: drivers/gpu/drm/i915/display/intel_display_reg_defs.h:43:
+ DISPLAY_INFO(dev_priv)->trans_offsets[TRANSCODER_A] + \
-:1742: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues #1742: FILE: drivers/gpu/drm/i915/intel_device_info.c:141:
+#define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, str_yes_no(info->display->name))
total: 0 errors, 1 warnings, 1 checks, 1610 lines checkedd3676df51bad drm/i915/display: Move display runtime info to display structure -:71: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #71: FILE: drivers/gpu/drm/i915/display/intel_display.h:108:
+#define sprite_name(p, s) ((p) * DISPLAY_RUNTIME_INFO(dev_priv)->num_sprites[(p)] + (s) + 'A')
-:89: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #89: FILE: drivers/gpu/drm/i915/display/intel_display.h:232:
+ for_each_if (DISPLAY_RUNTIME_INFO(__dev_priv)->cpu_transcoder_mask & BIT(__t))
-:197: WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns #197: FILE: drivers/gpu/drm/i915/i915_drv.h:208:
+ struct intel_display_runtime_info __display_runtime; /* Access with DISPLAY_RUNTIME_INFO() */
-:232: WARNING:LONG_LINE: line length of 110 exceeds 100 columns #232: FILE: drivers/gpu/drm/i915/i915_drv.h:836:
+#define HAS_TRANSCODER(i915, trans) ((DISPLAY_RUNTIME_INFO(i915)->cpu_transcoder_mask & BIT(trans)) != 0)
total: 0 errors, 3 warnings, 1 checks, 1066 lines checkededdc77d2575d drm/i915/display: Make display responsible for probing its own IP Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:46: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #46:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 1898 lines checked 4ef775a00548 drm/i915/display: Handle GMD_ID identification in display code 27a8a59ac49d drm/i915/display: Move feature test macros to intel_display_device.h -:24: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #24: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:37:
+#define HAS_CUR_FBC(i915) (!HAS_GMCH(i915) && DISPLAY_VER(i915) >= 7)
-:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #25: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:38:
+#define HAS_D12_PLANE_MINIMIZATION(i915) (IS_ROCKETLAKE(i915) || IS_ALDERLAKE_S(i915))
-:29: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #29: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:42:
+#define HAS_DOUBLE_BUFFERED_M_N(i915) (DISPLAY_VER(i915) >= 9 || IS_BROADWELL(i915))
-:31: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #31: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:44:
+#define HAS_DP20(i915) (IS_DG2(i915) || DISPLAY_VER(i915) >= 14)
-:39: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #39: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:52:
+#define HAS_GMBUS_BURST_READ(i915) (DISPLAY_VER(i915) >= 10 || IS_KABYLAKE(i915))
-:41: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #41: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:54:
+#define HAS_HW_SAGV_WM(i915) (DISPLAY_VER(i915) >= 13 && !IS_DGFX(i915))
-:43: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #43: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:56:
+#define HAS_IPS(i915) (IS_HSW_ULT(i915) || IS_BROADWELL(i915))
-:45: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #45: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:58:
+#define HAS_MBUS_JOINING(i915) (IS_ALDERLAKE_P(i915) || DISPLAY_VER(i915) >= 14)
-:51: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #51: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:64:
+#define HAS_SAGV(i915) (DISPLAY_VER(i915) >= 9 && !IS_LP(i915))
total: 0 errors, 0 warnings, 9 checks, 161 lines checked
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Move display identification/probing under display/ (rev3)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: i915: Move display identification/probing under display/ (rev3)
URL : https://patchwork.freedesktop.org/series/117931/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Move display identification/probing under display/ (rev3)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: i915: Move display identification/probing under display/ (rev3)
URL : https://patchwork.freedesktop.org/series/117931/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13180 -> Patchwork_117931v3
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v3/index.html
Participating hosts (40 -> 38)
------------------------------
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_117931v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@verify-random:
- fi-cfl-8109u: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#4613]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v3/fi-cfl-8109u/igt@[email protected]
* igt@i915_selftest@live@requests:
- bat-rpls-1: [PASS][2] -> [ABORT][3] ([i915#4983] / [i915#7911] / [i915#7920])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/bat-rpls-1/igt@i915_selftest@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v3/bat-rpls-1/igt@i915_selftest@[email protected]
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-cfl-8109u: NOTRUN -> [SKIP][4] ([fdo#109271]) +16 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v3/fi-cfl-8109u/igt@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- fi-cfl-8109u: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4579])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v3/fi-cfl-8109u/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-skl-guc: [DMESG-WARN][6] ([i915#8073]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/fi-skl-guc/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v3/fi-skl-guc/igt@i915_selftest@[email protected]
* igt@kms_busy@basic@flip:
- fi-cfl-8109u: [INCOMPLETE][8] -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/fi-cfl-8109u/igt@kms_busy@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v3/fi-cfl-8109u/igt@kms_busy@[email protected]
#### Warnings ####
* igt@kms_psr@sprite_plane_onoff:
- bat-rplp-1: [SKIP][10] ([i915#1072]) -> [ABORT][11] ([i915#8442])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v3/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8073]: https://gitlab.freedesktop.org/drm/intel/issues/8073
[i915#8189]: https://gitlab.freedesktop.org/drm/intel/issues/8189
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
Build changes
-------------
* Linux: CI_DRM_13180 -> Patchwork_117931v3
CI-20190529: 20190529
CI_DRM_13180: e48bc7435824325de6a73fae68dc521e2be13960 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7301: 4b388fa87e1281587e723ef864e466fe396c3381 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117931v3: e48bc7435824325de6a73fae68dc521e2be13960 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
deaa29e3686c drm/i915/display: Move feature test macros to intel_display_device.h 577a17eb52d7 drm/i915/display: Handle GMD_ID identification in display code 66884309a4da drm/i915/display: Make display responsible for probing its own IP 6e702fc107d8 drm/i915/display: Move display runtime info to display structure ef5f9d01e398 drm/i915: Convert INTEL_INFO()->display to a pointer a2e21bd0b816 drm/i915/display: Move display device info to header under display/
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v3/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Move display identification/probing under display/ (rev4)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: i915: Move display identification/probing under display/ (rev4)
URL : https://patchwork.freedesktop.org/series/117931/
State : warning
== Summary ==
Error: dim checkpatch failed7ffe6d000c98 drm/i915/display: Move display device info to header under display/ Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:16: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #16:
new file mode 100644
-:33: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #33: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:13:
+#define DEV_INFO_DISPLAY_FOR_EACH_FLAG(func) \
+ /* Keep in alphabetical order */ \
+ func(cursor_needs_physical); \
+ func(has_cdclk_crawl); \
+ func(has_cdclk_squash); \
+ func(has_ddi); \
+ func(has_dp_mst); \
+ func(has_dsb); \
+ func(has_fpga_dbg); \
+ func(has_gmch); \
+ func(has_hotplug); \
+ func(has_hti); \
+ func(has_ipc); \
+ func(has_overlay); \
+ func(has_psr); \
+ func(has_psr_hw_tracking); \
+ func(overlay_needs_physical); \
+ func(supports_tv);
-:33: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects? #33: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:13:
+#define DEV_INFO_DISPLAY_FOR_EACH_FLAG(func) \
+ /* Keep in alphabetical order */ \
+ func(cursor_needs_physical); \
+ func(has_cdclk_crawl); \
+ func(has_cdclk_squash); \
+ func(has_ddi); \
+ func(has_dp_mst); \
+ func(has_dsb); \
+ func(has_fpga_dbg); \
+ func(has_gmch); \
+ func(has_hotplug); \
+ func(has_hti); \
+ func(has_ipc); \
+ func(has_overlay); \
+ func(has_psr); \
+ func(has_psr_hw_tracking); \
+ func(overlay_needs_physical); \
+ func(supports_tv);
-:33: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #33: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:13:
+#define DEV_INFO_DISPLAY_FOR_EACH_FLAG(func) \
+ /* Keep in alphabetical order */ \
+ func(cursor_needs_physical); \
+ func(has_cdclk_crawl); \
+ func(has_cdclk_squash); \
+ func(has_ddi); \
+ func(has_dp_mst); \
+ func(has_dsb); \
+ func(has_fpga_dbg); \
+ func(has_gmch); \
+ func(has_hotplug); \
+ func(has_hti); \
+ func(has_ipc); \
+ func(has_overlay); \
+ func(has_psr); \
+ func(has_psr_hw_tracking); \
+ func(overlay_needs_physical); \
+ func(supports_tv);
total: 1 errors, 2 warnings, 1 checks, 127 lines checked 6294f58b3d62 drm/i915: Convert INTEL_INFO()->display to a pointer -:241: WARNING:LONG_LINE: line length of 101 exceeds 100 columns #241: FILE: drivers/gpu/drm/i915/display/intel_display_reg_defs.h:43:
+ DISPLAY_INFO(dev_priv)->trans_offsets[TRANSCODER_A] + \
-:1742: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues #1742: FILE: drivers/gpu/drm/i915/intel_device_info.c:141:
+#define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, str_yes_no(info->display->name))
total: 0 errors, 1 warnings, 1 checks, 1610 lines checkedcebe73c61b1a drm/i915/display: Move display runtime info to display structure -:71: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #71: FILE: drivers/gpu/drm/i915/display/intel_display.h:108:
+#define sprite_name(p, s) ((p) * DISPLAY_RUNTIME_INFO(dev_priv)->num_sprites[(p)] + (s) + 'A')
-:89: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #89: FILE: drivers/gpu/drm/i915/display/intel_display.h:232:
+ for_each_if (DISPLAY_RUNTIME_INFO(__dev_priv)->cpu_transcoder_mask & BIT(__t))
-:197: WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns #197: FILE: drivers/gpu/drm/i915/i915_drv.h:208:
+ struct intel_display_runtime_info __display_runtime; /* Access with DISPLAY_RUNTIME_INFO() */
-:232: WARNING:LONG_LINE: line length of 110 exceeds 100 columns #232: FILE: drivers/gpu/drm/i915/i915_drv.h:836:
+#define HAS_TRANSCODER(i915, trans) ((DISPLAY_RUNTIME_INFO(i915)->cpu_transcoder_mask & BIT(trans)) != 0)
total: 0 errors, 3 warnings, 1 checks, 1066 lines checked401e0dc719b0 drm/i915/display: Make display responsible for probing its own IP Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:46: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #46:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 1898 lines checked f63573931151 drm/i915/display: Handle GMD_ID identification in display code 9be3f41b9537 drm/i915/display: Move feature test macros to intel_display_device.h -:24: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #24: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:37:
+#define HAS_CUR_FBC(i915) (!HAS_GMCH(i915) && DISPLAY_VER(i915) >= 7)
-:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #25: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:38:
+#define HAS_D12_PLANE_MINIMIZATION(i915) (IS_ROCKETLAKE(i915) || IS_ALDERLAKE_S(i915))
-:29: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #29: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:42:
+#define HAS_DOUBLE_BUFFERED_M_N(i915) (DISPLAY_VER(i915) >= 9 || IS_BROADWELL(i915))
-:31: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #31: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:44:
+#define HAS_DP20(i915) (IS_DG2(i915) || DISPLAY_VER(i915) >= 14)
-:39: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #39: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:52:
+#define HAS_GMBUS_BURST_READ(i915) (DISPLAY_VER(i915) >= 10 || IS_KABYLAKE(i915))
-:41: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #41: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:54:
+#define HAS_HW_SAGV_WM(i915) (DISPLAY_VER(i915) >= 13 && !IS_DGFX(i915))
-:43: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #43: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:56:
+#define HAS_IPS(i915) (IS_HSW_ULT(i915) || IS_BROADWELL(i915))
-:45: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #45: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:58:
+#define HAS_MBUS_JOINING(i915) (IS_ALDERLAKE_P(i915) || DISPLAY_VER(i915) >= 14)
-:51: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i915' - possible side-effects? #51: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:64:
+#define HAS_SAGV(i915) (DISPLAY_VER(i915) >= 9 && !IS_LP(i915))
total: 0 errors, 0 warnings, 9 checks, 161 lines checked
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: Move display identification/probing under display/ (rev4)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: i915: Move display identification/probing under display/ (rev4)
URL : https://patchwork.freedesktop.org/series/117931/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Move display identification/probing under display/ (rev4)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: i915: Move display identification/probing under display/ (rev4)
URL : https://patchwork.freedesktop.org/series/117931/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13180 -> Patchwork_117931v4
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/index.html
Participating hosts (40 -> 39)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_117931v4 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@verify-random:
- fi-cfl-8109u: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#4613]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/fi-cfl-8109u/igt@[email protected]
* igt@i915_selftest@live@gt_lrc:
- bat-adlp-9: [PASS][2] -> [INCOMPLETE][3] ([i915#4983] / [i915#7913])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/bat-adlp-9/igt@i915_selftest@live@gt_lrc.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/bat-adlp-9/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][4] -> [ABORT][5] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/bat-rpls-1/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/bat-rpls-1/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@slpc:
- bat-rpls-2: [PASS][6] -> [DMESG-WARN][7] ([i915#6367])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/bat-rpls-2/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/bat-rpls-2/igt@i915_selftest@[email protected]
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-cfl-8109u: NOTRUN -> [SKIP][8] ([fdo#109271]) +16 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/fi-cfl-8109u/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [PASS][9] -> [FAIL][10] ([i915#7932]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/bat-dg2-8/igt@kms_pipe_crc_basic@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- fi-cfl-8109u: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4579])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/fi-cfl-8109u/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gt_mocs:
- {bat-mtlp-8}: [DMESG-FAIL][12] ([i915#7059]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@hangcheck:
- fi-skl-guc: [DMESG-WARN][14] ([i915#8073]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/fi-skl-guc/igt@i915_selftest@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/fi-skl-guc/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@requests:
- {bat-mtlp-8}: [DMESG-FAIL][16] ([i915#8497]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/bat-mtlp-8/igt@i915_selftest@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/bat-mtlp-8/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@slpc:
- {bat-mtlp-8}: [DMESG-WARN][18] ([i915#6367]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/bat-mtlp-8/igt@i915_selftest@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/bat-mtlp-8/igt@i915_selftest@[email protected]
* igt@kms_busy@basic@flip:
- fi-cfl-8109u: [INCOMPLETE][20] -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/fi-cfl-8109u/igt@kms_busy@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/fi-cfl-8109u/igt@kms_busy@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#8073]: https://gitlab.freedesktop.org/drm/intel/issues/8073
[i915#8189]: https://gitlab.freedesktop.org/drm/intel/issues/8189
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
Build changes
-------------
* Linux: CI_DRM_13180 -> Patchwork_117931v4
CI-20190529: 20190529
CI_DRM_13180: e48bc7435824325de6a73fae68dc521e2be13960 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7301: 4b388fa87e1281587e723ef864e466fe396c3381 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117931v4: e48bc7435824325de6a73fae68dc521e2be13960 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
3ac3b7603308 drm/i915/display: Move feature test macros to intel_display_device.h 3691db797410 drm/i915/display: Handle GMD_ID identification in display code e9a78c6277a9 drm/i915/display: Make display responsible for probing its own IP f514dec300e8 drm/i915/display: Move display runtime info to display structure eaa46e9f4aef drm/i915: Convert INTEL_INFO()->display to a pointer 7770ba21d5cc drm/i915/display: Move display device info to header under display/
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for i915: Move display identification/probing under display/ (rev4)
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: i915: Move display identification/probing under display/ (rev4)
URL : https://patchwork.freedesktop.org/series/117931/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13180_full -> Patchwork_117931v4_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (8 -> 7)
------------------------------
Missing (1): shard-rkl0
New tests
---------
New tests have been introduced between CI_DRM_13180_full and Patchwork_117931v4_full:
### New IGT tests (3) ###
* igt@kms_flip@single-buffer-flip-vs-dpms-off-vs-modeset-interruptible@a-dp1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_flip@single-buffer-flip-vs-dpms-off-vs-modeset-interruptible@b-dp1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_flip@single-buffer-flip-vs-dpms-off-vs-modeset-interruptible@c-dp1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_117931v4_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2842])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-glk2/igt@gem_exec_fair@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-glk1/igt@gem_exec_fair@[email protected]
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#3886])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl3/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium_hpd@hdmi-hpd-storm:
- shard-apl: NOTRUN -> [SKIP][4] ([fdo#109271]) +21 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl3/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][5] -> [FAIL][6] ([IGT#6] / [i915#2346])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_hdr@static-swap:
- shard-apl: NOTRUN -> [SKIP][7] ([IGT#6] / [fdo#109271] / [i915#4579])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl3/igt@[email protected]
* igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4579]) +13 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-snb4/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][9] ([fdo#109271]) +17 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-snb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-hdmi-a-1.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#658])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl3/igt@[email protected]
* igt@kms_psr@basic:
- shard-apl: NOTRUN -> [SKIP][11] ([IGT#6] / [fdo#109271]) +16 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl3/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][12] ([i915#6268]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-tglu-7/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-tglu-6/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- {shard-tglu}: [FAIL][14] ([i915#2842]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-tglu-9/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-tglu-9/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][16] ([i915#2842]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-glk6/igt@gem_exec_fair@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-glk4/igt@gem_exec_fair@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- {shard-tglu}: [SKIP][18] ([i915#4281]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-tglu-8/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-tglu-2/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-dg1}: [FAIL][20] ([i915#3591]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-dg1-12/igt@i915_pm_rc6_residency@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-dg1-14/igt@i915_pm_rc6_residency@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][22] ([IGT#6] / [i915#2346]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-glk1/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-glk5/igt@[email protected]
* igt@kms_cursor_legacy@single-move@pipe-b:
- {shard-rkl}: [INCOMPLETE][24] ([i915#8011]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-rkl-7/igt@kms_cursor_legacy@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-rkl-3/igt@kms_cursor_legacy@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][26] ([IGT#6] / [i915#4767]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-apl1/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl7/igt@[email protected]
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [ABORT][28] ([i915#180]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-apl2/igt@kms_flip@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl3/igt@kms_flip@[email protected]
* igt@kms_rotation_crc@primary-y-tiled-reflect-x-0:
- {shard-rkl}: [ABORT][30] ([i915#7461] / [i915#8311]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-rkl-6/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-rkl-1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8311]: https://gitlab.freedesktop.org/drm/intel/issues/8311
[i915#8398]: https://gitlab.freedesktop.org/drm/intel/issues/8398
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
Build changes
-------------
* Linux: CI_DRM_13180 -> Patchwork_117931v4
CI-20190529: 20190529
CI_DRM_13180: e48bc7435824325de6a73fae68dc521e2be13960 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7301: 4b388fa87e1281587e723ef864e466fe396c3381 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117931v4: e48bc7435824325de6a73fae68dc521e2be13960 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/index.html
Re: [Intel-gfx] ✓ Fi.CI.IGT: success for i915: Move display identification/probing under display/ (rev4)
Quoted 11 lines · Patchwork
== Series Details ==
Series: i915: Move display identification/probing under display/ (rev4)
URL : https://patchwork.freedesktop.org/series/117931/
State : success== Summary ==
CI Bug Log - changes from
CI_DRM_13180_full->Patchwork_117931v4_full
====================================================
Quoted 6 lines
Summary
-------**SUCCESS**
No regressions found.
Series applied to drm-intel-next. Thanks for the reviews!
Matt
Quoted 230 lines
Participating hosts (8 -> 7)
------------------------------Missing (1): shard-rkl0
New tests
---------New tests have been introduced between
CI_DRM_13180_fullandPatchwork_117931v4_full:### New IGT tests (3) ###
* igt@kms_flip@single-buffer-flip-vs-dpms-off-vs-modeset-interruptible@a-dp1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s* igt@kms_flip@single-buffer-flip-vs-dpms-off-vs-modeset-interruptible@b-dp1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s* igt@kms_flip@single-buffer-flip-vs-dpms-off-vs-modeset-interruptible@c-dp1:
- Statuses : 1 pass(s)
- Exec time: [0.0] sKnown issues
------------Here are the changes found in
Patchwork_117931v4_fullthat come from known issues:### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2842])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-glk2/igt@gem_exec_fair@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-glk1/igt@gem_exec_fair@[email protected]* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#3886])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl3/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html* igt@kms_chamelium_hpd@hdmi-hpd-storm:
- shard-apl: NOTRUN -> [SKIP][4] ([fdo#109271]) +21 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl3/igt@[email protected]* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [PASS][5] -> [FAIL][6] ([IGT#6] / [i915#2346])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html* igt@kms_hdr@static-swap:
- shard-apl: NOTRUN -> [SKIP][7] ([IGT#6] / [fdo#109271] / [i915#4579])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl3/igt@[email protected]* igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4579]) +13 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-snb4/igt@kms_plane_scaling@[email protected]* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][9] ([fdo#109271]) +17 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-snb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-hdmi-a-1.html* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#658])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl3/igt@[email protected]* igt@kms_psr@basic:
- shard-apl: NOTRUN -> [SKIP][11] ([IGT#6] / [fdo#109271]) +16 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl3/igt@[email protected]#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][12] ([i915#6268]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-tglu-7/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-tglu-6/igt@[email protected]* igt@gem_exec_fair@basic-flow@rcs0:
- {shard-tglu}: [FAIL][14] ([i915#2842]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-tglu-9/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-tglu-9/igt@gem_exec_fair@[email protected]* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][16] ([i915#2842]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-glk6/igt@gem_exec_fair@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-glk4/igt@gem_exec_fair@[email protected]* igt@i915_pm_dc@dc9-dpms:
- {shard-tglu}: [SKIP][18] ([i915#4281]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-tglu-8/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-tglu-2/igt@[email protected]* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-dg1}: [FAIL][20] ([i915#3591]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-dg1-12/igt@i915_pm_rc6_residency@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-dg1-14/igt@i915_pm_rc6_residency@[email protected]* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][22] ([IGT#6] / [i915#2346]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-glk1/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-glk5/igt@[email protected]* igt@kms_cursor_legacy@single-move@pipe-b:
- {shard-rkl}: [INCOMPLETE][24] ([i915#8011]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-rkl-7/igt@kms_cursor_legacy@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-rkl-3/igt@kms_cursor_legacy@[email protected]* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [FAIL][26] ([IGT#6] / [i915#4767]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-apl1/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl7/igt@[email protected]* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [ABORT][28] ([i915#180]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-apl2/igt@kms_flip@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-apl3/igt@kms_flip@[email protected]* igt@kms_rotation_crc@primary-y-tiled-reflect-x-0:
- {shard-rkl}: [ABORT][30] ([i915#7461] / [i915#8311]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13180/shard-rkl-6/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/shard-rkl-1/igt@[email protected]{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8311]: https://gitlab.freedesktop.org/drm/intel/issues/8311
[i915#8398]: https://gitlab.freedesktop.org/drm/intel/issues/8398
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502Build changes
-------------* Linux:
CI_DRM_13180->Patchwork_117931v4CI-20190529: 20190529
CI_DRM_13180:e48bc7435824325de6a73fae68dc521e2be13960@git://anongit.freedesktop.org/gfx-ci/linux
IGT_7301:4b388fa87e1281587e723ef864e466fe396c3381@ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_117931v4:e48bc7435824325de6a73fae68dc521e2be13960@git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509:fdc5a4ca11124ab8413c7988896eec4c97336694@git://anongit.freedesktop.org/piglit== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117931v4/index.html
Signature · 4 lines
Matt Roper Graphics Software Engineer Linux GPU Platform Enablement Intel Corporation