Skip to contentSkip to conversation

tracing: Modify print_fields() for fields output order

PATCH New sunliming 1 participant 1 message May 25, 2023 Tracing

lore
Share & tools
lore

sunliming

author
#0 lore raw

PATCH 1/1 tracing: Modify print_fields() for fields output order

Now the print_fields() print trace event fields in reverse order. Modify it to the positive sequence.

Example outputs for a user event:

	test0 u32 count1; u32 count2

Output before:

	example-2547    [000] .....   325.666387: test0: count2=0x2 (2) count1=0x1 (1)

Output after:

	example-2742    [002] .....   429.769370: test0: count1=0x1 (1) count2=0x2 (2)
---
 kernel/trace/trace_output.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/trace_output.c +1 -1
index 15f05faaae44..1e33f367783e 100644
@@ -847,7 +847,7 @@ static void print_fields(struct trace_iterator *iter, struct trace_event_call *c
 	int ret;
 	void *pos;
 
-	list_for_each_entry(field, head, link) {
+	list_for_each_entry_reverse(field, head, link) {
 		trace_seq_printf(&iter->seq, " %s=", field->name);
 		if (field->offset + field->size > iter->ent_size) {
 			trace_seq_puts(&iter->seq, "<OVERFLOW>");
Signature · 1 line
2.25.1