Skip to contentSkip to conversation

hwmon:(pmbus/ucd9000): Drop unnecessary error check for debugfs_create_dir

PATCH Applied Osama Muhammad 2 participants 2 messages May 26, 2023 Hardware monitoring

v2 of 3 Applied Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 hwmon:(pmbus/ucd9000): Drop unnecessary error check for debugfs_create_dir

This patch removes the error checking for debugfs_create_dir in ucd9000.c. This is because the debugfs_create_dir() does not return NULL but an ERR_PTR after an error.
The DebugFS kernel API is developed in a way that the caller can safely ignore the errors that occur during the creation of DebugFS nodes.The debugfs Api handles it gracefully. The check is unnecessary.

Link to the comment above debugfs_create_dir:
https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L565

---
changes since v1
-Added more descriptive commit message.

---
 drivers/hwmon/pmbus/ucd9000.c | 2 --
 1 file changed, 2 deletions(-)
drivers/hwmon/pmbus/ucd9000.c +0 -2
index 3daaf2237832..73559afa8ba7 100644
@@ -512,8 +512,6 @@ static int ucd9000_init_debugfs(struct i2c_client *client,
 		return -ENOENT;
 
 	data->debugfs = debugfs_create_dir(client->name, debugfs);
-	if (!data->debugfs)
-		return -ENOENT;
 
 	/*
 	 * Of the chips this driver supports, only the UCD9090, UCD90160,
Signature · 1 line
2.34.1
maintainer Applied
#1 lore raw
Quoted 8 lines · Osama Muhammad

This patch removes the error checking for debugfs_create_dir in ucd9000.c. This is because the debugfs_create_dir() does not return NULL but an ERR_PTR after an error.
The DebugFS kernel API is developed in a way that the caller can safely ignore the errors that occur during the creation of DebugFS nodes.The debugfs Api handles it gracefully. The check is unnecessary.

Quoted 4 lines

Link to the comment above debugfs_create_dir:
https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L565

Applied.

Thanks,
Guenter

Quoted 20 lines

---
changes since v1
-Added more descriptive commit message.

---
 drivers/hwmon/pmbus/ucd9000.c | 2 --
 1 file changed, 2 deletions(-)
drivers/hwmon/pmbus/ucd9000.c +0 -2
index 3daaf2237832..73559afa8ba7 100644
@@ -512,8 +512,6 @@ static int ucd9000_init_debugfs(struct i2c_client *client,
 		return -ENOENT;
 
 	data->debugfs = debugfs_create_dir(client->name, debugfs);
-	if (!data->debugfs)
-		return -ENOENT;
 
 	/*
 	 * Of the chips this driver supports, only the UCD9090, UCD90160,