package/mbpoll: new package
PATCH 1/1 package/mbpoll: new package
From: Jon Ringle <[email protected]>
mbpoll is a tool that can be used to test communication with modbus slave devices
--- package/Config.in | 1 + package/mbpoll/Config.in | 5 +++++ package/mbpoll/mbpoll.hash | 3 +++ package/mbpoll/mbpoll.mk | 11 +++++++++++ 4 files changed, 20 insertions(+) create mode 100644 package/mbpoll/Config.in create mode 100644 package/mbpoll/mbpoll.hash create mode 100644 package/mbpoll/mbpoll.mk
package/Config.in +1 -0
@@ -125,6 +125,7 @@ menu "Debugging, profiling and benchmark" source "package/lttng-babeltrace/Config.in" source "package/lttng-modules/Config.in" source "package/lttng-tools/Config.in" + source "package/mbpoll/Config.in" source "package/mbw/Config.in" source "package/mcelog/Config.in" source "package/memstat/Config.in"
package/mbpoll/Config.in new file +5 -0
@@ -0,0 +1,5 @@ +config BR2_PACKAGE_MBPOLL + bool "mbpoll" + select BR2_PACKAGE_LIBMODBUS + help + mbpoll utility to test modbus
package/mbpoll/mbpoll.hash new file +3 -0
@@ -0,0 +1,3 @@ +# Locally calculated +sha256 046fdac2d88eddb71a1091a87d0a4bb23fee39595a929cde50c546dae0fbcd6d mbpoll-1.5.tar.gz +sha256 3972dc9744f6499f0f9b2dbf76696f2ae7ad8af9b23dde66d6af86c9dfb36986 COPYING
package/mbpoll/mbpoll.mk new file +11 -0
@@ -0,0 +1,11 @@ +################################################################################ +# +# mbpoll +# +################################################################################ + +MBPOLL_VERSION = 1.5 +MBPOLL_SITE = $(call github,epsilonrt,mbpoll,v$(MBPOLL_VERSION)) +MBPOLL_DEPENDENCIES = libmodbus + +$(eval $(cmake-package))
Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hello Jon,
Quoted 6 lines · On Fri, 26 May 2023 14:47:07 -0400 [email protected] wrote:
From: Jon Ringle <[email protected]>
mbpoll is a tool that can be used to test communication with modbus slave devices
Signed-off-by Jon Ringle <[email protected]>
Sorry for the long delay in providing feedback to your patch. The good news is that I have applied it, with a few changes (see below).
Quoted 6 lines
--- package/Config.in | 1 + package/mbpoll/Config.in | 5 +++++ package/mbpoll/mbpoll.hash | 3 +++ package/mbpoll/mbpoll.mk | 11 +++++++++++ 4 files changed, 20 insertions(+)
An entry in the DEVELOPERS file was missing... and I forgot about it myself, so I fixed that up in a follow-up commit.
package/mbpoll/Config.in line 5
Quoted 11 lines
package/mbpoll/Config.in new file +5
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_MBPOLL + bool "mbpoll" + select BR2_PACKAGE_LIBMODBUS + help + mbpoll utility to test modbus
I improved this a little bit: slightly extended description taken from the github homepage, and more importantly, URL of the upstream project, which is required in Buildroot Config.in help text.
Quoted 15 lines
package/mbpoll/mbpoll.hash new file +3
-0@@ -0,0 +1,3 @@ +# Locally calculated +sha256 046fdac2d88eddb71a1091a87d0a4bb23fee39595a929cde50c546dae0fbcd6d mbpoll-1.5.tar.gz +sha256 3972dc9744f6499f0f9b2dbf76696f2ae7ad8af9b23dde66d6af86c9dfb36986 COPYINGpackage/mbpoll/mbpoll.mk new file +0
-0
package/mbpoll/mbpoll.mk line 9
Quoted 9 lines
package/mbpoll/mbpoll.mk new file +9
-0@@ -0,0 +1,11 @@ +################################################################################ +# +# mbpoll +# +################################################################################ + +MBPOLL_VERSION = 1.5 +MBPOLL_SITE = $(call github,epsilonrt,mbpoll,v$(MBPOLL_VERSION)) +MBPOLL_DEPENDENCIES = libmodbus
You forgot host-pkgconf in the dependencies, which is needed for mbpoll to find libmodbus.
Also, you properly added the hash of COPYING in the hash file, but you forgot MBPOLL_LICENSE and MBPOLL_LICENSE_FILES.
As said, I fixed up those minor details when applying.
Thanks a lot for your contribution!
Thomas
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot