scsi: lpfc: Replace all non-returning strlcpy with strscpy
Subsystems (2)
PATCH 1/1 scsi: lpfc: Replace all non-returning strlcpy with strscpy
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
--- drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_hbadisc.c +1 -1
@@ -4835,7 +4835,7 @@ lpfc_nlp_state_name(char *buffer, size_t size, int state) };if (state <NLP_STE_MAX_STATE && states[state]) -strlcpy (buffer, states[state], size); +strscpy (buffer, states[state], size);else snprintf (buffer, size,"unknown (%d)" , state);return buffer;
Hi Azeem,
Looks good.
Thanks,
Justin
Quoted 31 lines · Azeem Shaikh
strlcpy()reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to removestrlcpy()completely [2], replacestrlcpy()here withstrscpy().
No return values were used, so direct replacement is safe.[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89Signed-off-by Azeem Shaikh <[email protected]>--- drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/scsi/lpfc/lpfc_hbadisc.c +1
-1@@ -4835,7 +4835,7 @@ lpfc_nlp_state_name(char *buffer, size_t size, int state) };if (state <NLP_STE_MAX_STATE && states[state]) -strlcpy (buffer, states[state], size); +strscpy (buffer, states[state], size);else snprintf (buffer, size,"unknown (%d)" , state);return buffer;
Martin K. Petersen
AppliedAzeem,
Quoted 6 lines
strlcpy()reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to removestrlcpy()completely [2], replacestrlcpy()here withstrscpy(). No return values were used, so direct replacement is safe.
Applied to 6.5/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering