mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M
PATCH 1/1 mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M
It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does not work when the core is trying to use REQ_OP_WRITE_ZEROES.
We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES:
[ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2
Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to disable TRIM.
--- drivers/mmc/core/quirks.h | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/mmc/core/quirks.h +7 -0
@@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {MMC_FIXUP ("V10016" ,CID_MANFID_KINGSTON ,CID_OEMID_ANY , add_quirk_mmc,MMC_QUIRK_TRIM_BROKEN ), +/* +* Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to +* support being used to offload WRITE_ZEROES. +*/ +MMC_FIXUP ("Q2J54A" ,CID_MANFID_MICRON ,0x014e , add_quirk_mmc, + MMC_QUIRK_TRIM_BROKEN), +/* * Some SD cards reports discard support while they don't */
Signature · 1 line
2.40.1
+Bean
Thanks,
Avri
Quoted 39 lines
It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does not work when the core is trying to use
REQ_OP_WRITE_ZEROES.We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W that we did not previously have and tracked it down to
REQ_OP_WRITE_ZEROES:[ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags
0x800phys_seg0 prio class 2Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to disable TRIM.
Signed-off-by Robert Marko <[email protected]>--- drivers/mmc/core/quirks.h | 7 +++++++ 1 file changed, 7 insertions(+)drivers/mmc/core/quirks.h index renamed from drivers/mmc/core/quirks.h +0
-0
29b9497936df..77caa0c903f8100644drivers/mmc/core/quirks.h +7
-0@@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = { MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY, add_quirk_mmc, MMC_QUIRK_TRIM_BROKEN), +/* +* Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to +* support being used to offload WRITE_ZEROES. +*/ +MMC_FIXUP ("Q2J54A" ,CID_MANFID_MICRON ,0x014e , add_quirk_mmc, + MMC_QUIRK_TRIM_BROKEN), +/* * Some SD cards reports discard support while they don't */
--
2.40.1
+ Luca (Bean was added by Avri in another thread)
Quoted 10 lines · Robert Marko
It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does not work when the core is trying to use
REQ_OP_WRITE_ZEROES.We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W that we did not previously have and tracked it down to
REQ_OP_WRITE_ZEROES:[ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to disable TRIM.
Let's leave this another week or so, to allow Micron folkz to confirm before applying.
Quoted 2 lines
Signed-off-by Robert Marko <[email protected]>
Kind regards
Uffe
Quoted 25 lines
--- drivers/mmc/core/quirks.h | 7 +++++++ 1 file changed, 7 insertions(+)drivers/mmc/core/quirks.h +7
-1@@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {MMC_FIXUP ("V10016" ,CID_MANFID_KINGSTON ,CID_OEMID_ANY , add_quirk_mmc,MMC_QUIRK_TRIM_BROKEN ), +/* +* Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to +* support being used to offload WRITE_ZEROES. +*/ +MMC_FIXUP ("Q2J54A" ,CID_MANFID_MICRON ,0x014e , add_quirk_mmc, + MMC_QUIRK_TRIM_BROKEN), +/* * Some SD cards reports discard support while they don't */ --2.40.1
Quoted 12 lines · Ulf Hansson
+ Luca (Bean was added by Avri in another thread)
Quoted 8 lines · Robert Marko
It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does not work when the core is trying to use
REQ_OP_WRITE_ZEROES.We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W that we did not previously have and tracked it down to
REQ_OP_WRITE_ZEROES:[ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2
Quoted 8 lines
Quoted 2 lines
Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to disable TRIM.
Let's leave this another week or so, to allow Micron folkz to confirm before applying.
Quoted 2 lines
Signed-off-by Robert Marko <[email protected]>
Applied for next and by adding a stable tag, thanks!
Kind regards
Uffe
Quoted 26 lines
Quoted 26 lines
--- drivers/mmc/core/quirks.h | 7 +++++++ 1 file changed, 7 insertions(+)drivers/mmc/core/quirks.h +7
-1@@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {MMC_FIXUP ("V10016" ,CID_MANFID_KINGSTON ,CID_OEMID_ANY , add_quirk_mmc,MMC_QUIRK_TRIM_BROKEN ), +/* +* Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to +* support being used to offload WRITE_ZEROES. +*/ +MMC_FIXUP ("Q2J54A" ,CID_MANFID_MICRON ,0x014e , add_quirk_mmc, + MMC_QUIRK_TRIM_BROKEN), +/* * Some SD cards reports discard support while they don't */ --2.40.1
Quoted 17 lines · Ulf Hansson
Quoted 15 lines · Ulf Hansson
+ Luca (Bean was added by Avri in another thread)
Quoted 10 lines · Robert Marko
It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does not work when the core is trying to use
REQ_OP_WRITE_ZEROES.We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W that we did not previously have and tracked it down to
REQ_OP_WRITE_ZEROES:[ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to disable TRIM.
Quoted 7 lines
Quoted 5 lines
Let's leave this another week or so, to allow Micron folkz to confirm before applying.
Quoted 2 lines
Signed-off-by Robert Marko <[email protected]>Applied for next and by adding a stable tag, thanks!
Thanks, I have sent the patch for one of Kingstom eMMC as well that seems to have TRIM broken
as well.
Regards,
Robert
Quoted 31 lines
Kind regards
UffeQuoted 26 lines
Quoted 26 lines
--- drivers/mmc/core/quirks.h | 7 +++++++ 1 file changed, 7 insertions(+)drivers/mmc/core/quirks.h +7
-1@@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = {MMC_FIXUP ("V10016" ,CID_MANFID_KINGSTON ,CID_OEMID_ANY , add_quirk_mmc,MMC_QUIRK_TRIM_BROKEN ), +/* +* Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to +* support being used to offload WRITE_ZEROES. +*/ +MMC_FIXUP ("Q2J54A" ,CID_MANFID_MICRON ,0x014e , add_quirk_mmc, + MMC_QUIRK_TRIM_BROKEN), +/* * Some SD cards reports discard support while they don't */ --2.40.1