leds: cht-wcove: set function cht_wc_leds_brightness_get storage-class-specifier to static
PATCH 1/1 leds: cht-wcove: set function cht_wc_leds_brightness_get storage-class-specifier to static
smatch reportsdrivers/leds/leds-cht-wcove.c:144:21: warning: symbol
'cht_wc_leds_brightness_get' was not declared. Should it be static?
This function is only used in its defining file, so it should be static.
Signed-off-by Tom Rix <[email protected]>
--- drivers/leds/leds-cht-wcove.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/leds/leds-cht-wcove.c +1 -1
@@ -141,7 +141,7 @@ static int cht_wc_leds_brightness_set(struct led_classdev *cdev,return ret; } -enum led_brightness cht_wc_leds_brightness_get (struct led_classdev *cdev) +static enum led_brightness cht_wc_leds_brightness_get (struct led_classdev *cdev) { struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev);unsigned int val;
Signature · 1 line
2.27.0
Lee Jones
maintainerQuoted 10 lines · Tom Rix
smatch reports
drivers/leds/leds-cht-wcove.c:144:21: warning: symbol
'cht_wc_leds_brightness_get' was not declared. Should it be static?This function is only used in its defining file, so it should be static.
Signed-off-by Tom Rix <[email protected]>--- drivers/leds/leds-cht-wcove.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Sorry, you were pipped to the post:
https://lore.kernel.org/r/[email protected]
Signature · 1 line
Lee Jones [李琼斯]