leds: cht-wcove: Fix an unsigned comparison which can never be negative
PATCH 1/1 leds: cht-wcove: Fix an unsigned comparison which can never be negative
The return value from the call to cht_wc_leds_find_freq() is int. However, the return value is being assigned to an unsigned int variable 'ctrl', so making it an int.
Eliminate the following warning:drivers/leds/leds-cht-wcove.c:236 cht_wc_leds_set_effect() warn: unsigned 'ctrl' is never less than zero.
Reported-by Abaci Robot <[email protected]>
Signed-off-by Yang Li <[email protected]>
--- drivers/leds/leds-cht-wcove.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/leds/leds-cht-wcove.c +1 -2
@@ -223,8 +223,7 @@ static int cht_wc_leds_set_effect(struct led_classdev *cdev, u8 effect) { struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev); -unsigned int ctrl; -int ret; +int ctrl, ret;mutex_lock (&led->mutex);
Signature · 1 line
2.20.1.7.g153144c
Quoted 7 lines · Yang Li
The return value from the call to
cht_wc_leds_find_freq()is int. However, the return value is being assigned to an unsigned int variable 'ctrl', so making it an int.Eliminate the following warning:
drivers/leds/leds-cht-wcove.c:236cht_wc_leds_set_effect()warn: unsigned 'ctrl' is never less than zero.
Quoted 6 lines
Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>--- drivers/leds/leds-cht-wcove.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks
Signature · 1 line
Lee Jones [李琼斯]