net: phy: mxl-gpy: extend interrupt fix to all impacted variants
Subsystems (4)
Xu Liang
maintainerPATCH 1/1 net: phy: mxl-gpy: extend interrupt fix to all impacted variants
The interrupt fix in commit 97a89ed101bb should be applied on all variants of GPY2xx PHY and GPY115C.
Fixes 97a89ed101bb ("net: phy: mxl-gpy: disable interrupts on GPY215 by default")
Signed-off-by Xu Liang <[email protected]>
--- drivers/net/phy/mxl-gpy.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-)
drivers/net/phy/mxl-gpy.c +3 -13
@@ -274,13 +274,6 @@ static int gpy_config_init(struct phy_device *phydev)return ret <0 ? ret :0 ; } -static bool gpy_has_broken_mdint (struct phy_device *phydev) -{ -/* At least these PHYs are known to have broken interrupt handling */ -return phydev->drv->phy_id ==PHY_ID_GPY215B || - phydev->drv->phy_id ==PHY_ID_GPY215C ; -} -static int gpy_probe (struct phy_device *phydev) {struct device *dev = &phydev->mdio.dev;
@@ -300,8 +293,7 @@ static int gpy_probe(struct phy_device *phydev) phydev->priv = priv;mutex_init (&priv->mbox_lock); -if (gpy_has_broken_mdint (phydev) && - !device_property_present (dev,"maxlinear,use-broken-interrupts" )) +if (!device_property_present (dev,"maxlinear,use-broken-interrupts" )) phydev->dev_flags |=PHY_F_NO_IRQ ; fw_version =phy_read (phydev,PHY_FWV );
@@ -659,11 +651,9 @@ static irqreturn_t gpy_handle_interrupt(struct phy_device *phydev)* frame. Therefore, polling is the best we can do and won't do any more * harm. * It was observed that this bug happens on link state and link speed -* changes on a GPY215B and GYP215C independent of the firmware version -* (which doesn't mean that this list is exhaustive). +* changes independent of the firmware version. */ -if (gpy_has_broken_mdint (phydev) && - (reg & (PHY_IMASK_LSTC |PHY_IMASK_LSPC ))) { +if (reg & (PHY_IMASK_LSTC |PHY_IMASK_LSPC )) { reg =gpy_mbox_read (phydev,REG_GPIO0_OUT );if (reg <0 ) {phy_error (phydev);
Signature · 1 line
2.17.1
Quoted 5 lines · Xu Liang
The interrupt fix in commit
97a89ed101bbshould be applied on all variants of GPY2xx PHY and GPY115C.Fixes 97a89ed101bb ("net: phy: mxl-gpy: disable interrupts on GPY215 by default")Signed-off-by Xu Liang <[email protected]>
Reviewed-by Simon Horman <[email protected]>
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 31 May 2023 15:48:22 +0800 you wrote:
The interrupt fix in commit
97a89ed101bbshould be applied on all variants of GPY2xx PHY and GPY115C.Fixes 97a89ed101bb ("net: phy: mxl-gpy: disable interrupts on GPY215 by default")Signed-off-by Xu Liang <[email protected]>--- drivers/net/phy/mxl-gpy.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-)
Here is the summary with links:
- [net] net: phy: mxl-gpy: extend interrupt fix to all impacted variants
https://git.kernel.org/netdev/net/c/519d64876408
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html