Skip to contentSkip to conversation

net: ipa: Use the correct value for IPA_STATUS_SIZE

PATCH Superseded Bert Karwatzki 6 participants 14 messages May 27, 2023 – Jun 1, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ipa: Use the correct value for IPA_STATUS_SIZE

commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced IPA_STATUS_SIZE as a replacement for the size of the removed struct ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this as IPA_STATUS_SIZE.

From 0623148733819bb5d3648b1ed404d57c8b6b31d8 Mon Sep 17 00:00:00 2001
From: Bert Karwatzki <[email protected]>
Date: Sat, 27 May 2023 22:16:52 +0200
Subject: [PATCH] Use the correct value for IPA_STATUS_SIZE. IPA_STATUS_SIZE
was introduced in commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c as a replacment for the size of the removed struct ipa_status which had
size =
sizeof(__le32[8]).

---
 drivers/net/ipa/ipa_endpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/net/ipa/ipa_endpoint.c
index 2ee80ed140b7..afa1d56d9095 100644

drivers/net/ipa/ipa_endpoint.c +1 -1
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
 };
 
 /* Size in bytes of an IPA packet status structure */
-#define IPA_STATUS_SIZE			sizeof(__le32[4])
+#define IPA_STATUS_SIZE			sizeof(__le32[8])
 
 /* IPA status structure decoder; looks up field values for a structure

*/
static u32 ipa_status_extract(struct ipa *ipa, const void *data,

Signature · 3 lines
2.40.1

Bert Karwatzki
maintainer
#1 lore raw
Quoted 5 lines · On Sat, 27 May 2023 22:46:25 +0200 Bert Karwatzki wrote:

commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced IPA_STATUS_SIZE as a replacement for the size of the removed struct ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this as IPA_STATUS_SIZE.

Quoted 9 lines

From 0623148733819bb5d3648b1ed404d57c8b6b31d8 Mon Sep 17 00:00:00 2001
From: Bert Karwatzki <[email protected]>
Date: Sat, 27 May 2023 22:16:52 +0200
Subject: [PATCH] Use the correct value for IPA_STATUS_SIZE. IPA_STATUS_SIZE
was introduced in commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c as a replacment for the size of the removed struct ipa_status which had
size =
sizeof(__le32[8]).

The posting looks damage, could you try sending again (with git send-email maybe?)

Before you do:
- please make sure the change applies to:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
- add a correct fixes tag
- fix issues pointed out by checkpatch --strict

Signature · 1 line
pw-bot: cr
#2 lore raw
In reply to Bert Karwatzki
Quoted 15 lines · Bert Karwatzki

commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced IPA_STATUS_SIZE as a replacement for the size of the removed struct ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this as IPA_STATUS_SIZE.

Quoted 1 line

From 0623148733819bb5d3648b1ed404d57c8b6b31d8 Mon Sep 17 00:00:00 2001

From: Bert Karwatzki <[email protected]>
Date: Sat, 27 May 2023 22:16:52 +0200
Subject: [PATCH] Use the correct value for IPA_STATUS_SIZE. IPA_STATUS_SIZE
was introduced in commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c as a replacment for the size of the removed struct ipa_status which had
size =
sizeof(__le32[8]).

Quoted 1 line

Hi Bert,

As well as the feedback provided by Jakub elsewhere in this thread I think it would be useful to CC the author of the above mentioned commit, Alex Elder <[email protected]>. I have CCed him on this email. Please consider doing likewise when you post v2.

FWIIW, I did take a look.
And I do agree with your maths: struct ipa_status was 32 (= 8 x 4) bytes long.

Quoted 23 lines
---
 drivers/net/ipa/ipa_endpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipa/ipa_endpoint.c +1 -1
index 2ee80ed140b7..afa1d56d9095 100644
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
 };
 
 /* Size in bytes of an IPA packet status structure */
-#define IPA_STATUS_SIZE			sizeof(__le32[4])
+#define IPA_STATUS_SIZE			sizeof(__le32[8])
 
 /* IPA status structure decoder; looks up field values for a structure
 */

static u32 ipa_status_extract(struct ipa *ipa, const void *data,

Signature · 3 lines
2.40.1

Bert Karwatzki
#3 lore raw

Am Dienstag, dem 30.05.2023 um 09:09 +0200 schrieb Simon Horman:

Quoted 50 lines · Bert Karwatzki
Quoted 15 lines

commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced IPA_STATUS_SIZE as a replacement for the size of the removed struct ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this as IPA_STATUS_SIZE.

Quoted 1 line

From 0623148733819bb5d3648b1ed404d57c8b6b31d8 Mon Sep 17 00:00:00 2001

From: Bert Karwatzki <[email protected]>
Date: Sat, 27 May 2023 22:16:52 +0200
Subject: [PATCH] Use the correct value for IPA_STATUS_SIZE. IPA_STATUS_SIZE
 was introduced in commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c as a replacment for the size of the removed struct ipa_status which had size =
 sizeof(__le32[8]).

Quoted 1 line

Hi Bert,

As well as the feedback provided by Jakub elsewhere in this thread I think it would be useful to CC the author of the above mentioned commit, Alex Elder <[email protected]>. I have CCed him on this email. Please consider doing likewise when you post v2.

FWIIW, I did take a look.
And I do agree with your maths: struct ipa_status was 32 (= 8 x 4) bytes long.

Quoted 22 lines

---
 drivers/net/ipa/ipa_endpoint.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipa/ipa_endpoint.c +0 -0
index 2ee80ed140b7..afa1d56d9095 100644
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
  };


 /* Size in bytes of an IPA packet status structure */

drivers/net/ipa/ipa_endpoint.c +1 -1
-#define IPA_STATUS_SIZE                        sizeof(__le32[4])
+#define IPA_STATUS_SIZE                        sizeof(__le32[8])


 /* IPA status structure decoder; looks up field values for a structure */
 static u32 ipa_status_extract(struct ipa *ipa, const void *data,

Signature · 1 line
2.40.1
Quoted 1 line
Quoted 1 line

Bert Karwatzki

Here is v2 of the patch, the first one was garbled by the linebreak setting of evolution.

From: Bert Karwatzki <[email protected]>
Date: Tue, 30 May 2023 10:55:55 +0200
Subject: [PATCH] IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a
replacement for the size of the removed struct ipa_status of size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.

---
 drivers/net/ipa/ipa_endpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipa/ipa_endpoint.c +1 -1
index 2ee80ed140b7..afa1d56d9095 100644
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
 };
 
 /* Size in bytes of an IPA packet status structure */
-#define IPA_STATUS_SIZE			sizeof(__le32[4])
+#define IPA_STATUS_SIZE			sizeof(__le32[8])
 
 /* IPA status structure decoder; looks up field values for a structure */
 static u32 ipa_status_extract(struct ipa *ipa, const void *data,
Signature · 1 line
2.40.1
#4 lore raw
Quoted 6 lines · Bert Karwatzki

Am Dienstag, dem 30.05.2023 um 09:09 +0200 schrieb Simon Horman:

Quoted 5 lines · Bert Karwatzki
Quoted 4 lines

commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced IPA_STATUS_SIZE as a replacement for the size of the removed struct ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this as IPA_STATUS_SIZE.

This is better, however it really isn't done in a way that's appropriate for a Linux kernel patch. I will gladly help you get it right if you have the patience for that. But I'm not going to say anything yet--until you say you want me to help you do this. If you prefer, I can submit the patch for you.

The reason this is important is your commit is permanent, and just like code, commit messages are best if kept consistent and readable. I also am offering to help you understand so you avoid any trouble next time you want to send a kernel patch.

Let me know what you prefer.

-Alex

Quoted 74 lines
Quoted 39 lines
Quoted 11 lines
Quoted 2 lines

From 0623148733819bb5d3648b1ed404d57c8b6b31d8 Mon Sep 17 00:00:00 2001

From: Bert Karwatzki <[email protected]>
Date: Sat, 27 May 2023 22:16:52 +0200
Subject: [PATCH] Use the correct value for IPA_STATUS_SIZE. IPA_STATUS_SIZE
 was introduced in commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c as a replacment for the size of the removed struct ipa_status which had
size =
 sizeof(__le32[8]).

Quoted 1 line

Hi Bert,

As well as the feedback provided by Jakub elsewhere in this thread I think it would be useful to CC the author of the above mentioned commit, Alex Elder <[email protected]>. I have CCed him on this email. Please consider doing likewise when you post v2.

FWIIW, I did take a look.
And I do agree with your maths: struct ipa_status was 32 (= 8 x 4) bytes long.

Quoted 16 lines
---
  drivers/net/ipa/ipa_endpoint.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipa/ipa_endpoint.c +1 -1
index 2ee80ed140b7..afa1d56d9095 100644
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
  };
 
  /* Size in bytes of an IPA packet status structure */
-#define IPA_STATUS_SIZE                        sizeof(__le32[4])
+#define IPA_STATUS_SIZE                        sizeof(__le32[8])
 
Quoted 7 lines
Quoted 7 lines
drivers/net/ipa/ipa_endpoint.c +0 -0
  /* IPA status structure decoder; looks up field values for a structure
 */

 static u32 ipa_status_extract(struct ipa *ipa, const void *data,

Signature · 3 lines
2.40.1

Bert Karwatzki

Here is v2 of the patch, the first one was garbled by the linebreak setting of evolution.

From: Bert Karwatzki <[email protected]>
Date: Tue, 30 May 2023 10:55:55 +0200
Subject: [PATCH] IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a
replacement for the size of the removed struct ipa_status of size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.

---
  drivers/net/ipa/ipa_endpoint.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipa/ipa_endpoint.c +1 -1
index 2ee80ed140b7..afa1d56d9095 100644
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
  };
 
  /* Size in bytes of an IPA packet status structure */
-#define IPA_STATUS_SIZE			sizeof(__le32[4])
+#define IPA_STATUS_SIZE			sizeof(__le32[8])
 
  /* IPA status structure decoder; looks up field values for a structure */
  static u32 ipa_status_extract(struct ipa *ipa, const void *data,
#5 lore raw

Am Dienstag, dem 30.05.2023 um 07:29 -0500 schrieb Alex Elder:

Quoted 14 lines · Bert Karwatzki
Quoted 6 lines

Am Dienstag, dem 30.05.2023 um 09:09 +0200 schrieb Simon Horman:

Quoted 5 lines · Bert Karwatzki
Quoted 4 lines

commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced IPA_STATUS_SIZE as a replacement for the size of the removed struct ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this as IPA_STATUS_SIZE.

This is better, however it really isn't done in a way that's appropriate for a Linux kernel patch.  I will gladly help you get it right if you have the patience for that.  But I'm not going to say anything yet--until you say you want me to help you do this.  If you prefer, I can submit the patch for you.

Quoted 10 lines

The reason this is important is your commit is permanent, and just like code, commit messages are best if kept consistent and readable.  I also am offering to help you understand so you avoid any trouble next time you want to send a kernel patch.

Let me know what you prefer.

                                        -Alex

Quoted 1 line
Quoted 1 line

So here's v3 of the patch, done (I hope) in a way that is more standard conforming.

From e0dc802b5f6f41c0a388c7281aabe077a4e3c5a2 Mon Sep 17 00:00:00 2001
From: Bert Karwatzki <[email protected]>
Date: Tue, 30 May 2023 20:23:29 +0200
Subject: [PATCH] net/ipa: Use correct value for IPA_STATUS_SIZE

IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement for the size of the removed struct ipa_status which had size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.

---
 drivers/net/ipa/ipa_endpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipa/ipa_endpoint.c +1 -1
index 2ee80ed140b7..afa1d56d9095 100644
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
 };
 
 /* Size in bytes of an IPA packet status structure */
-#define IPA_STATUS_SIZE			sizeof(__le32[4])
+#define IPA_STATUS_SIZE			sizeof(__le32[8])
 
 /* IPA status structure decoder; looks up field values for a structure */
 static u32 ipa_status_extract(struct ipa *ipa, const void *data,
Signature · 4 lines
2.40.1


Bert Karwatzki
#6 lore raw
Quoted 34 lines · Bert Karwatzki

Am Dienstag, dem 30.05.2023 um 07:29 -0500 schrieb Alex Elder:

Quoted 14 lines · Bert Karwatzki
Quoted 6 lines

Am Dienstag, dem 30.05.2023 um 09:09 +0200 schrieb Simon Horman:

Quoted 5 lines · Bert Karwatzki
Quoted 4 lines

commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced IPA_STATUS_SIZE as a replacement for the size of the removed struct ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this as IPA_STATUS_SIZE.

This is better, however it really isn't done in a way that's appropriate for a Linux kernel patch.  I will gladly help you get it right if you have the patience for that.  But I'm not going to say anything yet--until you say you want me to help you do this.  If you prefer, I can submit the patch for you.

Quoted 10 lines

The reason this is important is your commit is permanent, and just like code, commit messages are best if kept consistent and readable.  I also am offering to help you understand so you avoid any trouble next time you want to send a kernel patch.

Let me know what you prefer.

                                        -Alex

Quoted 1 line
Quoted 1 line

So here's v3 of the patch, done (I hope) in a way that is more standard conforming.

From e0dc802b5f6f41c0a388c7281aabe077a4e3c5a2 Mon Sep 17 00:00:00 2001
From: Bert Karwatzki <[email protected]>
Date: Tue, 30 May 2023 20:23:29 +0200
Subject: [PATCH] net/ipa: Use correct value for IPA_STATUS_SIZE

Quoted 5 lines

IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement for the size of the removed struct ipa_status which had size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.

This is better, but there are a few more things to do differently.
- When re-submitting a patch, please indicate a (new) version in the subject line. Since you haven't been doing that, it should be sufficient to just use "version 2", something like this:
[PATCH net v2] net: ipa: Use the correct value for IPA_STATUS_SIZE
- Add a "Fixes" tag above your "Signed-off-by:" line:

Fixes b8dc7d0eea5a ("net: ipa: stop using sizeof(status)")

- Do not send information above the patch in the e-mail. An easy way to get it right is to use "git send-email". For example:
- git format-patch -1
- Edit 0001-*.patch, adding lines like this below the "From:" line:
To: [email protected]
To: [email protected]
To: [email protected]
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
- Run this:
git send-email --dry-run 0001-*.patch
to try to catch any errors
- Finally, run this:
git send-email 0001-*.patch
to actually send the patch. This will require a password.

Even if you don't use "git send-email", just let the e-mail itself indicate the "From:" and "Subject:" lines. And have the content of the e-mail be the patch itself.

I hope this helps.

-Alex

Quoted 17 lines
---
  drivers/net/ipa/ipa_endpoint.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipa/ipa_endpoint.c +1 -1
index 2ee80ed140b7..afa1d56d9095 100644
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
  };
 
  /* Size in bytes of an IPA packet status structure */
-#define IPA_STATUS_SIZE			sizeof(__le32[4])
+#define IPA_STATUS_SIZE			sizeof(__le32[8])
 
  /* IPA status structure decoder; looks up field values for a structure */
  static u32 ipa_status_extract(struct ipa *ipa, const void *data,
#7 lore raw

From 2e5e4c07606a100fd4af0f08e4cd158f88071a3a Mon Sep 17 00:00:00 2001
From: Bert Karwatzki <[email protected]>
To: [email protected]
To: [email protected]
To: [email protected]
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Date: Wed, 31 May 2023 00:16:33 +0200
Subject: [PATCH net v2] net: ipa: Use correct value for IPA_STATUS_SIZE

IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement for the size of the removed struct ipa_status which had size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.

Fixes b8dc7d0eea5a ("net: ipa: stop using sizeof(status)")
---
 drivers/net/ipa/ipa_endpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipa/ipa_endpoint.c +1 -1
index 2ee80ed140b7..afa1d56d9095 100644
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
 };
 
 /* Size in bytes of an IPA packet status structure */
-#define IPA_STATUS_SIZE			sizeof(__le32[4])
+#define IPA_STATUS_SIZE			sizeof(__le32[8])
 
 /* IPA status structure decoder; looks up field values for a structure */
 static u32 ipa_status_extract(struct ipa *ipa, const void *data,
Signature · 6 lines
2.40.1

As I'm sure that git send-email didn't work (probably due to sendmail/exim
configuration issues), I'm sending this from evolution again.

Bert Karwatzki
Reviewed-by
#8 lore raw
Quoted 13 lines · Bert Karwatzki

From 2e5e4c07606a100fd4af0f08e4cd158f88071a3a Mon Sep 17 00:00:00 2001
From: Bert Karwatzki <[email protected]>
To: [email protected]
To: [email protected]
To: [email protected]
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Date: Wed, 31 May 2023 00:16:33 +0200
Subject: [PATCH net v2] net: ipa: Use correct value for IPA_STATUS_SIZE

Quoted 3 lines

IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement for the size of the removed struct ipa_status which had size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.

If the network maintainers can deal with your patch, I'm OK with it. David et al if you want something else, please say so.

Quoted 19 lines
Fixes b8dc7d0eea5a ("net: ipa: stop using sizeof(status)")
---
  drivers/net/ipa/ipa_endpoint.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipa/ipa_endpoint.c +1 -1
index 2ee80ed140b7..afa1d56d9095 100644
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
  };
 
  /* Size in bytes of an IPA packet status structure */
-#define IPA_STATUS_SIZE			sizeof(__le32[4])
+#define IPA_STATUS_SIZE			sizeof(__le32[8])
 
  /* IPA status structure decoder; looks up field values for a structure */
  static u32 ipa_status_extract(struct ipa *ipa, const void *data,
maintainer
#9 lore raw
Quoted 7 lines · On Tue, 30 May 2023 18:43:54 -0500 Alex Elder wrote:
Quoted 3 lines

IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement for the size of the removed struct ipa_status which had size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.

If the network maintainers can deal with your patch, I'm OK with it. David et al if you want something else, please say so.

It's not correctly formatted. There are headers in the email body.

#10 lore raw
In reply to Alex Elder
Quoted 14 lines · Alex Elder
Quoted 13 lines · Bert Karwatzki

 From 2e5e4c07606a100fd4af0f08e4cd158f88071a3a Mon Sep 17 00:00:00 2001
From: Bert Karwatzki <[email protected]>
To: [email protected]
To: [email protected]
To: [email protected]
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Date: Wed, 31 May 2023 00:16:33 +0200
Subject: [PATCH net v2] net: ipa: Use correct value for IPA_STATUS_SIZE

Quoted 7 lines
Quoted 3 lines

IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement for the size of the removed struct ipa_status which had size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.

If the network maintainers can deal with your patch, I'm OK with it.  David et al if you want something else, please say so.

OK, Jakub has spoken...

Bert, I tried before to explain what you needed to do, but it's still not quite right. Please contact me privately and we'll work out how to get this submitted in the proper format.

-Alex

Quoted 20 lines
Quoted 17 lines
Fixes b8dc7d0eea5a ("net: ipa: stop using sizeof(status)")

---
  drivers/net/ipa/ipa_endpoint.c | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipa/ipa_endpoint.c +1 -1
index 2ee80ed140b7..afa1d56d9095 100644
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
   };
   /* Size in bytes of an IPA packet status structure */
-#define IPA_STATUS_SIZE            sizeof(__le32[4])
+#define IPA_STATUS_SIZE            sizeof(__le32[8])
   /* IPA status structure decoder; looks up field values for a structure */
   static u32 ipa_status_extract(struct ipa *ipa, const void *data,
#11 lore raw

PATCH v3 1/1 net: ipa: Use correct value for IPA_STATUS_SIZE

IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement for the size of the removed struct ipa_status which had size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.

Fixes b8dc7d0eea5a ("net: ipa: stop using sizeof(status)")
---
 drivers/net/ipa/ipa_endpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipa/ipa_endpoint.c +1 -1
index 2ee80ed140b7..afa1d56d9095 100644
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
 };
 
 /* Size in bytes of an IPA packet status structure */
-#define IPA_STATUS_SIZE			sizeof(__le32[4])
+#define IPA_STATUS_SIZE			sizeof(__le32[8])
 
 /* IPA status structure decoder; looks up field values for a structure */
 static u32 ipa_status_extract(struct ipa *ipa, const void *data,

--
2.40.1

As none of you seem to be in Europe, I'll do another attempt, this time with git send-email.
Bert Karwatzki

Reviewed-by on v3 1/1
#12 lore raw

Re: [PATCH net v3] net: ipa: Use correct value for IPA_STATUS_SIZE

Quoted 26 lines · Bert Karwatzki

IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement for the size of the removed struct ipa_status which had size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.

Fixes b8dc7d0eea5a ("net: ipa: stop using sizeof(status)")
---
 drivers/net/ipa/ipa_endpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipa/ipa_endpoint.c +1 -2
index 2ee80ed140b7..afa1d56d9095 100644
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
 };
 
 /* Size in bytes of an IPA packet status structure */
-#define IPA_STATUS_SIZE			sizeof(__le32[4])
+#define IPA_STATUS_SIZE			sizeof(__le32[8])
 
 /* IPA status structure decoder; looks up field values for a structure */
 static u32 ipa_status_extract(struct ipa *ipa, const void *data,
--

2.40.1

Quoted 2 lines

As none of you seem to be in Europe, I'll do another attempt, this time with git send-email.

This looks good to me.

(somewhere in Europe)

#13 lore raw

Re: [PATCH net v3] net: ipa: Use correct value for IPA_STATUS_SIZE

In reply to Bert Karwatzki
This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <[email protected]>:

Quoted 8 lines · On Wed, 31 May 2023 12:36:19 +0200 you wrote:

IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement for the size of the removed struct ipa_status which had size sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.

Fixes b8dc7d0eea5a ("net: ipa: stop using sizeof(status)")

[...]

Here is the summary with links:
- [net,v3] net: ipa: Use correct value for IPA_STATUS_SIZE

    https://git.kernel.org/netdev/net/c/be7f8012a513

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html