Skip to contentSkip to conversation

dt-bindings: samsung,mipi-dsim: Use port-base reference

PATCH Applied Fabio Estevam 3 participants 3 messages May 31, 2023 – Jun 1, 2023

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: samsung,mipi-dsim: Use port-base reference

From: Fabio Estevam <[email protected]>

Use port-base reference for port@1.

This fixes the following schema warning:

imx8mp-dhcom-pdk3.dtb: dsi@32e60000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) From schema: Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml

Fixes 1f0d40d88f7a ("dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml")

---
Changes since v1:
- Only changed port@1.
- Used Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml as reference. (Thanks Marek for the suggestion!)

To reproduce the original problem against linux-next 20230531:

- Enable the mipi_dsi node on imx8mp-dhcom-som.dtsi

 &mipi_dsi {
        samsung,burst-clock-frequency = <160000000>;
        samsung,esc-clock-frequency = <10000000>;

+ status = "okay";

        ports {
                port@1 {
$ make CHECK_DTBS=y DT_SCHEMA_FILES=samsung,mipi-dsim.yaml freescale/imx8mp-dhcom-pdk3.dtb
  UPD     include/config/kernel.release
  LINT    Documentation/devicetree/bindings
  CHKDT   Documentation/devicetree/bindings/processed-schema.json
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
  DTC_CHK arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dtb
arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dtb: dsi@32e60000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected)
From schema: Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
 .../devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml +2 -1
index 06b6c44d4641..4ed7a799ba26 100644
@@ -103,7 +103,8 @@ properties:
           specified.
 
       port@1:
-        $ref: /schemas/graph.yaml#/properties/port
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
         description:
           DSI output port node to the panel or the next bridge
           in the chain.
Signature · 1 line
2.34.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 11 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Use port-base reference for port@1.

This fixes the following schema warning:

imx8mp-dhcom-pdk3.dtb: dsi@32e60000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) From schema: Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml

Fixes 1f0d40d88f7a ("dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml")

No line breaks between tags (in general, no need to resend)

Quoted 1 line

Best regards,
Krzysztof

maintainer Applied
#2 lore raw
In reply to Fabio Estevam

Hi,

Quoted 8 lines · Fabio Estevam

Use port-base reference for port@1.

This fixes the following schema warning:

imx8mp-dhcom-pdk3.dtb: dsi@32e60000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) From schema: Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml

[...]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] dt-bindings: samsung,mipi-dsim: Use port-base reference

      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=54df4868fb728bebbb0fb7c3f187eba383e922b5
Signature · 1 line
Neil