arm64: dts: qcom: sm8150: Add missing interconnect paths to USB HCs
PATCH 1/4 arm64: dts: qcom: sm8150: Add missing interconnect paths to USB HCs
The USB HCs nodes are missing the interconnect paths, so add them.
--- arch/arm64/boot/dts/qcom/sm8150.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/qcom/sm8150.dtsi +8 -0
@@ -3595,6 +3595,10 @@ usb_1: usb@a6f8800 { resets = <&gcc GCC_USB30_PRIM_BCR>; + interconnects = <&aggre1_noc MASTER_USB3 0 &mc_virt SLAVE_EBI_CH0 0>, + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_USB3 0>; + interconnect-names = "usb-ddr", "apps-usb"; + usb_1_dwc3: usb@a600000 { compatible = "snps,dwc3"; reg = <0 0x0a600000 0 0xcd00>;
@@ -3644,6 +3648,10 @@ usb_2: usb@a8f8800 { resets = <&gcc GCC_USB30_SEC_BCR>; + interconnects = <&aggre1_noc MASTER_USB3_1 0 &mc_virt SLAVE_EBI_CH0 0>, + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_USB3_1 0>; + interconnect-names = "usb-ddr", "apps-usb"; + usb_2_dwc3: usb@a800000 { compatible = "snps,dwc3"; reg = <0 0x0a800000 0 0xcd00>;
Signature · 1 line
2.34.1
PATCH 2/4 arm64: dts: qcom: sm8250: Add missing interconnect paths to USB HCs
The USB HCs nodes are missing the interconnect paths, so add them.
--- arch/arm64/boot/dts/qcom/sm8250.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/qcom/sm8250.dtsi +8 -0
@@ -3750,6 +3750,10 @@ usb_1: usb@a6f8800 { resets = <&gcc GCC_USB30_PRIM_BCR>; + interconnects = <&aggre1_noc MASTER_USB3 0 &mc_virt SLAVE_EBI_CH0 0>, + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_USB3 0>; + interconnect-names = "usb-ddr", "apps-usb"; + usb_1_dwc3: usb@a600000 { compatible = "snps,dwc3"; reg = <0 0x0a600000 0 0xcd00>;
@@ -3810,6 +3814,10 @@ usb_2: usb@a8f8800 { resets = <&gcc GCC_USB30_SEC_BCR>; + interconnects = <&aggre1_noc MASTER_USB3_1 0 &mc_virt SLAVE_EBI_CH0 0>, + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_USB3_1 0>; + interconnect-names = "usb-ddr", "apps-usb"; + usb_2_dwc3: usb@a800000 { compatible = "snps,dwc3"; reg = <0 0x0a800000 0 0xcd00>;
Signature · 1 line
2.34.1
Re: [PATCH 2/4] arm64: dts: qcom: sm8250: Add missing interconnect paths to USB HCs
Quoted 12 lines · Abel Vesa
The USB HCs nodes are missing the interconnect paths, so add them.
Signed-off-by Abel Vesa <[email protected]>--- arch/arm64/boot/dts/qcom/sm8250.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm64/boot/dts/qcom/sm8250.dtsi +0
-0
arch/arm64/boot/dts/qcom/sm8250.dtsi usb_1: usb@a6f8800 { · line 3754
Quoted 5 lines
arch/arm64/boot/dts/qcom/sm8250.dtsi +2
-0@@ -3750,6 +3750,10 @@ usb_1: usb@a6f8800 { resets = <&gcc GCC_USB30_PRIM_BCR>; + interconnects = <&aggre1_noc MASTER_USB3 0 &mc_virt SLAVE_EBI_CH0 0>, + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_USB3 0>;
You need to update #interconnect-cells to 2.
Konrad
Quoted 16 lines
arch/arm64/boot/dts/qcom/sm8250.dtsi +6
-0+ interconnect-names = "usb-ddr", "apps-usb"; + usb_1_dwc3: usb@a600000 { compatible = "snps,dwc3"; reg = <0 0x0a600000 0 0xcd00>;@@ -3810,6 +3814,10 @@ usb_2: usb@a8f8800 { resets = <&gcc GCC_USB30_SEC_BCR>; + interconnects = <&aggre1_noc MASTER_USB3_1 0 &mc_virt SLAVE_EBI_CH0 0>, + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_USB3_1 0>; + interconnect-names = "usb-ddr", "apps-usb"; + usb_2_dwc3: usb@a800000 { compatible = "snps,dwc3"; reg = <0 0x0a800000 0 0xcd00>;
Re: [PATCH 2/4] arm64: dts: qcom: sm8250: Add missing interconnect paths to USB HCs
Quoted 16 lines · Konrad Dybcio
Quoted 13 lines · Abel Vesa
The USB HCs nodes are missing the interconnect paths, so add them.
Signed-off-by Abel Vesa <[email protected]>--- arch/arm64/boot/dts/qcom/sm8250.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm64/boot/dts/qcom/sm8250.dtsi +0
-0@@ -3750,6 +3750,10 @@ usb_1: usb@a6f8800 {
Quoted 5 lines
arch/arm64/boot/dts/qcom/sm8250.dtsi usb_1: usb@a6f8800 { · line 3754
Quoted 4 lines
arch/arm64/boot/dts/qcom/sm8250.dtsi +2
-0resets = <&gcc GCC_USB30_PRIM_BCR>; + interconnects = <&aggre1_noc MASTER_USB3 0 &mc_virt SLAVE_EBI_CH0 0>, + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_USB3 0>;You need to update #interconnect-cells to 2.
Ugh, missed that. Will send a new version.
Thanks,
Abel
Quoted 18 lines
Konrad
Quoted 16 lines
arch/arm64/boot/dts/qcom/sm8250.dtsi +6
-0+ interconnect-names = "usb-ddr", "apps-usb"; + usb_1_dwc3: usb@a600000 { compatible = "snps,dwc3"; reg = <0 0x0a600000 0 0xcd00>;@@ -3810,6 +3814,10 @@ usb_2: usb@a8f8800 { resets = <&gcc GCC_USB30_SEC_BCR>; + interconnects = <&aggre1_noc MASTER_USB3_1 0 &mc_virt SLAVE_EBI_CH0 0>, + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_USB3_1 0>; + interconnect-names = "usb-ddr", "apps-usb"; + usb_2_dwc3: usb@a800000 { compatible = "snps,dwc3"; reg = <0 0x0a800000 0 0xcd00>;
PATCH 3/4 arm64: dts: qcom: sm8350: Add missing interconnect paths to USB HCs
In reply to Abel VesaThe USB HCs nodes are missing the interconnect paths, so add them.
--- arch/arm64/boot/dts/qcom/sm8350.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/qcom/sm8350.dtsi +8 -0
@@ -2304,6 +2304,10 @@ usb_1: usb@a6f8800 { resets = <&gcc GCC_USB30_PRIM_BCR>; + interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>, + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>; + interconnect-names = "usb-ddr", "apps-usb"; + usb_1_dwc3: usb@a600000 { compatible = "snps,dwc3"; reg = <0 0x0a600000 0 0xcd00>;
@@ -2373,6 +2377,10 @@ usb_2: usb@a8f8800 { resets = <&gcc GCC_USB30_SEC_BCR>; + interconnects = <&aggre1_noc MASTER_USB3_1 0 &mc_virt SLAVE_EBI1 0>, + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_1 0>; + interconnect-names = "usb-ddr", "apps-usb"; + usb_2_dwc3: usb@a800000 { compatible = "snps,dwc3"; reg = <0 0x0a800000 0 0xcd00>;
Signature · 1 line
2.34.1
Re: [PATCH 3/4] arm64: dts: qcom: sm8350: Add missing interconnect paths to USB HCs
Quoted 4 lines · Abel Vesa
The USB HCs nodes are missing the interconnect paths, so add them.
Signed-off-by Abel Vesa <[email protected]>---
Konrad
Quoted 29 lines
arch/arm64/boot/dts/qcom/sm8350.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm64/boot/dts/qcom/sm8350.dtsi +8
-0@@ -2304,6 +2304,10 @@ usb_1: usb@a6f8800 { resets = <&gcc GCC_USB30_PRIM_BCR>; + interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>, + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>; + interconnect-names = "usb-ddr", "apps-usb"; + usb_1_dwc3: usb@a600000 { compatible = "snps,dwc3"; reg = <0 0x0a600000 0 0xcd00>;@@ -2373,6 +2377,10 @@ usb_2: usb@a8f8800 { resets = <&gcc GCC_USB30_SEC_BCR>; + interconnects = <&aggre1_noc MASTER_USB3_1 0 &mc_virt SLAVE_EBI1 0>, + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_1 0>; + interconnect-names = "usb-ddr", "apps-usb"; + usb_2_dwc3: usb@a800000 { compatible = "snps,dwc3"; reg = <0 0x0a800000 0 0xcd00>;
PATCH 4/4 arm64: dts: qcom: sm8450: Add missing interconnect paths to USB HC
In reply to Abel VesaThe USB HC node is missing the interconnect paths, so add them.
--- arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/qcom/sm8450.dtsi +4 -0
@@ -4306,6 +4306,10 @@ usb_1: usb@a6f8800 { resets = <&gcc GCC_USB30_PRIM_BCR>; + interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>, + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>; + interconnect-names = "usb-ddr", "apps-usb"; + usb_1_dwc3: usb@a600000 { compatible = "snps,dwc3"; reg = <0 0x0a600000 0 0xcd00>;
Signature · 1 line
2.34.1
Re: [PATCH 4/4] arm64: dts: qcom: sm8450: Add missing interconnect paths to USB HC
Quoted 4 lines · Abel Vesa
The USB HC node is missing the interconnect paths, so add them.
Signed-off-by Abel Vesa <[email protected]>---
Konrad
Quoted 18 lines
arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++++ 1 file changed, 4 insertions(+)arch/arm64/boot/dts/qcom/sm8450.dtsi +4
-0@@ -4306,6 +4306,10 @@ usb_1: usb@a6f8800 { resets = <&gcc GCC_USB30_PRIM_BCR>; + interconnects = <&aggre1_noc MASTER_USB3_0 0 &mc_virt SLAVE_EBI1 0>, + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>; + interconnect-names = "usb-ddr", "apps-usb"; + usb_1_dwc3: usb@a600000 { compatible = "snps,dwc3"; reg = <0 0x0a600000 0 0xcd00>;
Quoted 12 lines · Abel Vesa
The USB HCs nodes are missing the interconnect paths, so add them.
Signed-off-by Abel Vesa <[email protected]>--- arch/arm64/boot/dts/qcom/sm8150.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm64/boot/dts/qcom/sm8150.dtsi +0
-0
arch/arm64/boot/dts/qcom/sm8150.dtsi usb_1: usb@a6f8800 { · line 3600
Quoted 6 lines
arch/arm64/boot/dts/qcom/sm8150.dtsi +3
-0@@ -3595,6 +3595,10 @@ usb_1: usb@a6f8800 { resets = <&gcc GCC_USB30_PRIM_BCR>; + interconnects = <&aggre1_noc MASTER_USB3 0 &mc_virt SLAVE_EBI_CH0 0>, + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_USB3 0>; + interconnect-names = "usb-ddr", "apps-usb";
You need to update interconnect-cells to 2.
Konrad
Quoted 15 lines
arch/arm64/boot/dts/qcom/sm8150.dtsi +5
-0+ usb_1_dwc3: usb@a600000 { compatible = "snps,dwc3"; reg = <0 0x0a600000 0 0xcd00>;@@ -3644,6 +3648,10 @@ usb_2: usb@a8f8800 { resets = <&gcc GCC_USB30_SEC_BCR>; + interconnects = <&aggre1_noc MASTER_USB3_1 0 &mc_virt SLAVE_EBI_CH0 0>, + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_USB3_1 0>; + interconnect-names = "usb-ddr", "apps-usb"; + usb_2_dwc3: usb@a800000 { compatible = "snps,dwc3"; reg = <0 0x0a800000 0 0xcd00>;