mm: vmscan: move shrinker_debugfs_remove() before synchronize_srcu()
Subsystems (3)
Qi Zheng
reviewerPATCH RESEND 1/1 mm: vmscan: move shrinker_debugfs_remove() before synchronize_srcu()
From: Qi Zheng <[email protected]>
The debugfs_remove_recursive() will wait for debugfs_file_put() to return, so there is no need to put it after synchronize_srcu() to wait for the rcu read-side critical section to exit.
Just move it before synchronize_srcu(), which is also convenient to put the heavy synchronize_srcu() in the delayed work later.
Signed-off-by Qi Zheng <[email protected]>
---
Resend as an independent patch.
mm/vmscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/vmscan.c +2 -2
@@ -818,11 +818,11 @@ void unregister_shrinker(struct shrinker *shrinker) debugfs_entry =shrinker_debugfs_detach (shrinker, &debugfs_id);mutex_unlock (&shrinker_mutex); +shrinker_debugfs_remove (debugfs_entry, debugfs_id); +atomic_inc (&shrinker_srcu_generation);synchronize_srcu (&shrinker_srcu); -shrinker_debugfs_remove (debugfs_entry, debugfs_id); -kfree (shrinker->nr_deferred); shrinker->nr_deferred =NULL ; }
Signature · 1 line
2.30.2