Skip to contentSkip to conversation

dt-bindings: pinctrl: Drop k3

PATCH In review Nishanth Menon 3 participants 3 messages Jun 1, 2023 – Jun 9, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: pinctrl: Drop k3

For convenience (less code duplication), the pin controller pin configuration register values were defined in the bindings header. These are not some IDs or other abstraction layer but raw numbers used in the registers.

These constants do not fit the purpose of bindings. They do not provide any abstraction, any hardware and driver independent ID. In fact, the Linux pinctrl-single driver actually do not use the bindings header at all.

Commit f2de003e1426 ("dt-bindings: pinctrl: k3: Deprecate header with register constants") already moved users to the local header, so, drop the binding header. See background discussion in [1].

While at it, clean up the MAINTAINERS file which is the only reference left.

[1]: https://lore.kernel.org/linux-arm-kernel/[email protected]/

---
Linus,

If you could pick this up for the next 6.5 kernel window now that we have kept the old header around for one cycle.

Ref: https://lore.kernel.org/linux-arm-kernel/20230313160019.vask6atfs6qwphml@twerp/

 MAINTAINERS                      |  1 -
 include/dt-bindings/pinctrl/k3.h | 60 --------------------------------
 2 files changed, 61 deletions(-)
 delete mode 100644 include/dt-bindings/pinctrl/k3.h
MAINTAINERS +0 -1
index 16ee982ce8cf..d25a463fd6a9 100644
@@ -2948,7 +2948,6 @@ F:	Documentation/devicetree/bindings/arm/ti/k3.yaml
 F:	Documentation/devicetree/bindings/hwinfo/ti,k3-socinfo.yaml
 F:	arch/arm64/boot/dts/ti/Makefile
 F:	arch/arm64/boot/dts/ti/k3-*
-F:	include/dt-bindings/pinctrl/k3.h
 
 ARM/TOSHIBA VISCONTI ARCHITECTURE
 M:	Nobuhiro Iwamatsu <[email protected]>
include/dt-bindings/pinctrl/k3.h deleted +0 -60

60 lines not on this page · raw message

Signature · 1 line
2.40.0
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Nishanth Menon

For convenience (less code duplication), the pin controller pin configuration register values were defined in the bindings header. These are not some IDs or other abstraction layer but raw numbers used in the registers.

Quoted 9 lines

These constants do not fit the purpose of bindings. They do not provide any abstraction, any hardware and driver independent ID. In fact, the Linux pinctrl-single driver actually do not use the bindings header at all.

Commit f2de003e1426 ("dt-bindings: pinctrl: k3: Deprecate header with register constants") already moved users to the local header, so, drop the binding header. See background discussion in [1].

This happened just a release ago, so I would rather expect to have it deprecated for some time, so out of tree DTBs won't be broken. But any platform ABI is up to platform maintainer so:

Best regards,
Krzysztof

#2 lore raw
In reply to Nishanth Menon
Quoted 2 lines · Nishanth Menon

If you could pick this up for the next 6.5 kernel window now that we have kept the old header around for one cycle.

Patch applied!

Yours,
Linus Walleij