Skip to contentSkip to conversation

usb: typec: mux: Fix extraneous semicolon

PATCH In review Arnd Bergmann 2 participants 2 messages Jun 1, 2023 – Jun 2, 2023 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: typec: mux: Fix extraneous semicolon

From: Arnd Bergmann <[email protected]>

A recent patch introduced a typo in the fwnode_typec_mux_get() stub function that causes a build failure in some configurations:

In file included from drivers/phy/qualcomm/phy-qcom-qmp-combo.c:23:
include/linux/usb/typec_mux.h:77:1: error: expected identifier or '(' before '{' token include/linux/usb/typec_mux.h:76:33: error: 'fwnode_typec_mux_get' used but never defined [-Werror]

Fixes 3524fe31538c1 ("usb: typec: mux: Remove alt mode parameters from the API")
---
 include/linux/usb/typec_mux.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/usb/typec_mux.h +1 -1
index 11bfa314529fd..2489a7857d8e1 100644
@@ -73,7 +73,7 @@ void *typec_mux_get_drvdata(struct typec_mux_dev *mux);
 
 #else
 
-static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode);
+static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode)
 {
 	return NULL;
 }
Signature · 1 line
2.39.2
#1 lore raw
Quoted 31 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

A recent patch introduced a typo in the fwnode_typec_mux_get() stub function that causes a build failure in some configurations:

In file included from drivers/phy/qualcomm/phy-qcom-qmp-combo.c:23:
include/linux/usb/typec_mux.h:77:1: error: expected identifier or '(' before '{' token include/linux/usb/typec_mux.h:76:33: error: 'fwnode_typec_mux_get' used but never defined [-Werror]

Fixes 3524fe31538c1 ("usb: typec: mux: Remove alt mode parameters from the API")
---
 include/linux/usb/typec_mux.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/usb/typec_mux.h +1 -1
index 11bfa314529fd..2489a7857d8e1 100644
@@ -73,7 +73,7 @@ void *typec_mux_get_drvdata(struct typec_mux_dev *mux);
 
 #else
 
-static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode);
+static inline struct typec_mux *fwnode_typec_mux_get(struct fwnode_handle *fwnode)
 {
 	return NULL;
 }
Signature · 1 line
2.39.2

Should already be fixed in my tree, and in the next linux-next, sorry.

greg k-h