Skip to contentSkip to conversation

drm/meson: venc: include linux/bitfield.h

PATCH Applied Arnd Bergmann 2 participants 3 messages Jun 2, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/meson: venc: include linux/bitfield.h

From: Arnd Bergmann <[email protected]>

Without this header, the use of FIELD_PREP() can cause a build failure:

drivers/gpu/drm/meson/meson_venc.c: In function 'meson_encl_set_gamma_table':
drivers/gpu/drm/meson/meson_venc.c:1595:24: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]

Fixes 51fc01a03442c ("drm/meson: venc: add ENCL encoder setup for MIPI-DSI output")
---
 drivers/gpu/drm/meson/meson_venc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/meson/meson_venc.c +1 -0
index 2bdc2855e249b..3bf0d6e4fc30a 100644
@@ -5,6 +5,7 @@
  * Copyright (C) 2015 Amlogic, Inc. All rights reserved.
  */
 
+#include <linux/bitfield.h>
 #include <linux/export.h>
 #include <linux/iopoll.h>
 
Signature · 1 line
2.39.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 18 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Without this header, the use of FIELD_PREP() can cause a build failure:

drivers/gpu/drm/meson/meson_venc.c: In function 'meson_encl_set_gamma_table':
drivers/gpu/drm/meson/meson_venc.c:1595:24: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]

Fixes 51fc01a03442c ("drm/meson: venc: add ENCL encoder setup for MIPI-DSI output")
---
  drivers/gpu/drm/meson/meson_venc.c | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/meson/meson_venc.c +0 -0
index 2bdc2855e249b..3bf0d6e4fc30a 100644

drivers/gpu/drm/meson/meson_venc.c line 11

Quoted 7 lines
drivers/gpu/drm/meson/meson_venc.c +1 -0
@@ -5,6 +5,7 @@
   * Copyright (C) 2015 Amlogic, Inc. All rights reserved.
   */
 
+#include <linux/bitfield.h>
  #include <linux/export.h>
  #include <linux/iopoll.h>
 
maintainer Applied
#2 lore raw
In reply to Arnd Bergmann

Hi,

Quoted 6 lines · Arnd Bergmann

Without this header, the use of FIELD_PREP() can cause a build failure:

drivers/gpu/drm/meson/meson_venc.c: In function 'meson_encl_set_gamma_table':
drivers/gpu/drm/meson/meson_venc.c:1595:24: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm/meson: venc: include linux/bitfield.h

      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=664dba662cb313da9cbb1c944c472638a65c552e
Signature · 1 line
Neil