Skip to contentSkip to conversation

leds: sgm3140: Add richtek,rt5033-led compatible

PATCH Applied Raymond Hackley 3 participants 12 messages Jun 2, 2023 – Jun 21, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover leds: sgm3140: Add richtek,rt5033-led compatible

Richtek's rt5033-led has pin configurations similar to sgm3140. Add it to the compatable list.

#1 lore raw

PATCH 1/2 dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

Add devicetree binding for Richtek RT5033 Flash LED charge pump used for camera flash LEDs.

---
 Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml +1 -0
index 4d2ffe5fcfc7..37d2a93780ab 100644
@@ -20,6 +20,7 @@ properties:
   compatible:
     enum:
       - ocs,ocp8110
+      - richtek,rt5033-led
       - sgmicro,sgm3140
 
   enable-gpios:
Signature · 1 line
2.30.2
maintainer
#2 lore raw

Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

Quoted 13 lines · Raymond Hackley

Add devicetree binding for Richtek RT5033 Flash LED charge pump used for camera flash LEDs.

---
 Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml +0 -0
index 4d2ffe5fcfc7..37d2a93780ab 100644

Documentation/devicetree/bindings/leds/leds-sgm3140.yaml properties: · line 23

Quoted 4 lines
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml +1 -0
@@ -20,6 +20,7 @@ properties:
   compatible:
     enum:
       - ocs,ocp8110
+      - richtek,rt5033-led

Why is "-led" appended on to this one and not the others?

Quoted 8 lines
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml +0 -0
       - sgmicro,sgm3140
 
 

enable-gpios:

Signature · 1 line
2.30.2
Signature · 1 line
Lee Jones [李琼斯]
maintainer
#3 lore raw

Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

Quoted 10 lines · Lee Jones
Quoted 8 lines · Raymond Hackley

Add devicetree binding for Richtek RT5033 Flash LED charge pump used for camera flash LEDs.

---
 Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

Documentation/devicetree/bindings/leds/leds-sgm3140.yaml properties: · line 23

Quoted 9 lines
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml +1 -0
index 4d2ffe5fcfc7..37d2a93780ab 100644
@@ -20,6 +20,7 @@ properties:
   compatible:
     enum:
       - ocs,ocp8110
+      - richtek,rt5033-led

Why is "-led" appended on to this one and not the others?

It's unusual for me to have to dump through a bunch of hoops just to read and then subsequently reply to mail. Can you consider removing whatever encryption you have enabled please?

Signature · 1 line
Lee Jones [李琼斯]
#4 lore raw

Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

Raymond,

Quoted 24 lines · Lee Jones
Quoted 10 lines · Lee Jones
Quoted 8 lines · Raymond Hackley

Add devicetree binding for Richtek RT5033 Flash LED charge pump used for camera flash LEDs.

---
 Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

Documentation/devicetree/bindings/leds/leds-sgm3140.yaml properties: · line 23

Quoted 9 lines
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml +1 -0
index 4d2ffe5fcfc7..37d2a93780ab 100644
@@ -20,6 +20,7 @@ properties:
   compatible:
     enum:
       - ocs,ocp8110
+      - richtek,rt5033-led

Why is "-led" appended on to this one and not the others?

Quoted 3 lines

It's unusual for me to have to dump through a bunch of hoops just to read and then subsequently reply to mail. Can you consider removing whatever encryption you have enabled please?

https://www.kernel.org/doc/html/latest/process/email-clients.html#proton-mail

I was under the impression that there was no way to disable this behaviour, but I saw mention somewhere that they managed to patch the open source version of the protonmail bridge to function. I cannot find this on lore, because the person's domain was not a proton one and I completely forget their name as it was several months ago. I'll reply here if I find it.

Cheers,
Conor.

maintainer
#5 lore raw

Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

Quoted 27 lines · Conor Dooley

Raymond,

Quoted 24 lines · Lee Jones
Quoted 21 lines · Lee Jones
Quoted 13 lines · Raymond Hackley

Add devicetree binding for Richtek RT5033 Flash LED charge pump used for camera flash LEDs.

---
 Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml +0 -0
index 4d2ffe5fcfc7..37d2a93780ab 100644

Documentation/devicetree/bindings/leds/leds-sgm3140.yaml properties: · line 23

Quoted 4 lines
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml +1 -0
@@ -20,6 +20,7 @@ properties:
   compatible:
     enum:
       - ocs,ocp8110
+      - richtek,rt5033-led

Why is "-led" appended on to this one and not the others?

Quoted 5 lines
Quoted 3 lines

It's unusual for me to have to dump through a bunch of hoops just to read and then subsequently reply to mail. Can you consider removing whatever encryption you have enabled please?

https://www.kernel.org/doc/html/latest/process/email-clients.html#proton-mail

Thanks for the link. This is perfect!

At least I know it's not just me being unreasonable.

Quoted 6 lines

I was under the impression that there was no way to disable this behaviour, but I saw mention somewhere that they managed to patch the open source version of the protonmail bridge to function. I cannot find this on lore, because the person's domain was not a proton one and I completely forget their name as it was several months ago. I'll reply here if I find it.

Thanks.

Signature · 1 line
Lee Jones [李琼斯]
#6 lore raw

Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

Quoted 5 lines · Lee Jones
Quoted 3 lines · Conor Dooley
Quoted 2 lines · Lee Jones
Quoted 1 line · Lee Jones

On Fri, 02 Jun 2023, Raymond Hackley wrote:

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

It's unusual for me to have to dump through a bunch of hoops just to read and then subsequently reply to mail. Can you consider removing whatever encryption you have enabled please?

https://www.kernel.org/doc/html/latest/process/email-clients.html#proton-mail

Thanks for the link. This is perfect!

Ye, no worries chief. I got yelled at about it when I started out, so figured I should at least document it after I noticed others getting yelled at for the same reason, since it is a bit insidious.

Quoted 8 lines

At least I know it's not just me being unreasonable.

Quoted 6 lines

I was under the impression that there was no way to disable this behaviour, but I saw mention somewhere that they managed to patch the open source version of the protonmail bridge to function. I cannot find this on lore, because the person's domain was not a proton one and I completely forget their name as it was several months ago. I'll reply here if I find it.

It was Marc Bornand. Add to CC.

Thanks,
Conor.

#7 lore raw

Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

In reply to Lee Jones

Hi Lee,

Quoted 10 lines · Lee Jones
Quoted 8 lines · Raymond Hackley

Add devicetree binding for Richtek RT5033 Flash LED charge pump used for camera flash LEDs.

---
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +

1 file changed, 1 insertion(+)
Quoted 13 lines
Quoted 9 lines
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml +0 -0
index 4d2ffe5fcfc7..37d2a93780ab 100644
@@ -20,6 +20,7 @@ properties:

compatible:
enum:
- ocs,ocp8110
+ - richtek,rt5033-led

Why is "-led" appended on to this one and not the others?

"richtek,rt5033" has already been taken by a MFD device, and this LED is a part of rt5033 MFD, so "-led" is appended here.

Quoted 6 lines
Quoted 6 lines

- sgmicro,sgm3140

enable-gpios:
--

2.30.2

I tried to configure protonmail not to send encrypted mails. Hope that it works for you.

Regards,
Raymond

#8 lore raw

Re: [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

In reply to Lee Jones

Hi Krzysztof,

Quoted 10 lines · Krzysztof Kozlowski
Quoted 2 lines · Raymond Hackley

Add devicetree binding for Richtek RT5033 Flash LED charge pump used for camera flash LEDs.

What are the similarities? Same register interface? Same pins? It's not obvious and your commit should clear explain this. It will be also justification why you did not make devices compatible.

There is a similar way to control with 2 GPIO pins, strobe and enable, which is not described well in this patch set.

Regards,
Raymond

maintainer Applied
#9 lore raw

Re: [PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

In reply to Raymond Hackley
Quoted 7 lines · Raymond Hackley

Add devicetree binding for Richtek RT5033 Flash LED charge pump used for camera flash LEDs.

---
 Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks

Signature · 1 line
Lee Jones [李琼斯]
#10 lore raw

PATCH 2/2 leds: sgm3140: Add richtek,rt5033-led compatible

In reply to Raymond Hackley

Richtek's rt5033-led has pin configurations similar to sgm3140. Add it to the compatible list.

---
 drivers/leds/flash/leds-sgm3140.c | 1 +
 1 file changed, 1 insertion(+)
drivers/leds/flash/leds-sgm3140.c +1 -0
index d3a30ad94ac4..d3f50dca5136 100644
@@ -291,6 +291,7 @@ static int sgm3140_remove(struct platform_device *pdev)
 
 static const struct of_device_id sgm3140_dt_match[] = {
 	{ .compatible = "ocs,ocp8110" },
+	{ .compatible = "richtek,rt5033-led" },
 	{ .compatible = "sgmicro,sgm3140" },
 	{ /* sentinel */ }
 };
Signature · 1 line
2.30.2
maintainer Applied
#11 lore raw
Quoted 7 lines · Raymond Hackley

Richtek's rt5033-led has pin configurations similar to sgm3140. Add it to the compatible list.

---
 drivers/leds/flash/leds-sgm3140.c | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks

Signature · 1 line
Lee Jones [李琼斯]