Skip to contentSkip to conversation

leds: sgm3140: Add richtek,rt5033-led compatible

PATCH RESEND In review Raymond Hackley 4 participants 7 messages Jun 2, 2023 – Jun 21, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover leds: sgm3140: Add richtek,rt5033-led compatible

Richtek's rt5033-led has pin configurations similar to sgm3140. Add it to the compatible list.

#1 lore raw

PATCH RESEND 1/2 dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

Add devicetree binding for Richtek RT5033 Flash LED charge pump used for camera flash LEDs.

---
 Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml +1 -0
index 4d2ffe5fcfc7..37d2a93780ab 100644
@@ -20,6 +20,7 @@ properties:
   compatible:
     enum:
       - ocs,ocp8110
+      - richtek,rt5033-led
       - sgmicro,sgm3140
 
   enable-gpios:
Signature · 1 line
2.30.2
#2 lore raw

Re: [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

Quoted 2 lines · Raymond Hackley

Add devicetree binding for Richtek RT5033 Flash LED charge pump used for camera flash LEDs.

What are the similarities? Same register interface? Same pins? It's not obvious and your commit should clear explain this. It will be also justification why you did not make devices compatible.

Best regards,
Krzysztof

#3 lore raw

Re: [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

Hi Krzysztof,

Quoted 10 lines · Krzysztof Kozlowski
Quoted 2 lines · Raymond Hackley

Add devicetree binding for Richtek RT5033 Flash LED charge pump used for camera flash LEDs.

What are the similarities? Same register interface? Same pins? It's not obvious and your commit should clear explain this. It will be also justification why you did not make devices compatible.

There is a similar way to control with 2 GPIO pins, strobe and enable, which is not described well in this patch set.

Regards,
Raymond

maintainer
#4 lore raw

Re: [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible

In reply to Raymond Hackley

I've not seen this because Protonmail has encoded your mail.

Quoted 24 lines · Raymond Hackley

Add devicetree binding for Richtek RT5033 Flash LED charge pump used for camera flash LEDs.

---
 Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml +1 -0
index 4d2ffe5fcfc7..37d2a93780ab 100644
@@ -20,6 +20,7 @@ properties:
   compatible:
     enum:
       - ocs,ocp8110
+      - richtek,rt5033-led
       - sgmicro,sgm3140
 
   enable-gpios:
Signature · 1 line
2.30.2
Signature · 1 line
Lee Jones [李琼斯]
#5 lore raw

PATCH RESEND 2/2 leds: sgm3140: Add richtek,rt5033-led compatible

In reply to Raymond Hackley

Richtek's rt5033-led has pin configurations similar to sgm3140. Add it to the compatible list.

---
 drivers/leds/flash/leds-sgm3140.c | 1 +
 1 file changed, 1 insertion(+)
drivers/leds/flash/leds-sgm3140.c +1 -0
index d3a30ad94ac4..d3f50dca5136 100644
@@ -291,6 +291,7 @@ static int sgm3140_remove(struct platform_device *pdev)
 
 static const struct of_device_id sgm3140_dt_match[] = {
 	{ .compatible = "ocs,ocp8110" },
+	{ .compatible = "richtek,rt5033-led" },
 	{ .compatible = "sgmicro,sgm3140" },
 	{ /* sentinel */ }
 };
Signature · 1 line
2.30.2
#6 lore raw
In reply to Raymond Hackley

Hi Raymond,

Quoted 2 lines · On Freitag, 2. Juni 2023 15:36:16 CEST Raymond Hackley wrote:

Richtek's rt5033-led has pin configurations similar to sgm3140. Add it to the compatible list.

please fix your email setup so that patches also sent to public mailing lists don't get *encrypted*. This is completely pointless and just makes everything more difficult.

Regards
Luca