Skip to contentSkip to conversation

dt-bindings: net: wireless: brcm,bcm4329-fmac: add BCM4366 binding

PATCH Applied Rafał Miłecki 3 participants 8 messages Jun 2, 2023 – Jun 9, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 dt-bindings: net: wireless: brcm,bcm4329-fmac: add BCM4366 binding

From: Rafał Miłecki <[email protected]>

It's an 802.11ac chipset that can be found hardwired in a lot of Northstar based routers.

---
 .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml      | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +1 -0
index fec1cc9b9a08..527f055a6683 100644
@@ -38,6 +38,7 @@ properties:
               - brcm,bcm4354-fmac
               - brcm,bcm4356-fmac
               - brcm,bcm4359-fmac
+              - brcm,bcm4366-fmac
               - cypress,cyw4373-fmac
               - cypress,cyw43012-fmac
           - const: brcm,bcm4329-fmac
Signature · 1 line
2.35.3
#1 lore raw

PATCH 2/3 dt-bindings: net: wireless: brcm,bcm4329-fmac: allow generic properties

From: Rafał Miłecki <[email protected]>

Include ieee80211.yaml to allow using generic 802.11 properties for bindings of Broadcom FullMAC devices. That allows specifying frequencies ranges.

---
 .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml  | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +4 -1
index 527f055a6683..4aa521f1be8c 100644
@@ -15,6 +15,9 @@ description:
   These chips also have a Bluetooth portion described in a separate
   binding.
 
+allOf:
+  - $ref: ieee80211.yaml#
+
 properties:
   compatible:
     oneOf:
@@ -121,7 +124,7 @@ required:
   - compatible
   - reg
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
Signature · 1 line
2.35.3
Acked-by on v1 2/3
#2 lore raw

Re: [PATCH 2/3] dt-bindings: net: wireless: brcm,bcm4329-fmac: allow generic properties

Quoted 7 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

Include ieee80211.yaml to allow using generic 802.11 properties for bindings of Broadcom FullMAC devices. That allows specifying frequencies ranges.

Thanks,
Conor.

Quoted 30 lines
---
 .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml  | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +4 -1
index 527f055a6683..4aa521f1be8c 100644
@@ -15,6 +15,9 @@ description:
   These chips also have a Bluetooth portion described in a separate
   binding.
 
+allOf:
+  - $ref: ieee80211.yaml#
+
 properties:
   compatible:
     oneOf:
@@ -121,7 +124,7 @@ required:
   - compatible
   - reg
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
Signature · 1 line
2.35.3
#3 lore raw

Re: [PATCH 2/3] dt-bindings: net: wireless: brcm,bcm4329-fmac: allow generic properties

In reply to Rafał Miłecki

From: Florian Fainelli <[email protected]>

Quoted 8 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

Include ieee80211.yaml to allow using generic 802.11 properties for bindings of Broadcom FullMAC devices. That allows specifying frequencies ranges.

---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! --
Florian

#4 lore raw

PATCH 3/3 ARM: dts: BCM5301X: Add Netgear R8000 WiFi regulator mappings

In reply to Rafał Miłecki

From: Rafał Miłecki <[email protected]>

This allows setting FullMAC firmware regulatory domain.

---
 arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
arch/arm/boot/dts/bcm4709-netgear-r8000.dts +17 -0
index 14303ab521ea..3552b6deffc2 100644
@@ -137,8 +137,10 @@ bridge@0,0,0 {
 		#size-cells = <2>;
 
 		wifi@0,1,0 {
+			compatible = "brcm,bcm4366-fmac", "brcm,bcm4329-fmac";
 			reg = <0x0000 0 0 0 0>;
 			ieee80211-freq-limit = <5735000 5835000>;
+			brcm,ccode-map = "JP-JP-78", "US-Q2-86";
 		};
 	};
 };
@@ -159,6 +161,19 @@ bridge@1,1,0 {
 			#address-cells = <3>;
 			#size-cells = <2>;
 
+			bridge@1,0 {
+				reg = <0x800 0 0 0 0>;
+
+				#address-cells = <3>;
+				#size-cells = <2>;
+
+				wifi@0,0 {
+					compatible = "brcm,bcm4366-fmac", "brcm,bcm4329-fmac";
+					reg = <0x0000 0 0 0 0>;
+					brcm,ccode-map = "JP-JP-78", "US-Q2-86";
+				};
+			};
+
 			bridge@1,2,2 {
 				reg = <0x1000 0 0 0 0>;
 
@@ -166,8 +181,10 @@ bridge@1,2,2 {
 				#size-cells = <2>;
 
 				wifi@1,4,0 {
+					compatible = "brcm,bcm4366-fmac", "brcm,bcm4329-fmac";
 					reg = <0x0000 0 0 0 0>;
 					ieee80211-freq-limit = <5170000 5730000>;
+					brcm,ccode-map = "JP-JP-78", "US-Q2-86";
 				};
 			};
 		};
Signature · 1 line
2.35.3