Skip to contentSkip to conversation

vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices

PATCH In review Eugenio Pérez 4 participants 5 messages Jun 2, 2023 – Jun 7, 2023 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vdpa: mask _F_CTRL_GUEST_OFFLOADS for vhost vdpa devices

QEMU does not emulate it so it must be disabled as long as the backend does not support it.

---
 net/vhost-vdpa.c | 1 +
 1 file changed, 1 insertion(+)
net/vhost-vdpa.c +1 -0
index 5360924ba0..427a57dd6f 100644
@@ -54,6 +54,7 @@ const int vdpa_feature_bits[] = {
     VIRTIO_F_VERSION_1,
     VIRTIO_NET_F_CSUM,
     VIRTIO_NET_F_GUEST_CSUM,
+    VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
     VIRTIO_NET_F_GSO,
     VIRTIO_NET_F_GUEST_TSO4,
     VIRTIO_NET_F_GUEST_TSO6,
Signature · 1 line
2.31.1
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Eugenio Pérez

QEMU does not emulate it so it must be disabled as long as the backend does not support it.

Thanks

Quoted 19 lines
---
 net/vhost-vdpa.c | 1 +
 1 file changed, 1 insertion(+)
net/vhost-vdpa.c +1 -1
index 5360924ba0..427a57dd6f 100644
@@ -54,6 +54,7 @@ const int vdpa_feature_bits[] = {
     VIRTIO_F_VERSION_1,
     VIRTIO_NET_F_CSUM,
     VIRTIO_NET_F_GUEST_CSUM,
+    VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
     VIRTIO_NET_F_GSO,
     VIRTIO_NET_F_GUEST_TSO4,
     VIRTIO_NET_F_GUEST_TSO6,
--

2.31.1

Tested-by
#2 lore raw

QE tested sanity testing for this patch on the vhost_vdpa device, everything works fine.

Quoted 32 lines · Jason Wang
Quoted 5 lines · Eugenio Pérez

QEMU does not emulate it so it must be disabled as long as the backend does not support it.

Thanks

Quoted 19 lines
---
 net/vhost-vdpa.c | 1 +
 1 file changed, 1 insertion(+)
net/vhost-vdpa.c +1 -1
index 5360924ba0..427a57dd6f 100644
@@ -54,6 +54,7 @@ const int vdpa_feature_bits[] = {
     VIRTIO_F_VERSION_1,
     VIRTIO_NET_F_CSUM,
     VIRTIO_NET_F_GUEST_CSUM,
+    VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
     VIRTIO_NET_F_GSO,
     VIRTIO_NET_F_GUEST_TSO4,
     VIRTIO_NET_F_GUEST_TSO6,
--

2.31.1

#4 lore raw
Quoted 5 lines · Michael Tokarev
Quoted 3 lines · Eugenio Pérez

QEMU does not emulate it so it must be disabled as long as the backend does not support it.

Quoted 7 lines
Quoted 4 lines
---
  net/vhost-vdpa.c | 1 +
  1 file changed, 1 insertion(+)

Is it -stable material?

Yes, I forgot to CC qemu-stable here too.

Thanks!