vdpa: fix not using CVQ buffer in case of error
PATCH 1/1 vdpa: fix not using CVQ buffer in case of error
Bug introducing when refactoring. Otherway, the guest never received the used buffer.
--- net/vhost-vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/vhost-vdpa.c +1 -1
@@ -807,7 +807,7 @@ static int vhost_vdpa_net_handle_ctrl_avail(VhostShadowVirtqueue *svq, }if (*s->status !=VIRTIO_NET_OK ) { -return VIRTIO_NET_ERR ; + goto out; } status =VIRTIO_NET_ERR ;
Signature · 1 line
2.31.1
Quoted 6 lines · Eugenio Pérez
Bug introducing when refactoring. Otherway, the guest never received the used buffer.
Fixes be4278b65fc1 ("vdpa: extract vhost_vdpa_net_cvq_add from vhost_vdpa_net_handle_ctrl_avail")Signed-off-by Eugenio Pérez <[email protected]>
Thanks
Quoted 20 lines
--- net/vhost-vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/vhost-vdpa.c +1
-2@@ -807,7 +807,7 @@ static int vhost_vdpa_net_handle_ctrl_avail(VhostShadowVirtqueue *svq, }if (*s->status !=VIRTIO_NET_OK ) { -return VIRTIO_NET_ERR ; + goto out; } status =VIRTIO_NET_ERR ; --2.31.1
Lei Yang
Tested-byQE tested sanity testing for this patch on the vhost_vdpa device, everything works fine.
Quoted 34 lines · Jason Wang
Quoted 6 lines · Eugenio Pérez
Bug introducing when refactoring. Otherway, the guest never received the used buffer.
Fixes be4278b65fc1 ("vdpa: extract vhost_vdpa_net_cvq_add from vhost_vdpa_net_handle_ctrl_avail")Signed-off-by Eugenio Pérez <[email protected]>Acked-by Jason Wang <[email protected]>Thanks
Quoted 20 lines
--- net/vhost-vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/vhost-vdpa.c +1
-2@@ -807,7 +807,7 @@ static int vhost_vdpa_net_handle_ctrl_avail(VhostShadowVirtqueue *svq, }if (*s->status !=VIRTIO_NET_OK ) { -return VIRTIO_NET_ERR ; + goto out; } status =VIRTIO_NET_ERR ; --2.31.1
Quoted 8 lines · Eugenio Pérez
Bug introducing when refactoring. Otherway, the guest never received the used buffer.
Fixes be4278b65fc1 ("vdpa: extract vhost_vdpa_net_cvq_add from vhost_vdpa_net_handle_ctrl_avail")Signed-off-by Eugenio Pérez <[email protected]>--- net/vhost-vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Again, smells like a stable material, is it not?
Please Cc: [email protected] for other changes you think should be applied to stable qemu series.
Thanks,
/mjt
Quoted 11 lines · Michael Tokarev
Quoted 8 lines · Eugenio Pérez
Bug introducing when refactoring. Otherway, the guest never received the used buffer.
Fixes be4278b65fc1 ("vdpa: extract vhost_vdpa_net_cvq_add from vhost_vdpa_net_handle_ctrl_avail")Signed-off-by Eugenio Pérez <[email protected]>--- net/vhost-vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines
Again, smells like a stable material, is it not?
Please Cc: [email protected] for other changes you think should be applied to stable qemu series.
Sorry, I totally forgot. This one should go to stable, yes.
Thanks!
Quoted 1 line · Eugenio Perez Martin
On Wed, Jun 7, 2023 at 12:11 PM Michael Tokarev <[email protected]> wrote:
..
Quoted 6 lines
Quoted 4 lines
Again, smells like a stable material, is it not?
Please Cc: [email protected] for other changes you think should be applied to stable qemu series.
Sorry, I totally forgot. This one should go to stable, yes.
That's okay, nothing to be sorry about. You did a good job already fixing the issues.
Queued up.
Thank you!
/mjt