package/perl-http-message: add missing reverse dependency on perl-clone
PATCH 1/1 package/perl-http-message: add missing reverse dependency on perl-clone
Commit [1] added dependency on perl-clone but forgot to propagate the reverse dependency on !BR2_STATIC_LIBS.
Fixes:
WARNING: unmet direct dependencies detected for BR2_PACKAGE_PERL_CLONE
Depends on [n]: BR2_PACKAGE_PERL [=y] && !BR2_STATIC_LIBS [=y] Selected by [y]:
- BR2_PACKAGE_PERL_HTTP_MESSAGE [=y] && BR2_PACKAGE_PERL [=y]
http://autobuild.buildroot.org/results/5d5/5d503aaa94b56523c684be7946123921747ebf52
[1] 742258fec06df18782e4bd75b00ca530120312cb
---
While looking at perl-clone build, I noticed that "-shared" is provided to lddlflags by the Perl package infrastructure:
--config lddlflags="-shared $$(TARGET_LDFLAGS)"
It would means that any Perl package in Buildroot requires a dependency on !BR2_STATIC_LIBS.
Currently some Perl packages doesn't requires !BR2_STATIC_LIBS since they simply copy some .pm files. But as soon as something is built, it break for static only builds.
--- package/perl-http-cookies/Config.in | 4 ++++ package/perl-http-daemon/Config.in | 4 ++++ package/perl-http-message/Config.in | 4 ++++ package/perl-http-negotiate/Config.in | 4 ++++ package/perl-plack/Config.in | 4 ++++ 5 files changed, 20 insertions(+)
package/perl-http-cookies/Config.in +4 -0
@@ -1,8 +1,12 @@ config BR2_PACKAGE_PERL_HTTP_COOKIES bool "perl-http-cookies" + depends on !BR2_STATIC_LIBS # perl-http-message -> perl-clone select BR2_PACKAGE_PERL_HTTP_DATE # runtime select BR2_PACKAGE_PERL_HTTP_MESSAGE # runtime help HTTP cookie jars. https://github.com/libwww-perl/HTTP-Cookies + +comment "perl-http-cookies needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS
package/perl-http-daemon/Config.in +4 -0
@@ -1,5 +1,6 @@ config BR2_PACKAGE_PERL_HTTP_DAEMON bool "perl-http-daemon" + depends on !BR2_STATIC_LIBS # perl-http-message -> perl-clone select BR2_PACKAGE_PERL_HTTP_DATE # runtime select BR2_PACKAGE_PERL_HTTP_MESSAGE # runtime select BR2_PACKAGE_PERL_LWP_MEDIATYPES # runtime
@@ -7,3 +8,6 @@ config BR2_PACKAGE_PERL_HTTP_DAEMON A simple http server class. https://github.com/libwww-perl/HTTP-Daemon + +comment "perl-http-daemon needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS
package/perl-http-message/Config.in +4 -0
@@ -1,5 +1,6 @@ config BR2_PACKAGE_PERL_HTTP_MESSAGE bool "perl-http-message" + depends on !BR2_STATIC_LIBS # perl-clone select BR2_PACKAGE_PERL_CLONE # runtime select BR2_PACKAGE_PERL_ENCODE_LOCALE # runtime select BR2_PACKAGE_PERL_HTTP_DATE # runtime
@@ -10,3 +11,6 @@ config BR2_PACKAGE_PERL_HTTP_MESSAGE HTTP style message (base class). https://github.com/libwww-perl/HTTP-Message + +comment "perl-http-message needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS
package/perl-http-negotiate/Config.in +4 -0
@@ -1,7 +1,11 @@ config BR2_PACKAGE_PERL_HTTP_NEGOTIATE bool "perl-http-negotiate" + depends on !BR2_STATIC_LIBS # perl-http-message -> perl-clone select BR2_PACKAGE_PERL_HTTP_MESSAGE # runtime help choose a variant to serve. https://metacpan.org/release/HTTP-Negotiate + +comment "perl-http-negotiate needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS
package/perl-plack/Config.in +4 -0
@@ -1,5 +1,6 @@ config BR2_PACKAGE_PERL_PLACK bool "perl-plack" + depends on !BR2_STATIC_LIBS # perl-http-message -> perl-clone select BR2_PACKAGE_PERL_APACHE_LOGFORMAT_COMPILER # runtime select BR2_PACKAGE_PERL_COOKIE_BAKER # runtime select BR2_PACKAGE_PERL_DEVEL_STACKTRACE # runtime
@@ -19,3 +20,6 @@ config BR2_PACKAGE_PERL_PLACK toolkit). https://github.com/plack/Plack + +comment "perl-plack needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS
Signature · 6 lines
2.34.3 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Romain" == Romain Naour <[email protected]> writes:
Commit [1] added dependency on perl-clone but forgot to propagate the reverse dependency on !BR2_STATIC_LIBS.
Fixes:
WARNING: unmet direct dependencies detected for
BR2_PACKAGE_PERL_CLONE
Depends on [n]:BR2_PACKAGE_PERL[=y] && !BR2_STATIC_LIBS [=y] Selected by [y]:
-BR2_PACKAGE_PERL_HTTP_MESSAGE[=y] &&BR2_PACKAGE_PERL[=y]
Quoted 5 lines
http://autobuild.buildroot.org/results/5d5/5d503aaa94b56523c684be7946123921747ebf52
[1]
742258fec06df18782e4bd75b00ca530120312cbSigned-off-by Romain Naour <[email protected]>
Committed, thanks.
Quoted 4 lines
---
While looking at perl-clone build, I noticed that "-shared" is provided to lddlflags by the Perl package infrastructure:
Quoted 8 lines
--config lddlflags="-shared $$(TARGET_LDFLAGS)"It would means that any Perl package in Buildroot requires a dependency on !BR2_STATIC_LIBS.
Currently some Perl packages doesn't requires !BR2_STATIC_LIBS since they simply copy some .pm files. But as soon as something is built, it break for static only builds.
Hmm, indeed. Maybe we should just make BR2_PACKAGE_PERL depend on !BR2_STATIC_LIBS. I doubt there are a lot of use cases for a statically built perl.
Signature · 5 lines
Bye, Peter Korsgaard _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Romain" == Romain Naour <[email protected]> writes:
Commit [1] added dependency on perl-clone but forgot to propagate the reverse dependency on !BR2_STATIC_LIBS.
Fixes:
WARNING: unmet direct dependencies detected for
BR2_PACKAGE_PERL_CLONE
Depends on [n]:BR2_PACKAGE_PERL[=y] && !BR2_STATIC_LIBS [=y] Selected by [y]:
-BR2_PACKAGE_PERL_HTTP_MESSAGE[=y] &&BR2_PACKAGE_PERL[=y]
Quoted 5 lines
http://autobuild.buildroot.org/results/5d5/5d503aaa94b56523c684be7946123921747ebf52
[1]
742258fec06df18782e4bd75b00ca530120312cbSigned-off-by Romain Naour <[email protected]>
Committed to 2023.02.x, thanks.
Signature · 5 lines
Bye, Peter Korsgaard _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot