Samsung Galaxy Express SGH-I437 Support
Subsystems (5)
v3 cover Samsung Galaxy Express SGH-I437 Support
This patch series adds support for the Samsung Galaxy Express SGH-I437. Currently the following things work on this phone: UART, eMMC, SD Card, and USB.
version 3:
- Added Ack
- Fixed compatible in qcom,usb-hs-phy.yaml. make dt_binding_check dtbs_check no longer complains about USB
- Fixed formatting in qcom-msm8960.dtsi and qcom-msm8960-samsung-expressatt.dts
- Fixed the spi1_default node in qcom-msm8960-samsung-expressatt.dts. make dt_binding_check dtbs_check no longer complains
version 2:
- Combined patch 1 into patch 4, as the sleep_clk label is specifically needed for the USB node.
- Reformatted the commit messages to align with the style used in other commit messages that modify the same files.
- Included a cover letter to provide an overview of the patch series.
- Slight refactoring of the device tree source (DTS) file.
Rudraksha Gupta (4):
dt-bindings: arm: qcom: Add Samsung Galaxy Express
dt-bindings: phy: qcom,usb-hs-phy: Add compatible
ARM: dts: qcom: msm8960: Add USB node
ARM: dts: qcom: Add Samsung Galaxy Express support
.../devicetree/bindings/arm/qcom.yaml | 1 + .../bindings/phy/qcom,usb-hs-phy.yaml | 5 +- arch/arm/boot/dts/Makefile | 1 + .../dts/qcom-msm8960-samsung-expressatt.dts | 331 ++++++++++++++++++ arch/arm/boot/dts/qcom-msm8960.dtsi | 34 +- 5 files changed, 370 insertions(+), 2 deletions(-) create mode 100644 arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts
Signature · 1 line
2.34.1
PATCH v3 1/4 dt-bindings: arm: qcom: Add Samsung Galaxy Express
Add a compatible for Samsung Galaxy Express SGH-I437.
--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -191,6 +191,7 @@ properties: - items: - enum: - qcom,msm8960-cdp + - samsung,expressatt - const: qcom,msm8960 - items:
Signature · 1 line
2.34.1
PATCH v3 2/4 dt-bindings: phy: qcom,usb-hs-phy: Add compatible
In reply to Rudraksha GuptaAdds qcom,usb-hs-phy-msm8960 compatible
--- Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +4 -1
@@ -13,7 +13,9 @@ if: properties: compatible: contains: - const: qcom,usb-hs-phy-apq8064 + items: + - const: qcom,usb-hs-phy-apq8064 + - const: qcom,usb-hs-phy-msm8960 then: properties: resets:
@@ -40,6 +42,7 @@ properties: - qcom,usb-hs-phy-apq8064 - qcom,usb-hs-phy-msm8226 - qcom,usb-hs-phy-msm8916 + - qcom,usb-hs-phy-msm8960 - qcom,usb-hs-phy-msm8974 - const: qcom,usb-hs-phy
Signature · 1 line
2.34.1
Rob Herring
maintainerRe: [PATCH v3 2/4] dt-bindings: phy: qcom,usb-hs-phy: Add compatible
Quoted 7 lines · Rudraksha Gupta
Adds qcom,usb-hs-phy-msm8960 compatible
Signed-off-by Rudraksha Gupta <[email protected]>--- Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.example.dtb: phy: resets: [[4294967295, 10], [1, 0]] is too long
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.example.dtb: phy: reset-names:0: 'por' was expected
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.example.dtb: phy: reset-names: ['phy', 'por'] is too long
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v3 2/4] dt-bindings: phy: qcom,usb-hs-phy: Add compatible
Quoted 23 lines · Rob Herring
Quoted 7 lines · Rudraksha Gupta
Adds qcom,usb-hs-phy-msm8960 compatible
Signed-off-by Rudraksha Gupta <[email protected]>--- Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)My bot found errors running 'make DT_CHECKER_FLAGS=-m
dt_binding_check' on your patch (DT_CHECKER_FLAGSis new in v5.13):yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.example.dtb: phy: resets: [[4294967295, 10], [1, 0]] is too long
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.example.dtb: phy: reset-names:0: 'por' was expected
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.example.dtb: phy: reset-names: ['phy', 'por'] is too long
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml
Quoted 6 lines
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
I see. Why is it off the latest rc1 and not off the latest commit?
Quoted 10 lines
If you already ran 'make
dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that
DT_SCHEMA_FILEScan be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Thanks. I didn't see these errors as I was only looking for expressatt binding errors.
Re: [PATCH v3 2/4] dt-bindings: phy: qcom,usb-hs-phy: Add compatible
In reply to Rudraksha GuptaQuoted 12 lines · Rudraksha Gupta
Adds qcom,usb-hs-phy-msm8960 compatible
Signed-off-by Rudraksha Gupta <[email protected]>--- Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +0
-0
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml if: · line 18
Quoted 7 lines
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +3
-1@@ -13,7 +13,9 @@ if: properties: compatible: contains: - const: qcom,usb-hs-phy-apq8064 + items: + - const: qcom,usb-hs-phy-apq8064 + - const: qcom,usb-hs-phy-msm8960
I have no clue what you want to achieve here. You break the bindings.
It does not look like you tested the bindings, at least after quick look. Please run make dt_binding_check (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint.
Best regards,
Krzysztof
Re: [PATCH v3 2/4] dt-bindings: phy: qcom,usb-hs-phy: Add compatible
Quoted 8 lines · Krzysztof Kozlowski
Quoted 7 lines · Rudraksha Gupta
Adds qcom,usb-hs-phy-msm8960 compatible
Signed-off-by Rudraksha Gupta <[email protected]>--- Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Quoted 14 lines
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml if: · line 18
Quoted 12 lines
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.yaml +3
-1@@ -13,7 +13,9 @@ if: properties: compatible: contains: - const: qcom,usb-hs-phy-apq8064 + items: + - const: qcom,usb-hs-phy-apq8064 + - const: qcom,usb-hs-phy-msm8960I have no clue what you want to achieve here. You break the bindings.
When I added the USB node to the msm8960 dtsi file, I got similar messages for the expressatt/cdp that Rob mentioned in his email reply:
phy: resets: [[25, 0]] is too short
phy: reset-names:0: 'phy' was expected
phy: reset-names: ['por'] is too short
I will send an updated patch soon that addresses this.
Quoted 8 lines
It does not look like you tested the bindings, at least after quick look. Please run
make dt_binding_check(seeDocumentation/devicetree/bindings/writing-schema.rstfor instructions). Maybe you need to update your dtschema and yamllint.Best regards,
Krzysztof
Sorry. I was only looking for expressatt errors/warnings and failed to see the other errors/warnings in the sea of text.
Re: [PATCH v3 2/4] dt-bindings: phy: qcom,usb-hs-phy: Add compatible
On 06/06/2023 04:48, Rudraksha Gupta wrote:
ted patch soon that addresses this.
Quoted 11 lines
Quoted 9 lines
It does not look like you tested the bindings, at least after quick look. Please run
make dt_binding_check(seeDocumentation/devicetree/bindings/writing-schema.rstfor instructions). Maybe you need to update your dtschema and yamllint.Best regards,
KrzysztofSorry. I was only looking for expressatt errors/warnings and failed to see the other errors/warnings in the sea of text.
Best regards,
Krzysztof
PATCH v3 3/4 ARM: dts: qcom: msm8960: Add USB node
In reply to Rudraksha GuptaAdd the required nodes to support USB on the MSM8960 SoC. As it's very similar to the APQ8064 SoC, the nodes are almost identical
Add a label to sleep_clk for the USB node to reference
--- arch/arm/boot/dts/qcom-msm8960.dtsi | 34 ++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-)
arch/arm/boot/dts/qcom-msm8960.dtsi +33 -1
@@ -3,6 +3,7 @@ #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/clock/qcom,gcc-msm8960.h> +#include <dt-bindings/reset/qcom,gcc-msm8960.h> #include <dt-bindings/clock/qcom,lcc-msm8960.h> #include <dt-bindings/mfd/qcom-rpm.h> #include <dt-bindings/soc/qcom,gsbi.h>
@@ -71,7 +72,7 @@ pxo_board: pxo_board { clock-output-names = "pxo_board"; }; - sleep_clk { + sleep_clk: sleep_clk { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <32768>;
@@ -370,5 +371,36 @@ gsbi1_spi: spi@16080000 { status = "disabled"; }; }; + + usb1: usb@12500000 { + compatible = "qcom,ci-hdrc"; + reg = <0x12500000 0x200>, + <0x12500200 0x200>; + interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&gcc USB_HS1_XCVR_CLK>, <&gcc USB_HS1_H_CLK>; + clock-names = "core", "iface"; + assigned-clocks = <&gcc USB_HS1_XCVR_CLK>; + assigned-clock-rates = <60000000>; + resets = <&gcc USB_HS1_RESET>; + reset-names = "core"; + phy_type = "ulpi"; + ahb-burst-config = <0>; + phys = <&usb_hs1_phy>; + phy-names = "usb-phy"; + #reset-cells = <1>; + status = "disabled"; + + ulpi { + usb_hs1_phy: phy { + compatible = "qcom,usb-hs-phy-msm8960", + "qcom,usb-hs-phy"; + clocks = <&sleep_clk>, <&cxo_board>; + clock-names = "sleep", "ref"; + resets = <&usb1 0>; + reset-names = "por"; + #phy-cells = <0>; + }; + }; + }; }; };
Signature · 1 line
2.34.1
PATCH v3 4/4 ARM: dts: qcom: Add Samsung Galaxy Express support
In reply to Rudraksha GuptaAdd a very basic device tree file for the Samsung Galaxy Express SGH-I437. Currently, the following things work: UART, eMMC, SD Card, and USB.
--- arch/arm/boot/dts/Makefile | 1 + .../dts/qcom-msm8960-samsung-expressatt.dts | 331 ++++++++++++++++++ 2 files changed, 332 insertions(+) create mode 100644 arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts
arch/arm/boot/dts/Makefile +1 -0
@@ -1081,6 +1081,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \ qcom-msm8916-samsung-grandmax.dtb \ qcom-msm8916-samsung-serranove.dtb \ qcom-msm8960-cdp.dtb \ + qcom-msm8960-samsung-expressatt.dtb \ qcom-msm8974-lge-nexus5-hammerhead.dtb \ qcom-msm8974-sony-xperia-rhine-amami.dtb \ qcom-msm8974-sony-xperia-rhine-honami.dtb \
arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts new file +331 -0
331 lines not on this page · raw message
Signature · 1 line
2.34.1