Skip to contentSkip to conversation

serial: st-asc: fix typo in property name

PATCH In review Raphael Gallais-Pou 2 participants 2 messages Jun 4, 2023 – Jun 5, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 serial: st-asc: fix typo in property name

Changes the property name read in the driver according to the YAML. According to device-tree documentation, property names should not include underscores.

---
 drivers/tty/serial/st-asc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/st-asc.c +1 -1
index 5215e6910f68..6ef99a037a9b 100644
@@ -754,7 +754,7 @@ static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev)
 
 	asc_ports[id].hw_flow_control = of_property_read_bool(np,
 							"uart-has-rtscts");
-	asc_ports[id].force_m1 =  of_property_read_bool(np, "st,force_m1");
+	asc_ports[id].force_m1 =  of_property_read_bool(np, "st,force-m1");
 	asc_ports[id].port.line = id;
 	asc_ports[id].rts = NULL;
 
Signature · 1 line
2.40.1
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi Raphael

Quoted 14 lines · Raphael Gallais-Pou

Changes the property name read in the driver according to the YAML. According to device-tree documentation, property names should not include underscores.

---
 drivers/tty/serial/st-asc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/st-asc.c +0 -0
index 5215e6910f68..6ef99a037a9b 100644

drivers/tty/serial/st-asc.c static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev) · line 760

Quoted 8 lines
drivers/tty/serial/st-asc.c +1 -1
@@ -754,7 +754,7 @@ static struct asc_port *asc_of_get_asc_port(struct platform_device *pdev)
 
 	asc_ports[id].hw_flow_control = of_property_read_bool(np,
 							"uart-has-rtscts");
-	asc_ports[id].force_m1 =  of_property_read_bool(np, "st,force_m1");
+	asc_ports[id].force_m1 =  of_property_read_bool(np, "st,force-m1");
 	asc_ports[id].port.line = id;
 	asc_ports[id].rts = NULL;
 

Thanks
Patrice