Integrate igt_spin_new with Xe
Subsystems (2)
cover Integrate igt_spin_new with Xe
From: Sai Gowtham Ch <[email protected]>
Extending the spin_create implementation and allocator handle support in xe, where it submits dummy work loads to engine. This Implementation is wrapped around vm_bind and unbind as we are supposed to do it manually for xe.
Sai Gowtham Ch (2):
lib/xe/xe_spin: Integrate igt_spin_new with Xe tests/xe/xe_spin_batch: Add new test to exercise igt_spin_new for xe
lib/igt_dummyload.c | 24 ++++-- lib/igt_dummyload.h | 12 +++ lib/xe/xe_spin.c | 121 ++++++++++++++++++++++++++++ lib/xe/xe_spin.h | 6 +- tests/meson.build | 1 + tests/xe/xe_spin_batch.c | 168 +++++++++++++++++++++++++++++++++++++++ 6 files changed, 325 insertions(+), 7 deletions(-) create mode 100644 tests/xe/xe_spin_batch.c
Signature · 1 line
2.39.1
PATCH 1/2 lib/xe/xe_spin: Integrate igt_spin_new with Xe
From: Sai Gowtham Ch <[email protected]>
Extending the spin_create implementation and allocator handle support in xe, where it submits dummy work loads to engine. This Implementation is wrapped around vm_bind and unbind as we are supposed to do it manually for xe.
--- lib/igt_dummyload.c | 24 ++++++--- lib/igt_dummyload.h | 12 +++++ lib/xe/xe_spin.c | 121 ++++++++++++++++++++++++++++++++++++++++++++ lib/xe/xe_spin.h | 6 ++- 4 files changed, 156 insertions(+), 7 deletions(-)
lib/igt_dummyload.c +18 -6
@@ -46,6 +46,7 @@#include "intel_reg.h" #include "ioctl_wrappers.h" #include "sw_sync.h" +#include "xe/xe_spin.h" /** * SECTION:igt_dummyload
@@ -447,7 +448,10 @@ spin_create(int fd, const struct igt_spin_factory *opts)igt_spin_t *__igt_spin_factory (int fd,const struct igt_spin_factory *opts) { -return spin_create (fd, opts); +if (is_xe_device (fd)) +return xe_spin_create (fd, opts); +else +return spin_create (fd, opts); }/**
@@ -467,6 +471,11 @@ igt_spin_factory(int fd, const struct igt_spin_factory *opts) {igt_spin_t *spin; +if (is_xe_device (fd)) { + spin =xe_spin_create (fd, opts); +return spin; + } +if ((opts->flags &IGT_SPIN_POLL_RUN ) && opts->engine !=ALL_ENGINES ) {unsigned int class;
@@ -647,11 +656,14 @@ void igt_spin_free(int fd, igt_spin_t *spin)if (!spin)return ; -pthread_mutex_lock (&list_lock); -igt_list_del (&spin->link); -pthread_mutex_unlock (&list_lock); - -__igt_spin_free (fd, spin); +if (is_xe_device (fd)) { +xe_spin_free (fd, spin); + }else { +pthread_mutex_lock (&list_lock); +igt_list_del (&spin->link); +pthread_mutex_unlock (&list_lock); +__igt_spin_free (fd, spin); + } }void igt_terminate_spins (void )
lib/igt_dummyload.h +12 -0
@@ -54,6 +54,8 @@ typedef struct igt_spin_factory {unsigned int flags;int fence;uint64_t ahnd; +struct drm_xe_engine_class_instance *hwe; +uint32_t vm; } igt_spin_factory_t; typedef struct igt_spin {
@@ -83,6 +85,16 @@ typedef struct igt_spin {#define SPIN_CLFLUSH (1 << 0)struct igt_spin_factory opts; + +struct xe_spin *xe_spin; +size_t bo_size; +uint64_t address; +unsigned int engine; +uint32_t vm; +uint32_t syncobj; +bool is_user_vm; +bool is_user_engine; + } igt_spin_t;
lib/xe/xe_spin.c +121 -0
127 lines not on this page · raw message
lib/xe/xe_spin.h +5 -1
@@ -13,6 +13,7 @@#include <stdbool.h> #include "xe_query.h" +#include "lib/igt_dummyload.h" /* Mapped GPU object */ struct xe_spin {
@@ -21,11 +22,14 @@ struct xe_spin {uint32_t start;uint32_t end; }; - +void xe_spin_user_vm_engine (int fd,const struct igt_spin_factory *opt,struct igt_spin *spin); +igt_spin_t *xe_spin_create (int fd,const struct igt_spin_factory *opt);void xe_spin_init (struct xe_spin *spin,uint64_t addr,bool preempt);bool xe_spin_started (struct xe_spin *spin); +void xe_spin_sync_wait (int fd,struct igt_spin *spin);void xe_spin_wait_started (struct xe_spin *spin);void xe_spin_end (struct xe_spin *spin); +void xe_spin_free (int fd,struct igt_spin *spin);struct xe_cork {struct xe_spin *spin;
Signature · 1 line
2.39.1
Re: [igt-dev] [PATCH i-g-t 1/2] lib/xe/xe_spin: Integrate igt_spin_new with Xe
Quoted 168 lines
-----Original Message-----
From: Ch, Sai Gowtham <[email protected]>
Sent: 05 June 2023 01:28
To: [email protected]; Kempczynski, Zbigniew <[email protected]>; Ch, Sai Gowtham <[email protected]>; Kumar, Janga Rahul <[email protected]>; [email protected]
Subject: [PATCH i-g-t 1/2]lib/xe/xe_spin: Integrateigt_spin_newwith XeFrom: Sai Gowtham Ch <[email protected]>
Extending the
spin_createimplementation and allocator handle support in xe, where it submits dummy work loads to engine. This Implementation is wrapped aroundvm_bindand unbind as we are supposed to do it manually for xe.Cc Zbigniew Kempczyński <[email protected]>Signed-off-by Sai Gowtham Ch <[email protected]>--- lib/igt_dummyload.c | 24 ++++++--- lib/igt_dummyload.h | 12 +++++ lib/xe/xe_spin.c | 121 ++++++++++++++++++++++++++++++++++++++++++++ lib/xe/xe_spin.h | 6 ++- 4 files changed, 156 insertions(+), 7 deletions(-)lib/igt_dummyload.c index renamed from lib/igt_dummyload.c +0
-0
740a58f3..6e89b72d100644lib/igt_dummyload.c +18
-6@@ -46,6 +46,7 @@#include "intel_reg.h" #include "ioctl_wrappers.h" #include "sw_sync.h" +#include "xe/xe_spin.h" /** * SECTION:igt_dummyload @@ -447,7 +448,10 @@ spin_create(int fd, const struct igt_spin_factory *opts)igt_spin_t *__igt_spin_factory (int fd,const struct igt_spin_factory *opts) { -return spin_create (fd, opts); +if (is_xe_device (fd)) +return xe_spin_create (fd, opts); +else +return spin_create (fd, opts); }/** @@ -467,6 +471,11 @@ igt_spin_factory(int fd, const struct igt_spin_factory *opts) {igt_spin_t *spin; +if (is_xe_device (fd)) { + spin =xe_spin_create (fd, opts); +return spin; + } +if ((opts->flags &IGT_SPIN_POLL_RUN ) && opts->engine !=ALL_ENGINES ) {unsigned int class;@@ -647,11 +656,14 @@ void igt_spin_free(int fd, igt_spin_t *spin)if (!spin)return ; -pthread_mutex_lock (&list_lock); -igt_list_del (&spin->link); -pthread_mutex_unlock (&list_lock); - -__igt_spin_free (fd, spin); +if (is_xe_device (fd)) { +xe_spin_free (fd, spin); + }else { +pthread_mutex_lock (&list_lock); +igt_list_del (&spin->link); +pthread_mutex_unlock (&list_lock); +__igt_spin_free (fd, spin); + } }void igt_terminate_spins (void )lib/igt_dummyload.h index renamed from lib/igt_dummyload.h +0
-0
b247ab02..c5d7b993100644lib/igt_dummyload.h +12
-0@@ -54,6 +54,8 @@ typedef struct igt_spin_factory {unsigned int flags;int fence;uint64_t ahnd; +struct drm_xe_engine_class_instance *hwe; +uint32_t vm; } igt_spin_factory_t; typedef struct igt_spin {@@ -83,6 +85,16 @@ typedef struct igt_spin { #define SPIN_CLFLUSH (1 << 0)struct igt_spin_factory opts; + +struct xe_spin *xe_spin; +size_t bo_size; +uint64_t address; +unsigned int engine; +uint32_t vm; +uint32_t syncobj; +bool is_user_vm; +bool is_user_engine; + } igt_spin_t;lib/xe/xe_spin.c index 856d0ba2..c5a4479b renamed from lib/xe/xe_spin.c +0
-0100644
lib/xe/xe_spin.c +51
-0@@ -82,6 +82,127 @@ void xe_spin_end(struct xe_spin *spin) spin->end =0 ; } +/** +* xe_spin_user_vm_engine: +* @spin: spin state from igt_spin_new() +* @opt: controlling options such as allocator handle, engine, vm etc +* +* Wrapper function collects the vm and engine data from the user, +* if engine is not given from the user, engine will be created. +* +*/ +void xe_spin_user_vm_engine (int fd,const struct igt_spin_factory *opt, +struct igt_spin *spin) { + spin->vm = opt->vm; + spin->is_user_vm = true; +if (opt->engine) { + spin->engine = opt->engine; + spin->is_user_engine = true; + }else { +if (opt->hwe) + spin->engine =xe_engine_create (fd, spin->vm, opt- >hwe, 0); +else + spin->engine =xe_engine_create_class (fd, spin->vm, +DRM_XE_ENGINE_CLASS_COPY ); + + spin->is_user_engine = false; + } +} + +/** +* xe_spin_create: +*@opt: controlling options such as allocator handle, engine, vmetc +* +* igt_spin_new for xe, xe_spin_create submits a batch using +xe_spin_init +* which wraps around vm bind and unbinding the object associated to it. +* This returs a spinner after submitting a dummy load. +* +*/ +igt_spin_t * +xe_spin_create (int fd,const struct igt_spin_factory *opt) { +size_t bo_size =xe_get_default_alignment (fd); +uint64_t ahnd = opt->ahnd, addr; +struct igt_spin *spin; +struct xe_spin *xe_spin; +struct drm_xe_sync sync = { + .flags =DRM_XE_SYNC_SYNCOBJ |DRM_XE_SYNC_SIGNAL , + }; +struct drm_xe_exec exec = { + .num_batch_buffer =1 , + .num_syncs =1 , + .syncs =to_user_pointer (&sync), + };
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 146
Quoted 10 lines
lib/xe/xe_spin.c +10
-0+ +igt_assert (ahnd); + spin =calloc (1 ,sizeof (struct igt_spin )); +igt_assert (spin); + + spin->syncobj =syncobj_create (fd,0 ); + +if (opt->vm) { +xe_spin_user_vm_engine (fd, opt, spin); +
Remove above extra line
Quoted 93 lines
lib/xe/xe_spin.c +13
-0+ }else { + spin->vm =xe_vm_create (fd,0 ,0 ); +if (opt->hwe) + spin->engine =xe_engine_create (fd, spin->vm, opt- >hwe, 0); +else + spin->engine =xe_engine_create_class (fd, spin->vm,DRM_XE_ENGINE_CLASS_COPY ); + spin->is_user_vm = false; + spin->is_user_engine = false; + } + + spin->handle =xe_bo_create (fd,0 , spin->vm, bo_size); + xe_spin =xe_bo_map (fd, spin->handle, bo_size); + addr = intel_allocator_alloc_with_strategy(ahnd, spin->handle, bo_size,0,
ALLOC_STRATEGY_LOW_TO_HIGH);lib/xe/xe_spin.c +45
-0+xe_vm_bind_sync (fd, spin->vm, spin->handle,0 , addr, bo_size); + +xe_spin_init (xe_spin, addr, true); + exec.engine_id = spin->engine; + exec.address = addr; + sync.handle = spin->syncobj; +igt_assert_eq (igt_ioctl (fd,DRM_IOCTL_XE_EXEC , &exec),0 ); +xe_spin_wait_started (xe_spin); + + spin->bo_size = bo_size; + spin->address = addr; + spin->xe_spin = xe_spin; + +return spin; +} + +void xe_spin_sync_wait (int fd,struct igt_spin *spin) { +igt_assert (syncobj_wait (fd, &spin->syncobj,1 ,INT64_MAX ,0 ,NULL )); } + +/* +* xe_spin_free: +*@spin: spin state from igt_spin_new() +* +* Wrapper to free spinner whhich is triggered by xe_spin_create. +* which distroys vm, engine and unbinds the vm which is binded to +* the engine and bo. +* +*/ +void xe_spin_free (int fd,struct igt_spin *spin) { +xe_spin_end (spin->xe_spin); +xe_spin_sync_wait (fd, spin); +xe_vm_unbind_sync (fd, spin->vm,0 , spin->address, spin->bo_size); +syncobj_destroy (fd, spin->syncobj); +gem_munmap (spin->xe_spin, spin->bo_size); +gem_close (fd, spin->handle); + +if (!spin->is_user_engine) +xe_engine_destroy (fd, spin->engine); + +if (!spin->is_user_vm) +xe_vm_destroy (fd, spin->vm); + +free (spin); +} +void xe_cork_init (int fd,struct drm_xe_engine_class_instance *hwe,struct xe_cork *cork) {lib/xe/xe_spin.h +6
-2@@ -13,6 +13,7 @@#include <stdbool.h> #include "xe_query.h" +#include "lib/igt_dummyload.h" /* Mapped GPU object */ struct xe_spin {@@ -21,11 +22,14 @@ struct xe_spin {uint32_t start;uint32_t end; }; - +void +(int fd, const struct igt_spin_factory *opt, +struct igt_spin *spin); igt_spin_t *xe_spin_create(int fd, const struct +igt_spin_factory *opt);void xe_spin_init (struct xe_spin *spin,uint64_t addr,bool preempt);bool xe_spin_started (struct xe_spin *spin); +void xe_spin_sync_wait (int fd,struct igt_spin *spin);void xe_spin_wait_started (struct xe_spin *spin);void xe_spin_end (struct xe_spin *spin); +void xe_spin_free (int fd,struct igt_spin *spin);struct xe_cork {struct xe_spin *spin; --
Quoted 1 line
2.39.1
LGTM
Re: [igt-dev] [PATCH i-g-t 1/2] lib/xe/xe_spin: Integrate igt_spin_new with Xe
In reply to [email protected]Quoted 28 lines · On Mon, Jun 05, 2023 at 01:28:10AM +0530, [email protected] wrote:
From: Sai Gowtham Ch <[email protected]>
Extending the
spin_createimplementation and allocator handle support in xe, where it submits dummy work loads to engine. This Implementation is wrapped aroundvm_bindand unbind as we are supposed to do it manually for xe.Cc Zbigniew Kempczyński <[email protected]>Signed-off-by Sai Gowtham Ch <[email protected]>--- lib/igt_dummyload.c | 24 ++++++--- lib/igt_dummyload.h | 12 +++++ lib/xe/xe_spin.c | 121 ++++++++++++++++++++++++++++++++++++++++++++ lib/xe/xe_spin.h | 6 ++- 4 files changed, 156 insertions(+), 7 deletions(-)lib/igt_dummyload.c +1
-0@@ -46,6 +46,7 @@#include "intel_reg.h" #include "ioctl_wrappers.h" #include "sw_sync.h" +#include "xe/xe_spin.h" /** * SECTION:igt_dummyload
lib/igt_dummyload.c spin_create(int fd, const struct igt_spin_factory *opts) · line 452
Quoted 6 lines
lib/igt_dummyload.c +2
-1@@ -447,7 +448,10 @@ spin_create(int fd, const struct igt_spin_factory *opts)igt_spin_t *__igt_spin_factory (int fd,const struct igt_spin_factory *opts) { -return spin_create (fd, opts); +if (is_xe_device (fd)) +return xe_spin_create (fd, opts);
Add spinner to spin_list to handle igt_terminate_spins() in igt_core.c. If test will fail you cannot leave dangling spinners.
Add 'intel_driver' to the struct and store which driver executed the spinner, you'll need it in igt_spin_end().
lib/igt_dummyload.c igt_spin_factory(int fd, const struct igt_spin_factory *opts) · line 477
Quoted 13 lines
lib/igt_dummyload.c +6
-0+else +return spin_create (fd, opts); }/** @@ -467,6 +471,11 @@ igt_spin_factory(int fd, const struct igt_spin_factory *opts) {igt_spin_t *spin; +if (is_xe_device (fd)) { + spin =xe_spin_create (fd, opts); +return spin; + }
In this path too, you may create some wrapper if you want to avoid code duplication in __igt_spin_factory() and igt_spin_factory().
lib/igt_dummyload.c void igt_spin_free(int fd, igt_spin_t *spin) · line 652
Quoted 11 lines
lib/igt_dummyload.c +1
-3+if ((opts->flags &IGT_SPIN_POLL_RUN ) && opts->engine !=ALL_ENGINES ) {unsigned int class;@@ -647,11 +656,14 @@ void igt_spin_free(int fd, igt_spin_t *spin)if (!spin)return ; -pthread_mutex_lock (&list_lock); -igt_list_del (&spin->link); -pthread_mutex_unlock (&list_lock);
This can stay here, will handle both i915 and xe spinners.
Quoted 29 lines
lib/igt_dummyload.c +8
-2- -__igt_spin_free (fd, spin); +if (is_xe_device (fd)) { +xe_spin_free (fd, spin); + }else { +pthread_mutex_lock (&list_lock); +igt_list_del (&spin->link); +pthread_mutex_unlock (&list_lock); +__igt_spin_free (fd, spin); + } }void igt_terminate_spins (void )lib/igt_dummyload.h +2
-0@@ -54,6 +54,8 @@ typedef struct igt_spin_factory {unsigned int flags;int fence;uint64_t ahnd; +struct drm_xe_engine_class_instance *hwe; +uint32_t vm; } igt_spin_factory_t; typedef struct igt_spin {@@ -83,6 +85,16 @@ typedef struct igt_spin {#define SPIN_CLFLUSH (1 << 0)
lib/igt_dummyload.h typedef struct igt_spin { · line 96
Quoted 10 lines
lib/igt_dummyload.h +9
-0struct igt_spin_factory opts; + +struct xe_spin *xe_spin; +size_t bo_size; +uint64_t address; +unsigned int engine; +uint32_t vm; +uint32_t syncobj; +bool is_user_vm; +bool is_user_engine;
Those two vars are not necessary, reuse opts, see below.
Quoted 27 lines
lib/igt_dummyload.h +1
-0+ } igt_spin_t;lib/xe/xe_spin.c +15
-0@@ -82,6 +82,127 @@ void xe_spin_end(struct xe_spin *spin) spin->end =0 ; } +/** +* xe_spin_user_vm_engine: +* @spin: spin state from igt_spin_new() +* @opt: controlling options such as allocator handle, engine, vm etc +* +* Wrapper function collects the vm and engine data from the user, +* if engine is not given from the user, engine will be created. +* +*/ +void xe_spin_user_vm_engine (int fd,const struct igt_spin_factory *opt,struct igt_spin *spin) +{ + spin->vm = opt->vm; + spin->is_user_vm = true; +if (opt->engine) { + spin->engine = opt->engine;
lib/xe/xe_spin.c void xe_spin_end(struct xe_spin *spin) · line 109
Quoted 10 lines
lib/xe/xe_spin.c +10
-0+ spin->is_user_engine = true; + }else { +if (opt->hwe) + spin->engine =xe_engine_create (fd, spin->vm, opt->hwe,0 ); +else + spin->engine =xe_engine_create_class (fd, spin->vm,DRM_XE_ENGINE_CLASS_COPY ); + + spin->is_user_engine = false; + } +}
Too complicated, especially you don't need is_user_ variables, maybe:
@@ -139,17 +113,17 @@ xe_spin_create(int fd, const struct igt_spin_factory *opt)
spin->syncobj = syncobj_create(fd, 0);
- if (opt->vm) {
- xe_spin_user_vm_engine(fd, opt, spin);
+ spin->vm = opt->vm;
+ spin->engine = opt->engine;
- } else {
+ if (!spin->vm)
spin->vm = xe_vm_create(fd, 0, 0);
+
+ if (!spin->engine) {
if (opt->hwe)
spin->engine = xe_engine_create(fd, spin->vm, opt->hwe, 0);
else
spin->engine = xe_engine_create_class(fd, spin->vm, DRM_XE_ENGINE_CLASS_COPY);
- spin->is_user_vm = false;
- spin->is_user_engine = false;
}
spin->handle = xe_bo_create(fd, 0, spin->vm, bo_size);
@@ -167,6 +141,7 @@ xe_spin_create(int fd, const struct igt_spin_factory *opt)
spin->bo_size = bo_size;
spin->address = addr;
spin->xe_spin = xe_spin;+ spin->opts = *opt;
return spin;
}
@@ -194,10 +169,10 @@ void xe_spin_free(int fd, struct igt_spin *spin)
gem_munmap(spin->xe_spin, spin->bo_size);
gem_close(fd, spin->handle);- if (!spin->is_user_engine)
+ if (!spin->opts.engine)
xe_engine_destroy(fd, spin->engine);
- if (!spin->is_user_vm)
+ if (!spin->opts.vm)
xe_vm_destroy(fd, spin->vm);
free(spin);--
Zbigniew
Quoted 130 lines
lib/xe/xe_spin.c +96
-0+ +/** +* xe_spin_create: +*@opt: controlling options such as allocator handle, engine, vmetc +* +* igt_spin_new for xe, xe_spin_create submits a batch using xe_spin_init +* which wraps around vm bind and unbinding the object associated to it. +* This returs a spinner after submitting a dummy load. +* +*/ +igt_spin_t * +xe_spin_create (int fd,const struct igt_spin_factory *opt) +{ +size_t bo_size =xe_get_default_alignment (fd); +uint64_t ahnd = opt->ahnd, addr; +struct igt_spin *spin; +struct xe_spin *xe_spin; +struct drm_xe_sync sync = { + .flags =DRM_XE_SYNC_SYNCOBJ |DRM_XE_SYNC_SIGNAL , + }; +struct drm_xe_exec exec = { + .num_batch_buffer =1 , + .num_syncs =1 , + .syncs =to_user_pointer (&sync), + }; + +igt_assert (ahnd); + spin =calloc (1 ,sizeof (struct igt_spin )); +igt_assert (spin); + + spin->syncobj =syncobj_create (fd,0 ); + +if (opt->vm) { +xe_spin_user_vm_engine (fd, opt, spin); + + }else { + spin->vm =xe_vm_create (fd,0 ,0 ); +if (opt->hwe) + spin->engine =xe_engine_create (fd, spin->vm, opt->hwe,0 ); +else + spin->engine =xe_engine_create_class (fd, spin->vm,DRM_XE_ENGINE_CLASS_COPY ); + spin->is_user_vm = false; + spin->is_user_engine = false; + } + + spin->handle =xe_bo_create (fd,0 , spin->vm, bo_size); + xe_spin =xe_bo_map (fd, spin->handle, bo_size); + addr =intel_allocator_alloc_with_strategy (ahnd, spin->handle, bo_size,0 ,ALLOC_STRATEGY_LOW_TO_HIGH ); +xe_vm_bind_sync (fd, spin->vm, spin->handle,0 , addr, bo_size); + +xe_spin_init (xe_spin, addr, true); + exec.engine_id = spin->engine; + exec.address = addr; + sync.handle = spin->syncobj; +igt_assert_eq (igt_ioctl (fd,DRM_IOCTL_XE_EXEC , &exec),0 ); +xe_spin_wait_started (xe_spin); + + spin->bo_size = bo_size; + spin->address = addr; + spin->xe_spin = xe_spin; + +return spin; +} + +void xe_spin_sync_wait (int fd,struct igt_spin *spin) +{ +igt_assert (syncobj_wait (fd, &spin->syncobj,1 ,INT64_MAX ,0 ,NULL )); +} + +/* +* xe_spin_free: +*@spin: spin state from igt_spin_new() +* +* Wrapper to free spinner whhich is triggered by xe_spin_create. +* which distroys vm, engine and unbinds the vm which is binded to +* the engine and bo. +* +*/ +void xe_spin_free (int fd,struct igt_spin *spin) +{ +xe_spin_end (spin->xe_spin); +xe_spin_sync_wait (fd, spin); +xe_vm_unbind_sync (fd, spin->vm,0 , spin->address, spin->bo_size); +syncobj_destroy (fd, spin->syncobj); +gem_munmap (spin->xe_spin, spin->bo_size); +gem_close (fd, spin->handle); + +if (!spin->is_user_engine) +xe_engine_destroy (fd, spin->engine); + +if (!spin->is_user_vm) +xe_vm_destroy (fd, spin->vm); + +free (spin); +} +void xe_cork_init (int fd,struct drm_xe_engine_class_instance *hwe,struct xe_cork *cork) {lib/xe/xe_spin.h +5
-1@@ -13,6 +13,7 @@#include <stdbool.h> #include "xe_query.h" +#include "lib/igt_dummyload.h" /* Mapped GPU object */ struct xe_spin {@@ -21,11 +22,14 @@ struct xe_spin {uint32_t start;uint32_t end; }; - +void xe_spin_user_vm_engine (int fd,const struct igt_spin_factory *opt,struct igt_spin *spin); +igt_spin_t *xe_spin_create (int fd,const struct igt_spin_factory *opt);void xe_spin_init (struct xe_spin *spin,uint64_t addr,bool preempt);bool xe_spin_started (struct xe_spin *spin); +void xe_spin_sync_wait (int fd,struct igt_spin *spin);void xe_spin_wait_started (struct xe_spin *spin);void xe_spin_end (struct xe_spin *spin); +void xe_spin_free (int fd,struct igt_spin *spin);struct xe_cork {struct xe_spin *spin;Signature · 1 line
2.39.1
PATCH 2/2 tests/xe/xe_spin_batch: Add new test to exercise igt_spin_new for xe
In reply to [email protected]From: Sai Gowtham Ch <[email protected]>
xe_spin_batch test exercises igt_spin_new submissions with different combination.
--- tests/meson.build | 1 + tests/xe/xe_spin_batch.c | 168 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 169 insertions(+) create mode 100644 tests/xe/xe_spin_batch.c
tests/meson.build +1 -0
@@ -268,6 +268,7 @@ xe_progs = [ 'xe_query', 'xe_vm', 'xe_waitfence', + 'xe_spin_batch', ] msm_progs = [
tests/xe/xe_spin_batch.c new file +168 -0
168 lines not on this page · raw message
Signature · 1 line
2.39.1
Re: [igt-dev] [PATCH i-g-t 2/2] tests/xe/xe_spin_batch: Add new test to exercise igt_spin_new for xe
Quoted 211 lines
-----Original Message-----
From: Ch, Sai Gowtham <[email protected]>
Sent: 05 June 2023 01:28
To: [email protected]; Kempczynski, Zbigniew <[email protected]>; Ch, Sai Gowtham <[email protected]>; Kumar, Janga Rahul <[email protected]>; [email protected]
Subject: [PATCH i-g-t 2/2] tests/xe/xe_spin_batch: Add new test to exerciseigt_spin_newfor xeFrom: Sai Gowtham Ch <[email protected]>
xe_spin_batchtest exercisesigt_spin_newsubmissions with different combination.Cc Zbigniew Kempczyński <[email protected]>Signed-off-by Sai Gowtham Ch <[email protected]>--- tests/meson.build | 1 + tests/xe/xe_spin_batch.c | 168 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 169 insertions(+) create mode 100644 tests/xe/xe_spin_batch.ctests/meson.build index f71be1db..e794b75a renamed from tests/meson.build +0
-0100644
tests/meson.build +1
-0@@ -268,6 +268,7 @@ xe_progs = [ 'xe_query', 'xe_vm', 'xe_waitfence', + 'xe_spin_batch', ] msm_progs = [tests/xe/xe_spin_batch.c new file mode renamed from tests/xe/xe_spin_batch.c +0
-0100644 index 00000000..ac531110
tests/xe/xe_spin_batch.c new file +66
-0@@ -0,0 +1,168 @@ +#include "igt.h" +#include "lib/intel_reg.h" +#include "xe_drm.h" +#include "xe/xe_ioctl.h" +#include "xe/xe_query.h" + +#define MAX_INSTANCE 9 + +/** +* TEST: Basic test for spin batch submissons. +* +* SUBTEST: spin-basic +* Description: Basic test to submit spin batch submissons on copy engine. +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin_basic (int fd) +{ +uint64_t ahnd; +igt_spin_t *spin; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + spin = __igt_spin_new(fd, .ahnd = ahnd); +igt_assert (spin); + +igt_spin_free (fd, spin); +put_ahnd (ahnd); +} + +/** +* TEST:Test for spin batch submissons. +* +* SUBTEST: spin-batch +* Description: Create vm and engine of hwe class and run the spinner on it. +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin (int fd,struct drm_xe_engine_class_instance *hwe) { +uint64_t ahnd; +unsigned int engine; +uint32_t vm; +igt_spin_t *spin; + + vm =xe_vm_create (fd,0 ,0 ); + engine =xe_engine_create (fd, vm, hwe,0 ); + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + + spin = igt_spin_new(fd, .ahnd = ahnd, .engine = engine, .vm = vm); +igt_assert (spin); + +igt_spin_free (fd, spin); +xe_engine_destroy (fd, engine); +xe_vm_destroy (fd, vm); + +put_ahnd (ahnd); +} + +/** +* TEST: Basic test for spin batch submission on all hwe. +* +* SUBTEST: spin-basic-all +* Description: Basic test which validates the functionality of spinner on all hwe.
+ * Run type: FULL
+ * TODO: change ``'Run type' == FULL`` to a better category
+ *
+ */tests/xe/xe_spin_batch.c new file +54
-0+static void spin_basic_all (int fd,struct drm_xe_engine_class_instance +*hwe) { +uint64_t ahnd; +igt_spin_t *spin; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + spin = __igt_spin_new(fd, .ahnd = ahnd, .hwe = hwe); +igt_assert (spin); + +igt_spin_free (fd, spin); +put_ahnd (ahnd); +} + +/** +* TEST: Test for spin batch submissions. +* SUBTEST: spin-all +* Description: Spinner test to run on all the engines! +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin_all (int fd,int gt,int class) { +uint64_t ahnd; +uint32_t engines[MAX_INSTANCE ]; +uint32_t vm[MAX_INSTANCE ]; +int i, num_placements =0 ; +struct drm_xe_engine_class_instance eci[MAX_INSTANCE ]; +igt_spin_t *spin[MAX_INSTANCE ]; +struct drm_xe_engine_class_instance *hwe; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + +xe_for_each_hw_engine (fd, hwe) { +if (hwe->engine_class != class || hwe->gt_id != gt) +continue ; + eci[num_placements++] = *hwe; + } +if (num_placements <2 ) +return ; + +for (i =0 ; i < num_placements; i++) { +struct drm_xe_engine_create create; + vm[i] =xe_vm_create (fd,0 ,0 ); + + create.vm_id = vm[i]; + create.width =1 ; + create.num_placements = num_placements; + create.instances =to_user_pointer (eci); + +igt_assert_eq (igt_ioctl (fd,DRM_IOCTL_XE_ENGINE_CREATE , + &create),0 ); + engines[i] = create.engine_id; + spin[i] = __igt_spin_new(fd, .ahnd = ahnd, .engine = engines[i],.vm = vm[i]);
tests/xe/xe_spin_batch.c new file +42
-1+ } + +for (i =0 ; i < num_placements; i++) { +igt_assert (spin[i]); +igt_spin_free (fd, spin[i]); + } +put_ahnd (ahnd); +} + +igt_main +{ +struct drm_xe_engine_class_instance *hwe; +int fd; +int gt, class; + + igt_fixture { + fd =drm_open_driver (DRIVER_XE ); +xe_device_get (fd); + } + + igt_subtest("spin-basic") +spin_basic (fd); + + igt_subtest("spin-batch") +xe_for_each_hw_engine (fd, hwe) +spin (fd, hwe); + + igt_subtest("spin-basic-all") +xe_for_each_hw_engine (fd, hwe) +spin_basic_all (fd, hwe); + + igt_subtest("spin-all") { +xe_for_each_gt (fd, gt) +xe_for_each_hw_engine_class (class) +spin_all (fd, gt, class); + } + + igt_fixture { +xe_device_put (fd); +close (fd); + } +} --
Quoted 1 line
2.39.1
LGTM,
Re: [igt-dev] [PATCH i-g-t 2/2] tests/xe/xe_spin_batch: Add new test to exercise igt_spin_new for xe
In reply to [email protected]Quoted 4 lines · On Mon, Jun 05, 2023 at 01:28:11AM +0530, [email protected] wrote:
From: Sai Gowtham Ch <[email protected]>
xe_spin_batchtest exercisesigt_spin_newsubmissions with different combination.
On DG2:
Starting subtest: spin-all
(xe_spin_batch:6866) CRITICAL: Test assertion failure function spin_all, file ../tests/xe/xe_spin_batch.c:123:
(xe_spin_batch:6866) CRITICAL: Failed assertion: igt_ioctl(fd, (((2U|1U) << (((0+8)+8)+14)) | ((('d')) << (0+8)) | (((0x40 + 0x06)) << 0) | ((((sizeof(struct drm_xe_engine_create)))) << ((0+8)+8))), &create) == 0 (xe_spin_batch:6866) CRITICAL: Last errno: 22, Invalid argument
(xe_spin_batch:6866) CRITICAL: error: -1 != 0
Stack trace:
#0 ../lib/igt_core.c:1963 __igt_fail_assert()
#1 ../tests/xe/xe_spin_batch.c:168 __igt_unique____real_main136()
#2 ../tests/xe/xe_spin_batch.c:136 main()
#3 ../csu/libc-start.c:332 __libc_start_main()
#4 [_start+0x2e]
Subtest spin-all failed.
**** DEBUG ****
(xe_spin_batch:6866) intel_allocator_reloc-DEBUG: Using reloc allocator
(xe_spin_batch:6866) CRITICAL: Test assertion failure function spin_all, file ../tests/xe/xe_spin_batch.c:123:
(xe_spin_batch:6866) CRITICAL: Failed assertion: igt_ioctl(fd, (((2U|1U) << (((0+8)+8)+14)) | ((('d')) << (0+8)) | (((0x40 + 0x06)) << 0) | ((((sizeof(struct drm_xe_engine_create)))) << ((0+8)+8))), &create) == 0 (xe_spin_batch:6866) CRITICAL: Last errno: 22, Invalid argument
(xe_spin_batch:6866) CRITICAL: error: -1 != 0
(xe_spin_batch:6866) igt_core-INFO: Stack trace:
(xe_spin_batch:6866) igt_core-INFO: #0 ../lib/igt_core.c:1963 __igt_fail_assert() (xe_spin_batch:6866) igt_core-INFO: #1 ../tests/xe/xe_spin_batch.c:168 __igt_unique____real_main136() (xe_spin_batch:6866) igt_core-INFO: #2 ../tests/xe/xe_spin_batch.c:136 main() (xe_spin_batch:6866) igt_core-INFO: #3 ../csu/libc-start.c:332 __libc_start_main() (xe_spin_batch:6866) igt_core-INFO: #4 [_start+0x2e]
**** END ****
Subtest spin-all: FAIL (0.014s)
Please check.
--
Zbigniew
Quoted 198 lines
Cc Zbigniew Kempczyński <[email protected]>Signed-off-by Sai Gowtham Ch <[email protected]>--- tests/meson.build | 1 + tests/xe/xe_spin_batch.c | 168 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 169 insertions(+) create mode 100644 tests/xe/xe_spin_batch.ctests/meson.build +1
-0@@ -268,6 +268,7 @@ xe_progs = [ 'xe_query', 'xe_vm', 'xe_waitfence', + 'xe_spin_batch', ] msm_progs = [tests/xe/xe_spin_batch.c new file +168
-0@@ -0,0 +1,168 @@ +#include "igt.h" +#include "lib/intel_reg.h" +#include "xe_drm.h" +#include "xe/xe_ioctl.h" +#include "xe/xe_query.h" + +#define MAX_INSTANCE 9 + +/** +* TEST: Basic test for spin batch submissons. +* +* SUBTEST: spin-basic +* Description: Basic test to submit spin batch submissons on copy engine. +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin_basic (int fd) +{ +uint64_t ahnd; +igt_spin_t *spin; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + spin = __igt_spin_new(fd, .ahnd = ahnd); +igt_assert (spin); + +igt_spin_free (fd, spin); +put_ahnd (ahnd); +} + +/** +* TEST:Test for spin batch submissons. +* +* SUBTEST: spin-batch +* Description: Create vm and engine of hwe class and run the spinner on it. +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin (int fd,struct drm_xe_engine_class_instance *hwe) +{ +uint64_t ahnd; +unsigned int engine; +uint32_t vm; +igt_spin_t *spin; + + vm =xe_vm_create (fd,0 ,0 ); + engine =xe_engine_create (fd, vm, hwe,0 ); + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + + spin = igt_spin_new(fd, .ahnd = ahnd, .engine = engine, .vm = vm); +igt_assert (spin); + +igt_spin_free (fd, spin); +xe_engine_destroy (fd, engine); +xe_vm_destroy (fd, vm); + +put_ahnd (ahnd); +} + +/** +* TEST: Basic test for spin batch submission on all hwe. +* +* SUBTEST: spin-basic-all +* Description: Basic test which validates the functionality of spinner on all hwe. +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ +static void spin_basic_all (int fd,struct drm_xe_engine_class_instance *hwe) +{ +uint64_t ahnd; +igt_spin_t *spin; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + spin = __igt_spin_new(fd, .ahnd = ahnd, .hwe = hwe); +igt_assert (spin); + +igt_spin_free (fd, spin); +put_ahnd (ahnd); +} + +/** +* TEST: Test for spin batch submissions. +* SUBTEST: spin-all +* Description: Spinner test to run on all the engines! +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin_all (int fd,int gt,int class) +{ +uint64_t ahnd; +uint32_t engines[MAX_INSTANCE ]; +uint32_t vm[MAX_INSTANCE ]; +int i, num_placements =0 ; +struct drm_xe_engine_class_instance eci[MAX_INSTANCE ]; +igt_spin_t *spin[MAX_INSTANCE ]; +struct drm_xe_engine_class_instance *hwe; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + +xe_for_each_hw_engine (fd, hwe) { +if (hwe->engine_class != class || hwe->gt_id != gt) +continue ; + eci[num_placements++] = *hwe; + } +if (num_placements <2 ) +return ; + +for (i =0 ; i < num_placements; i++) { +struct drm_xe_engine_create create; + vm[i] =xe_vm_create (fd,0 ,0 ); + + create.vm_id = vm[i]; + create.width =1 ; + create.num_placements = num_placements; + create.instances =to_user_pointer (eci); + +igt_assert_eq (igt_ioctl (fd,DRM_IOCTL_XE_ENGINE_CREATE , + &create),0 ); + engines[i] = create.engine_id; + spin[i] = __igt_spin_new(fd, .ahnd = ahnd, .engine = engines[i], .vm = vm[i]); + } + +for (i =0 ; i < num_placements; i++) { +igt_assert (spin[i]); +igt_spin_free (fd, spin[i]); + } +put_ahnd (ahnd); +} + +igt_main +{ +struct drm_xe_engine_class_instance *hwe; +int fd; +int gt, class; + + igt_fixture { + fd =drm_open_driver (DRIVER_XE ); +xe_device_get (fd); + } + + igt_subtest("spin-basic") +spin_basic (fd); + + igt_subtest("spin-batch") +xe_for_each_hw_engine (fd, hwe) +spin (fd, hwe); + + igt_subtest("spin-basic-all") +xe_for_each_hw_engine (fd, hwe) +spin_basic_all (fd, hwe); + + igt_subtest("spin-all") { +xe_for_each_gt (fd, gt) +xe_for_each_hw_engine_class (class) +spin_all (fd, gt, class); + } + + igt_fixture { +xe_device_put (fd); +close (fd); + } +}Signature · 1 line
2.39.1
Re: [igt-dev] [PATCH i-g-t 2/2] tests/xe/xe_spin_batch: Add new test to exercise igt_spin_new for xe
Quoted 54 lines
-----Original Message-----
From: Kempczynski, Zbigniew <[email protected]>
Sent: Monday, June 5, 2023 4:15 PM
To: Ch, Sai Gowtham <[email protected]>
Cc: [email protected]; Kumar, Janga Rahul <[email protected]>; [email protected]
Subject: Re: [PATCH i-g-t 2/2] tests/xe/xe_spin_batch: Add new test to exerciseigt_spin_newfor xeQuoted 4 lines · On Mon, Jun 05, 2023 at 01:28:11AM +0530, [email protected] wrote:
From: Sai Gowtham Ch <[email protected]>
xe_spin_batchtest exercisesigt_spin_newsubmissions with different combination.On DG2:
Starting subtest: spin-all
(xe_spin_batch:6866) CRITICAL: Test assertion failure functionspin_all, file../tests/xe/xe_spin_batch.c:123:
(xe_spin_batch:6866) CRITICAL: Failed assertion: igt_ioctl(fd, (((2U|1U) << (((0+8)+8)+14)) | ((('d')) << (0+8)) | (((0x40+0x06)) << 0) | ((((sizeof(struct drm_xe_engine_create)))) << ((0+8)+8))), &create) == 0 (xe_spin_batch:6866) CRITICAL: Last errno: 22, Invalid argument (xe_spin_batch:6866) CRITICAL: error: -1 != 0 Stack trace:
#0../lib/igt_core.c:1963__igt_fail_assert()
#1../tests/xe/xe_spin_batch.c:168__igt_unique____real_main136()#2../tests/xe/xe_spin_batch.c:136main()
#3../csu/libc-start.c:332__libc_start_main()
#4 [_start+0x2e]
Subtest spin-all failed.
**** DEBUG ****
(xe_spin_batch:6866) intel_allocator_reloc-DEBUG: Using reloc allocator (xe_spin_batch:6866) CRITICAL: Test assertion failure functionspin_all, file../tests/xe/xe_spin_batch.c:123:
(xe_spin_batch:6866) CRITICAL: Failed assertion: igt_ioctl(fd, (((2U|1U) << (((0+8)+8)+14)) | ((('d')) << (0+8)) | (((0x40+0x06)) << 0) | ((((sizeof(struct drm_xe_engine_create)))) << ((0+8)+8))), &create) == 0 (xe_spin_batch:6866) CRITICAL: Last errno: 22, Invalid argument (xe_spin_batch:6866) CRITICAL: error: -1 != 0
(xe_spin_batch:6866) igt_core-INFO: Stack trace:
(xe_spin_batch:6866) igt_core-INFO: #0../lib/igt_core.c:1963__igt_fail_assert()
(xe_spin_batch:6866) igt_core-INFO: #1../tests/xe/xe_spin_batch.c:168__igt_unique____real_main136()
(xe_spin_batch:6866) igt_core-INFO: #2../tests/xe/xe_spin_batch.c:136main()
(xe_spin_batch:6866) igt_core-INFO: #3../csu/libc-start.c:332__libc_start_main()
(xe_spin_batch:6866) igt_core-INFO: #4 [_start+0x2e]
**** END ****
Subtest spin-all: FAIL (0.014s)
Quoted 2 lines
Please check.
Strange, Working fine for me.
gta@DUT051DG2FRD:~/Gowtham/0106/igt-gpu-tools$ sudo ./build/tests/xe_spin_batch IGT-Version: 1.27.1-g41db4db7 (x86_64) (Linux: 6.3.0-xe-15052023+ x86_64) Opened device: /dev/dri/card0 Starting subtest: spin-basic Subtest spin-basic: SUCCESS (0.008s) Starting subtest: spin-batch Subtest spin-batch: SUCCESS (0.061s) Starting subtest: spin-basic-all Subtest spin-basic-all: SUCCESS (0.075s) Starting subtest: spin-all Subtest spin-all: SUCCESS (0.028s)
---
Gowtham
Quoted 202 lines
--
ZbigniewQuoted 83 lines
Cc Zbigniew Kempczyński <[email protected]>Signed-off-by Sai Gowtham Ch <[email protected]>--- tests/meson.build | 1 + tests/xe/xe_spin_batch.c | 168 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 169 insertions(+) create mode 100644 tests/xe/xe_spin_batch.ctests/meson.build index renamed from tests/meson.build +0
-0
f71be1db..e794b75a100644tests/meson.build +1
-0@@ -268,6 +268,7 @@ xe_progs = [ 'xe_query', 'xe_vm', 'xe_waitfence', + 'xe_spin_batch', ] msm_progs = [tests/xe/xe_spin_batch.c new renamed from tests/xe/xe_spin_batch.c +0
-0file mode 100644 index 00000000..ac531110
tests/xe/xe_spin_batch.c new file +56
-0@@ -0,0 +1,168 @@ +#include "igt.h" +#include "lib/intel_reg.h" +#include "xe_drm.h" +#include "xe/xe_ioctl.h" +#include "xe/xe_query.h" + +#define MAX_INSTANCE 9 + +/** +* TEST: Basic test for spin batch submissons. +* +* SUBTEST: spin-basic +* Description: Basic test to submit spin batch submissons on copy engine. +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin_basic (int fd) +{ +uint64_t ahnd; +igt_spin_t *spin; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + spin = __igt_spin_new(fd, .ahnd = ahnd); +igt_assert (spin); + +igt_spin_free (fd, spin); +put_ahnd (ahnd); +} + +/** +* TEST:Test for spin batch submissons. +* +* SUBTEST: spin-batch +* Description: Create vm and engine of hwe class and run the spinner on it. +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin (int fd,struct drm_xe_engine_class_instance *hwe) { +uint64_t ahnd; +unsigned int engine; +uint32_t vm; +igt_spin_t *spin; + + vm =xe_vm_create (fd,0 ,0 ); + engine =xe_engine_create (fd, vm, hwe,0 ); + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + + spin = igt_spin_new(fd, .ahnd = ahnd, .engine = engine, .vm = vm); +igt_assert (spin); + +igt_spin_free (fd, spin); +xe_engine_destroy (fd, engine);tests/xe/xe_spin_batch.c line 66
Quoted 10 lines
tests/xe/xe_spin_batch.c new file +10
-0+xe_vm_destroy (fd, vm); + +put_ahnd (ahnd); +} + +/** +* TEST: Basic test for spin batch submission on all hwe. +* +* SUBTEST: spin-basic-all +* Description: Basic test which validates the functionality of spinner on all hwe.
Quoted 48 lines
tests/xe/xe_spin_batch.c new file +48
-0+* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ +static void spin_basic_all (int fd,struct +drm_xe_engine_class_instance *hwe) { +uint64_t ahnd; +igt_spin_t *spin; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + spin = __igt_spin_new(fd, .ahnd = ahnd, .hwe = hwe); +igt_assert (spin); + +igt_spin_free (fd, spin); +put_ahnd (ahnd); +} + +/** +* TEST: Test for spin batch submissions. +* SUBTEST: spin-all +* Description: Spinner test to run on all the engines! +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin_all (int fd,int gt,int class) { +uint64_t ahnd; +uint32_t engines[MAX_INSTANCE ]; +uint32_t vm[MAX_INSTANCE ]; +int i, num_placements =0 ; +struct drm_xe_engine_class_instance eci[MAX_INSTANCE ]; +igt_spin_t *spin[MAX_INSTANCE ]; +struct drm_xe_engine_class_instance *hwe; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + +xe_for_each_hw_engine (fd, hwe) { +if (hwe->engine_class != class || hwe->gt_id != gt) +continue ; + eci[num_placements++] = *hwe; + } +if (num_placements <2 ) +return ; + +for (i =0 ; i < num_placements; i++) { +struct drm_xe_engine_create create; + vm[i] =xe_vm_create (fd,0 ,0 );tests/xe/xe_spin_batch.c
Quoted 10 lines
tests/xe/xe_spin_batch.c new file +10
-0+ + create.vm_id = vm[i]; + create.width =1 ; + create.num_placements = num_placements; + create.instances =to_user_pointer (eci); + +igt_assert_eq (igt_ioctl (fd,DRM_IOCTL_XE_ENGINE_CREATE , + &create),0 ); + engines[i] = create.engine_id; + spin[i] = __igt_spin_new(fd, .ahnd = ahnd, .engine = engines[i],.vm = vm[i]);
Quoted 45 lines
tests/xe/xe_spin_batch.c new file +42
-1+ } + +for (i =0 ; i < num_placements; i++) { +igt_assert (spin[i]); +igt_spin_free (fd, spin[i]); + } +put_ahnd (ahnd); +} + +igt_main +{ +struct drm_xe_engine_class_instance *hwe; +int fd; +int gt, class; + + igt_fixture { + fd =drm_open_driver (DRIVER_XE ); +xe_device_get (fd); + } + + igt_subtest("spin-basic") +spin_basic (fd); + + igt_subtest("spin-batch") +xe_for_each_hw_engine (fd, hwe) +spin (fd, hwe); + + igt_subtest("spin-basic-all") +xe_for_each_hw_engine (fd, hwe) +spin_basic_all (fd, hwe); + + igt_subtest("spin-all") { +xe_for_each_gt (fd, gt) +xe_for_each_hw_engine_class (class) +spin_all (fd, gt, class); + } + + igt_fixture { +xe_device_put (fd); +close (fd); + } +} --2.39.1
Re: [igt-dev] [PATCH i-g-t 2/2] tests/xe/xe_spin_batch: Add new test to exercise igt_spin_new for xe
Quoted 59 lines · Sai Gowtham
Quoted 54 lines
-----Original Message-----
From: Kempczynski, Zbigniew <[email protected]>
Sent: Monday, June 5, 2023 4:15 PM
To: Ch, Sai Gowtham <[email protected]>
Cc: [email protected]; Kumar, Janga Rahul <[email protected]>; [email protected]
Subject: Re: [PATCH i-g-t 2/2] tests/xe/xe_spin_batch: Add new test to exerciseigt_spin_newfor xeQuoted 4 lines · On Mon, Jun 05, 2023 at 01:28:11AM +0530, [email protected] wrote:
From: Sai Gowtham Ch <[email protected]>
xe_spin_batchtest exercisesigt_spin_newsubmissions with different combination.On DG2:
Starting subtest: spin-all
(xe_spin_batch:6866) CRITICAL: Test assertion failure functionspin_all, file../tests/xe/xe_spin_batch.c:123:
(xe_spin_batch:6866) CRITICAL: Failed assertion: igt_ioctl(fd, (((2U|1U) << (((0+8)+8)+14)) | ((('d')) << (0+8)) | (((0x40+0x06)) << 0) | ((((sizeof(struct drm_xe_engine_create)))) << ((0+8)+8))), &create) == 0 (xe_spin_batch:6866) CRITICAL: Last errno: 22, Invalid argument (xe_spin_batch:6866) CRITICAL: error: -1 != 0 Stack trace:
#0../lib/igt_core.c:1963__igt_fail_assert()
#1../tests/xe/xe_spin_batch.c:168__igt_unique____real_main136()#2../tests/xe/xe_spin_batch.c:136main()
#3../csu/libc-start.c:332__libc_start_main()
#4 [_start+0x2e]
Subtest spin-all failed.
**** DEBUG ****
(xe_spin_batch:6866) intel_allocator_reloc-DEBUG: Using reloc allocator (xe_spin_batch:6866) CRITICAL: Test assertion failure functionspin_all, file../tests/xe/xe_spin_batch.c:123:
(xe_spin_batch:6866) CRITICAL: Failed assertion: igt_ioctl(fd, (((2U|1U) << (((0+8)+8)+14)) | ((('d')) << (0+8)) | (((0x40+0x06)) << 0) | ((((sizeof(struct drm_xe_engine_create)))) << ((0+8)+8))), &create) == 0 (xe_spin_batch:6866) CRITICAL: Last errno: 22, Invalid argument (xe_spin_batch:6866) CRITICAL: error: -1 != 0
(xe_spin_batch:6866) igt_core-INFO: Stack trace:
(xe_spin_batch:6866) igt_core-INFO: #0../lib/igt_core.c:1963__igt_fail_assert()
(xe_spin_batch:6866) igt_core-INFO: #1../tests/xe/xe_spin_batch.c:168__igt_unique____real_main136()
(xe_spin_batch:6866) igt_core-INFO: #2../tests/xe/xe_spin_batch.c:136main()
(xe_spin_batch:6866) igt_core-INFO: #3../csu/libc-start.c:332__libc_start_main()
(xe_spin_batch:6866) igt_core-INFO: #4 [_start+0x2e]
**** END ****
Subtest spin-all: FAIL (0.014s)Quoted 2 lines
Please check.
Strange, Working fine for me.
Quoted 12 lines
gta@DUT051DG2FRD:~/Gowtham/0106/igt-gpu-tools$ sudo ./build/tests/xe_spin_batch IGT-Version: 1.27.1-g41db4db7 (x86_64) (Linux: 6.3.0-xe-15052023+ x86_64) Opened device: /dev/dri/card0 Starting subtest: spin-basic Subtest spin-basic: SUCCESS (0.008s) Starting subtest: spin-batch Subtest spin-batch: SUCCESS (0.061s) Starting subtest: spin-basic-all Subtest spin-basic-all: SUCCESS (0.075s) Starting subtest: spin-all Subtest spin-all: SUCCESS (0.028s)
May you run tools/lsgpu?
--
Zbigniew
Quoted 205 lines
---
GowthamQuoted 202 lines
--
ZbigniewQuoted 83 lines
Cc Zbigniew Kempczyński <[email protected]>Signed-off-by Sai Gowtham Ch <[email protected]>--- tests/meson.build | 1 + tests/xe/xe_spin_batch.c | 168 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 169 insertions(+) create mode 100644 tests/xe/xe_spin_batch.ctests/meson.build index renamed from tests/meson.build +0
-0
f71be1db..e794b75a100644tests/meson.build +1
-0@@ -268,6 +268,7 @@ xe_progs = [ 'xe_query', 'xe_vm', 'xe_waitfence', + 'xe_spin_batch', ] msm_progs = [tests/xe/xe_spin_batch.c new renamed from tests/xe/xe_spin_batch.c +0
-0file mode 100644 index 00000000..ac531110
tests/xe/xe_spin_batch.c new file +56
-0@@ -0,0 +1,168 @@ +#include "igt.h" +#include "lib/intel_reg.h" +#include "xe_drm.h" +#include "xe/xe_ioctl.h" +#include "xe/xe_query.h" + +#define MAX_INSTANCE 9 + +/** +* TEST: Basic test for spin batch submissons. +* +* SUBTEST: spin-basic +* Description: Basic test to submit spin batch submissons on copy engine. +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin_basic (int fd) +{ +uint64_t ahnd; +igt_spin_t *spin; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + spin = __igt_spin_new(fd, .ahnd = ahnd); +igt_assert (spin); + +igt_spin_free (fd, spin); +put_ahnd (ahnd); +} + +/** +* TEST:Test for spin batch submissons. +* +* SUBTEST: spin-batch +* Description: Create vm and engine of hwe class and run the spinner on it. +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin (int fd,struct drm_xe_engine_class_instance *hwe) { +uint64_t ahnd; +unsigned int engine; +uint32_t vm; +igt_spin_t *spin; + + vm =xe_vm_create (fd,0 ,0 ); + engine =xe_engine_create (fd, vm, hwe,0 ); + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + + spin = igt_spin_new(fd, .ahnd = ahnd, .engine = engine, .vm = vm); +igt_assert (spin); + +igt_spin_free (fd, spin); +xe_engine_destroy (fd, engine);tests/xe/xe_spin_batch.c line 66
Quoted 10 lines
tests/xe/xe_spin_batch.c new file +10
-0+xe_vm_destroy (fd, vm); + +put_ahnd (ahnd); +} + +/** +* TEST: Basic test for spin batch submission on all hwe. +* +* SUBTEST: spin-basic-all +* Description: Basic test which validates the functionality of spinner on all hwe.
Quoted 48 lines
tests/xe/xe_spin_batch.c new file +48
-0+* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ +static void spin_basic_all (int fd,struct +drm_xe_engine_class_instance *hwe) { +uint64_t ahnd; +igt_spin_t *spin; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + spin = __igt_spin_new(fd, .ahnd = ahnd, .hwe = hwe); +igt_assert (spin); + +igt_spin_free (fd, spin); +put_ahnd (ahnd); +} + +/** +* TEST: Test for spin batch submissions. +* SUBTEST: spin-all +* Description: Spinner test to run on all the engines! +* Run type: FULL +* TODO: change ``'Run type' == FULL`` to a better category +* +*/ + +static void spin_all (int fd,int gt,int class) { +uint64_t ahnd; +uint32_t engines[MAX_INSTANCE ]; +uint32_t vm[MAX_INSTANCE ]; +int i, num_placements =0 ; +struct drm_xe_engine_class_instance eci[MAX_INSTANCE ]; +igt_spin_t *spin[MAX_INSTANCE ]; +struct drm_xe_engine_class_instance *hwe; + + ahnd =intel_allocator_open (fd,0 ,INTEL_ALLOCATOR_RELOC ); + +xe_for_each_hw_engine (fd, hwe) { +if (hwe->engine_class != class || hwe->gt_id != gt) +continue ; + eci[num_placements++] = *hwe; + } +if (num_placements <2 ) +return ; + +for (i =0 ; i < num_placements; i++) { +struct drm_xe_engine_create create; + vm[i] =xe_vm_create (fd,0 ,0 );tests/xe/xe_spin_batch.c
Quoted 10 lines
tests/xe/xe_spin_batch.c new file +10
-0+ + create.vm_id = vm[i]; + create.width =1 ; + create.num_placements = num_placements; + create.instances =to_user_pointer (eci); + +igt_assert_eq (igt_ioctl (fd,DRM_IOCTL_XE_ENGINE_CREATE , + &create),0 ); + engines[i] = create.engine_id; + spin[i] = __igt_spin_new(fd, .ahnd = ahnd, .engine = engines[i],.vm = vm[i]);
Quoted 45 lines
tests/xe/xe_spin_batch.c new file +42
-1+ } + +for (i =0 ; i < num_placements; i++) { +igt_assert (spin[i]); +igt_spin_free (fd, spin[i]); + } +put_ahnd (ahnd); +} + +igt_main +{ +struct drm_xe_engine_class_instance *hwe; +int fd; +int gt, class; + + igt_fixture { + fd =drm_open_driver (DRIVER_XE ); +xe_device_get (fd); + } + + igt_subtest("spin-basic") +spin_basic (fd); + + igt_subtest("spin-batch") +xe_for_each_hw_engine (fd, hwe) +spin (fd, hwe); + + igt_subtest("spin-basic-all") +xe_for_each_hw_engine (fd, hwe) +spin_basic_all (fd, hwe); + + igt_subtest("spin-all") { +xe_for_each_gt (fd, gt) +xe_for_each_hw_engine_class (class) +spin_all (fd, gt, class); + } + + igt_fixture { +xe_device_put (fd); +close (fd); + } +} --2.39.1
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for Integrate igt_spin_new with Xe (rev2)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: Integrate igt_spin_new with Xe (rev2)
URL : https://patchwork.freedesktop.org/series/118837/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13226 -> IGTPW_9101
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/index.html
Participating hosts (37 -> 35)
------------------------------
Additional (1): fi-kbl-soraka
Missing (3): bat-rpls-2 fi-snb-2520m fi-kbl-8809g
Known issues
------------
Here are the changes found in IGTPW_9101 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/fi-kbl-soraka/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/fi-kbl-soraka/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- fi-glk-j4005: [PASS][3] -> [DMESG-FAIL][4] ([i915#5334])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/fi-glk-j4005/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][5] ([i915#1886] / [i915#7913])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][6] -> [ABORT][7] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/bat-rpls-1/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/bat-rpls-1/igt@i915_selftest@[email protected]
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271]) +14 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/fi-kbl-soraka/igt@[email protected]
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-skl-6600u: NOTRUN -> [SKIP][9] ([fdo#109271])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/fi-skl-6600u/igt@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4579])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/fi-kbl-soraka/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- fi-skl-6600u: [ABORT][11] -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/fi-skl-6600u/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/fi-skl-6600u/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7953]: https://gitlab.freedesktop.org/drm/intel/issues/7953
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7318 -> IGTPW_9101
CI-20190529: 20190529
CI_DRM_13226: 29c0f369e17ba0abf08c65ca065417aebab208c6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9101: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/index.html
IGT_7318: c2d8ef8b9397d0976959f29dc1dd7c8a698d65fe @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/index.html
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for Integrate igt_spin_new with Xe (rev2)
In reply to [email protected]== Series Details ==
== Series Details ==
Series: Integrate igt_spin_new with Xe (rev2)
URL : https://patchwork.freedesktop.org/series/118837/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13226_full -> IGTPW_9101_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_9101_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_selftest@live@gem_contexts:
- {shard-dg1}: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-dg1-16/igt@i915_selftest@live@gem_contexts.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-dg1-13/igt@i915_selftest@live@gem_contexts.html
Known issues
------------
Here are the changes found in IGTPW_9101_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2842])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-glk8/igt@gem_exec_fair@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-glk8/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@verify-random:
- shard-apl: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-apl2/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-apl: NOTRUN -> [WARN][6] ([i915#2658])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-apl4/igt@[email protected]
* igt@i915_pipe_stress@stress-xrgb8888-ytiled:
- shard-apl: NOTRUN -> [FAIL][7] ([i915#7036])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-apl4/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][8] -> [SKIP][9] ([fdo#109271])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-apl6/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-apl3/igt@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-vga:
- shard-snb: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4579]) +10 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-snb7/igt@i915_pm_lpsp@[email protected]
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][11] -> [ABORT][12] ([i915#180]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-apl6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-apl2/igt@[email protected]
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#3886]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-apl3/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271]) +52 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-apl3/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_cursor_crc@cursor-sliding-32x32:
- shard-apl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#4579]) +6 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-apl2/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#79])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-glk6/igt@kms_flip@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-glk9/igt@kms_flip@[email protected]
* igt@kms_flip@2x-plain-flip:
- shard-snb: NOTRUN -> [SKIP][18] ([fdo#109271]) +24 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-snb5/igt@[email protected]
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-apl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#658])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-apl6/igt@[email protected]
#### Possible fixes ####
* igt@api_intel_allocator@default-alignment:
- {shard-dg1}: [DMESG-WARN][20] ([i915#4423]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-dg1-16/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-dg1-14/igt@[email protected]
* igt@gem_eio@kms:
- {shard-tglu}: [INCOMPLETE][22] -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-tglu-2/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-tglu-9/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- {shard-tglu}: [FAIL][24] ([i915#2842]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-tglu-8/igt@gem_exec_fair@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-tglu-2/igt@gem_exec_fair@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-rkl}: [SKIP][26] ([i915#1937] / [i915#4579]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-rkl-3/igt@i915_pm_lpsp@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-rkl-7/igt@i915_pm_lpsp@[email protected]
* igt@i915_pm_rpm@dpms-lpsp:
- {shard-rkl}: [SKIP][28] ([i915#1397]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-rkl-6/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-rkl-7/igt@[email protected]
* igt@i915_pm_rps@reset:
- shard-snb: [DMESG-FAIL][30] ([i915#8319]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-snb1/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-snb7/igt@[email protected]
* igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1:
- shard-apl: [ABORT][32] ([i915#180]) -> [PASS][33] +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-apl6/igt@kms_cursor_crc@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-apl2/igt@kms_cursor_crc@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][34] ([i915#2346]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-glk4/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-glk2/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [FAIL][36] ([i915#2346]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_hdmi_inject@inject-audio:
- shard-snb: [FAIL][38] ([IGT#3]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-snb1/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-snb1/igt@[email protected]
#### Warnings ####
* igt@kms_content_protection@mei_interface:
- shard-apl: [SKIP][40] ([fdo#109271]) -> [SKIP][41] ([fdo#109271] / [i915#4579])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-apl1/igt@kms_content_protection@mei_interface.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-apl4/igt@kms_content_protection@mei_interface.html
- shard-snb: [SKIP][42] ([fdo#109271]) -> [SKIP][43] ([fdo#109271] / [i915#4579])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-snb1/igt@kms_content_protection@mei_interface.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-snb7/igt@kms_content_protection@mei_interface.html
- shard-glk: [SKIP][44] ([fdo#109271]) -> [SKIP][45] ([fdo#109271] / [i915#4579])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13226/shard-glk4/igt@kms_content_protection@mei_interface.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/shard-glk5/igt@kms_content_protection@mei_interface.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4521]: https://gitlab.freedesktop.org/drm/intel/issues/4521
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5251]: https://gitlab.freedesktop.org/drm/intel/issues/5251
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7036]: https://gitlab.freedesktop.org/drm/intel/issues/7036
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8319]: https://gitlab.freedesktop.org/drm/intel/issues/8319
[i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7318 -> IGTPW_9101
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13226: 29c0f369e17ba0abf08c65ca065417aebab208c6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9101: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/index.html
IGT_7318: c2d8ef8b9397d0976959f29dc1dd7c8a698d65fe @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9101/index.html