Skip to contentSkip to conversation

net: r8169: fix builds on archs without system.h header

PATCH Applied Denis Orlov 2 participants 2 messages Jun 4, 2023 – Jun 5, 2023 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: r8169: fix builds on archs without system.h header

Some architectures do lack <asm/system.h> header, which breaks building RTL8169 for them. However, it doesn't even seem to be needed there. From a quick glance at archs that do have one such header, its contents are quite platform-specific. Getting rid of this include fixes building the driver, so do just that.

---
 drivers/net/r8169_main.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/r8169_main.c +0 -1
index 5b448fa029..2225c26190 100644
@@ -17,7 +17,6 @@
 #include <linux/pci.h>
 #include <linux/sizes.h>
 #include <asm/unaligned.h>
-#include <asm/system.h>
 
 #include "r8169.h"
 #include "r8169_firmware.h"
Signature · 1 line
2.41.0
Applied
#1 lore raw
Quoted 10 lines · Denis Orlov

Some architectures do lack <asm/system.h> header, which breaks building RTL8169 for them. However, it doesn't even seem to be needed there. From a quick glance at archs that do have one such header, its contents are quite platform-specific. Getting rid of this include fixes building the driver, so do just that.

---
 drivers/net/r8169_main.c | 1 -
 1 file changed, 1 deletion(-)

Applied, thanks

Sascha

Quoted 17 lines
drivers/net/r8169_main.c +0 -1
index 5b448fa029..2225c26190 100644
@@ -17,7 +17,6 @@
 #include <linux/pci.h>
 #include <linux/sizes.h>
 #include <asm/unaligned.h>
-#include <asm/system.h>
 
 #include "r8169.h"
 #include "r8169_firmware.h"
Signature · 1 line
2.41.0
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |