Skip to contentSkip to conversation

drm/amd: Drop messages in init for radeon, amdgpu

PATCH In review Alex Deucher 2 participants 2 messages Jun 5, 2023

Subsystems (2)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amd: Drop messages in init for radeon, amdgpu

Since there is overlap in supported devices, both modules load, but only one will bind to a particular device depending on the user's configuration. Drop the message in the module init function as this can be confusing to users.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
 drivers/gpu/drm/radeon/radeon_drv.c     | 1 -
 2 files changed, 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0 -1
index 7eda4f039224..94509b76fa6c 100644
@@ -3065,7 +3065,6 @@ static int __init amdgpu_init(void)
 	if (r)
 		goto error_fence;
 
-	DRM_INFO("amdgpu kernel modesetting enabled.\n");
 	amdgpu_register_atpx_handler();
 	amdgpu_acpi_detect();
 
drivers/gpu/drm/radeon/radeon_drv.c +0 -1
index e4374814f0ef..16b9eab90185 100644
@@ -634,7 +634,6 @@ static int __init radeon_module_init(void)
 	if (radeon_modeset == 0)
 		return -EINVAL;
 
-	DRM_INFO("radeon kernel modesetting enabled.\n");
 	radeon_register_atpx_handler();
 
 	return pci_register_driver(&radeon_kms_pci_driver);
Signature · 1 line
2.40.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Alex Deucher

Since there is overlap in supported devices, both modules load, but only one will bind to a particular device depending on the user's configuration. Drop the message in the module init function as this can be confusing to users.

Quoted 29 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 -
  drivers/gpu/drm/radeon/radeon_drv.c     | 1 -
  2 files changed, 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0 -1
index 7eda4f039224..94509b76fa6c 100644
@@ -3065,7 +3065,6 @@ static int __init amdgpu_init(void)
  	if (r)
  		goto error_fence;
 
-	DRM_INFO("amdgpu kernel modesetting enabled.\n");
  	amdgpu_register_atpx_handler();
  	amdgpu_acpi_detect();
 
drivers/gpu/drm/radeon/radeon_drv.c +0 -1
index e4374814f0ef..16b9eab90185 100644
@@ -634,7 +634,6 @@ static int __init radeon_module_init(void)
  	if (radeon_modeset == 0)
  		return -EINVAL;
 
-	DRM_INFO("radeon kernel modesetting enabled.\n");
  	radeon_register_atpx_handler();
 
  	return pci_register_driver(&radeon_kms_pci_driver);