Skip to contentSkip to conversation

usb: musb-new: sunxi: fix error check

PATCH RESEND Applied Sam Edwards 2 participants 2 messages Jun 5, 2023 – Jun 7, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 usb: musb-new: sunxi: fix error check

The musb_register function returns some ERR_PTR(...) on failure, not NULL, so update the check here appropriately.

---
 drivers/usb/musb-new/sunxi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/musb-new/sunxi.c +1 -1
index 6e60dd47e0..65a528e229 100644
@@ -488,7 +488,7 @@ static int musb_usb_probe(struct udevice *dev)
 #else
 	pdata.mode = MUSB_PERIPHERAL;
 	host->host = musb_register(&pdata, &glue->dev, base);
-	if (!host->host)
+	if (IS_ERR_OR_NULL(host->host))
 		return -EIO;
 
 	printf("Allwinner mUSB OTG (Peripheral)\n");
Signature · 1 line
2.39.2
Applied
#1 lore raw
Quoted 2 lines · Sam Edwards

The musb_register function returns some ERR_PTR(...) on failure, not NULL, so update the check here appropriately.

Applied to usb/master, thanks .