Skip to contentSkip to conversation

ARM: dts: BCM5301X: Drop invalid #usb-cells

PATCH Applied Rafał Miłecki 2 participants 4 messages Jun 2, 2023 – Jun 5, 2023 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: dts: BCM5301X: Drop invalid #usb-cells

From: Rafał Miłecki <[email protected]>

Such property simply doesn't exist (is not documented or used anywhere).

This fixes:
arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dtb: usb@21000: Unevaluated properties are not allowed ('#usb-cells' was unexpected)
From schema: Documentation/devicetree/bindings/usb/generic-ehci.yaml
arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dtb: usb@22000: Unevaluated properties are not allowed ('#usb-cells' was unexpected)
From schema: Documentation/devicetree/bindings/usb/generic-ohci.yaml
arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dtb: usb@23000: Unevaluated properties are not allowed ('#usb-cells' was unexpected)
From schema: Documentation/devicetree/bindings/usb/generic-xhci.yaml

---
 arch/arm/boot/dts/bcm-ns.dtsi | 6 ------
 1 file changed, 6 deletions(-)
arch/arm/boot/dts/bcm-ns.dtsi +0 -6
index 3f8220a7a54d..793891f1f260 100644
@@ -192,8 +192,6 @@ usb2: usb2@21000 {
 			interrupt-parent = <&gic>;
 
 			ehci: usb@21000 {
-				#usb-cells = <0>;
-
 				compatible = "generic-ehci";
 				reg = <0x00021000 0x1000>;
 				interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
@@ -214,8 +212,6 @@ ehci_port2: port@2 {
 			};
 
 			ohci: usb@22000 {
-				#usb-cells = <0>;
-
 				compatible = "generic-ohci";
 				reg = <0x00022000 0x1000>;
 				interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
@@ -245,8 +241,6 @@ usb3: usb3@23000 {
 			interrupt-parent = <&gic>;
 
 			xhci: usb@23000 {
-				#usb-cells = <0>;
-
 				compatible = "generic-xhci";
 				reg = <0x00023000 0x1000>;
 				interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.35.3
#1 lore raw

PATCH 2/2 ARM: dts: BCM5301X: Drop invalid properties from Meraki MR32 keys

From: Rafał Miłecki <[email protected]>

This fixes:
arch/arm/boot/dts/bcm53015-meraki-mr26.dtb: keys: '#address-cells', '#size-cells' do not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/input/gpio-keys.yaml

---
 arch/arm/boot/dts/bcm53015-meraki-mr26.dts | 2 --
 1 file changed, 2 deletions(-)
arch/arm/boot/dts/bcm53015-meraki-mr26.dts +0 -2
index 14f58033efeb..071f2cb97251 100644
@@ -39,8 +39,6 @@ led-1 {
 
 	keys {
 		compatible = "gpio-keys";
-		#address-cells = <1>;
-		#size-cells = <0>;
 
 		key-restart {
 			label = "Reset";
Signature · 1 line
2.35.3
#2 lore raw

Re: [PATCH 2/2] ARM: dts: BCM5301X: Drop invalid properties from Meraki MR32 keys

From: Florian Fainelli <[email protected]>

Quoted 8 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

This fixes:
arch/arm/boot/dts/bcm53015-meraki-mr26.dtb: keys: '#address-cells', '#size-cells' do not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/input/gpio-keys.yaml

---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! --
Florian

#3 lore raw
In reply to Rafał Miłecki

From: Florian Fainelli <[email protected]>

Quoted 12 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

Such property simply doesn't exist (is not documented or used anywhere).

This fixes:
arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dtb: usb@21000: Unevaluated properties are not allowed ('#usb-cells' was unexpected)
From schema: Documentation/devicetree/bindings/usb/generic-ehci.yaml
arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dtb: usb@22000: Unevaluated properties are not allowed ('#usb-cells' was unexpected)
From schema: Documentation/devicetree/bindings/usb/generic-ohci.yaml
arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dtb: usb@23000: Unevaluated properties are not allowed ('#usb-cells' was unexpected)
From schema: Documentation/devicetree/bindings/usb/generic-xhci.yaml

Quoted 2 lines

---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! --
Florian