Skip to contentSkip to conversation

netfilter: ipset: remove rcu_read_lock_bh pair from ip_set_test

PATCH New Florian Westphal 1 participant 1 message Jun 6, 2023

Subsystems (2)
lore
Share & tools
lore

Florian Westphal

author maintainer
#0 lore raw

PATCH 1/1 netfilter: ipset: remove rcu_read_lock_bh pair from ip_set_test

Callers already hold rcu_read_lock.

Prior to RCU conversion this used to be a read_lock_bh(), but now the bh-disable isn't needed anymore.

---
 net/netfilter/ipset/ip_set_core.c | 2 --
 1 file changed, 2 deletions(-)
net/netfilter/ipset/ip_set_core.c +0 -2
index 46ebee9400da..a77c75f6dfb9 100644
@@ -739,9 +739,7 @@ ip_set_test(ip_set_id_t index, const struct sk_buff *skb,
 	    !(opt->family == set->family || set->family == NFPROTO_UNSPEC))
 		return 0;
 
-	rcu_read_lock_bh();
 	ret = set->variant->kadt(set, skb, par, IPSET_TEST, opt);
-	rcu_read_unlock_bh();
 
 	if (ret == -EAGAIN) {
 		/* Type requests element to be completed */
Signature · 1 line
2.39.2