drm/panel: add fannal c3004 panel
Subsystems (4)
v3 cover drm/panel: add fannal c3004 panel
Fannal C3004 is a 2 lane MIPI DSI 480x800 panel which requires initialization with DSI DCS commands. After few initialization commands delay is required.
Paulo Pavacic (3):
dt-bindings: add fannal vendor prefix
dt-bindings: display: panel: add fannal,c3004 drm/panel-fannal-c3004: Add fannal c3004 DSI panel
.../bindings/display/panel/fannal,c3004.yaml | 78 +++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-fannal-c3004.c | 318 ++++++++++++++++++ 6 files changed, 417 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml create mode 100644 drivers/gpu/drm/panel/panel-fannal-c3004.c
Signature · 1 line
2.40.1
PATCH v3 1/3 dt-bindings: add fannal vendor prefix
Fannal is a one-stop-solution provider for touch displays in industrial application, committed to delivering a variety of professional high-quality products and technical services globally.
Website: www.fannal.com
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -462,6 +462,8 @@ patternProperties: description: Facebook "^fairphone,.*": description: Fairphone B.V. + "^fannal,.*": + description: Fannal Electronics Co., Ltd "^faraday,.*": description: Faraday Technology Corporation "^fastrax,.*":
Signature · 1 line
2.40.1
Re: [PATCH v3 1/3] dt-bindings: add fannal vendor prefix
Quoted 9 lines · Paulo Pavacic
Fannal is a one-stop-solution provider for touch displays in industrial application, committed to delivering a variety of professional high-quality products and technical services globally.
Website: www.fannal.com
Signed-off-by Paulo Pavacic <[email protected]>--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
This is a friendly reminder during the review process.
It looks like you received a tag and forgot to add it.
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
If a tag was not added on purpose, please state why and what changed.
Best regards,
Krzysztof
PATCH v3 2/3 dt-bindings: display: panel: add fannal,c3004
In reply to Paulo PavacicAdded fannal to vendor-prefixes and dt bindings for Fannal C3004. Fannal C3004 is a 480x800 MIPI DSI Panel which requires DCS initialization sequences with certain delays between certain commands.
---
v4 changelog:
- add spaces between properties
v3 changelog:
- renamed yml file
- refactored yml file to describe fannal,c3004
- added matrix URI to MAINTAINERS
v2 changelog:
- revised driver title, now describes purpose
- revised description, now describes hw
- revised maintainers, now has only 1 mail
- removed diacritics from commit/commit author
- properties/compatible is now enum
- compatible using only lowercase
- revised dts example
- modified MAINTAINERS in this commit (instead of driver commit)
- dt_bindings_check checked yml
- checkpatch warning fixed
--- .../bindings/display/panel/fannal,c3004.yaml | 78 +++++++++++++++++++ MAINTAINERS | 6 ++ 2 files changed, 84 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml
Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml new file +78 -0
@@ -0,0 +1,78 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/fannal,c3004.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Fannal C3004 MIPI-DSI + +maintainers: + - Paulo Pavacic <[email protected]> + +description: | + Fannal C3004 is a 480x800 panel which requires DSI DCS + initialization sequences. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + items: + - const: fannal,c3004 + + reg: true + + reset-gpios: true + + vdd-supply: + description: power supply voltage + + vddio-supply: + description: power supply voltage for IO + + width-mm: + description: physical panel width [mm] + + height-mm: + description: physical panel height [mm] + + panel-timing: true + +required: + - compatible + - reg + - reset-gpios + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "fannal,c3004"; + reg = <0>; + pinctrl-0 = <&pinctrl_mipi_dsi_rst>; + pinctrl-names = "default"; + reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>; + vdd-supply = <®1>; + vddio-supply = <®2>; + width-mm = <93>; + height-mm = <56>; + panel-timing { + clock-frequency = <27000000>; + hactive = <480>; + vactive = <800>; + hfront-porch = <30>; + hback-porch = <30>; + hsync-len = <8>; + vback-porch = <30>; + vfront-porch = <30>; + vsync-len = <8>; + }; + }; + }; +...
MAINTAINERS +6 -0
@@ -6427,6 +6427,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F: Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml F: drivers/gpu/drm/panel/panel-ebbg-ft8719.c +DRM DRIVER FOR FANNAL C3004373132019A +M: Paulo Pavacic <[email protected]> +S: Maintained +C: matrix:r/linux-drm:matrix.org +F: Documentation/devicetree/bindings/display/panel/panel-fannal,c3004.yaml + DRM DRIVER FOR FARADAY TVE200 TV ENCODER M: Linus Walleij <[email protected]> S: Maintained
Signature · 1 line
2.40.1
Re: [PATCH v3 2/3] dt-bindings: display: panel: add fannal,c3004
Quoted 9 lines · Paulo Pavacic
Added fannal to vendor-prefixes and dt bindings for Fannal C3004. Fannal C3004 is a 480x800 MIPI DSI Panel which requires DCS initialization sequences with certain delays between certain commands.
Signed-off-by Paulo Pavacic <[email protected]>---
v4 changelog:
- add spaces between properties
???
I pointed out last incorrect versioning. This is v3, not v4. Or is it v4?
What about my tag?
What about my comment?
Best regards,
Krzysztof
Re: [PATCH v3 2/3] dt-bindings: display: panel: add fannal,c3004
Hello Krzysztof,
uto, 6. lip 2023. u 16:43 Krzysztof Kozlowski
<[email protected]> napisao je:
Quoted 7 lines · Paulo Pavacic
Quoted 5 lines
Added fannal to vendor-prefixes and dt bindings for Fannal C3004. Fannal C3004 is a 480x800 MIPI DSI Panel which requires DCS initialization sequences with certain delays between certain commands.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Paulo Pavacic <[email protected]>---
v4 changelog:
- add spaces between properties???
Added empty lines between properties in yml file
Quoted 2 lines
I pointed out last incorrect versioning. This is v3, not v4. Or is it v4?
It is v4 of the patch but v3 of the patchset. I wasn't sure whether somebody would complain if I were to name [patch 2/3] in a patch set with different version. I will try to edit changelog to match patchset version.
Quoted 3 lines
What about my tag?
I have changed in MAINTAINERS file from "+C:
matrix:r/mipi-dsi-bringup:matrix.org" to " +C:
matrix:r/linux-drm:matrix.org". So I wasn't sure whether to add it. I will add it in future version of the patch.
Quoted 2 lines
What about my comment?
I thought you wanted me to have more generalized MAINTAINERS community URI that's why I have changed it to linux-drm. I will remove community URI in future version of the patch.
Quoted 3 lines
Best regards,
Krzysztof
Thanks,
Paulo
Re: [PATCH v3 2/3] dt-bindings: display: panel: add fannal,c3004
Quoted 21 lines · Paulo Pavacic
Hello Krzysztof,
uto, 6. lip 2023. u 16:43 Krzysztof Kozlowski
<[email protected]> napisao je:Quoted 7 lines · Paulo Pavacic
Quoted 5 lines
Added fannal to vendor-prefixes and dt bindings for Fannal C3004. Fannal C3004 is a 480x800 MIPI DSI Panel which requires DCS initialization sequences with certain delays between certain commands.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Paulo Pavacic <[email protected]>---
v4 changelog:
- add spaces between properties???
Added empty lines between properties in yml file
Quoted 1 line
Quoted 6 lines
Quoted 1 line
I pointed out last incorrect versioning. This is v3, not v4. Or is it v4?
It is v4 of the patch but v3 of the patchset. I wasn't sure whether somebody would complain if I were to name [patch 2/3] in a patch set with different version. I will try to edit changelog to match patchset version.
Please maintain consistent versioning. There is only one version - that's the version you are sending.
Quoted 9 lines
Quoted 4 lines
What about my tag?
I have changed in
MAINTAINERSfile from "+C:
matrix:r/mipi-dsi-bringup:matrix.org" to " +C:
matrix:r/linux-drm:matrix.org". So I wasn't sure whether to add it. I will add it in future version of the patch.
Keep the tags you received.
Quoted 7 lines
Quoted 3 lines
What about my comment?
I thought you wanted me to have more generalized
MAINTAINERScommunity URI that's why I have changed it to linux-drm. I will remove community URI in future version of the patch.
The chat should be in subsystem entry, not in individual drivers. People will not hop between 100 IRC rooms to figure out discussion. Just like we have only one mailing list dedicated to given topic.
Best regards,
Krzysztof
PATCH v3 3/3 drm/panel-fannal-c3004: Add fannal c3004 DSI panel
In reply to Paulo PavacicFannal C3004 is a 480x800 display made by fannal that requires DCS initialization sequences.
---
v4 changelog:
- formatting and style changes
- change community room
v3 changelog:
- using generic mipi_dsi_dcs_write_seq
- removed success prints
- removed some comments
- simplified code/removed support for different panels
- changed namespace from fann to fannal
v2 changelog:
- renamed from panel-mipi-dsi-bringup
- only one MAINTAINER e-mail
--- MAINTAINERS | 1 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-fannal-c3004.c | 318 +++++++++++++++++++++ 4 files changed, 331 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-fannal-c3004.c
MAINTAINERS +1 -0
@@ -6432,6 +6432,7 @@ M: Paulo Pavacic <[email protected]> S: Maintained C: matrix:r/linux-drm:matrix.org F: Documentation/devicetree/bindings/display/panel/panel-fannal,c3004.yaml +F: drivers/gpu/drm/panel/panel-fannal-c3004.c DRM DRIVER FOR FARADAY TVE200 TV ENCODER M: Linus Walleij <[email protected]>
drivers/gpu/drm/panel/Kconfig +11 -0
@@ -144,6 +144,17 @@ config DRM_PANEL_ELIDA_KD35T133 KD35T133 controller for 320x480 LCD panels with MIPI-DSI system interfaces. +config DRM_PANEL_FANNAL_C3004 + tristate "Fannal C3004 panel" + depends on OF + depends on DRM_MIPI_DSI + help + Say Y here if you want to enable support for the Fannal C3004 + 2-lane 480x800 MIPI DSI panel which requires initialization + sequence. + + If M is selected the module will be called panel-fannal-c3004. + config DRM_PANEL_FEIXIN_K101_IM2BA02 tristate "Feixin K101 IM2BA02 panel" depends on OF
drivers/gpu/drm/panel/Makefile +1 -0
@@ -12,6 +12,7 @@ obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o obj-$(CONFIG_DRM_PANEL_EDP) += panel-edp.o obj-$(CONFIG_DRM_PANEL_EBBG_FT8719) += panel-ebbg-ft8719.o obj-$(CONFIG_DRM_PANEL_ELIDA_KD35T133) += panel-elida-kd35t133.o +obj-$(CONFIG_DRM_PANEL_FANNAL_C3004) += panel-fannal-c3004.o obj-$(CONFIG_DRM_PANEL_FEIXIN_K101_IM2BA02) += panel-feixin-k101-im2ba02.o obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) += panel-feiyang-fy07024di26a30d.o obj-$(CONFIG_DRM_PANEL_HIMAX_HX8394) += panel-himax-hx8394.o
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +318 -0
318 lines not on this page · raw message
Signature · 1 line
2.40.1
Re: [PATCH v3 3/3] drm/panel-fannal-c3004: Add fannal c3004 DSI panel
Quoted 7 lines · Paulo Pavacic
Fannal C3004 is a 480x800 display made by fannal that requires DCS initialization sequences.
Signed-off-by Paulo Pavacic <[email protected]>---
v4 changelog:
- formatting and style changes
Are you sure? I see other changes - removal of some code, handling errors and GPIO.
Quoted 1 line
- change community room
What does it mean? Where is this change in this patch?
...
Quoted 7 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +7
-0+ +static const struct drm_panel_funcs fannal_panel_funcs = { + .prepare = fannal_panel_prepare, + .unprepare = fannal_panel_unprepare, + .enable = fannal_panel_enable, + .disable = fannal_panel_disable, + .get_modes = fannal_panel_get_modes,
drivers/gpu/drm/panel/panel-fannal-c3004.c line 263
Quoted 10 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +10
-0+}; + +static int fannal_panel_probe (struct mipi_dsi_device *dsi) +{ +struct device *dev = &dsi->dev; +struct fannal_panel_data *panel_data; +int ret; + + panel_data =devm_kzalloc (&dsi->dev,sizeof (*panel_data),GFP_KERNEL ); +
Drop blank line.
drivers/gpu/drm/panel/panel-fannal-c3004.c line 267
Quoted 4 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +4
-0+if (!panel_data) +return -ENOMEM ; + + panel_data->reset =
You have wrong wrapping here. devm_gpiod_get_optional() goes after =.
drivers/gpu/drm/panel/panel-fannal-c3004.c line 269
Quoted 2 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +2
-0+devm_gpiod_get_optional (dev,"reset" ,GPIOD_OUT_LOW ); +
Drop blank line.
Quoted 14 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +14
-0+if (IS_ERR (panel_data->reset)) { +return dev_err_probe ( + dev,PTR_ERR (panel_data->reset), +"error: probe: get reset GPIO: (%d) Check the fdt\n" , + ret); + } + +mipi_dsi_set_drvdata (dsi, panel_data); + + dsi->format =MIPI_DSI_FMT_RGB888 ; + dsi->mode_flags =MIPI_DSI_CLOCK_NON_CONTINUOUS | +MIPI_DSI_MODE_VSYNC_FLUSH |MIPI_DSI_MODE_VIDEO_HSE | +MIPI_DSI_MODE_NO_EOT_PACKET | +MIPI_DSI_MODE_VIDEO_SYNC_PULSE |MIPI_DSI_MODE_VIDEO ;
drivers/gpu/drm/panel/panel-fannal-c3004.c line 293
Quoted 10 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +10
-0+ dsi->lanes =2 ; + +gpiod_set_value_cansleep (panel_data->reset,1 ); + +drm_panel_init (&panel_data->panel, dev, &fannal_panel_funcs, +DRM_MODE_CONNECTOR_DSI ); +dev_set_drvdata (dev, panel_data); + +drm_panel_add (&panel_data->panel); +
Best regards,
Krzysztof
Re: [PATCH v3 3/3] drm/panel-fannal-c3004: Add fannal c3004 DSI panel
Hello,
uto, 6. lip 2023. u 16:45 Krzysztof Kozlowski
<[email protected]> napisao je:
Quoted 39 lines · Paulo Pavacic
Quoted 7 lines
Fannal C3004 is a 480x800 display made by fannal that requires DCS initialization sequences.
Signed-off-by Paulo Pavacic <[email protected]>---
v4 changelog:
- formatting and style changesAre you sure? I see other changes - removal of some code, handling errors and GPIO.
Quoted 1 line
- change community room
What does it mean? Where is this change in this patch?
...
Quoted 7 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +7
-0+ +static const struct drm_panel_funcs fannal_panel_funcs = { + .prepare = fannal_panel_prepare, + .unprepare = fannal_panel_unprepare, + .enable = fannal_panel_enable, + .disable = fannal_panel_disable, + .get_modes = fannal_panel_get_modes,drivers/gpu/drm/panel/panel-fannal-c3004.c line 263
Quoted 10 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +10
-0+}; + +static int fannal_panel_probe (struct mipi_dsi_device *dsi) +{ +struct device *dev = &dsi->dev; +struct fannal_panel_data *panel_data; +int ret; + + panel_data =devm_kzalloc (&dsi->dev,sizeof (*panel_data),GFP_KERNEL ); +Drop blank line.
Quoted 6 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c line 267
Quoted 4 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +4
-0+if (!panel_data) +return -ENOMEM ; + + panel_data->reset =You have wrong wrapping here.
devm_gpiod_get_optional()goes after =.
I'm not sure why, but clang-format makes it that way. I'm using this
style: https://raw.githubusercontent.com/torvalds/linux/master/.clang-format
Do you have some other style?
Quoted 26 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c line 269
Quoted 3 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +2
-0+devm_gpiod_get_optional (dev,"reset" ,GPIOD_OUT_LOW ); +Drop blank line.
Quoted 20 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +20
-0+if (IS_ERR (panel_data->reset)) { +return dev_err_probe ( + dev,PTR_ERR (panel_data->reset), +"error: probe: get reset GPIO: (%d) Check the fdt\n" , + ret); + } + +mipi_dsi_set_drvdata (dsi, panel_data); + + dsi->format =MIPI_DSI_FMT_RGB888 ; + dsi->mode_flags =MIPI_DSI_CLOCK_NON_CONTINUOUS | +MIPI_DSI_MODE_VSYNC_FLUSH |MIPI_DSI_MODE_VIDEO_HSE | +MIPI_DSI_MODE_NO_EOT_PACKET | +MIPI_DSI_MODE_VIDEO_SYNC_PULSE |MIPI_DSI_MODE_VIDEO ; + dsi->lanes =2 ; + +gpiod_set_value_cansleep (panel_data->reset,1 ); + +drm_panel_init (&panel_data->panel, dev, &fannal_panel_funcs, +DRM_MODE_CONNECTOR_DSI );
Quoted 9 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c line 293
Quoted 4 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +4
-0+dev_set_drvdata (dev, panel_data); + +drm_panel_add (&panel_data->panel); +Best regards,
Krzysztof
Thanks,
Paulo
Re: [PATCH v3 3/3] drm/panel-fannal-c3004: Add fannal c3004 DSI panel
Quoted 48 lines · Paulo Pavacic
Hello,
uto, 6. lip 2023. u 16:45 Krzysztof Kozlowski
<[email protected]> napisao je:Quoted 44 lines · Paulo Pavacic
Quoted 7 lines
Fannal C3004 is a 480x800 display made by fannal that requires DCS initialization sequences.
Signed-off-by Paulo Pavacic <[email protected]>---
v4 changelog:
- formatting and style changesAre you sure? I see other changes - removal of some code, handling errors and GPIO.
Quoted 1 line
- change community room
What does it mean? Where is this change in this patch?
...
Quoted 7 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +7
-0+ +static const struct drm_panel_funcs fannal_panel_funcs = { + .prepare = fannal_panel_prepare, + .unprepare = fannal_panel_unprepare, + .enable = fannal_panel_enable, + .disable = fannal_panel_disable, + .get_modes = fannal_panel_get_modes,drivers/gpu/drm/panel/panel-fannal-c3004.c line 263
Quoted 10 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +10
-0+}; + +static int fannal_panel_probe (struct mipi_dsi_device *dsi) +{ +struct device *dev = &dsi->dev; +struct fannal_panel_data *panel_data; +int ret; + + panel_data =devm_kzalloc (&dsi->dev,sizeof (*panel_data),GFP_KERNEL ); +Drop blank line.
Quoted 4 lines
drivers/gpu/drm/panel/panel-fannal-c3004.c new file +4
-0+if (!panel_data) +return -ENOMEM ; + + panel_data->reset =
Quoted 5 lines
Quoted 1 line
You have wrong wrapping here.
devm_gpiod_get_optional()goes after =.I'm not sure why, but clang-format makes it that way. I'm using this
style: https://raw.githubusercontent.com/torvalds/linux/master/.clang-format
Do you have some other style?
Linux kernel coding style.
https://elixir.bootlin.com/linux/v6.4-rc5/source/Documentation/process/coding-style.rst
Don't use clang or other non-kernel formatters.
Best regards,
Krzysztof