RDMA/mana_ib: Add EQ interrupt support to mana ib driver.
Subsystems (5)
Wei Hu
maintainerPATCH v2 1/1 RDMA/mana_ib: Add EQ interrupt support to mana ib driver.
Add EQ interrupt support for mana ib driver. Allocate EQs per ucontext to receive interrupt. Attach EQ when CQ is created. Call CQ interrupt handler when completion interrupt happens. EQs are destroyed when ucontext is deallocated.
The change calls some public APIs in mana ethernet driver to allocate EQs and other resources. Ehe EQ process routine is also shared by mana ethernet and mana ib drivers.
---
v2: Use ibdev_dbg to print error messages and return -ENOMEN
when kzalloc fails.
drivers/infiniband/hw/mana/cq.c | 32 ++++- drivers/infiniband/hw/mana/main.c | 87 ++++++++++++ drivers/infiniband/hw/mana/mana_ib.h | 4 + drivers/infiniband/hw/mana/qp.c | 90 +++++++++++- .../net/ethernet/microsoft/mana/gdma_main.c | 131 ++++++++++-------- drivers/net/ethernet/microsoft/mana/mana_en.c | 1 + include/net/mana/gdma.h | 9 +- 7 files changed, 290 insertions(+), 64 deletions(-)
drivers/infiniband/hw/mana/cq.c +30 -2
@@ -12,13 +12,20 @@ int mana_ib_create_cq(struct ib_cq *ibcq, const struct ib_cq_init_attr *attr,struct ib_device *ibdev = ibcq->device;struct mana_ib_create_cq ucmd = {};struct mana_ib_dev *mdev; +struct gdma_context *gc; +struct gdma_dev *gd;int err; mdev = container_of(ibdev, struct mana_ib_dev, ib_dev); + gd = mdev->gdma_dev; + gc = gd->gdma_context;if (udata->inlen <sizeof (ucmd))return -EINVAL ; + cq->comp_vector = attr->comp_vector > gc->max_num_queues ? +0 : attr->comp_vector; + err =ib_copy_from_udata (&ucmd, udata,min (sizeof (ucmd), udata->inlen));if (err) { ibdev_dbg(ibdev,
@@ -69,11 +76,32 @@ int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) struct mana_ib_cq *cq = container_of(ibcq, struct mana_ib_cq, ibcq);struct ib_device *ibdev = ibcq->device;struct mana_ib_dev *mdev; +struct gdma_context *gc; +struct gdma_dev *gd; + mdev = container_of(ibdev, struct mana_ib_dev, ib_dev); + gd = mdev->gdma_dev; + gc = gd->gdma_context; -mana_ib_gd_destroy_dma_region (mdev, cq->gdma_region); -ib_umem_release (cq->umem); + + +if (atomic_read (&ibcq->usecnt) ==0 ) { +mana_ib_gd_destroy_dma_region (mdev, cq->gdma_region); +ibdev_dbg (ibdev,"freeing gdma cq %p\n" , gc->cq_table[cq->id]); +kfree (gc->cq_table[cq->id]); + gc->cq_table[cq->id] =NULL ; +ib_umem_release (cq->umem); + }return 0 ; } + +void mana_ib_cq_handler (void *ctx,struct gdma_queue *gdma_cq) +{ +struct mana_ib_cq *cq = ctx; +struct ib_device *ibdev = cq->ibcq.device; + +ibdev_dbg (ibdev,"Enter %s %d\n" , __func__, __LINE__); + cq->ibcq.comp_handler (&cq->ibcq, cq->ibcq.cq_context); +}
drivers/infiniband/hw/mana/main.c +87 -0
106 lines not on this page · raw message
drivers/infiniband/hw/mana/mana_ib.h +4 -0
@@ -67,6 +67,7 @@ struct mana_ib_cq {int cqe;u64 gdma_region;u64 id; +u32 comp_vector; };struct mana_ib_qp {
@@ -86,6 +87,7 @@ struct mana_ib_qp {struct mana_ib_ucontext {struct ib_ucontext ibucontext;u32 doorbell; +struct mana_eq *eqs; };struct mana_ib_rwq_ind_table {
@@ -159,4 +161,6 @@ int mana_ib_query_gid(struct ib_device *ibdev, u32 port, int index,void mana_ib_disassociate_ucontext (struct ib_ucontext *ibcontext); +void mana_ib_cq_handler (void *ctx,struct gdma_queue *gdma_cq); +#endif
drivers/infiniband/hw/mana/qp.c +84 -6
179 lines not on this page · raw message
drivers/net/ethernet/microsoft/mana/gdma_main.c +77 -54
227 lines not on this page · raw message
drivers/net/ethernet/microsoft/mana/mana_en.c +1 -0
@@ -1156,6 +1156,7 @@ static int mana_create_eq(struct mana_context *ac) spec.eq.callback =NULL ; spec.eq.context = ac->eqs; spec.eq.log2_throttle_limit =LOG2_EQ_THROTTLE ; + spec.eq.msix_allocated = false;for (i =0 ; i < gc->max_num_queues; i++) { err =mana_gd_create_mana_eq (gd, &spec, &ac->eqs[i].eq);
include/net/mana/gdma.h +7 -2
@@ -6,6 +6,7 @@#include <linux/dma-mapping.h> #include <linux/netdevice.h> +#include <linux/list.h> #include "shm_channel.h"
@@ -291,6 +292,8 @@ struct gdma_queue {u32 head;u32 tail; +struct list_head entry; +/* Extra fields specific to EQ/CQ. */ union { struct {
@@ -325,6 +328,8 @@ struct gdma_queue_spec {void *context;unsigned long log2_throttle_limit; +bool msix_allocated; +unsigned int msix_index; } eq;struct {
@@ -340,8 +345,8 @@ struct gdma_queue_spec {#define MANA_IRQ_NAME_SZ 32struct gdma_irq_context { -void (*handler)(void *arg); -void *arg; +void (*handler)(struct list_head *arg); +struct list_head eq_list;char name[MANA_IRQ_NAME_SZ ]; };
Signature · 1 line
2.25.1
Quoted 64 lines
Subject: [PATCH v2 1/1] RDMA/mana_ib: Add EQ interrupt support to mana ib driver.
Add EQ interrupt support for mana ib driver. Allocate EQs per ucontext to receive interrupt. Attach EQ when CQ is created. Call CQ interrupt handler when completion interrupt happens. EQs are destroyed when ucontext is deallocated.
The change calls some public APIs in mana ethernet driver to allocate EQs and other resources. Ehe EQ process routine is also shared by mana ethernet and mana ib drivers.
Co-developed-by Ajay Sharma <[email protected]>Signed-off-by Ajay Sharma <[email protected]>Signed-off-by Wei Hu <[email protected]>---
v2: Use
ibdev_dbgto print error messages and return-ENOMEN
when kzalloc fails.drivers/infiniband/hw/mana/cq.c | 32 ++++- drivers/infiniband/hw/mana/main.c | 87 ++++++++++++ drivers/infiniband/hw/mana/mana_ib.h | 4 + drivers/infiniband/hw/mana/qp.c | 90 +++++++++++- .../net/ethernet/microsoft/mana/gdma_main.c | 131 ++++++++++-------- drivers/net/ethernet/microsoft/mana/mana_en.c | 1 + include/net/mana/gdma.h | 9 +- 7 files changed, 290 insertions(+), 64 deletions(-)drivers/infiniband/hw/mana/cq.c +7
-0@@ -12,13 +12,20 @@ int mana_ib_create_cq(struct ib_cq *ibcq, const structib_cq_init_attr *attr, struct ib_device *ibdev = ibcq->device;struct mana_ib_create_cq ucmd = {};struct mana_ib_dev *mdev; +struct gdma_context *gc; +struct gdma_dev *gd;int err; mdev = container_of(ibdev, struct mana_ib_dev, ib_dev); + gd = mdev->gdma_dev; + gc = gd->gdma_context;if (udata->inlen <sizeof (ucmd))return -EINVAL ; + cq->comp_vector = attr->comp_vector > gc->max_num_queues ? +0 : attr->comp_vector; + err =ib_copy_from_udata (&ucmd, udata,min (sizeof (ucmd), udata- >inlen));drivers/infiniband/hw/mana/cq.c +3
-0if (err) { ibdev_dbg(ibdev,@@ -69,11 +76,32 @@ int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) struct mana_ib_cq *cq = container_of(ibcq, struct mana_ib_cq, ibcq);struct ib_device *ibdev = ibcq->device;struct mana_ib_dev *mdev; +struct gdma_context *gc; +struct gdma_dev *gd; +
drivers/infiniband/hw/mana/cq.c int mana_ib_destroy_cq(struct ib_cq *ibcq, struct · line 91
Quoted 10 lines
drivers/infiniband/hw/mana/cq.c +6
-2mdev = container_of(ibdev, struct mana_ib_dev, ib_dev); + gd = mdev->gdma_dev; + gc = gd->gdma_context; -mana_ib_gd_destroy_dma_region (mdev, cq->gdma_region); -ib_umem_release (cq->umem); + + +if (atomic_read (&ibcq->usecnt) ==0 ) { +mana_ib_gd_destroy_dma_region (mdev, cq->gdma_region);
Need to check if this function fails. The following code will call kfree(gc->cq_table[cq->id]), it's possible that IRQ is happening at the same time if CQ is not destroyed.
Quoted 4 lines
drivers/infiniband/hw/mana/cq.c +4
-0+ibdev_dbg (ibdev,"freeing gdma cq %p\n" , gc->cq_table[cq->id]); +kfree (gc->cq_table[cq->id]); + gc->cq_table[cq->id] =NULL ; +ib_umem_release (cq->umem);
drivers/infiniband/hw/mana/cq.c int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) · line 105
Quoted 10 lines
drivers/infiniband/hw/mana/cq.c +7
-0+ }return 0 ; } + +void mana_ib_cq_handler (void *ctx,struct gdma_queue *gdma_cq) { +struct mana_ib_cq *cq = ctx; +struct ib_device *ibdev = cq->ibcq.device; + +ibdev_dbg (ibdev,"Enter %s %d\n" , __func__, __LINE__);
This debug message seems overkill?
Quoted 24 lines
drivers/infiniband/hw/mana/cq.c +1
-0+ cq->ibcq.comp_handler (&cq->ibcq, cq->ibcq.cq_context); }drivers/infiniband/hw/mana/main.c +13
-0@@ -143,6 +143,81 @@ int mana_ib_dealloc_pd(struct ib_pd *ibpd, struct ib_udata *udata)return err; } +static void mana_ib_destroy_eq (struct mana_ib_ucontext *ucontext, +struct mana_ib_dev *mdev) +{ +struct gdma_context *gc = mdev->gdma_dev->gdma_context; +struct ib_device *ibdev = ucontext->ibucontext.device; +struct gdma_queue *eq; +int i; + +if (!ucontext->eqs) +return ; + +for (i =0 ; i < gc->max_num_queues; i++) { + eq = ucontext->eqs[i].eq;
drivers/infiniband/hw/mana/main.c int mana_ib_dealloc_pd(struct ib_pd *ibpd, struct · line 169
Quoted 10 lines
drivers/infiniband/hw/mana/main.c +10
-0+if (!eq) +continue ; + +mana_gd_destroy_queue (gc, eq); + } + +kfree (ucontext->eqs); + ucontext->eqs =NULL ; + +ibdev_dbg (ibdev,"destroyed eq's count %d\n" , gc->max_num_queues); }
Will gc->max_num_queues change after destroying a EQ?
Quoted 280 lines
drivers/infiniband/hw/mana/main.c +61
-0+ +static int mana_ib_create_eq (struct mana_ib_ucontext *ucontext, +struct mana_ib_dev *mdev) +{ +struct gdma_queue_spec spec = {}; +struct gdma_queue *queue; +struct gdma_context *gc; +struct ib_device *ibdev; +struct gdma_dev *gd; +int err; +int i; + +if (!ucontext || !mdev) +return -EINVAL ; + + ibdev = ucontext->ibucontext.device; + gd = mdev->gdma_dev; + + gc = gd->gdma_context; + + ucontext->eqs =kcalloc (gc->max_num_queues,sizeof (struct mana_eq ), +GFP_KERNEL ); +if (!ucontext->eqs) +return -ENOMEM ; + + spec.type =GDMA_EQ ; + spec.monitor_avl_buf = false; + spec.queue_size =EQ_SIZE ; + spec.eq.callback =NULL ; + spec.eq.context = ucontext->eqs; + spec.eq.log2_throttle_limit =LOG2_EQ_THROTTLE ; + spec.eq.msix_allocated = true; + +for (i =0 ; i < gc->max_num_queues; i++) { + spec.eq.msix_index = i; + err =mana_gd_create_mana_eq (gd, &spec, &queue); +if (err) + goto out; + + queue->eq.disable_needed = true; + ucontext->eqs[i].eq = queue; + } + +return 0 ; + +out: +ibdev_dbg (ibdev,"Failed to allocated eq err %d\n" , err); +mana_ib_destroy_eq (ucontext, mdev); +return err; +} +static int mana_gd_destroy_doorbell_page (struct gdma_context *gc,int doorbell_page) {@@ -225,7 +300,17 @@ int mana_ib_alloc_ucontext(struct ib_ucontext *ibcontext, ucontext->doorbell = doorbell_page; + ret =mana_ib_create_eq (ucontext, mdev); +if (ret) { +ibdev_dbg (ibdev,"Failed to create eq's , ret %d\n" , ret); + goto err; + } +return 0 ; + +err: +mana_gd_destroy_doorbell_page (gc, doorbell_page); +return ret; }void
mana_ib_dealloc_ucontext(struct ib_ucontext *ibcontext)@@ -240,6
+325,8 @@ voidmana_ib_dealloc_ucontext(struct ib_ucontext *ibcontext)drivers/infiniband/hw/mana/main.c +2
-0mdev = container_of(ibdev, struct mana_ib_dev, ib_dev); gc = mdev->gdma_dev->gdma_context; +mana_ib_destroy_eq (mana_ucontext, mdev); + ret =mana_gd_destroy_doorbell_page (gc, mana_ucontext->doorbell);if (ret)ibdev_dbg (ibdev,"Failed to destroy doorbell page %d\n" , ret);drivers/infiniband/hw/mana/mana_ib.h +4
-0@@ -67,6 +67,7 @@ struct mana_ib_cq {int cqe;u64 gdma_region;u64 id; +u32 comp_vector; };struct mana_ib_qp {@@ -86,6 +87,7 @@ struct mana_ib_qp {struct mana_ib_ucontext {struct ib_ucontext ibucontext;u32 doorbell; +struct mana_eq *eqs; };struct mana_ib_rwq_ind_table {@@ -159,4 +161,6 @@ int mana_ib_query_gid(struct ib_device *ibdev, u32 port,int index, void mana_ib_disassociate_ucontext(struct ib_ucontext *ibcontext); +void mana_ib_cq_handler (void *ctx,struct gdma_queue *gdma_cq); +#endif
drivers/infiniband/hw/mana/qp.c +4
-0@@ -96,16 +96,20 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp,struct ib_pd *pd, struct mana_ib_qp *qp = container_of(ibqp, struct mana_ib_qp, ibqp);struct mana_ib_dev *mdev = container_of(pd->device, struct mana_ib_dev, ib_dev); +struct ib_ucontext *ib_ucontext = pd->uobject->context;struct ib_rwq_ind_table *ind_tbl = attr->rwq_ind_tbl;struct mana_ib_create_qp_rss_resp resp = {};struct mana_ib_create_qp_rss ucmd = {}; +struct mana_ib_ucontext *mana_ucontext;struct gdma_dev *gd = mdev->gdma_dev;mana_handle_t *mana_ind_table;struct mana_port_context *mpc; +struct gdma_queue *gdma_cq;struct mana_context *mc;struct net_device *ndev;struct mana_ib_cq *cq;struct mana_ib_wq *wq; +struct mana_eq *eq;unsigned int ind_tbl_size;struct ib_cq *ibcq;drivers/infiniband/hw/mana/qp.c +2
-0struct ib_wq *ibwq;@@ -114,6 +118,8 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp,struct ib_pd *pd, int ret; mc = gd->driver_data; + mana_ucontext = + container_of(ib_ucontext, struct mana_ib_ucontext, ibucontext);if (!udata || udata->inlen <sizeof (ucmd))drivers/infiniband/hw/mana/qp.c +1
-0return -EINVAL ;@@ -180,6 +186,7 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp,struct ib_pd *pd, for (i = 0; i < ind_tbl_size; i++) {struct mana_obj_spec wq_spec = {};struct mana_obj_spec cq_spec = {}; +unsigned int max_num_queues = gd->gdma_context- >max_num_queues;drivers/infiniband/hw/mana/qp.c +1
-0ibwq = ind_tbl->ind_tbl[i]; wq = container_of(ibwq, struct mana_ib_wq, ibwq); @@ -193,7 +200,8 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp, struct ib_pd*pd,
drivers/infiniband/hw/mana/qp.c +1
-1cq_spec.gdma_region = cq->gdma_region; cq_spec.queue_size = cq->cqe *COMP_ENTRY_SIZE ; cq_spec.modr_ctx_id =0 ; - cq_spec.attached_eq =GDMA_CQ_NO_EQ ; + eq = &mana_ucontext->eqs[cq->comp_vector %
max_num_queues];drivers/infiniband/hw/mana/qp.c +1
-0+ cq_spec.attached_eq = eq->eq->id; ret = mana_create_wq_obj(mpc, mpc->port_handle, GDMA_RQ, &wq_spec, &cq_spec, &wq-Quoted 1 line
rx_object); @@ -207,6 +215,9 @@ static int mana_ib_create_qp_rss(struct
ib_qp*ibqp, structib_pd*pd,drivers/infiniband/hw/mana/qp.c +1
-0wq->id = wq_spec.queue_index; cq->id = cq_spec.queue_index; + ibdev_dbg(&mdev->ib_dev, "attached eq id %u cq withid %llu\n",
drivers/infiniband/hw/mana/qp.c +3
-0+ eq->eq->id, cq->id); +ibdev_dbg (&mdev->ib_dev,"ret %d rx_object 0x%llx wq id %llu cq id %llu\n" , ret, wq->rx_object, wq->id, cq->id); @@ -215,6 +226,27 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp, struct ib_pd*pd,
drivers/infiniband/hw/mana/qp.c +22
-1resp.entries[i].wqid = wq->id; mana_ind_table[i] = wq->rx_object; + +if (gd->gdma_context->cq_table[cq->id] ==NULL ) { + + gdma_cq =kzalloc (sizeof (*gdma_cq),GFP_KERNEL ); +if (!gdma_cq) { +ibdev_dbg (&mdev->ib_dev, +"failed to allocate gdma_cq\n" ); + ret = -ENOMEM ; + goto free_cq; + } + +ibdev_dbg (&mdev->ib_dev,"gdma cq allocated %p\n" , + gdma_cq); + + gdma_cq->cq.context = cq; + gdma_cq->type =GDMA_CQ ; + gdma_cq->cq.callback = mana_ib_cq_handler; + gdma_cq->id = cq->id; + gd->gdma_context->cq_table[cq->id] = gdma_cq; + } + } resp.num_entries = i;@@ -224,7 +256,7 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp,struct ib_pd *pd, ucmd.rx_hash_key_len, ucmd.rx_hash_key);if (ret) - goto fail; + goto free_cq; ret =ib_copy_to_udata (udata, &resp,sizeof (resp));drivers/infiniband/hw/mana/qp.c +17
-0if (ret) {@@ -238,6 +270,23 @@ static int mana_ib_create_qp_rss(struct ib_qp *ibqp,struct ib_pd *pd, return 0; +free_cq: + { +int j = i; +u64 cqid; + +while (j-- >0 ) { + cqid = resp.entries[j].cqid; + gdma_cq = gd->gdma_context->cq_table[cqid]; + cq = gdma_cq->cq.context; +if (atomic_read (&cq->ibcq.usecnt) ==0 ) { +kfree (gd->gdma_context->cq_table[cqid]); + gd->gdma_context->cq_table[cqid] =NULL ; + } + } + + } + fail:while (i-- >0 ) {drivers/infiniband/hw/mana/qp.c +3
-1ibwq = ind_tbl->ind_tbl[i];@@ -269,10 +318,12 @@ static int mana_ib_create_qp_raw(struct ib_qp *ibqp,struct ib_pd *ibpd, struct mana_obj_spec wq_spec = {};struct mana_obj_spec cq_spec = {};struct mana_port_context *mpc; +struct gdma_queue *gdma_cq;struct mana_context *mc;struct net_device *ndev;struct ib_umem *umem; -int err; +struct mana_eq *eq; +int err, eq_vec;u32 port;drivers/infiniband/hw/mana/qp.c +3
-1mc = gd->driver_data;@@ -350,7 +401,9 @@ static int mana_ib_create_qp_raw(struct ib_qp *ibqp,struct ib_pd *ibpd, cq_spec.gdma_region = send_cq->gdma_region; cq_spec.queue_size = send_cq->cqe *COMP_ENTRY_SIZE ; cq_spec.modr_ctx_id =0 ; - cq_spec.attached_eq =GDMA_CQ_NO_EQ ; + eq_vec = send_cq->comp_vector % gd->gdma_context- >max_num_queues; + eq = &mana_ucontext->eqs[eq_vec]; + cq_spec.attached_eq = eq->eq->id;err = mana_create_wq_obj(mpc,
mpc->port_handle,GDMA_SQ,&wq_spec,drivers/infiniband/hw/mana/qp.c +1
-0&cq_spec, &qp->tx_object);@@ -368,6 +421,26 @@ static int mana_ib_create_qp_raw(struct ib_qp *ibqp,struct ib_pd *ibpd, qp->sq_id = wq_spec.queue_index; send_cq->id = cq_spec.queue_index; +if (gd->gdma_context->cq_table[send_cq->id] ==NULL ) {
drivers/infiniband/hw/mana/qp.c static int mana_ib_create_qp_raw(struct ib_qp *ibqp, · line 435
Quoted 10 lines
drivers/infiniband/hw/mana/qp.c +10
-0+ + gdma_cq =kzalloc (sizeof (*gdma_cq),GFP_KERNEL ); +if (!gdma_cq) { +ibdev_dbg (&mdev->ib_dev, +"failed to allocate gdma_cq\n" ); + err = -ENOMEM ; + goto err_destroy_wqobj_and_cq; + } + +pr_debug ("gdma cq allocated %p\n" , gdma_cq);
Should use ibdev_dbg
Thanks,
Long
Wei Hu
maintainerQuoted 84 lines
-----Original Message-----
Subject: RE: [PATCH v2 1/1] RDMA/mana_ib: Add EQ interrupt support to mana ib driver.Quoted 6 lines
Subject: [PATCH v2 1/1] RDMA/mana_ib: Add EQ interrupt support to mana ib driver.
Add EQ interrupt support for mana ib driver. Allocate EQs per ucontext to receive interrupt. Attach EQ when CQ is created. Call CQ interrupt handler when completion interrupt happens. EQs are destroyed when
ucontext is deallocated.
Quoted 59 lines
The change calls some public APIs in mana ethernet driver to allocate EQs and other resources. Ehe EQ process routine is also shared by mana ethernet and mana ib drivers.
Co-developed-by Ajay Sharma <[email protected]>Signed-off-by Ajay Sharma <[email protected]>Signed-off-by Wei Hu <[email protected]>---
v2: Use
ibdev_dbgto print error messages and return-ENOMEN
when kzalloc fails.drivers/infiniband/hw/mana/cq.c | 32 ++++- drivers/infiniband/hw/mana/main.c | 87 ++++++++++++ drivers/infiniband/hw/mana/mana_ib.h | 4 + drivers/infiniband/hw/mana/qp.c | 90 +++++++++++- .../net/ethernet/microsoft/mana/gdma_main.c | 131 ++++++++++-------- drivers/net/ethernet/microsoft/mana/mana_en.c | 1 + include/net/mana/gdma.h | 9 +- 7 files changed, 290 insertions(+), 64 deletions(-)(quoted diff) +0
-0
b/drivers/infiniband/hw/mana/cq.cindexd141cab8a1e6..3cd680e0e753100644drivers/infiniband/hw/mana/cq.c +7
-0@@ -12,13 +12,20 @@ int mana_ib_create_cq(struct ib_cq *ibcq, conststruct ib_cq_init_attr *attr, struct ib_device *ibdev = ibcq->device;struct mana_ib_create_cq ucmd = {};struct mana_ib_dev *mdev; +struct gdma_context *gc; +struct gdma_dev *gd;int err; mdev = container_of(ibdev, struct mana_ib_dev, ib_dev); + gd = mdev->gdma_dev; + gc = gd->gdma_context;if (udata->inlen <sizeof (ucmd))return -EINVAL ; + cq->comp_vector = attr->comp_vector > gc->max_num_queues ? +0 : attr->comp_vector; + err =ib_copy_from_udata (&ucmd, udata,min (sizeof (ucmd), udata- >inlen));drivers/infiniband/hw/mana/cq.c +3
-0if (err) { ibdev_dbg(ibdev,@@ -69,11 +76,32 @@ int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) struct mana_ib_cq *cq = container_of(ibcq, struct mana_ib_cq, ibcq);struct ib_device *ibdev = ibcq->device;struct mana_ib_dev *mdev; +struct gdma_context *gc; +struct gdma_dev *gd; +drivers/infiniband/hw/mana/cq.c int mana_ib_destroy_cq(struct ib_cq *ibcq, struct · line 91
Quoted 10 lines
drivers/infiniband/hw/mana/cq.c +6
-2mdev = container_of(ibdev, struct mana_ib_dev, ib_dev); + gd = mdev->gdma_dev; + gc = gd->gdma_context; -mana_ib_gd_destroy_dma_region (mdev, cq->gdma_region); -ib_umem_release (cq->umem); + + +if (atomic_read (&ibcq->usecnt) ==0 ) { +mana_ib_gd_destroy_dma_region (mdev, cq->gdma_region);Need to check if this function fails. The following code will call kfree(gc-
Quoted 3 lines
Quoted 1 line
cq_table[cq->id]), it's possible that IRQ is happening at the same time if CQ
is not destroyed.
Sure. Will update.
Quoted 47 lines
Quoted 5 lines
drivers/infiniband/hw/mana/cq.c +1
-0+ ibdev_dbg(ibdev, "freeing gdma cq %p\n", gc->cq_table[cq-id]);
drivers/infiniband/hw/mana/cq.c +3
-0+kfree (gc->cq_table[cq->id]); + gc->cq_table[cq->id] =NULL ; +ib_umem_release (cq->umem);drivers/infiniband/hw/mana/cq.c int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) · line 105
Quoted 10 lines
drivers/infiniband/hw/mana/cq.c +7
-0+ }return 0 ; } + +void mana_ib_cq_handler (void *ctx,struct gdma_queue *gdma_cq) { +struct mana_ib_cq *cq = ctx; +struct ib_device *ibdev = cq->ibcq.device; + +ibdev_dbg (ibdev,"Enter %s %d\n" , __func__, __LINE__);This debug message seems overkill?
Quoted 29 lines
drivers/infiniband/hw/mana/cq.c +1
-0+ cq->ibcq.comp_handler (&cq->ibcq, cq->ibcq.cq_context); }drivers/infiniband/hw/mana/main.c +18
-0@@ -143,6 +143,81 @@ int mana_ib_dealloc_pd(struct ib_pd *ibpd, struct ib_udata *udata)return err; } +static void mana_ib_destroy_eq (struct mana_ib_ucontext *ucontext, +struct mana_ib_dev *mdev) +{ +struct gdma_context *gc = mdev->gdma_dev->gdma_context; +struct ib_device *ibdev = ucontext->ibucontext.device; +struct gdma_queue *eq; +int i; + +if (!ucontext->eqs) +return ; + +for (i =0 ; i < gc->max_num_queues; i++) { + eq = ucontext->eqs[i].eq; +if (!eq) +continue ; + +mana_gd_destroy_queue (gc, eq); + }
Quoted 9 lines
drivers/infiniband/hw/mana/main.c int mana_ib_dealloc_pd(struct ib_pd *ibpd, struct ib_udata *udata)
Quoted 6 lines
drivers/infiniband/hw/mana/main.c +5
-0+ +kfree (ucontext->eqs); + ucontext->eqs =NULL ; + +ibdev_dbg (ibdev,"destroyed eq's count %d\n" , gc- max_num_queues); }Will
gc->max_num_queueschange after destroying a EQ?
I think it will not change. Also the compiler might optimize the code to just read the value once and store it in a register.
Thanks,
Wei
Quoted 153 lines
Subject: RE: [PATCH v2 1/1] RDMA/mana_ib: Add EQ interrupt support to mana ib driver.
Quoted 4 lines
-----Original Message-----
Subject: RE: [PATCH v2 1/1] RDMA/mana_ib: Add EQ interrupt support to mana ib driver.Quoted 26 lines
Quoted 7 lines
Subject: [PATCH v2 1/1] RDMA/mana_ib: Add EQ interrupt support to mana ib driver.
Add EQ interrupt support for mana ib driver. Allocate EQs per ucontext to receive interrupt. Attach EQ when CQ is created. Call CQ interrupt handler when completion interrupt happens. EQs are destroyed when
ucontext is deallocated.
Quoted 18 lines
The change calls some public APIs in mana ethernet driver to allocate EQs and other resources. Ehe EQ process routine is also shared by mana ethernet and mana ib drivers.
Co-developed-by Ajay Sharma <[email protected]>Signed-off-by Ajay Sharma <[email protected]>Signed-off-by Wei Hu <[email protected]>---
v2: Use
ibdev_dbgto print error messages and return-ENOMEN
when kzalloc fails.drivers/infiniband/hw/mana/cq.c | 32 ++++- drivers/infiniband/hw/mana/main.c | 87 ++++++++++++ drivers/infiniband/hw/mana/mana_ib.h | 4 + drivers/infiniband/hw/mana/qp.c | 90 +++++++++++- .../net/ethernet/microsoft/mana/gdma_main.c | 131 ++++++++++--------
Quoted 54 lines
Quoted 41 lines
drivers/net/ethernet/microsoft/mana/mana_en.c | 1 + include/net/mana/gdma.h | 9 +- 7 files changed, 290 insertions(+), 64 deletions(-)(quoted diff) +0
-0
b/drivers/infiniband/hw/mana/cq.cindexd141cab8a1e6..3cd680e0e753100644drivers/infiniband/hw/mana/cq.c +7
-0@@ -12,13 +12,20 @@ int mana_ib_create_cq(struct ib_cq *ibcq, conststruct ib_cq_init_attr *attr, struct ib_device *ibdev = ibcq->device;struct mana_ib_create_cq ucmd = {};struct mana_ib_dev *mdev; +struct gdma_context *gc; +struct gdma_dev *gd;int err; mdev = container_of(ibdev, struct mana_ib_dev, ib_dev); + gd = mdev->gdma_dev; + gc = gd->gdma_context;if (udata->inlen <sizeof (ucmd))return -EINVAL ; + cq->comp_vector = attr->comp_vector > gc->max_num_queues ? +0 : attr->comp_vector; + err =ib_copy_from_udata (&ucmd, udata,min (sizeof (ucmd), udata- >inlen));drivers/infiniband/hw/mana/cq.c +3
-0if (err) { ibdev_dbg(ibdev,@@ -69,11 +76,32 @@ int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) struct mana_ib_cq *cq = container_of(ibcq, struct mana_ib_cq, ibcq);struct ib_device *ibdev = ibcq->device;struct mana_ib_dev *mdev; +struct gdma_context *gc; +struct gdma_dev *gd; +drivers/infiniband/hw/mana/cq.c int mana_ib_destroy_cq(struct ib_cq *ibcq, · line 91
Quoted 10 lines
drivers/infiniband/hw/mana/cq.c +6
-2mdev = container_of(ibdev, struct mana_ib_dev, ib_dev); + gd = mdev->gdma_dev; + gc = gd->gdma_context; -mana_ib_gd_destroy_dma_region (mdev, cq->gdma_region); -ib_umem_release (cq->umem); + + +if (atomic_read (&ibcq->usecnt) ==0 ) { +mana_ib_gd_destroy_dma_region (mdev, cq->gdma_region);Need to check if this function fails. The following code will call kfree(gc-
Quoted 4 lines
Quoted 2 lines
cq_table[cq->id]), it's possible that IRQ is happening at the same time if CQ
is not destroyed.
Sure. Will update.
Quoted 46 lines
Quoted 5 lines
drivers/infiniband/hw/mana/cq.c +1
-0+ ibdev_dbg(ibdev, "freeing gdma cq %p\n", gc->cq_table[cq-id]);
drivers/infiniband/hw/mana/cq.c +3
-0+kfree (gc->cq_table[cq->id]); + gc->cq_table[cq->id] =NULL ; +ib_umem_release (cq->umem);drivers/infiniband/hw/mana/cq.c int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) · line 105
Quoted 10 lines
drivers/infiniband/hw/mana/cq.c +7
-0+ }return 0 ; } + +void mana_ib_cq_handler (void *ctx,struct gdma_queue *gdma_cq) { +struct mana_ib_cq *cq = ctx; +struct ib_device *ibdev = cq->ibcq.device; + +ibdev_dbg (ibdev,"Enter %s %d\n" , __func__, __LINE__);This debug message seems overkill?
Quoted 28 lines
drivers/infiniband/hw/mana/cq.c +1
-0+ cq->ibcq.comp_handler (&cq->ibcq, cq->ibcq.cq_context); }drivers/infiniband/hw/mana/main.c +17
-0@@ -143,6 +143,81 @@ int mana_ib_dealloc_pd(struct ib_pd *ibpd, struct ib_udata *udata)return err; } +static void mana_ib_destroy_eq (struct mana_ib_ucontext *ucontext, +struct mana_ib_dev *mdev) { +struct gdma_context *gc = mdev->gdma_dev->gdma_context; +struct ib_device *ibdev = ucontext->ibucontext.device; +struct gdma_queue *eq; +int i; + +if (!ucontext->eqs) +return ; + +for (i =0 ; i < gc->max_num_queues; i++) { + eq = ucontext->eqs[i].eq; +if (!eq) +continue ; + +mana_gd_destroy_queue (gc, eq); + }Quoted 9 lines
drivers/infiniband/hw/mana/main.c int mana_ib_dealloc_pd(struct ib_pd *ibpd, struct ib_udata *udata)
Quoted 6 lines
drivers/infiniband/hw/mana/main.c +5
-0+ +kfree (ucontext->eqs); + ucontext->eqs =NULL ; + +ibdev_dbg (ibdev,"destroyed eq's count %d\n" , gc- max_num_queues); }Will
gc->max_num_queueschange after destroying a EQ?
Quoted 5 lines
I think it will not change. Also the compiler might optimize the code to just read the value once and store it in a register.
Thanks,
Wei
This message is confusing. How about changing it to " destroyed eq. Maximum count %d", or just remove the count as it's not informational.
Long
Wei Hu
maintainerQuoted 174 lines
-----Original Message-----
From: Long Li <[email protected]>
Sent: Friday, June 9, 2023 1:48 AM
To: Wei Hu <[email protected]>; [email protected]; linux- [email protected]; [email protected]; Ajay Sharma <[email protected]>; [email protected]; [email protected]; KY Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; [email protected]; Dexuan Cui <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: RE: [PATCH v2 1/1] RDMA/mana_ib: Add EQ interrupt support to mana ib driver.Quoted 35 lines
Subject: RE: [PATCH v2 1/1] RDMA/mana_ib: Add EQ interrupt support to mana ib driver.
Quoted 30 lines
-----Original Message-----
Subject: RE: [PATCH v2 1/1] RDMA/mana_ib: Add EQ interrupt support to mana ib driver.Quoted 7 lines
Subject: [PATCH v2 1/1] RDMA/mana_ib: Add EQ interrupt support to mana ib driver.
Add EQ interrupt support for mana ib driver. Allocate EQs per ucontext to receive interrupt. Attach EQ when CQ is created. Call CQ interrupt handler when completion interrupt happens. EQs are destroyed when
ucontext is deallocated.
Quoted 18 lines
The change calls some public APIs in mana ethernet driver to allocate EQs and other resources. Ehe EQ process routine is also shared by mana ethernet and mana ib drivers.
Co-developed-by Ajay Sharma <[email protected]>Signed-off-by Ajay Sharma <[email protected]>Signed-off-by Wei Hu <[email protected]>---
v2: Use
ibdev_dbgto print error messages and return-ENOMEN
when kzalloc fails.drivers/infiniband/hw/mana/cq.c | 32 ++++- drivers/infiniband/hw/mana/main.c | 87 ++++++++++++ drivers/infiniband/hw/mana/mana_ib.h | 4 + drivers/infiniband/hw/mana/qp.c | 90 +++++++++++- .../net/ethernet/microsoft/mana/gdma_main.c | 131 ++++++++++-------
Quoted 7 lines
-
Quoted 6 lines
Quoted 6 lines
drivers/net/ethernet/microsoft/mana/mana_en.c | 1 + include/net/mana/gdma.h | 9 +- 7 files changed, 290 insertions(+), 64 deletions(-)(quoted diff) +0
-0
b/drivers/infiniband/hw/mana/cq.cindex
d141cab8a1e6..3cd680e0e753Quoted 114 lines
Quoted 48 lines
Quoted 35 lines
100644
drivers/infiniband/hw/mana/cq.c +7
-0@@ -12,13 +12,20 @@ int mana_ib_create_cq(struct ib_cq *ibcq,const struct ib_cq_init_attr *attr, struct ib_device *ibdev = ibcq->device;struct mana_ib_create_cq ucmd = {};struct mana_ib_dev *mdev; +struct gdma_context *gc; +struct gdma_dev *gd;int err; mdev = container_of(ibdev, struct mana_ib_dev, ib_dev); + gd = mdev->gdma_dev; + gc = gd->gdma_context;if (udata->inlen <sizeof (ucmd))return -EINVAL ; + cq->comp_vector = attr->comp_vector > gc->max_num_queues ? +0 : attr->comp_vector; + err =ib_copy_from_udata (&ucmd, udata,min (sizeof (ucmd), udata- >inlen));drivers/infiniband/hw/mana/cq.c +3
-0if (err) { ibdev_dbg(ibdev,@@ -69,11 +76,32 @@ int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) struct mana_ib_cq *cq = container_of(ibcq, struct mana_ib_cq, ibcq);struct ib_device *ibdev = ibcq->device;struct mana_ib_dev *mdev; +struct gdma_context *gc; +struct gdma_dev *gd; +drivers/infiniband/hw/mana/cq.c int mana_ib_destroy_cq(struct ib_cq *ibcq, · line 91
Quoted 10 lines
drivers/infiniband/hw/mana/cq.c +6
-2mdev = container_of(ibdev, struct mana_ib_dev, ib_dev); + gd = mdev->gdma_dev; + gc = gd->gdma_context; -mana_ib_gd_destroy_dma_region (mdev, cq->gdma_region); -ib_umem_release (cq->umem); + + +if (atomic_read (&ibcq->usecnt) ==0 ) { +mana_ib_gd_destroy_dma_region (mdev, cq->gdma_region);Need to check if this function fails. The following code will call kfree(gc-
Quoted 4 lines
Quoted 2 lines
cq_table[cq->id]), it's possible that IRQ is happening at the same time if CQ
is not destroyed.
Sure. Will update.
Quoted 46 lines
Quoted 5 lines
drivers/infiniband/hw/mana/cq.c +1
-0+ ibdev_dbg(ibdev, "freeing gdma cq %p\n", gc->cq_table[cq-id]);
drivers/infiniband/hw/mana/cq.c +3
-0+kfree (gc->cq_table[cq->id]); + gc->cq_table[cq->id] =NULL ; +ib_umem_release (cq->umem);drivers/infiniband/hw/mana/cq.c int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) · line 105
Quoted 10 lines
drivers/infiniband/hw/mana/cq.c +7
-0+ }return 0 ; } + +void mana_ib_cq_handler (void *ctx,struct gdma_queue *gdma_cq) { +struct mana_ib_cq *cq = ctx; +struct ib_device *ibdev = cq->ibcq.device; + +ibdev_dbg (ibdev,"Enter %s %d\n" , __func__, __LINE__);This debug message seems overkill?
Quoted 28 lines
drivers/infiniband/hw/mana/cq.c +1
-0+ cq->ibcq.comp_handler (&cq->ibcq, cq->ibcq.cq_context); }drivers/infiniband/hw/mana/main.c +17
-0@@ -143,6 +143,81 @@ int mana_ib_dealloc_pd(struct ib_pd *ibpd, struct ib_udata *udata)return err; } +static void mana_ib_destroy_eq (struct mana_ib_ucontext *ucontext, +struct mana_ib_dev *mdev) { +struct gdma_context *gc = mdev->gdma_dev->gdma_context; +struct ib_device *ibdev = ucontext->ibucontext.device; +struct gdma_queue *eq; +int i; + +if (!ucontext->eqs) +return ; + +for (i =0 ; i < gc->max_num_queues; i++) { + eq = ucontext->eqs[i].eq; +if (!eq) +continue ; + +mana_gd_destroy_queue (gc, eq); + }Quoted 9 lines
drivers/infiniband/hw/mana/main.c int mana_ib_dealloc_pd(struct ib_pd *ibpd, struct ib_udata *udata)
Quoted 6 lines
drivers/infiniband/hw/mana/main.c +5
-0+ +kfree (ucontext->eqs); + ucontext->eqs =NULL ; + +ibdev_dbg (ibdev,"destroyed eq's count %d\n" , gc- max_num_queues); }Will
gc->max_num_queueschange after destroying a EQ?I think it will not change. Also the compiler might optimize the code to just read the value once and store it in a register.
Quoted 7 lines
Quoted 2 lines
Thanks,
WeiThis message is confusing. How about changing it to " destroyed eq. Maximum count %d", or just remove the count as it's not informational.
Long
Sure. I will remove the count from the message.
Thanks,
Wei
Jakub Kicinski
maintainerQuoted 7 lines · On Tue, 6 Jun 2023 15:17:47 +0000 Wei Hu wrote:
drivers/infiniband/hw/mana/cq.c | 32 ++++- drivers/infiniband/hw/mana/main.c | 87 ++++++++++++ drivers/infiniband/hw/mana/mana_ib.h | 4 + drivers/infiniband/hw/mana/qp.c | 90 +++++++++++- .../net/ethernet/microsoft/mana/gdma_main.c | 131 ++++++++++-------- drivers/net/ethernet/microsoft/mana/mana_en.c | 1 + include/net/mana/gdma.h | 9 +-
IB and netdev are different subsystem, can you put it on a branch and send a PR as the cover letter so that both subsystems can pull?
Examples:
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
Wei Hu
maintainerHi Jakub,
Quoted 36 lines
-----Original Message-----
From: Jakub Kicinski <[email protected]>
Sent: Thursday, June 8, 2023 12:39 PM
To: Wei Hu <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]; Long Li <[email protected]>; Ajay Sharma <[email protected]>; [email protected]; [email protected]; KY Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; [email protected]; Dexuan Cui <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v2 1/1] RDMA/mana_ib: Add EQ interrupt support to mana ib driver.Quoted 7 lines · On Tue, 6 Jun 2023 15:17:47 +0000 Wei Hu wrote:
drivers/infiniband/hw/mana/cq.c | 32 ++++- drivers/infiniband/hw/mana/main.c | 87 ++++++++++++ drivers/infiniband/hw/mana/mana_ib.h | 4 + drivers/infiniband/hw/mana/qp.c | 90 +++++++++++- .../net/ethernet/microsoft/mana/gdma_main.c | 131 ++++++++++-------- drivers/net/ethernet/microsoft/mana/mana_en.c | 1 + include/net/mana/gdma.h | 9 +-IB and netdev are different subsystem, can you put it on a branch and send a PR as the cover letter so that both subsystems can pull?
Examples:
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.
kernel.org%2Fall%2F20230607210410.88209-1- saeed%40kernel.org%2F&data=05%7C01%7Cweh%40microsoft.com%7Cb672 4a9f672f47d433ef08db67da4ada%7C72f988bf86f141af91ab2d7cd011db47%7C 1%7C0%7C638217959538674174%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000 %7C%7C%7C&sdata=amO0W8QsR2I5INNNzCNOKEjrsYbzuZ92KXhNdfwSCHA %3D&reserved=0
Quoted 8 lines
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.
kernel.org%2Fall%2F20230602171302.745492-1- anthony.l.nguyen%40intel.com%2F&data=05%7C01%7Cweh%40microsoft.co m%7Cb6724a9f672f47d433ef08db67da4ada%7C72f988bf86f141af91ab2d7cd0 11db47%7C1%7C0%7C638217959538674174%7CUnknown%7CTWFpbGZsb3d8 eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3 D%7C3000%7C%7C%7C&sdata=A%2BjjtSx%2FvY2T%2BNIEPGuftk%2BCr%2Fv Yt2Xc1q8B6h2tb6g%3D&reserved=0
Thanks for you comment. I am new to the process. I have a few questions regarding to this and hope you can help. First of all, the patch is mostly for IB. Is it possible for the patch to just go through the RDMA branch, since most of the changes are in RDMA?
If the patch also needs to go through the NETDEV branch, does it mean two subsystems will pull its own part? A few follow-up questions about generating a PR, since I have never done such before.
1. Which repo should I clone and create the branch from?
2. From the example you provided, I see these people has their own branches on kernel.org, for example something like:git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git tags/mlx5-updates-2023-06-06.
I am not Linux maintainer. I just have repo on Github. How do I create or fork on kernel.org? Do I need an account to do so? Or I can use my own repo on Github?
3. How to create PR in this case? Should I follow this link: https://docs.kernel.org/maintainer/pull-requests.html?
Thanks,
Wei
Quoted 47 lines · Wei Hu
Hi Jakub,
Quoted 36 lines
-----Original Message-----
From: Jakub Kicinski <[email protected]>
Sent: Thursday, June 8, 2023 12:39 PM
To: Wei Hu <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]; Long Li <[email protected]>; Ajay Sharma <[email protected]>; [email protected]; [email protected]; KY Srinivasan <[email protected]>; Haiyang Zhang <[email protected]>; [email protected]; Dexuan Cui <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v2 1/1] RDMA/mana_ib: Add EQ interrupt support to mana ib driver.Quoted 7 lines · On Tue, 6 Jun 2023 15:17:47 +0000 Wei Hu wrote:
drivers/infiniband/hw/mana/cq.c | 32 ++++- drivers/infiniband/hw/mana/main.c | 87 ++++++++++++ drivers/infiniband/hw/mana/mana_ib.h | 4 + drivers/infiniband/hw/mana/qp.c | 90 +++++++++++- .../net/ethernet/microsoft/mana/gdma_main.c | 131 ++++++++++-------- drivers/net/ethernet/microsoft/mana/mana_en.c | 1 + include/net/mana/gdma.h | 9 +-IB and netdev are different subsystem, can you put it on a branch and send a PR as the cover letter so that both subsystems can pull?
Examples:
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.
kernel.org%2Fall%2F20230607210410.88209-1- saeed%40kernel.org%2F&data=05%7C01%7Cweh%40microsoft.com%7Cb672 4a9f672f47d433ef08db67da4ada%7C72f988bf86f141af91ab2d7cd011db47%7C 1%7C0%7C638217959538674174%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiM C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000 %7C%7C%7C&sdata=amO0W8QsR2I5INNNzCNOKEjrsYbzuZ92KXhNdfwSCHA %3D&reserved=0Quoted 8 lines
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.
kernel.org%2Fall%2F20230602171302.745492-1- anthony.l.nguyen%40intel.com%2F&data=05%7C01%7Cweh%40microsoft.co m%7Cb6724a9f672f47d433ef08db67da4ada%7C72f988bf86f141af91ab2d7cd0 11db47%7C1%7C0%7C638217959538674174%7CUnknown%7CTWFpbGZsb3d8 eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3 D%7C3000%7C%7C%7C&sdata=A%2BjjtSx%2FvY2T%2BNIEPGuftk%2BCr%2Fv Yt2Xc1q8B6h2tb6g%3D&reserved=0
Quoted 1 line
Thanks for you comment. I am new to the process. I have a few questions regarding to this and hope you can help. First of all, the patch is mostly for IB. Is it possible for the patch to just go through the RDMA branch, since most of the changes are in RDMA?
Yes, it can, we (RDMA) will handle it.
Thanks
Jakub Kicinski
maintainerQuoted 6 lines · On Mon, 12 Jun 2023 09:13:49 +0300 Leon Romanovsky wrote:
Quoted 4 lines
Thanks for you comment. I am new to the process. I have a few questions regarding to this and hope you can help. First of all, the patch is mostly for IB. Is it possible for the patch to just go through the RDMA branch, since most of the changes are in RDMA?
Yes, it can, we (RDMA) will handle it.
Probably, although it's better to teach them some process sooner rather than later?
Quoted 10 lines · Jakub Kicinski
Quoted 6 lines · On Mon, 12 Jun 2023 09:13:49 +0300 Leon Romanovsky wrote:
Quoted 4 lines
Thanks for you comment. I am new to the process. I have a few questions regarding to this and hope you can help. First of all, the patch is mostly for IB. Is it possible for the patch to just go through the RDMA branch, since most of the changes are in RDMA?
Yes, it can, we (RDMA) will handle it.
Probably, although it's better to teach them some process sooner rather than later?
I've been of the opinion the shared branch process is difficult - we took a long time to fine tune the process. If you don't fully understand how to do this with git you can make a real mess of it.
So I would say MS is welcome to use it if they can do it right, but I wouldn't push them to do so or expect they must to be successful. Really only Mellanox and Intel seem to have enough churn to justify it right now.
If they don't use shared branches then they must be responsible to avoid conflicts, even if that means they have to delay sending patches for a cycle.
Jason
Quoted 10 lines · Jakub Kicinski
Quoted 6 lines · On Mon, 12 Jun 2023 09:13:49 +0300 Leon Romanovsky wrote:
Quoted 4 lines
Thanks for you comment. I am new to the process. I have a few questions regarding to this and hope you can help. First of all, the patch is mostly for IB. Is it possible for the patch to just go through the RDMA branch, since most of the changes are in RDMA?
Yes, it can, we (RDMA) will handle it.
Probably, although it's better to teach them some process sooner rather than later?
Like Jason wrote above, shared branch is valuable once the submitter has enough volume to justify. In previous cycles, when we needed it, I simply created shared branch [1] for them.
Even we (Nvidia), who has enough patch volume, sometimes prefer to delay submission to next cycle and don't bother ourselves with shared branch.
[1] https://lore.kernel.org/all/Y2v2CGEWC70g+Ot+@unreal/
Thanks
Jakub Kicinski
maintainerQuoted 3 lines · On Mon, 12 Jun 2023 04:44:44 +0000 Wei Hu wrote:
If the patch also needs to go through the NETDEV branch, does it mean two subsystems will pull its own part? A few follow-up questions about generating a PR, since I have never done such before.
1. Which repo should I clone and create the branch from?
The main tree of Linus Torvalds. Check which tags are present in both netdev and rdma trees and use the newest common tag between the trees as a base.
Quoted 5 lines
2. From the example you provided, I see these people has their own branches on kernel.org, for example something like:
git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.gittags/mlx5-updates-2023-06-06.
I am not Linux maintainer. I just have repo on Github. How do I
create or fork on kernel.org? Do I need an account to do so? Or I can
use my own repo on Github?
GitHub is fine.
Quoted 2 lines
3. How to create PR in this case? Should I follow this link:
https://docs.kernel.org/maintainer/pull-requests.html?
Sort of. But still post the patches, so you'd want to use these commands somewhere along the way:
git format-patch [...] -o $path --cover-letter git request-pull [...] >> $path/0000-cover-letter.patch
Quoted 16 lines · Wei Hu
Add EQ interrupt support for mana ib driver. Allocate EQs per ucontext to receive interrupt. Attach EQ when CQ is created. Call CQ interrupt handler when completion interrupt happens. EQs are destroyed when ucontext is deallocated.
The change calls some public APIs in mana ethernet driver to allocate EQs and other resources. Ehe EQ process routine is also shared by mana ethernet and mana ib drivers.
Co-developed-by Ajay Sharma <[email protected]>Signed-off-by Ajay Sharma <[email protected]>Signed-off-by Wei Hu <[email protected]>---
v2: Use
ibdev_dbgto print error messages and return-ENOMEN
when kzalloc fails.
<...>
drivers/infiniband/hw/mana/cq.c int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) · line 89
Quoted 1 line
drivers/infiniband/hw/mana/cq.c +1
-0+if (atomic_read (&ibcq->usecnt) ==0 ) {
What exactly are you checking here? And in all places where you access ibcq->usecnt?
Quoted 6 lines
drivers/infiniband/hw/mana/cq.c +6
-0+mana_ib_gd_destroy_dma_region (mdev, cq->gdma_region); +ibdev_dbg (ibdev,"freeing gdma cq %p\n" , gc->cq_table[cq->id]); +kfree (gc->cq_table[cq->id]); + gc->cq_table[cq->id] =NULL ; +ib_umem_release (cq->umem); + }
drivers/infiniband/hw/mana/cq.c int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) · line 105
Quoted 10 lines
drivers/infiniband/hw/mana/cq.c +7
-0return 0 ; } + +void mana_ib_cq_handler (void *ctx,struct gdma_queue *gdma_cq) +{ +struct mana_ib_cq *cq = ctx; +struct ib_device *ibdev = cq->ibcq.device; + +ibdev_dbg (ibdev,"Enter %s %d\n" , __func__, __LINE__);
This patch has two many debug prints, most if not all should go.
Thanks
Wei Hu
maintainerQuoted 4 lines
-----Original Message-----
From: Leon Romanovsky <[email protected]>
Sent: Monday, June 12, 2023 2:19 AM
Quoted 9 lines
drivers/infiniband/hw/mana/cq.c int mana_ib_destroy_cq(struct ib_cq *ibcq, struct ib_udata *udata) · line 105
Quoted 6 lines
drivers/infiniband/hw/mana/cq.c +6
-0+ +void mana_ib_cq_handler (void *ctx,struct gdma_queue *gdma_cq) { +struct mana_ib_cq *cq = ctx; +struct ib_device *ibdev = cq->ibcq.device; + +ibdev_dbg (ibdev,"Enter %s %d\n" , __func__, __LINE__);This patch has two many debug prints, most if not all should go.
Thanks. I will remove the debug prints in the normal path.
Wei