net: sched: fix possible refcount leak in tc_chain_tmplt_add()
Subsystems (3)
PATCH v2 1/1 net: sched: fix possible refcount leak in tc_chain_tmplt_add()
try_module_get will be called in tcf_proto_lookup_ops. So module_put needs to be called to drop the refcount if ops don't implement the required function.
---
v2: fix the patch description.
net/sched/cls_api.c | 1 + 1 file changed, 1 insertion(+)
net/sched/cls_api.c +1 -0
@@ -2952,6 +2952,7 @@ static int tc_chain_tmplt_add(struct tcf_chain *chain, struct net *net,return PTR_ERR (ops);if (!ops->tmplt_create || !ops->tmplt_destroy || !ops->tmplt_dump) {NL_SET_ERR_MSG (extack,"Chain templates are not supported with specified classifier" ); +module_put (ops->owner);return -EOPNOTSUPP ; }
Signature · 1 line
2.34.1
Quoted 5 lines · Hangyu Hua
try_module_getwill be called intcf_proto_lookup_ops. Somodule_putneeds to be called to drop the refcount if ops don't implement the required function.Fixes 9f407f1768d3 ("net: sched: introduce chain templates")
Quoted 23 lines
Signed-off-by Hangyu Hua <[email protected]>---
v2: fix the patch description.
net/sched/cls_api.c | 1 + 1 file changed, 1 insertion(+)net/sched/cls_api.c +1
-0@@ -2952,6 +2952,7 @@ static int tc_chain_tmplt_add(struct tcf_chain *chain, struct net *net,return PTR_ERR (ops);if (!ops->tmplt_create || !ops->tmplt_destroy || !ops->tmplt_dump) {NL_SET_ERR_MSG (extack,"Chain templates are not supported with specified classifier" ); +module_put (ops->owner);return -EOPNOTSUPP ; }Signature · 1 line
2.34.1
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:
Quoted 8 lines · On Wed, 7 Jun 2023 10:23:01 +0800 you wrote:
try_module_getwill be called intcf_proto_lookup_ops. Somodule_putneeds to be called to drop the refcount if ops don't implement the required function.Fixes 9f407f1768d3 ("net: sched: introduce chain templates")Signed-off-by Hangyu Hua <[email protected]>[...]
Here is the summary with links:
- [net,v2] net: sched: fix possible refcount leak in tc_chain_tmplt_add()
https://git.kernel.org/netdev/net/c/44f8baaf230c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html