Skip to contentSkip to conversation

tpm: Check for availability of chip->ops before requesting locality

PATCH New Stefan Berger 1 participant 1 message Jun 7, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tpm: Check for availability of chip->ops before requesting locality

When executing kexec on ppc64 tpm_class_shutdown() is called before tpm_chip_unregister() and therefore chip->ops is NULL when tpm_amd_is_rng_defective() is called. Check for chip->ops before requesting the locality in tpm_amd_is_rng_defective() to avoid a crash.

Fixes bd8621ca1510 ("tpm: Add !tpm_amd_is_rng_defective() to the hwrng_unregister() call site")
---
 drivers/char/tpm/tpm-chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/tpm/tpm-chip.c +1 -1
index cd48033b804a..bc1ec1632fd8 100644
@@ -524,7 +524,7 @@ static bool tpm_amd_is_rng_defective(struct tpm_chip *chip)
 	u64 version;
 	int ret;
 
-	if (!(chip->flags & TPM_CHIP_FLAG_TPM2))
+	if (!chip->ops || !(chip->flags & TPM_CHIP_FLAG_TPM2))
 		return false;
 
 	ret = tpm_request_locality(chip);
Signature · 1 line
2.39.1