net/iavf: fix abnormal disable HW interrupt
PATCH 1/1 net/iavf: fix abnormal disable HW interrupt
For command VIRTCHNL_OP_REQUEST_QUEUES, polling access to the admin queue has the issue of access overruns after disabling interrupt. That results in FW disabling HW interrupt for protection purposes.
The updates/changes in this patch:
1. Remove the polling admin queue processing and use the generic interrupt processing instead.
2. Release redundant queue resource before stopping processing interrupt events.
--- drivers/net/iavf/iavf_ethdev.c | 25 +++++++++--------- drivers/net/iavf/iavf_vchnl.c | 48 +++++++--------------------------- 2 files changed, 23 insertions(+), 50 deletions(-)
drivers/net/iavf/iavf_ethdev.c +13 -12
@@ -2756,6 +2756,19 @@ iavf_dev_close(struct rte_eth_dev *dev) } ret =iavf_dev_stop (dev); + +/* +* Release redundant queue resource when close the dev +* so that other vfs can re-use the queues. +*/ +if (vf->lv_enabled) { + ret =iavf_request_queues (dev,IAVF_MAX_NUM_QUEUES_DFLT ); +if (ret) +PMD_DRV_LOG (ERR ,"Reset the num of queues failed" ); + + vf->max_rss_qregion =IAVF_MAX_NUM_QUEUES_DFLT ; + } + adapter->closed = true;/* free iAVF security device context all related resources */
@@ -2772,18 +2785,6 @@ iavf_dev_close(struct rte_eth_dev *dev)if (vf->promisc_unicast_enabled || vf->promisc_multicast_enabled)iavf_config_promisc (adapter, false, false); -/* -* Release redundant queue resource when close the dev -* so that other vfs can re-use the queues. -*/ -if (vf->lv_enabled) { - ret =iavf_request_queues (dev,IAVF_MAX_NUM_QUEUES_DFLT ); -if (ret) -PMD_DRV_LOG (ERR ,"Reset the num of queues failed" ); - - vf->max_rss_qregion =IAVF_MAX_NUM_QUEUES_DFLT ; - } -iavf_shutdown_adminq (hw);if (vf->vf_res->vf_cap_flags &VIRTCHNL_VF_OFFLOAD_WB_ON_ITR ) {/* disable uio intr before callback unregister */
drivers/net/iavf/iavf_vchnl.c +10 -38
82 lines not on this page · raw message
Signature · 1 line
2.25.1
Quoted 95 lines
-----Original Message-----
From: Mingjin Ye <[email protected]>
Sent: Thursday, June 8, 2023 2:23 PM
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Zhou, YidingX <[email protected]>; Ye, MingjinX <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: [PATCH] net/iavf: fix abnormal disable HW interruptFor command
VIRTCHNL_OP_REQUEST_QUEUES, polling access to the admin queue has the issue of access overruns after disabling interrupt. That results in FW disabling HW interrupt for protection purposes.The updates/changes in this patch:
1. Remove the polling admin queue processing and use the generic interrupt processing instead.
2. Release redundant queue resource before stopping processing interrupt events.Fixes 22b123a36d07 ("net/avf: initialize PMD")Fixes ef807926e148 ("net/iavf: support requesting additional queues fromPF")
Fixes 84108425054a ("net/iavf: support asynchronous virtual channelmessage")
Cc: [email protected]Signed-off-by Mingjin Ye <[email protected]>--- drivers/net/iavf/iavf_ethdev.c | 25 +++++++++--------- drivers/net/iavf/iavf_vchnl.c | 48 +++++++--------------------------- 2 files changed, 23 insertions(+), 50 deletions(-)drivers/net/iavf/iavf_ethdev.c +13
-0@@ -2756,6 +2756,19 @@ iavf_dev_close(struct rte_eth_dev *dev) } ret =iavf_dev_stop (dev); + +/* +* Release redundant queue resource when close the dev +* so that other vfs can re-use the queues. +*/ +if (vf->lv_enabled) { + ret =iavf_request_queues (dev,IAVF_MAX_NUM_QUEUES_DFLT ); +if (ret) +PMD_DRV_LOG (ERR ,"Reset the num of queues failed"); + + vf->max_rss_qregion =IAVF_MAX_NUM_QUEUES_DFLT ; + } + adapter->closed = true;/* free iAVF security device context all related resources */ @@ -
2772,18 +2785,6 @@iavf_dev_close(struct rte_eth_dev *dev)drivers/net/iavf/iavf_ethdev.c +0
-6if (vf->promisc_unicast_enabled || vf->promisc_multicast_enabled)iavf_config_promisc (adapter, false, false); -/* -* Release redundant queue resource when close the dev -* so that other vfs can re-use the queues. -*/ -if (vf->lv_enabled) { - ret = iavf_request_queues(dev,
IAVF_MAX_NUM_QUEUES_DFLT);drivers/net/iavf/iavf_ethdev.c +0
-2-if (ret) - PMD_DRV_LOG(ERR, "Reset the num of queuesfailed");
drivers/net/iavf/iavf_ethdev.c +0
-4- - vf->max_rss_qregion =IAVF_MAX_NUM_QUEUES_DFLT ; - } -iavf_shutdown_adminq (hw);if (vf->vf_res->vf_cap_flags &VIRTCHNL_VF_OFFLOAD_WB_ON_ITR ){
/* disable uio intr before callback unregister */ diff --gita/drivers/net/iavf/iavf_vchnl.cb/drivers/net/iavf/iavf_vchnl.cindex8cc5377bcf..579c0d0d70100644drivers/net/iavf/iavf_vchnl.c +1
-0@@ -323,6 +323,7 @@ iavf_execute_vf_cmd(struct iavf_adapter *adapter, struct iavf_cmd_info *args, switch (args->ops) {case VIRTCHNL_OP_RESET_VF : +case VIRTCHNL_OP_REQUEST_QUEUES :/*no need to wait for response */ _clear_cmd (vf);
Quoted 1 line
break;
Have you tested the "large VF" case ( > 16 queue) with this patch.
I assume event VIRTCHNL_EVENT_RESET_IMPENDING need to be handled here then to trigger a device reset. But I didn't see related part in your patch.
Quoted 104 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: 2023年6月9日 9:48
To: Ye, MingjinX <[email protected]>; [email protected]
Cc: Yang, Qiming <[email protected]>; Zhou, YidingX <[email protected]>; Ye, MingjinX <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interruptQuoted 11 lines
-----Original Message-----
From: Mingjin Ye <[email protected]>
Sent: Thursday, June 8, 2023 2:23 PM
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Zhou, YidingX <[email protected]>; Ye, MingjinX <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: [PATCH] net/iavf: fix abnormal disable HW interruptFor command
VIRTCHNL_OP_REQUEST_QUEUES, polling access to theadmin
Quoted 63 lines
queue has the issue of access overruns after disabling interrupt. That results in FW disabling HW interrupt for protection purposes.
The updates/changes in this patch:
1. Remove the polling admin queue processing and use the generic interrupt processing instead.
2. Release redundant queue resource before stopping processing interrupt events.Fixes 22b123a36d07 ("net/avf: initialize PMD")Fixes ef807926e148 ("net/iavf: support requesting additional queuesfrom
PF")Fixes 84108425054a ("net/iavf: support asynchronous virtual channelmessage")
Cc: [email protected]Signed-off-by Mingjin Ye <[email protected]>--- drivers/net/iavf/iavf_ethdev.c | 25 +++++++++--------- drivers/net/iavf/iavf_vchnl.c | 48 +++++++--------------------------- 2 files changed, 23 insertions(+), 50 deletions(-)(quoted diff) +0
-0
b/drivers/net/iavf/iavf_ethdev.cindexe6cf897293..ba5c88a1ec100644drivers/net/iavf/iavf_ethdev.c +13
-0@@ -2756,6 +2756,19 @@ iavf_dev_close(struct rte_eth_dev *dev) } ret =iavf_dev_stop (dev); + +/* +* Release redundant queue resource when close the dev +* so that other vfs can re-use the queues. +*/ +if (vf->lv_enabled) { + ret =iavf_request_queues (dev,IAVF_MAX_NUM_QUEUES_DFLT ); +if (ret) +PMD_DRV_LOG (ERR ,"Reset the num of queues failed"); + + vf->max_rss_qregion =IAVF_MAX_NUM_QUEUES_DFLT ; + } + adapter->closed = true;/* free iAVF security device context all related resources */ @@ -
2772,18 +2785,6 @@iavf_dev_close(struct rte_eth_dev *dev)drivers/net/iavf/iavf_ethdev.c +0
-6if (vf->promisc_unicast_enabled || vf->promisc_multicast_enabled)iavf_config_promisc (adapter, false, false); -/* -* Release redundant queue resource when close the dev -* so that other vfs can re-use the queues. -*/ -if (vf->lv_enabled) { - ret = iavf_request_queues(dev,
IAVF_MAX_NUM_QUEUES_DFLT);drivers/net/iavf/iavf_ethdev.c +0
-2-if (ret) - PMD_DRV_LOG(ERR, "Reset the num of queuesfailed");
drivers/net/iavf/iavf_ethdev.c iavf_dev_close(struct rte_eth_dev *dev)
Quoted 6 lines
drivers/net/iavf/iavf_ethdev.c +0
-4- - vf->max_rss_qregion =IAVF_MAX_NUM_QUEUES_DFLT ; - } -iavf_shutdown_adminq (hw);if (vf->vf_res->vf_cap_flags &VIRTCHNL_VF_OFFLOAD_WB_ON_ITR ){
Quoted 8 lines
/* disable uio intr before callback unregister */ diff --git
a/drivers/net/iavf/iavf_vchnl.cb/drivers/net/iavf/iavf_vchnl.cindex8cc5377bcf..579c0d0d70100644drivers/net/iavf/iavf_vchnl.c +0
-0@@ -323,6 +323,7 @@ iavf_execute_vf_cmd(struct iavf_adapter *adapter, struct iavf_cmd_info *args,
Quoted 11 lines
Quoted 6 lines
drivers/net/iavf/iavf_vchnl.c +1
-0switch (args->ops) {case VIRTCHNL_OP_RESET_VF : +case VIRTCHNL_OP_REQUEST_QUEUES :/*no need to wait for response */ _clear_cmd (vf);break;
Have you tested the "large VF" case ( > 16 queue) with this patch. I assume event
VIRTCHNL_EVENT_RESET_IMPENDINGneed to be handled here then to trigger a device reset.
But I didn't see related part in your patch.
The processing related to the "big VF" is moved before "adapter->closed = true;"
to make sure it can be handled correctly by the interrupt function.
Quoted 125 lines
-----Original Message-----
From: Ye, MingjinX <[email protected]>
Sent: Friday, June 9, 2023 11:20 AM
To: Zhang, Qi Z <[email protected]>; [email protected]
Cc: Yang, Qiming <[email protected]>; Zhou, YidingX <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interruptQuoted 112 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: 2023年6月9日 9:48
To: Ye, MingjinX <[email protected]>; [email protected]
Cc: Yang, Qiming <[email protected]>; Zhou, YidingX <[email protected]>; Ye, MingjinX <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interruptQuoted 11 lines
-----Original Message-----
From: Mingjin Ye <[email protected]>
Sent: Thursday, June 8, 2023 2:23 PM
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Zhou, YidingX <[email protected]>; Ye, MingjinX <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: [PATCH] net/iavf: fix abnormal disable HW interruptFor command
VIRTCHNL_OP_REQUEST_QUEUES, polling access to theadmin
Quoted 64 lines
queue has the issue of access overruns after disabling interrupt. That results in FW disabling HW interrupt for protection purposes.
The updates/changes in this patch:
1. Remove the polling admin queue processing and use the generic interrupt processing instead.
2. Release redundant queue resource before stopping processing interrupt events.Fixes 22b123a36d07 ("net/avf: initialize PMD")Fixes ef807926e148 ("net/iavf: support requesting additional queuesfrom
PF")Fixes 84108425054a ("net/iavf: support asynchronous virtual channelmessage")
Cc: [email protected]Signed-off-by Mingjin Ye <[email protected]>--- drivers/net/iavf/iavf_ethdev.c | 25 +++++++++--------- drivers/net/iavf/iavf_vchnl.c | 48 +++++++--------------------------- 2 files changed, 23 insertions(+), 50 deletions(-)(quoted diff) +0
-0
b/drivers/net/iavf/iavf_ethdev.cindexe6cf897293..ba5c88a1ec100644drivers/net/iavf/iavf_ethdev.c +13
-0@@ -2756,6 +2756,19 @@ iavf_dev_close(struct rte_eth_dev *dev) } ret =iavf_dev_stop (dev); + +/* +* Release redundant queue resource when close the dev +* so that other vfs can re-use the queues. +*/ +if (vf->lv_enabled) { + ret =iavf_request_queues (dev,IAVF_MAX_NUM_QUEUES_DFLT ); +if (ret) +PMD_DRV_LOG (ERR ,"Reset the num of queues failed"); + + vf->max_rss_qregion =IAVF_MAX_NUM_QUEUES_DFLT ; + } + adapter->closed = true;/* free iAVF security device context all related resources */ @@ -
2772,18 +2785,6 @@iavf_dev_close(struct rte_eth_dev *dev)drivers/net/iavf/iavf_ethdev.c +0
-6if (vf->promisc_unicast_enabled || vf->promisc_multicast_enabled)iavf_config_promisc (adapter, false, false); -/* -* Release redundant queue resource when close the dev -* so that other vfs can re-use the queues. -*/ -if (vf->lv_enabled) { - ret = iavf_request_queues(dev,
IAVF_MAX_NUM_QUEUES_DFLT);drivers/net/iavf/iavf_ethdev.c +0
-2-if (ret) - PMD_DRV_LOG(ERR, "Reset the num of queuesfailed");
drivers/net/iavf/iavf_ethdev.c iavf_dev_close(struct rte_eth_dev *dev)
Quoted 6 lines
drivers/net/iavf/iavf_ethdev.c +0
-4- - vf->max_rss_qregion =IAVF_MAX_NUM_QUEUES_DFLT ; - } -iavf_shutdown_adminq (hw);if (vf->vf_res->vf_cap_flags &VIRTCHNL_VF_OFFLOAD_WB_ON_ITR ){
Quoted 14 lines
/* disable uio intr before callback unregister */ diff --git
a/drivers/net/iavf/iavf_vchnl.cb/drivers/net/iavf/iavf_vchnl.cindex8cc5377bcf..579c0d0d70100644drivers/net/iavf/iavf_vchnl.c +1
-0@@ -323,6 +323,7 @@ iavf_execute_vf_cmd(struct iavf_adapter *adapter, struct iavf_cmd_info *args, switch (args->ops) {case VIRTCHNL_OP_RESET_VF : +case VIRTCHNL_OP_REQUEST_QUEUES :/*no need to wait for response */ _clear_cmd (vf);Quoted 1 line
break;
Have you tested the "large VF" case ( > 16 queue) with this patch.
You didn't answer my question.
Quoted 9 lines
Quoted 1 line
I assume event
VIRTCHNL_EVENT_RESET_IMPENDINGneed to be handledhere
Quoted 2 lines
then to trigger a device reset.
But I didn't see related part in your patch.The processing related to the "big VF" is moved before "
adapter->closed= true;"
to make sure it can be handled correctly by the interrupt function.
I'm not asking what happened during dev_close but the init scenario in the large VF case,
dev_configure-> iavf_queues_req_reset-> iavf_request_queues
this happens at the situation that is no interrupt is enabled and it need to handle event VIRTCHNL_EVENT_RESET_IMPENDING
Quoted 152 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: Monday, June 12, 2023 8:40 PM
To: Ye, MingjinX <[email protected]>; [email protected]
Cc: Yang, Qiming <[email protected]>; Zhou, YidingX <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interruptQuoted 126 lines
-----Original Message-----
From: Ye, MingjinX <[email protected]>
Sent: Friday, June 9, 2023 11:20 AM
To: Zhang, Qi Z <[email protected]>; [email protected]
Cc: Yang, Qiming <[email protected]>; Zhou, YidingX <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interruptQuoted 115 lines
-----Original Message-----
From: Zhang, Qi Z <[email protected]>
Sent: 2023年6月9日 9:48
To: Ye, MingjinX <[email protected]>; [email protected]
Cc: Yang, Qiming <[email protected]>; Zhou, YidingX <[email protected]>; Ye, MingjinX <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interruptQuoted 11 lines
-----Original Message-----
From: Mingjin Ye <[email protected]>
Sent: Thursday, June 8, 2023 2:23 PM
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Zhou, YidingX <[email protected]>; Ye, MingjinX <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: [PATCH] net/iavf: fix abnormal disable HW interruptFor command
VIRTCHNL_OP_REQUEST_QUEUES, polling access to theadmin
Quoted 67 lines
queue has the issue of access overruns after disabling interrupt. That results in FW disabling HW interrupt for protection purposes.
The updates/changes in this patch:
1. Remove the polling admin queue processing and use the generic interrupt processing instead.
2. Release redundant queue resource before stopping processing interrupt events.Fixes 22b123a36d07 ("net/avf: initialize PMD")Fixes ef807926e148 ("net/iavf: support requesting additionalqueues from
PF")Fixes 84108425054a ("net/iavf: support asynchronous virtualchannel
message")
Cc: [email protected]Signed-off-by Mingjin Ye <[email protected]>--- drivers/net/iavf/iavf_ethdev.c | 25 +++++++++--------- drivers/net/iavf/iavf_vchnl.c | 48 +++++++--------------------------- 2 files changed, 23 insertions(+), 50 deletions(-)(quoted diff) +0
-0
b/drivers/net/iavf/iavf_ethdev.cindexe6cf897293..ba5c88a1ec100644drivers/net/iavf/iavf_ethdev.c +13
-0@@ -2756,6 +2756,19 @@ iavf_dev_close(struct rte_eth_dev *dev) } ret =iavf_dev_stop (dev); + +/* +* Release redundant queue resource when close the dev +* so that other vfs can re-use the queues. +*/ +if (vf->lv_enabled) { + ret =iavf_request_queues (dev,IAVF_MAX_NUM_QUEUES_DFLT ); +if (ret) +PMD_DRV_LOG (ERR ,"Reset the num of queues failed"); + + vf->max_rss_qregion =IAVF_MAX_NUM_QUEUES_DFLT ; + } + adapter->closed = true;drivers/net/iavf/iavf_ethdev.c +0
-1/* free iAVF security device context all related resources */ @@ -2772,18 +2785,6 @@
iavf_dev_close(struct rte_eth_dev *dev)drivers/net/iavf/iavf_ethdev.c +0
-6if (vf->promisc_unicast_enabled || vf->promisc_multicast_enabled)iavf_config_promisc (adapter, false, false); -/* -* Release redundant queue resource when close the dev -* so that other vfs can re-use the queues. -*/ -if (vf->lv_enabled) { - ret = iavf_request_queues(dev,
IAVF_MAX_NUM_QUEUES_DFLT);drivers/net/iavf/iavf_ethdev.c +0
-2-if (ret) - PMD_DRV_LOG(ERR, "Reset the num of queuesfailed");
drivers/net/iavf/iavf_ethdev.c iavf_dev_close(struct rte_eth_dev *dev)
Quoted 6 lines
drivers/net/iavf/iavf_ethdev.c +0
-4- - vf->max_rss_qregion =IAVF_MAX_NUM_QUEUES_DFLT ; - } -iavf_shutdown_adminq (hw);if (vf->vf_res->vf_cap_flags &VIRTCHNL_VF_OFFLOAD_WB_ON_ITR ){
Quoted 14 lines
/* disable uio intr before callback unregister */ diff --git
a/drivers/net/iavf/iavf_vchnl.cb/drivers/net/iavf/iavf_vchnl.cindex8cc5377bcf..579c0d0d70100644drivers/net/iavf/iavf_vchnl.c +1
-0@@ -323,6 +323,7 @@ iavf_execute_vf_cmd(struct iavf_adapter *adapter, struct iavf_cmd_info *args, switch (args->ops) {case VIRTCHNL_OP_RESET_VF : +case VIRTCHNL_OP_REQUEST_QUEUES :/*no need to wait for response */ _clear_cmd (vf);Quoted 1 line
break;
Have you tested the "large VF" case ( > 16 queue) with this patch.
You didn't answer my question.
Quoted 9 lines
Quoted 1 line
I assume event
VIRTCHNL_EVENT_RESET_IMPENDINGneed to be handledhere
Quoted 2 lines
then to trigger a device reset.
But I didn't see related part in your patch.The processing related to the "big VF" is moved before "
adapter->closed= true;"
to make sure it can be handled correctly by the interrupt function.
Quoted 8 lines
I'm not asking what happened during
dev_closebut the init scenario in the large VF case,dev_configure-> iavf_queues_req_reset->
iavf_request_queuesthis happens at the situation that is no interrupt is enabled and it need to handle event
VIRTCHNL_EVENT_RESET_IMPENDING
This is not correct, as the interrupt has already been enabled in dev_init.
But I still have question for other part of the implementation, will raise it in another thread.
PATCH v2 1/1 net/iavf: fix abnormal disable HW interrupt
In reply to Mingjin YeFor command VIRTCHNL_OP_REQUEST_QUEUES, polling access to the admin queue has the issue of access overruns after disabling interrupt. That results in FW disabling HW interrupt for protection purposes.
The updates/changes in this patch:
1. Remove the polling admin queue processing and use the generic interrupt processing instead.
2. Release redundant queue resource before stopping processing interrupt events.
---
v2: Fix git version conflict.
--- drivers/net/iavf/iavf_ethdev.c | 25 +++++++++--------- drivers/net/iavf/iavf_vchnl.c | 48 +++++++--------------------------- 2 files changed, 23 insertions(+), 50 deletions(-)
drivers/net/iavf/iavf_ethdev.c +13 -12
@@ -2757,6 +2757,19 @@ iavf_dev_close(struct rte_eth_dev *dev) } ret =iavf_dev_stop (dev); + +/* +* Release redundant queue resource when close the dev +* so that other vfs can re-use the queues. +*/ +if (vf->lv_enabled) { + ret =iavf_request_queues (dev,IAVF_MAX_NUM_QUEUES_DFLT ); +if (ret) +PMD_DRV_LOG (ERR ,"Reset the num of queues failed" ); + + vf->max_rss_qregion =IAVF_MAX_NUM_QUEUES_DFLT ; + } + adapter->closed = true;/* free iAVF security device context all related resources */
@@ -2773,18 +2786,6 @@ iavf_dev_close(struct rte_eth_dev *dev)if (vf->promisc_unicast_enabled || vf->promisc_multicast_enabled)iavf_config_promisc (adapter, false, false); -/* -* Release redundant queue resource when close the dev -* so that other vfs can re-use the queues. -*/ -if (vf->lv_enabled) { - ret =iavf_request_queues (dev,IAVF_MAX_NUM_QUEUES_DFLT ); -if (ret) -PMD_DRV_LOG (ERR ,"Reset the num of queues failed" ); - - vf->max_rss_qregion =IAVF_MAX_NUM_QUEUES_DFLT ; - } -iavf_shutdown_adminq (hw);if (vf->vf_res->vf_cap_flags &VIRTCHNL_VF_OFFLOAD_WB_ON_ITR ) {/* disable uio intr before callback unregister */
drivers/net/iavf/iavf_vchnl.c +10 -38
82 lines not on this page · raw message
Signature · 1 line
2.25.1
Quoted 22 lines
-----Original Message-----
From: Mingjin Ye <[email protected]>
Sent: Wednesday, June 14, 2023 5:53 PM
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Zhou, YidingX <[email protected]>; Ye, MingjinX <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>
Subject: [PATCH v2] net/iavf: fix abnormal disable HW interruptFor command
VIRTCHNL_OP_REQUEST_QUEUES, polling access to the admin queue has the issue of access overruns after disabling interrupt. That results in FW disabling HW interrupt for protection purposes.The updates/changes in this patch:
1. Remove the polling admin queue processing and use the generic interrupt processing instead.
2. Release redundant queue resource before stopping processing interrupt events.
Quoted 8 lines
Fixes 22b123a36d07 ("net/avf: initialize PMD")Fixes ef807926e148 ("net/iavf: support requesting additional queues fromPF")
Fixes 84108425054a ("net/iavf: support asynchronous virtual channelmessage")
Cc: [email protected]Signed-off-by Mingjin Ye <[email protected]>
Applied to dpdk-next-net-intel.
Thanks
Qi