Skip to contentSkip to conversation

net: hv_netvsc: Remove duplicated include in rndis_filter.c

PATCH In review Yang Li 2 participants 2 messages Jun 8, 2023

Subsystems (4)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 net: hv_netvsc: Remove duplicated include in rndis_filter.c

./drivers/net/hyperv/rndis_filter.c: linux/slab.h is included more than once.

Fixes 4cab498f33f7 ("hv_netvsc: Allocate rx indirection table size dynamically")
---
 drivers/net/hyperv/rndis_filter.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/hyperv/rndis_filter.c +0 -1
index af95947a87c5..ecc2128ca9b7 100644
@@ -21,7 +21,6 @@
 #include <linux/rtnetlink.h>
 #include <linux/ucs2_string.h>
 #include <linux/string.h>
-#include <linux/slab.h>
 
 #include "hyperv_net.h"
 #include "netvsc_trace.h"
Signature · 1 line
2.20.1.7.g153144c
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Yang Li

./drivers/net/hyperv/rndis_filter.c: linux/slab.h is included more than once.

Fixes 4cab498f33f7 ("hv_netvsc: Allocate rx indirection table size dynamically")

Hi Yang Li,

A few nits from my side;

1. The subject should include the target tree, in this case net-next.

	[PATCH net-next] ...

2. I don't think this needs a fixes tag: nothing was broken

I'm not sure this warrants a v2.
If you do decide to post a v2, please allow for 24h since v1 was posted.

Lastly, I think at least one other similar change has been posted recently. Please consider batching up such changes, say in groups of 10 patches, and posting them as a patch-set.

The change itself seems fine to me.

Quoted 20 lines
---
 drivers/net/hyperv/rndis_filter.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/hyperv/rndis_filter.c +0 -1
index af95947a87c5..ecc2128ca9b7 100644
@@ -21,7 +21,6 @@
 #include <linux/rtnetlink.h>
 #include <linux/ucs2_string.h>
 #include <linux/string.h>
-#include <linux/slab.h>
 
 #include "hyperv_net.h"
 #include "netvsc_trace.h"
Signature · 1 line
2.20.1.7.g153144c