powerpc/build: vdso linker warning for orphan sections
Nicholas Piggin
reviewerPATCH 1/1 powerpc/build: vdso linker warning for orphan sections
Add --orphan-handlin for vdsos, and adjust vdso linker scripts to deal with orphan sections.
--- arch/powerpc/kernel/vdso/Makefile | 2 ++ arch/powerpc/kernel/vdso/vdso32.lds.S | 4 +++- arch/powerpc/kernel/vdso/vdso64.lds.S | 4 +++- 3 files changed, 8 insertions(+), 2 deletions(-)
arch/powerpc/kernel/vdso/Makefile +2 -0
@@ -56,6 +56,8 @@ KCSAN_SANITIZE := n ccflags-y := -fno-common -fno-builtin ldflags-y := -Wl,--hash-style=both -nostdlib -shared -z noexecstack ldflags-$(CONFIG_LD_IS_LLD) += $(call cc-option,--ld-path=$(LD),-fuse-ld=lld) +ldflags-$(CONFIG_LD_ORPHAN_WARN) += -Wl,--orphan-handling=$(CONFIG_LD_ORPHAN_WARN_LEVEL) + # Filter flags that clang will warn are unused for linking ldflags-y += $(filter-out $(CC_AUTO_VAR_INIT_ZERO_ENABLER) $(CC_FLAGS_FTRACE) -Wa$(comma)%, $(KBUILD_CFLAGS))
arch/powerpc/kernel/vdso/vdso32.lds.S +3 -1
@@ -83,9 +83,11 @@ SECTIONS /DISCARD/ : { *(.note.GNU-stack) + *(*.EMB.apuinfo) + *(.branch_lt) *(.data .data.* .gnu.linkonce.d.* .sdata*) *(.bss .sbss .dynbss .dynsbss) - *(.got1) + *(.got1 .glink .iplt .rela*) } }
arch/powerpc/kernel/vdso/vdso64.lds.S +3 -1
@@ -32,7 +32,7 @@ SECTIONS . = ALIGN(16); .text : { *(.text .stub .text.* .gnu.linkonce.t.* __ftr_alt_*) - *(.sfpr .glink) + *(.sfpr) } :text PROVIDE(__etext = .); PROVIDE(_etext = .);
@@ -81,10 +81,12 @@ SECTIONS /DISCARD/ : { *(.note.GNU-stack) + *(*.EMB.apuinfo) *(.branch_lt) *(.data .data.* .gnu.linkonce.d.* .sdata*) *(.bss .sbss .dynbss .dynsbss) *(.opd) + *(.glink .iplt .plt .rela*) } }
Signature · 1 line
2.40.1
Michael Ellerman
AppliedQuoted 4 lines · Nicholas Piggin
Add --orphan-handlin for vdsos, and adjust vdso linker scripts to deal with orphan sections.
Applied to powerpc/next.
[1/1] powerpc/build: vdso linker warning for orphan sections
https://git.kernel.org/powerpc/c/8ad57add77d352102ba9edd500b00bc851c2e261
cheers
Hi Nicholas,
Quoted 2 lines · Nicholas Piggin
Add --orphan-handlin for vdsos, and adjust vdso linker scripts to deal with orphan sections.
I'm reporting that I am getting a linker warning with 6.5-rc2. The warning message is:
ld: warning: discarding dynamic section .rela.opd
and bisects to:
8ad57add77d3 ("powerpc/build: vdso linker warning for orphan sections")
Despite the warning, my ppc64 system seems to run fine. Let me know if you need any other information from me.
I noticed [0] this with 6.5-rc1 but didn't contact the right people.
John Ogness
Michael Ellerman
reviewerQuoted 9 lines · John Ogness
Hi Nicholas,
Quoted 2 lines · Nicholas Piggin
Add --orphan-handlin for vdsos, and adjust vdso linker scripts to deal with orphan sections.
I'm reporting that I am getting a linker warning with 6.5-rc2. The warning message is:
Quoted 8 lines
ld: warning: discarding dynamic section .rela.opd
and bisects to:
8ad57add77d3("powerpc/build: vdso linker warning for orphan sections")Despite the warning, my ppc64 system seems to run fine. Let me know if you need any other information from me.
We already discard .opd and .rela*, so I guess we should also be discarding .rela.opd.
Can you test with a newer compiler/binutils?
cheers
Quoted 7 lines · Michael Ellerman
Quoted 5 lines
ld: warning: discarding dynamic section .rela.opd
and bisects to:
8ad57add77d3("powerpc/build: vdso linker warning for orphan sections")Can you test with a newer compiler/binutils?
Testing the Debian release cross compilers/binutils:
Debian 10 / gcc 8.3.0 / ld 2.31.1: generates the warning
Debian 11 / gcc 10.2.1 / ld 2.35.2: generates the warning
Debian 12 / gcc 12.2.0 / ld 2.40: does _not_ generate the warning
I suppose moving to the newer toolchain is the workaround. Although it is a bit unusual to require such a modern toolchain in order to build a kernel without warnings.
John Ogness
Michael Ellerman
reviewerQuoted 13 lines · John Ogness
Quoted 7 lines · Michael Ellerman
Quoted 5 lines
ld: warning: discarding dynamic section .rela.opd
and bisects to:
8ad57add77d3("powerpc/build: vdso linker warning for orphan sections")Can you test with a newer compiler/binutils?
Testing the Debian release cross compilers/binutils:
Debian 10 / gcc 8.3.0 / ld 2.31.1: generates the warning
Quoted 7 lines
Debian 11 / gcc 10.2.1 / ld 2.35.2: generates the warning
Debian 12 / gcc 12.2.0 / ld 2.40: does _not_ generate the warning
I suppose moving to the newer toolchain is the workaround. Although it is a bit unusual to require such a modern toolchain in order to build a kernel without warnings.
I didn't mean that you should move to a new toolchain to avoid the warning, I was just curious why you're the only person to see it.
I regularly test with a gcc 5.5.0 / ld 2.29 toolchain and gcc 13.1.1 / ld 2.39, and I haven't seen the warning. I tried a bunch of others and can't reproduce it.
Can you confirm that this makes the warning go away?
cheers
arch/powerpc/kernel/vdso/vdso64.lds.S +1 -1
@@ -85,7 +85,7 @@ SECTIONS *(.branch_lt) *(.data .data.* .gnu.linkonce.d.* .sdata*) *(.bss .sbss .dynbss .dynsbss) - *(.opd) + *(.opd .rela.opd) *(.glink .iplt .plt .rela*) } }
Hi Michael,
Quoted 3 lines · Michael Ellerman
I regularly test with a gcc 5.5.0 / ld 2.29 toolchain and gcc 13.1.1 / ld 2.39, and I haven't seen the warning. I tried a bunch of others and can't reproduce it.
I will send my config in a separate email (without the lists in CC). Building the vdso_prepare target is all that is needed.
arch/powerpc/kernel/vdso/vdso64.lds.S SECTIONS · line 89
Quoted 13 lines
Can you confirm that this makes the warning go away?
arch/powerpc/kernel/vdso/vdso64.lds.S +1
-1@@ -85,7 +85,7 @@ SECTIONS *(.branch_lt) *(.data .data.* .gnu.linkonce.d.* .sdata*) *(.bss .sbss .dynbss .dynsbss) - *(.opd) + *(.opd .rela.opd) *(.glink .iplt .plt .rela*)
Hmmm. Not sure what that would change. And indeed it does not make the warning go away.
Doing some testing it seems that previously .rela.opd was being silently placed in the .rela.dyn section. So doing that explicitly obviously gets rid of the warning:
arch/powerpc/kernel/vdso/vdso64.lds.S +1 -1
@@ -69,7 +69,7 @@ SECTIONS .eh_frame_hdr : { *(.eh_frame_hdr) } :text :eh_frame_hdr .eh_frame : { KEEP (*(.eh_frame)) } :text .gcc_except_table : { *(.gcc_except_table) } - .rela.dyn ALIGN(8) : { *(.rela.dyn) } + .rela.dyn ALIGN(8) : { *(.rela.dyn) *(.rela.opd) } .got ALIGN(8) : { *(.got .toc) }
But if the goal is to get rid of .rela.opd then the question is: why is the linker complaining about it being discarded?
John