phy: tegra: xusb: Clear the driver reference in usb-phy dev
PATCH v3 1/1 phy: tegra: xusb: Clear the driver reference in usb-phy dev
From: EJ Hsu <[email protected]>
For the dual-role port, it will assign the phy dev to usb-phy dev and use the port dev driver as the dev driver of usb-phy.
When we try to destroy the port dev, it will destroy its dev driver as well. But we did not remove the reference from usb-phy dev. This might cause the use-after-free issue in KASAN.
---
V1 -> V2: Remove extra movements to clarify the change V2 -> V3: Update patch title
--- drivers/phy/tegra/xusb.c | 1 + 1 file changed, 1 insertion(+)
drivers/phy/tegra/xusb.c +1 -0
@@ -568,6 +568,7 @@ static void tegra_xusb_port_unregister(struct tegra_xusb_port *port)usb_role_switch_unregister (port->usb_role_sw);cancel_work_sync (&port->usb_phy_work);usb_remove_phy (&port->usb_phy); + port->usb_phy.dev->driver =NULL ; }if (port->ops->remove)
Signature · 1 line
2.25.1
Jon Hunter
maintainerHi Vinod,
Quoted 28 lines · Haotien Hsu
From: EJ Hsu <[email protected]>
For the dual-role port, it will assign the phy dev to usb-phy dev and use the port dev driver as the dev driver of usb-phy.
When we try to destroy the port dev, it will destroy its dev driver as well. But we did not remove the reference from usb-phy dev. This might cause the use-after-free issue in KASAN.
Fixes e8f7d2f409a1 ("phy: tegra: xusb: Add usb-phy support")Signed-off-by EJ Hsu <[email protected]>Signed-off-by Haotien Hsu <[email protected]>Acked-by Thierry Reding <[email protected]>Acked-by Jon Hunter <[email protected]>---
V1 -> V2: Remove extra movements to clarify the change V2 -> V3: Update patch title--- drivers/phy/tegra/xusb.c | 1 + 1 file changed, 1 insertion(+)drivers/phy/tegra/xusb.c +0
-0
drivers/phy/tegra/xusb.c static void tegra_xusb_port_unregister(struct tegra_xusb_port *port) · line 574
Quoted 7 lines
drivers/phy/tegra/xusb.c +1
-0@@ -568,6 +568,7 @@ static void tegra_xusb_port_unregister(struct tegra_xusb_port *port)usb_role_switch_unregister (port->usb_role_sw);cancel_work_sync (&port->usb_phy_work);usb_remove_phy (&port->usb_phy); + port->usb_phy.dev->driver =NULL ; }if (port->ops->remove)
OK to pick this up now?
Thanks
Jon
Signature · 6 lines
nvpublic -- linux-phy mailing list [email protected] https://lists.infradead.org/mailman/listinfo/linux-phy
Quoted 8 lines · Haotien Hsu
From: EJ Hsu <[email protected]>
For the dual-role port, it will assign the phy dev to usb-phy dev and use the port dev driver as the dev driver of usb-phy.
When we try to destroy the port dev, it will destroy its dev driver as well. But we did not remove the reference from usb-phy dev. This might cause the use-after-free issue in KASAN.
Applied, thanks
Signature · 1 line
~Vinod