Rid W=1 warnings from GPU
Subsystems (11)
cover Rid W=1 warnings from GPU
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings.
Lee Jones (15):
drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp drm/xlnx/zynqmp_dp: Fix function name zynqmp_dp_link_train() ->
zynqmp_dp_train()
drm/vkms/vkms_composer: Fix a few different kerneldoc formatting drm/mediatek/mtk_disp_aal: Remove half completed incorrect struct
header
drm/mediatek/mtk_disp_ccorr: Remove half completed incorrect struct
header
drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc' drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse drm/nouveau/nvkm/engine/gr/tu102: Staticify local function
gf100_fifo_nonstall_block()
drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move SYNAPTICS_DEVICE_ID
into CONFIG_DRM_AMD_DC_DCN ifdef
drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses
drm/nouveau/nvkm/engine/gr/tu102: Completely remove unused function
‘tu102_gr_load’ drm/radeon/radeon_ttm: Remove unused variable 'rbo' from
radeon_bo_move()
drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function
headers
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 +- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 6 +- drivers/gpu/drm/mediatek/mtk_disp_aal.c | 5 - drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 5 - drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 +- .../gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +- .../gpu/drm/nouveau/nvkm/engine/gr/tu102.c | 13 -- .../gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +- .../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++--------- .../gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 +- drivers/gpu/drm/radeon/radeon_ttm.c | 2 - drivers/gpu/drm/vkms/vkms_composer.c | 6 +- drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +- drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- 14 files changed, 89 insertions(+), 113 deletions(-)
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
PATCH RESEND 1/15 drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp' drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp' drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'audio' not described in 'zynqmp_disp'
--- drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/xlnx/zynqmp_disp.c +3 -3
@@ -128,9 +128,9 @@ struct zynqmp_disp_layer {* struct zynqmp_disp - Display controller * @dev: Device structure * @dpsub: Display subsystem -* @blend.base: Register I/O base address for the blender -* @avbuf.base: Register I/O base address for the audio/video buffer manager -* @audio.base: Registers I/O base address for the audio mixer +* @blend: .base: Register I/O base address for the blender +* @avbuf: .base: Register I/O base address for the audio/video buffer manager +* @audio: .base: Registers I/O base address for the audio mixer * @layers: Layers (planes) */ struct zynqmp_disp {
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
PATCH RESEND 2/15 drm/xlnx/zynqmp_dp: Fix function name zynqmp_dp_link_train() -> zynqmp_dp_train()
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/gpu/drm/xlnx/zynqmp_dp.c:793: warning: expecting prototype for zynqmp_dp_link_train(). Prototype was for zynqmp_dp_train() instead
--- drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/xlnx/zynqmp_dp.c +1 -1
@@ -784,7 +784,7 @@ static int zynqmp_dp_link_train_ce(struct zynqmp_dp *dp) }/** -* zynqmp_dp_link_train - Train the link +* zynqmp_dp_train - Train the link * @dp: DisplayPort IP core structure * * Return: 0 if all trains are done successfully, or corresponding error code.
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
PATCH RESEND 3/15 drm/vkms/vkms_composer: Fix a few different kerneldoc formatting
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/gpu/drm/vkms/vkms_composer.c:41: warning: Function parameter or member 'frame_info' not described in 'pre_mul_alpha_blend' drivers/gpu/drm/vkms/vkms_composer.c:41: warning: Excess function parameter 'src_frame_info' description in 'pre_mul_alpha_blend' drivers/gpu/drm/vkms/vkms_composer.c:72: warning: Cannot understand * @wb_frame_info: The writeback frame buffer metadata
--- drivers/gpu/drm/vkms/vkms_composer.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/vkms/vkms_composer.c +4 -2
@@ -23,7 +23,7 @@ static u16 pre_mul_blend_channel(u16 src, u16 dst, u16 alpha)/** * pre_mul_alpha_blend - alpha blending equation -* @src_frame_info: source framebuffer's metadata +* @frame_info: source framebuffer's metadata * @stage_buffer: The line with the pixels from src_plane * @output_buffer: A line buffer that receives all the blends output *
@@ -90,11 +90,13 @@ static void fill_background(const struct pixel_argb_u16 *background_color, }/** -* @wb_frame_info: The writeback frame buffer metadata +* blend - blend pixels from a given row and calculate CRC +* @wb: The writeback frame buffer metadata * @crtc_state: The crtc state * @crc32: The crc output of the final frame * @output_buffer: A buffer of a row that will receive the result of the blend(s) * @stage_buffer: The line with the pixels from plane being blend to the output +* @row_size: Size of memory taken up by row data (line_width * pixel_size) * * This function blends the pixels (Using the `pre_mul_alpha_blend`) * from all planes, calculates the crc32 of the output from the former step,
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
PATCH RESEND 4/15 drm/mediatek/mtk_disp_aal: Remove half completed incorrect struct header
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'clk' not described in 'mtk_disp_aal' drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'regs' not described in 'mtk_disp_aal' drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_aal' drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'data' not described in 'mtk_disp_aal'
--- drivers/gpu/drm/mediatek/mtk_disp_aal.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/gpu/drm/mediatek/mtk_disp_aal.c +0 -5
@@ -26,11 +26,6 @@ struct mtk_disp_aal_data {bool has_gamma; }; -/** -* struct mtk_disp_aal - DISP_AAL driver structure -* @ddp_comp - structure containing type enum and hardware resources -* @crtc - associated crtc to report irq events to -*/ struct mtk_disp_aal {struct clk *clk;void __iomem *regs;
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
Re: [RESEND 04/15] drm/mediatek/mtk_disp_aal: Remove half completed incorrect struct header
Il 09/06/23 10:17, Lee Jones ha scritto:
Quoted 7 lines
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'clk' not described in 'mtk_disp_aal'drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'regs' not described in 'mtk_disp_aal'drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_aal'drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'data' not described in 'mtk_disp_aal'
Quoted 10 lines
Cc Chun-Kuang Hu <[email protected]>Cc Philipp Zabel <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Cc Matthias Brugger <[email protected]>Cc AngeloGioacchino Del Regno <[email protected]>Signed-off-by Lee Jones <[email protected]>
PATCH RESEND 5/15 drm/mediatek/mtk_disp_ccorr: Remove half completed incorrect struct header
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'clk' not described in 'mtk_disp_ccorr' drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'regs' not described in 'mtk_disp_ccorr' drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_ccorr' drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'data' not described in 'mtk_disp_ccorr'
--- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c +0 -5
@@ -34,11 +34,6 @@ struct mtk_disp_ccorr_data {u32 matrix_bits; }; -/** -* struct mtk_disp_ccorr - DISP_CCORR driver structure -* @ddp_comp - structure containing type enum and hardware resources -* @crtc - associated crtc to report irq events to -*/ struct mtk_disp_ccorr {struct clk *clk;void __iomem *regs;
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
Re: [RESEND 05/15] drm/mediatek/mtk_disp_ccorr: Remove half completed incorrect struct header
Il 09/06/23 10:17, Lee Jones ha scritto:
Quoted 7 lines
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'clk' not described in 'mtk_disp_ccorr'drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'regs' not described in 'mtk_disp_ccorr'drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_ccorr'drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'data' not described in 'mtk_disp_ccorr'
Quoted 10 lines
Cc Chun-Kuang Hu <[email protected]>Cc Philipp Zabel <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Cc Matthias Brugger <[email protected]>Cc AngeloGioacchino Del Regno <[email protected]>Signed-off-by Lee Jones <[email protected]>
Matthias Brugger
maintainerRe: [RESEND 05/15] drm/mediatek/mtk_disp_ccorr: Remove half completed incorrect struct header
In reply to Lee JonesQuoted 26 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'clk' not described in 'mtk_disp_ccorr'drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'regs' not described in 'mtk_disp_ccorr'drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_ccorr'drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'data' not described in 'mtk_disp_ccorr'Cc Chun-Kuang Hu <[email protected]>Cc Philipp Zabel <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Cc Matthias Brugger <[email protected]>Cc AngeloGioacchino Del Regno <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 5 ----- 1 file changed, 5 deletions(-)drivers/gpu/drm/mediatek/mtk_disp_ccorr.c +0
-0
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c struct mtk_disp_ccorr_data { · line 41
Quoted 8 lines
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c +0
-5@@ -34,11 +34,6 @@ struct mtk_disp_ccorr_data {u32 matrix_bits; }; -/** -* struct mtk_disp_ccorr - DISP_CCORR driver structure -* @ddp_comp - structure containing type enum and hardware resources -* @crtc - associated crtc to report irq events to -*/
That surely suppress the warning but I think the correct to do here is to fix the documentation instead of deleting it.
Regards,
Matthias
Quoted 3 lines
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c +0
-0struct mtk_disp_ccorr {struct clk *clk;void __iomem *regs;
Re: [RESEND 05/15] drm/mediatek/mtk_disp_ccorr: Remove half completed incorrect struct header
Quoted 24 lines · Matthias Brugger
Quoted 21 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'clk' not described in 'mtk_disp_ccorr'drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'regs' not described in 'mtk_disp_ccorr'drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_ccorr'drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'data' not described in 'mtk_disp_ccorr'Cc Chun-Kuang Hu <[email protected]>Cc Philipp Zabel <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Cc Matthias Brugger <[email protected]>Cc AngeloGioacchino Del Regno <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 5 ----- 1 file changed, 5 deletions(-)
Quoted 15 lines
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c struct mtk_disp_ccorr_data { · line 40
Quoted 12 lines
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c +0
-5@@ -34,11 +34,6 @@ struct mtk_disp_ccorr_data {u32 matrix_bits; }; -/** -* struct mtk_disp_ccorr - DISP_CCORR driver structure -* @ddp_comp - structure containing type enum and hardware resources -* @crtc - associated crtc to report irq events to -*/ That surely suppress the warning but I think the correct to do here is to fix the documentation instead of deleting it.
If someone wants to take responsibility for it and author correct documentation, I'm all for it. That is the perfect resolution. If that's not going to happen immediately, I suggest we remove it in the first instance.
Signature · 1 line
Lee Jones [李琼斯]
PATCH RESEND 6/15 drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc'
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c: In function ‘nvkm_acr_lsfw_load_sig_image_desc_v2’:
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable ‘loc’ set but not used [-Wunused-but-set-variable]
--- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c +1 -2
@@ -218,7 +218,7 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,const struct firmware *hsbl;const struct nvfw_ls_hsbl_bin_hdr *hdr;const struct nvfw_ls_hsbl_hdr *hshdr; -u32 loc, sig, cnt, *meta; +u32 sig, cnt, *meta; ret =nvkm_firmware_load_name (subdev, path,"hs_bl_sig" , ver, &hsbl);if (ret)
@@ -227,7 +227,6 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev, hdr =nvfw_ls_hsbl_bin_hdr (subdev, hsbl->data); hshdr =nvfw_ls_hsbl_hdr (subdev, hsbl->data + hdr->header_offset); meta = (u32 *)(hsbl->data + hshdr->meta_data_offset); - loc = *(u32 *)(hsbl->data + hshdr->patch_loc); sig = *(u32 *)(hsbl->data + hshdr->patch_sig); cnt = *(u32 *)(hsbl->data + hshdr->num_sig);
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
Re: [RESEND 06/15] drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc'
Quoted 33 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c: In function ‘nvkm_acr_lsfw_load_sig_image_desc_v2’:
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable ‘loc’ set but not used [-Wunused-but-set-variable]Cc Ben Skeggs <[email protected]>Cc Karol Herbst <[email protected]>Cc Lyude Paul <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Cc Gourav Samaiya <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c +1
-1@@ -218,7 +218,7 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev,const struct firmware *hsbl;const struct nvfw_ls_hsbl_bin_hdr *hdr;const struct nvfw_ls_hsbl_hdr *hshdr; -u32 loc, sig, cnt, *meta; +u32 sig, cnt, *meta; ret =nvkm_firmware_load_name (subdev, path,"hs_bl_sig" , ver, &hsbl);if (ret)
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev, · line 230
Quoted 4 lines
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c +0
-1@@ -227,7 +227,6 @@ nvkm_acr_lsfw_load_sig_image_desc_v2(struct nvkm_subdev *subdev, hdr =nvfw_ls_hsbl_bin_hdr (subdev, hsbl->data); hshdr =nvfw_ls_hsbl_hdr (subdev, hsbl->data + hdr->header_offset); meta = (u32 *)(hsbl->data + hshdr->meta_data_offset); - loc = *(u32 *)(hsbl->data + hshdr->patch_loc);
Ben: should we do anything with this value or is it safe to ignore?
Quoted 6 lines
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c +0
-1sig = *(u32 *)(hsbl->data + hshdr->patch_sig); cnt = *(u32 *)(hsbl->data + hshdr->num_sig); --2.41.0.162.gfafddb0af9-goog
PATCH RESEND 7/15 drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved' drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: expecting prototype for INIT_DONE(). Prototype was for init_done() instead [Snipped ~140 lines for brevity]
--- .../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++--------- 1 file changed, 68 insertions(+), 68 deletions(-)
drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c +68 -68
@@ -575,7 +575,7 @@ init_tmds_reg(struct nvbios_init *init, u8 tmds)* init opcode handlers *****************************************************************************/ -/** +/* * init_reserved - stub for various unknown/unused single-byte opcodes * */
@@ -602,7 +602,7 @@ init_reserved(struct nvbios_init *init) init->offset += length; } -/** +/* * INIT_DONE - opcode 0x71 * */
@@ -613,7 +613,7 @@ init_done(struct nvbios_init *init) init->offset =0x0000 ; } -/** +/* * INIT_IO_RESTRICT_PROG - opcode 0x32 * */
@@ -650,7 +650,7 @@ init_io_restrict_prog(struct nvbios_init *init)trace ("}]\n" ); } -/** +/* * INIT_REPEAT - opcode 0x33 * */
@@ -676,7 +676,7 @@ init_repeat(struct nvbios_init *init) init->repeat = repeat; } -/** +/* * INIT_IO_RESTRICT_PLL - opcode 0x34 * */
@@ -716,7 +716,7 @@ init_io_restrict_pll(struct nvbios_init *init)trace ("}]\n" ); } -/** +/* * INIT_END_REPEAT - opcode 0x36 * */
@@ -732,7 +732,7 @@ init_end_repeat(struct nvbios_init *init) } } -/** +/* * INIT_COPY - opcode 0x37 * */
@@ -759,7 +759,7 @@ init_copy(struct nvbios_init *init)init_wrvgai (init, port, index, data); } -/** +/* * INIT_NOT - opcode 0x38 * */
@@ -771,7 +771,7 @@ init_not(struct nvbios_init *init)init_exec_inv (init); } -/** +/* * INIT_IO_FLAG_CONDITION - opcode 0x39 * */
@@ -788,7 +788,7 @@ init_io_flag_condition(struct nvbios_init *init)init_exec_set (init, false); } -/** +/* * INIT_GENERIC_CONDITION - opcode 0x3a * */
@@ -840,7 +840,7 @@ init_generic_condition(struct nvbios_init *init) } } -/** +/* * INIT_IO_MASK_OR - opcode 0x3b * */
@@ -859,7 +859,7 @@ init_io_mask_or(struct nvbios_init *init)init_wrvgai (init,0x03d4 , index, data &= ~(1 << or)); } -/** +/* * INIT_IO_OR - opcode 0x3c * */
@@ -878,7 +878,7 @@ init_io_or(struct nvbios_init *init)init_wrvgai (init,0x03d4 , index, data | (1 << or)); } -/** +/* * INIT_ANDN_REG - opcode 0x47 * */
@@ -895,7 +895,7 @@ init_andn_reg(struct nvbios_init *init)init_mask (init, reg, mask,0 ); } -/** +/* * INIT_OR_REG - opcode 0x48 * */
@@ -912,7 +912,7 @@ init_or_reg(struct nvbios_init *init)init_mask (init, reg,0 , mask); } -/** +/* * INIT_INDEX_ADDRESS_LATCHED - opcode 0x49 * */
@@ -942,7 +942,7 @@ init_idx_addr_latched(struct nvbios_init *init) } } -/** +/* * INIT_IO_RESTRICT_PLL2 - opcode 0x4a * */
@@ -977,7 +977,7 @@ init_io_restrict_pll2(struct nvbios_init *init)trace ("}]\n" ); } -/** +/* * INIT_PLL2 - opcode 0x4b * */
@@ -994,7 +994,7 @@ init_pll2(struct nvbios_init *init)init_prog_pll (init, reg, freq); } -/** +/* * INIT_I2C_BYTE - opcode 0x4c * */
@@ -1025,7 +1025,7 @@ init_i2c_byte(struct nvbios_init *init) } } -/** +/* * INIT_ZM_I2C_BYTE - opcode 0x4d * */
@@ -1051,7 +1051,7 @@ init_zm_i2c_byte(struct nvbios_init *init) } } -/** +/* * INIT_ZM_I2C - opcode 0x4e * */
@@ -1085,7 +1085,7 @@ init_zm_i2c(struct nvbios_init *init) } } -/** +/* * INIT_TMDS - opcode 0x4f * */
@@ -1111,7 +1111,7 @@ init_tmds(struct nvbios_init *init)init_wr32 (init, reg +0 , addr); } -/** +/* * INIT_ZM_TMDS_GROUP - opcode 0x50 * */
@@ -1138,7 +1138,7 @@ init_zm_tmds_group(struct nvbios_init *init) } } -/** +/* * INIT_CR_INDEX_ADDRESS_LATCHED - opcode 0x51 * */
@@ -1168,7 +1168,7 @@ init_cr_idx_adr_latch(struct nvbios_init *init)init_wrvgai (init,0x03d4 , addr0, save0); } -/** +/* * INIT_CR - opcode 0x52 * */
@@ -1188,7 +1188,7 @@ init_cr(struct nvbios_init *init)init_wrvgai (init,0x03d4 , addr, val | data); } -/** +/* * INIT_ZM_CR - opcode 0x53 * */
@@ -1205,7 +1205,7 @@ init_zm_cr(struct nvbios_init *init)init_wrvgai (init,0x03d4 , addr, data); } -/** +/* * INIT_ZM_CR_GROUP - opcode 0x54 * */
@@ -1229,7 +1229,7 @@ init_zm_cr_group(struct nvbios_init *init) } } -/** +/* * INIT_CONDITION_TIME - opcode 0x56 * */
@@ -1256,7 +1256,7 @@ init_condition_time(struct nvbios_init *init)init_exec_set (init, false); } -/** +/* * INIT_LTIME - opcode 0x57 * */
@@ -1273,7 +1273,7 @@ init_ltime(struct nvbios_init *init)mdelay (msec); } -/** +/* * INIT_ZM_REG_SEQUENCE - opcode 0x58 * */
@@ -1298,7 +1298,7 @@ init_zm_reg_sequence(struct nvbios_init *init) } } -/** +/* * INIT_PLL_INDIRECT - opcode 0x59 * */
@@ -1317,7 +1317,7 @@ init_pll_indirect(struct nvbios_init *init)init_prog_pll (init, reg, freq); } -/** +/* * INIT_ZM_REG_INDIRECT - opcode 0x5a * */
@@ -1336,7 +1336,7 @@ init_zm_reg_indirect(struct nvbios_init *init)init_wr32 (init, addr, data); } -/** +/* * INIT_SUB_DIRECT - opcode 0x5b * */
@@ -1362,7 +1362,7 @@ init_sub_direct(struct nvbios_init *init) init->offset +=3 ; } -/** +/* * INIT_JUMP - opcode 0x5c * */
@@ -1380,7 +1380,7 @@ init_jump(struct nvbios_init *init) init->offset +=3 ; } -/** +/* * INIT_I2C_IF - opcode 0x5e * */
@@ -1407,7 +1407,7 @@ init_i2c_if(struct nvbios_init *init)init_exec_force (init, false); } -/** +/* * INIT_COPY_NV_REG - opcode 0x5f * */
@@ -1433,7 +1433,7 @@ init_copy_nv_reg(struct nvbios_init *init)init_mask (init, dreg, ~dmask, (data & smask) ^ sxor); } -/** +/* * INIT_ZM_INDEX_IO - opcode 0x62 * */
@@ -1451,7 +1451,7 @@ init_zm_index_io(struct nvbios_init *init)init_wrvgai (init, port, index, data); } -/** +/* * INIT_COMPUTE_MEM - opcode 0x63 * */
@@ -1469,7 +1469,7 @@ init_compute_mem(struct nvbios_init *init)init_exec_force (init, false); } -/** +/* * INIT_RESET - opcode 0x65 * */
@@ -1496,7 +1496,7 @@ init_reset(struct nvbios_init *init)init_exec_force (init, false); } -/** +/* * INIT_CONFIGURE_MEM - opcode 0x66 * */
@@ -1555,7 +1555,7 @@ init_configure_mem(struct nvbios_init *init)init_exec_force (init, false); } -/** +/* * INIT_CONFIGURE_CLK - opcode 0x67 * */
@@ -1589,7 +1589,7 @@ init_configure_clk(struct nvbios_init *init)init_exec_force (init, false); } -/** +/* * INIT_CONFIGURE_PREINIT - opcode 0x68 * */
@@ -1615,7 +1615,7 @@ init_configure_preinit(struct nvbios_init *init)init_exec_force (init, false); } -/** +/* * INIT_IO - opcode 0x69 * */
@@ -1655,7 +1655,7 @@ init_io(struct nvbios_init *init)init_wrport (init, port, data | value); } -/** +/* * INIT_SUB - opcode 0x6b * */
@@ -1682,7 +1682,7 @@ init_sub(struct nvbios_init *init) init->offset +=2 ; } -/** +/* * INIT_RAM_CONDITION - opcode 0x6d * */
@@ -1701,7 +1701,7 @@ init_ram_condition(struct nvbios_init *init)init_exec_set (init, false); } -/** +/* * INIT_NV_REG - opcode 0x6e * */
@@ -1719,7 +1719,7 @@ init_nv_reg(struct nvbios_init *init)init_mask (init, reg, ~mask, data); } -/** +/* * INIT_MACRO - opcode 0x6f * */
@@ -1743,7 +1743,7 @@ init_macro(struct nvbios_init *init) init->offset +=2 ; } -/** +/* * INIT_RESUME - opcode 0x72 * */
@@ -1755,7 +1755,7 @@ init_resume(struct nvbios_init *init)init_exec_set (init, true); } -/** +/* * INIT_STRAP_CONDITION - opcode 0x73 * */
@@ -1773,7 +1773,7 @@ init_strap_condition(struct nvbios_init *init)init_exec_set (init, false); } -/** +/* * INIT_TIME - opcode 0x74 * */
@@ -1794,7 +1794,7 @@ init_time(struct nvbios_init *init) } } -/** +/* * INIT_CONDITION - opcode 0x75 * */
@@ -1811,7 +1811,7 @@ init_condition(struct nvbios_init *init)init_exec_set (init, false); } -/** +/* * INIT_IO_CONDITION - opcode 0x76 * */
@@ -1828,7 +1828,7 @@ init_io_condition(struct nvbios_init *init)init_exec_set (init, false); } -/** +/* * INIT_ZM_REG16 - opcode 0x77 * */
@@ -1845,7 +1845,7 @@ init_zm_reg16(struct nvbios_init *init)init_wr32 (init, addr, data); } -/** +/* * INIT_INDEX_IO - opcode 0x78 * */
@@ -1867,7 +1867,7 @@ init_index_io(struct nvbios_init *init)init_wrvgai (init, port, index, data | value); } -/** +/* * INIT_PLL - opcode 0x79 * */
@@ -1884,7 +1884,7 @@ init_pll(struct nvbios_init *init)init_prog_pll (init, reg, freq); } -/** +/* * INIT_ZM_REG - opcode 0x7a * */
@@ -1904,7 +1904,7 @@ init_zm_reg(struct nvbios_init *init)init_wr32 (init, addr, data); } -/** +/* * INIT_RAM_RESTRICT_PLL - opcde 0x87 * */
@@ -1934,7 +1934,7 @@ init_ram_restrict_pll(struct nvbios_init *init) } } -/** +/* * INIT_RESET_BEGUN - opcode 0x8c * */
@@ -1945,7 +1945,7 @@ init_reset_begun(struct nvbios_init *init) init->offset +=1 ; } -/** +/* * INIT_RESET_END - opcode 0x8d * */
@@ -1956,7 +1956,7 @@ init_reset_end(struct nvbios_init *init) init->offset +=1 ; } -/** +/* * INIT_GPIO - opcode 0x8e * */
@@ -1972,7 +1972,7 @@ init_gpio(struct nvbios_init *init)nvkm_gpio_reset (gpio,DCB_GPIO_UNUSED ); } -/** +/* * INIT_RAM_RESTRICT_ZM_GROUP - opcode 0x8f * */
@@ -2010,7 +2010,7 @@ init_ram_restrict_zm_reg_group(struct nvbios_init *init) } } -/** +/* * INIT_COPY_ZM_REG - opcode 0x90 * */
@@ -2027,7 +2027,7 @@ init_copy_zm_reg(struct nvbios_init *init)init_wr32 (init, dreg,init_rd32 (init, sreg)); } -/** +/* * INIT_ZM_REG_GROUP - opcode 0x91 * */
@@ -2049,7 +2049,7 @@ init_zm_reg_group(struct nvbios_init *init) } } -/** +/* * INIT_XLAT - opcode 0x96 * */
@@ -2077,7 +2077,7 @@ init_xlat(struct nvbios_init *init)init_mask (init, daddr, ~dmask, data); } -/** +/* * INIT_ZM_MASK_ADD - opcode 0x97 * */
@@ -2098,7 +2098,7 @@ init_zm_mask_add(struct nvbios_init *init)init_wr32 (init, addr, data); } -/** +/* * INIT_AUXCH - opcode 0x98 * */
@@ -2122,7 +2122,7 @@ init_auxch(struct nvbios_init *init) } } -/** +/* * INIT_AUXCH - opcode 0x99 * */
@@ -2144,7 +2144,7 @@ init_zm_auxch(struct nvbios_init *init) } } -/** +/* * INIT_I2C_LONG_IF - opcode 0x9a * */
@@ -2183,7 +2183,7 @@ init_i2c_long_if(struct nvbios_init *init)init_exec_set (init, false); } -/** +/* * INIT_GPIO_NE - opcode 0xa9 * */
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
Re: [RESEND 07/15] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses
Quoted 7 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved'drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: expecting prototype forINIT_DONE(). Prototype was forinit_done()instead [Snipped ~140 lines for brevity]
Quoted 8 lines
Cc Ben Skeggs <[email protected]>Cc Karol Herbst <[email protected]>Cc Lyude Paul <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Lee Jones <[email protected]>
Quoted 623 lines
--- .../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++--------- 1 file changed, 68 insertions(+), 68 deletions(-)drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c +68
-69@@ -575,7 +575,7 @@ init_tmds_reg(struct nvbios_init *init, u8 tmds)* init opcode handlers *****************************************************************************/ -/** +/* * init_reserved - stub for various unknown/unused single-byte opcodes * */ @@ -602,7 +602,7 @@ init_reserved(struct nvbios_init *init) init->offset += length; } -/** +/* * INIT_DONE - opcode 0x71 * */ @@ -613,7 +613,7 @@ init_done(struct nvbios_init *init) init->offset =0x0000 ; } -/** +/* * INIT_IO_RESTRICT_PROG - opcode 0x32 * */ @@ -650,7 +650,7 @@ init_io_restrict_prog(struct nvbios_init *init)trace ("}]\n" ); } -/** +/* * INIT_REPEAT - opcode 0x33 * */ @@ -676,7 +676,7 @@ init_repeat(struct nvbios_init *init) init->repeat = repeat; } -/** +/* * INIT_IO_RESTRICT_PLL - opcode 0x34 * */ @@ -716,7 +716,7 @@ init_io_restrict_pll(struct nvbios_init *init)trace ("}]\n" ); } -/** +/* * INIT_END_REPEAT - opcode 0x36 * */ @@ -732,7 +732,7 @@ init_end_repeat(struct nvbios_init *init) } } -/** +/* * INIT_COPY - opcode 0x37 * */ @@ -759,7 +759,7 @@ init_copy(struct nvbios_init *init)init_wrvgai (init, port, index, data); } -/** +/* * INIT_NOT - opcode 0x38 * */ @@ -771,7 +771,7 @@ init_not(struct nvbios_init *init)init_exec_inv (init); } -/** +/* * INIT_IO_FLAG_CONDITION - opcode 0x39 * */ @@ -788,7 +788,7 @@ init_io_flag_condition(struct nvbios_init *init)init_exec_set (init, false); } -/** +/* * INIT_GENERIC_CONDITION - opcode 0x3a * */ @@ -840,7 +840,7 @@ init_generic_condition(struct nvbios_init *init) } } -/** +/* * INIT_IO_MASK_OR - opcode 0x3b * */ @@ -859,7 +859,7 @@ init_io_mask_or(struct nvbios_init *init)init_wrvgai (init,0x03d4 , index, data &= ~(1 << or)); } -/** +/* * INIT_IO_OR - opcode 0x3c * */ @@ -878,7 +878,7 @@ init_io_or(struct nvbios_init *init)init_wrvgai (init,0x03d4 , index, data | (1 << or)); } -/** +/* * INIT_ANDN_REG - opcode 0x47 * */ @@ -895,7 +895,7 @@ init_andn_reg(struct nvbios_init *init)init_mask (init, reg, mask,0 ); } -/** +/* * INIT_OR_REG - opcode 0x48 * */ @@ -912,7 +912,7 @@ init_or_reg(struct nvbios_init *init)init_mask (init, reg,0 , mask); } -/** +/* * INIT_INDEX_ADDRESS_LATCHED - opcode 0x49 * */ @@ -942,7 +942,7 @@ init_idx_addr_latched(struct nvbios_init *init) } } -/** +/* * INIT_IO_RESTRICT_PLL2 - opcode 0x4a * */ @@ -977,7 +977,7 @@ init_io_restrict_pll2(struct nvbios_init *init)trace ("}]\n" ); } -/** +/* * INIT_PLL2 - opcode 0x4b * */ @@ -994,7 +994,7 @@ init_pll2(struct nvbios_init *init)init_prog_pll (init, reg, freq); } -/** +/* * INIT_I2C_BYTE - opcode 0x4c * */ @@ -1025,7 +1025,7 @@ init_i2c_byte(struct nvbios_init *init) } } -/** +/* * INIT_ZM_I2C_BYTE - opcode 0x4d * */ @@ -1051,7 +1051,7 @@ init_zm_i2c_byte(struct nvbios_init *init) } } -/** +/* * INIT_ZM_I2C - opcode 0x4e * */ @@ -1085,7 +1085,7 @@ init_zm_i2c(struct nvbios_init *init) } } -/** +/* * INIT_TMDS - opcode 0x4f * */ @@ -1111,7 +1111,7 @@ init_tmds(struct nvbios_init *init)init_wr32 (init, reg +0 , addr); } -/** +/* * INIT_ZM_TMDS_GROUP - opcode 0x50 * */ @@ -1138,7 +1138,7 @@ init_zm_tmds_group(struct nvbios_init *init) } } -/** +/* * INIT_CR_INDEX_ADDRESS_LATCHED - opcode 0x51 * */ @@ -1168,7 +1168,7 @@ init_cr_idx_adr_latch(struct nvbios_init *init)init_wrvgai (init,0x03d4 , addr0, save0); } -/** +/* * INIT_CR - opcode 0x52 * */ @@ -1188,7 +1188,7 @@ init_cr(struct nvbios_init *init)init_wrvgai (init,0x03d4 , addr, val | data); } -/** +/* * INIT_ZM_CR - opcode 0x53 * */ @@ -1205,7 +1205,7 @@ init_zm_cr(struct nvbios_init *init)init_wrvgai (init,0x03d4 , addr, data); } -/** +/* * INIT_ZM_CR_GROUP - opcode 0x54 * */ @@ -1229,7 +1229,7 @@ init_zm_cr_group(struct nvbios_init *init) } } -/** +/* * INIT_CONDITION_TIME - opcode 0x56 * */ @@ -1256,7 +1256,7 @@ init_condition_time(struct nvbios_init *init)init_exec_set (init, false); } -/** +/* * INIT_LTIME - opcode 0x57 * */ @@ -1273,7 +1273,7 @@ init_ltime(struct nvbios_init *init)mdelay (msec); } -/** +/* * INIT_ZM_REG_SEQUENCE - opcode 0x58 * */ @@ -1298,7 +1298,7 @@ init_zm_reg_sequence(struct nvbios_init *init) } } -/** +/* * INIT_PLL_INDIRECT - opcode 0x59 * */ @@ -1317,7 +1317,7 @@ init_pll_indirect(struct nvbios_init *init)init_prog_pll (init, reg, freq); } -/** +/* * INIT_ZM_REG_INDIRECT - opcode 0x5a * */ @@ -1336,7 +1336,7 @@ init_zm_reg_indirect(struct nvbios_init *init)init_wr32 (init, addr, data); } -/** +/* * INIT_SUB_DIRECT - opcode 0x5b * */ @@ -1362,7 +1362,7 @@ init_sub_direct(struct nvbios_init *init) init->offset +=3 ; } -/** +/* * INIT_JUMP - opcode 0x5c * */ @@ -1380,7 +1380,7 @@ init_jump(struct nvbios_init *init) init->offset +=3 ; } -/** +/* * INIT_I2C_IF - opcode 0x5e * */ @@ -1407,7 +1407,7 @@ init_i2c_if(struct nvbios_init *init)init_exec_force (init, false); } -/** +/* * INIT_COPY_NV_REG - opcode 0x5f * */ @@ -1433,7 +1433,7 @@ init_copy_nv_reg(struct nvbios_init *init)init_mask (init, dreg, ~dmask, (data & smask) ^ sxor); } -/** +/* * INIT_ZM_INDEX_IO - opcode 0x62 * */ @@ -1451,7 +1451,7 @@ init_zm_index_io(struct nvbios_init *init)init_wrvgai (init, port, index, data); } -/** +/* * INIT_COMPUTE_MEM - opcode 0x63 * */ @@ -1469,7 +1469,7 @@ init_compute_mem(struct nvbios_init *init)init_exec_force (init, false); } -/** +/* * INIT_RESET - opcode 0x65 * */ @@ -1496,7 +1496,7 @@ init_reset(struct nvbios_init *init)init_exec_force (init, false); } -/** +/* * INIT_CONFIGURE_MEM - opcode 0x66 * */ @@ -1555,7 +1555,7 @@ init_configure_mem(struct nvbios_init *init)init_exec_force (init, false); } -/** +/* * INIT_CONFIGURE_CLK - opcode 0x67 * */ @@ -1589,7 +1589,7 @@ init_configure_clk(struct nvbios_init *init)init_exec_force (init, false); } -/** +/* * INIT_CONFIGURE_PREINIT - opcode 0x68 * */ @@ -1615,7 +1615,7 @@ init_configure_preinit(struct nvbios_init *init)init_exec_force (init, false); } -/** +/* * INIT_IO - opcode 0x69 * */ @@ -1655,7 +1655,7 @@ init_io(struct nvbios_init *init)init_wrport (init, port, data | value); } -/** +/* * INIT_SUB - opcode 0x6b * */ @@ -1682,7 +1682,7 @@ init_sub(struct nvbios_init *init) init->offset +=2 ; } -/** +/* * INIT_RAM_CONDITION - opcode 0x6d * */ @@ -1701,7 +1701,7 @@ init_ram_condition(struct nvbios_init *init)init_exec_set (init, false); } -/** +/* * INIT_NV_REG - opcode 0x6e * */ @@ -1719,7 +1719,7 @@ init_nv_reg(struct nvbios_init *init)init_mask (init, reg, ~mask, data); } -/** +/* * INIT_MACRO - opcode 0x6f * */ @@ -1743,7 +1743,7 @@ init_macro(struct nvbios_init *init) init->offset +=2 ; } -/** +/* * INIT_RESUME - opcode 0x72 * */ @@ -1755,7 +1755,7 @@ init_resume(struct nvbios_init *init)init_exec_set (init, true); } -/** +/* * INIT_STRAP_CONDITION - opcode 0x73 * */ @@ -1773,7 +1773,7 @@ init_strap_condition(struct nvbios_init *init)init_exec_set (init, false); } -/** +/* * INIT_TIME - opcode 0x74 * */ @@ -1794,7 +1794,7 @@ init_time(struct nvbios_init *init) } } -/** +/* * INIT_CONDITION - opcode 0x75 * */ @@ -1811,7 +1811,7 @@ init_condition(struct nvbios_init *init)init_exec_set (init, false); } -/** +/* * INIT_IO_CONDITION - opcode 0x76 * */ @@ -1828,7 +1828,7 @@ init_io_condition(struct nvbios_init *init)init_exec_set (init, false); } -/** +/* * INIT_ZM_REG16 - opcode 0x77 * */ @@ -1845,7 +1845,7 @@ init_zm_reg16(struct nvbios_init *init)init_wr32 (init, addr, data); } -/** +/* * INIT_INDEX_IO - opcode 0x78 * */ @@ -1867,7 +1867,7 @@ init_index_io(struct nvbios_init *init)init_wrvgai (init, port, index, data | value); } -/** +/* * INIT_PLL - opcode 0x79 * */ @@ -1884,7 +1884,7 @@ init_pll(struct nvbios_init *init)init_prog_pll (init, reg, freq); } -/** +/* * INIT_ZM_REG - opcode 0x7a * */ @@ -1904,7 +1904,7 @@ init_zm_reg(struct nvbios_init *init)init_wr32 (init, addr, data); } -/** +/* * INIT_RAM_RESTRICT_PLL - opcde 0x87 * */ @@ -1934,7 +1934,7 @@ init_ram_restrict_pll(struct nvbios_init *init) } } -/** +/* * INIT_RESET_BEGUN - opcode 0x8c * */ @@ -1945,7 +1945,7 @@ init_reset_begun(struct nvbios_init *init) init->offset +=1 ; } -/** +/* * INIT_RESET_END - opcode 0x8d * */ @@ -1956,7 +1956,7 @@ init_reset_end(struct nvbios_init *init) init->offset +=1 ; } -/** +/* * INIT_GPIO - opcode 0x8e * */ @@ -1972,7 +1972,7 @@ init_gpio(struct nvbios_init *init)nvkm_gpio_reset (gpio,DCB_GPIO_UNUSED ); } -/** +/* * INIT_RAM_RESTRICT_ZM_GROUP - opcode 0x8f * */ @@ -2010,7 +2010,7 @@ init_ram_restrict_zm_reg_group(struct nvbios_init *init) } } -/** +/* * INIT_COPY_ZM_REG - opcode 0x90 * */ @@ -2027,7 +2027,7 @@ init_copy_zm_reg(struct nvbios_init *init)init_wr32 (init, dreg,init_rd32 (init, sreg)); } -/** +/* * INIT_ZM_REG_GROUP - opcode 0x91 * */ @@ -2049,7 +2049,7 @@ init_zm_reg_group(struct nvbios_init *init) } } -/** +/* * INIT_XLAT - opcode 0x96 * */ @@ -2077,7 +2077,7 @@ init_xlat(struct nvbios_init *init)init_mask (init, daddr, ~dmask, data); } -/** +/* * INIT_ZM_MASK_ADD - opcode 0x97 * */ @@ -2098,7 +2098,7 @@ init_zm_mask_add(struct nvbios_init *init)init_wr32 (init, addr, data); } -/** +/* * INIT_AUXCH - opcode 0x98 * */ @@ -2122,7 +2122,7 @@ init_auxch(struct nvbios_init *init) } } -/** +/* * INIT_AUXCH - opcode 0x99 * */ @@ -2144,7 +2144,7 @@ init_zm_auxch(struct nvbios_init *init) } } -/** +/* * INIT_I2C_LONG_IF - opcode 0x9a * */ @@ -2183,7 +2183,7 @@ init_i2c_long_if(struct nvbios_init *init)init_exec_set (init, false); } -/** +/* * INIT_GPIO_NE - opcode 0xa9 * */ --2.41.0.162.gfafddb0af9-goog
PATCH RESEND 8/15 drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:49: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
--- drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c +2 -2
@@ -45,7 +45,7 @@ static const struct cvb_coef gk20a_cvb_coef[] = { /* 852 */ { 1608418, -21643, -269, 0, 763, -48}, }; -/** +/* * cvb_mv = ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0) */ static inline int
@@ -58,7 +58,7 @@ gk20a_volt_get_cvb_voltage(int speedo, int s_scale, const struct cvb_coef *coef)return mv; } -/** +/* * cvb_t_mv = * ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0) + * ((c3 * speedo / s_scale + c4 + c5 * T / t_scale) * T / t_scale)
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
Re: [RESEND 08/15] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses
Quoted 6 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:49: warning: This comment starts with '/**', but isn't a kernel-doc comment. ReferDocumentation/doc-guide/kernel-doc.rstdrivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This comment starts with '/**', but isn't a kernel-doc comment. ReferDocumentation/doc-guide/kernel-doc.rst
Quoted 8 lines
Cc Ben Skeggs <[email protected]>Cc Karol Herbst <[email protected]>Cc Lyude Paul <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Lee Jones <[email protected]>
Quoted 29 lines
--- drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c +2
-3@@ -45,7 +45,7 @@ static const struct cvb_coef gk20a_cvb_coef[] = { /* 852 */ { 1608418, -21643, -269, 0, 763, -48}, }; -/** +/* * cvb_mv = ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0) */ static inline int@@ -58,7 +58,7 @@ gk20a_volt_get_cvb_voltage(int speedo, int s_scale, const struct cvb_coef *coef)return mv; } -/** +/* * cvb_t_mv = * ((c2 * speedo / s_scale + c1) * speedo / s_scale + c0) + * ((c3 * speedo / s_scale + c4 + c5 * T / t_scale) * T / t_scale) -- 2.41.0.162.gfafddb0af9-goog
PATCH RESEND 9/15 drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1044: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
--- drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c +1 -1
@@ -1040,7 +1040,7 @@ gf100_gr_zbc_init(struct gf100_gr *gr) } } -/** +/* * Wait until GR goes idle. GR is considered idle if it is disabled by the * MC (0x200) register, or GR is not busy and a context switch is not in * progress.
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
Re: [RESEND 09/15] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse
Quoted 5 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1044: warning: This comment starts with '/**', but isn't a kernel-doc comment. ReferDocumentation/doc-guide/kernel-doc.rst
Quoted 8 lines
Cc Ben Skeggs <[email protected]>Cc Karol Herbst <[email protected]>Cc Lyude Paul <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Lee Jones <[email protected]>
Quoted 20 lines
--- drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c +1
-2@@ -1040,7 +1040,7 @@ gf100_gr_zbc_init(struct gf100_gr *gr) } } -/** +/* * Wait until GR goes idle. GR is considered idle if it is disabled by the * MC (0x200) register, or GR is not busy and a context switch is not in * progress. -- 2.41.0.162.gfafddb0af9-goog
PATCH RESEND 10/15 drm/nouveau/nvkm/engine/gr/tu102: Staticify local function gf100_fifo_nonstall_block()
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: no previous prototype for ‘tu102_gr_load’ [-Wmissing-prototypes]
--- drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c +1 -1
@@ -206,7 +206,7 @@ tu102_gr_av_to_init_veid(struct nvkm_blob *blob, struct gf100_gr_pack **ppack)return gk20a_gr_av_to_init_ (blob,64 ,0x00100000 , ppack); } -int +static int tu102_gr_load (struct gf100_gr *gr,int ver,const struct gf100_gr_fwif *fwif) {int ret;
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
Re: [RESEND 10/15] drm/nouveau/nvkm/engine/gr/tu102: Staticify local function gf100_fifo_nonstall_block()
Quoted 5 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: no previous prototype for ‘tu102_gr_load’ [-Wmissing-prototypes]
Quoted 8 lines
Cc Ben Skeggs <[email protected]>Cc Karol Herbst <[email protected]>Cc Lyude Paul <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Lee Jones <[email protected]>
Quoted 20 lines
--- drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c +1
-2@@ -206,7 +206,7 @@ tu102_gr_av_to_init_veid(struct nvkm_blob *blob, struct gf100_gr_pack **ppack)return gk20a_gr_av_to_init_ (blob,64 ,0x00100000 , ppack); } -int +static int tu102_gr_load (struct gf100_gr *gr,int ver,const struct gf100_gr_fwif *fwif) {int ret; --2.41.0.162.gfafddb0af9-goog
PATCH RESEND 11/15 drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move SYNAPTICS_DEVICE_ID into CONFIG_DRM_AMD_DC_DCN ifdef
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:48:22: warning: ‘SYNAPTICS_DEVICE_ID’ defined but not used [-Wunused-const-variable=]
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +3 -3
@@ -44,9 +44,6 @@#include "dm_helpers.h" #include "ddc_service_types.h" -/* MST Dock */ -static const uint8_t SYNAPTICS_DEVICE_ID [] ="SYNA" ; -/* dm_helpers_parse_edid_caps * * Parse edid caps
@@ -702,6 +699,9 @@ static void apply_synaptics_fifo_reset_wa(struct drm_dp_aux *aux)DC_LOG_DC ("Done apply_synaptics_fifo_reset_wa\n" ); } +/* MST Dock */ +static const uint8_t SYNAPTICS_DEVICE_ID [] ="SYNA" ; + static uint8_t write_dsc_enable_synaptics_non_virtual_dpcd_mst( struct drm_dp_aux *aux, const struct dc_stream_state *stream,
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
Re: [RESEND 11/15] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move SYNAPTICS_DEVICE_ID into CONFIG_DRM_AMD_DC_DCN ifdef
Quoted 4 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:48:22: warning: ‘SYNAPTICS_DEVICE_ID’ defined but not used [-Wunused-const-variable=]
Quoted 11 lines
Cc Harry Wentland <[email protected]>Cc Leo Li <[email protected]>Cc Rodrigo Siqueira <[email protected]>Cc Alex Deucher <[email protected]>Cc "Christian König" <[email protected]>Cc "Pan, Xinhui" <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Lee Jones <[email protected]>
Harry
Quoted 28 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +3
-3@@ -44,9 +44,6 @@#include "dm_helpers.h" #include "ddc_service_types.h" -/* MST Dock */ -static const uint8_t SYNAPTICS_DEVICE_ID [] ="SYNA" ; -/* dm_helpers_parse_edid_caps * * Parse edid caps @@ -702,6 +699,9 @@ static void apply_synaptics_fifo_reset_wa(struct drm_dp_aux *aux)DC_LOG_DC ("Done apply_synaptics_fifo_reset_wa\n" ); } +/* MST Dock */ +static const uint8_t SYNAPTICS_DEVICE_ID [] ="SYNA" ; + static uint8_t write_dsc_enable_synaptics_non_virtual_dpcd_mst( struct drm_dp_aux *aux, const struct dc_stream_state *stream,
Hamza Mahfooz
AppliedRe: [RESEND 11/15] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move SYNAPTICS_DEVICE_ID into CONFIG_DRM_AMD_DC_DCN ifdef
In reply to Lee JonesQuoted 4 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:48:22: warning: ‘SYNAPTICS_DEVICE_ID’ defined but not used [-Wunused-const-variable=]
Quoted 11 lines
Cc Harry Wentland <[email protected]>Cc Leo Li <[email protected]>Cc Rodrigo Siqueira <[email protected]>Cc Alex Deucher <[email protected]>Cc "Christian König" <[email protected]>Cc "Pan, Xinhui" <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Lee Jones <[email protected]>
Applied, thanks!
Quoted 28 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +3
-3@@ -44,9 +44,6 @@#include "dm_helpers.h" #include "ddc_service_types.h" -/* MST Dock */ -static const uint8_t SYNAPTICS_DEVICE_ID [] ="SYNA" ; -/* dm_helpers_parse_edid_caps * * Parse edid caps @@ -702,6 +699,9 @@ static void apply_synaptics_fifo_reset_wa(struct drm_dp_aux *aux)DC_LOG_DC ("Done apply_synaptics_fifo_reset_wa\n" ); } +/* MST Dock */ +static const uint8_t SYNAPTICS_DEVICE_ID [] ="SYNA" ; + static uint8_t write_dsc_enable_synaptics_non_virtual_dpcd_mst( struct drm_dp_aux *aux, const struct dc_stream_state *stream,
Signature · 1 line
Hamza
PATCH RESEND 12/15 drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
--- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/nouveau/dispnv04/crtc.c +2 -2
@@ -449,7 +449,7 @@ nv_crtc_mode_set_vga(struct drm_crtc *crtc, struct drm_display_mode *mode) regp->Attribute[NV_CIO_AR_CSEL_INDEX ] =0x00 ; } -/** +/* * Sets up registers for the given mode/adjusted_mode pair. * * The clocks, CRTCs and outputs attached to this CRTC must be off.
@@ -625,7 +625,7 @@ nv_crtc_swap_fbs(struct drm_crtc *crtc, struct drm_framebuffer *old_fb)return ret; } -/** +/* * Sets up registers for the given mode/adjusted_mode pair. * * The clocks, CRTCs and outputs attached to this CRTC must be off.
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
Re: [RESEND 12/15] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses
Quoted 6 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. ReferDocumentation/doc-guide/kernel-doc.rstdrivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with '/**', but isn't a kernel-doc comment. ReferDocumentation/doc-guide/kernel-doc.rst
Quoted 8 lines
Cc Ben Skeggs <[email protected]>Cc Karol Herbst <[email protected]>Cc Lyude Paul <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Lee Jones <[email protected]>
Quoted 29 lines
--- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/nouveau/dispnv04/crtc.c +2
-3@@ -449,7 +449,7 @@ nv_crtc_mode_set_vga(struct drm_crtc *crtc, struct drm_display_mode *mode) regp->Attribute[NV_CIO_AR_CSEL_INDEX ] =0x00 ; } -/** +/* * Sets up registers for the given mode/adjusted_mode pair. * * The clocks, CRTCs and outputs attached to this CRTC must be off. @@ -625,7 +625,7 @@ nv_crtc_swap_fbs(struct drm_crtc *crtc, struct drm_framebuffer *old_fb)return ret; } -/** +/* * Sets up registers for the given mode/adjusted_mode pair. * * The clocks, CRTCs and outputs attached to this CRTC must be off. -- 2.41.0.162.gfafddb0af9-goog
Re: [RESEND,12/15] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses
In reply to Lee JonesQuoted 40 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. ReferDocumentation/doc-guide/kernel-doc.rstdrivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with '/**', but isn't a kernel-doc comment. ReferDocumentation/doc-guide/kernel-doc.rstCc Ben Skeggs <[email protected]>Cc Karol Herbst <[email protected]>Cc Lyude Paul <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Lee Jones <[email protected]>Reviewed-by Karol Herbst <[email protected]>--- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/nouveau/dispnv04/crtc.c +2
-2@@ -449,7 +449,7 @@ nv_crtc_mode_set_vga(struct drm_crtc *crtc, struct drm_display_mode *mode) regp->Attribute[NV_CIO_AR_CSEL_INDEX ] =0x00 ; } -/** +/* * Sets up registers for the given mode/adjusted_mode pair. * * The clocks, CRTCs and outputs attached to this CRTC must be off. @@ -625,7 +625,7 @@ nv_crtc_swap_fbs(struct drm_crtc *crtc, struct drm_framebuffer *old_fb)return ret; } -/** +/* * Sets up registers for the given mode/adjusted_mode pair. * * The clocks, CRTCs and outputs attached to this CRTC must be off.
Signature · 1 line
Jingfeng
PATCH RESEND 13/15 drm/nouveau/nvkm/engine/gr/tu102: Completely remove unused function ‘tu102_gr_load’
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: ‘tu102_gr_load’ defined but not used [-Wunused-function]
--- drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c | 13 ------------- 1 file changed, 13 deletions(-)
drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c +0 -13
@@ -206,19 +206,6 @@ tu102_gr_av_to_init_veid(struct nvkm_blob *blob, struct gf100_gr_pack **ppack)return gk20a_gr_av_to_init_ (blob,64 ,0x00100000 , ppack); } -static int -tu102_gr_load (struct gf100_gr *gr,int ver,const struct gf100_gr_fwif *fwif) -{ -int ret; - - ret =gm200_gr_load (gr, ver, fwif); -if (ret) -return ret; - -return gk20a_gr_load_net (gr,"gr/" ,"sw_veid_bundle_init" , ver, tu102_gr_av_to_init_veid, - &gr->bundle_veid); -} -static const struct gf100_gr_fwif tu102_gr_fwif[] = { {0 , gm200_gr_load, &tu102_gr, &gp108_gr_fecs_acr, &gp108_gr_gpccs_acr },
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
PATCH RESEND 14/15 drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move()
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_bo_move’:
drivers/gpu/drm/radeon/radeon_ttm.c:201:27: warning: variable ‘rbo’ set but not used [-Wunused-but-set-variable]
--- drivers/gpu/drm/radeon/radeon_ttm.c | 2 -- 1 file changed, 2 deletions(-)
drivers/gpu/drm/radeon/radeon_ttm.c +0 -2
@@ -197,7 +197,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict, {struct ttm_resource *old_mem = bo->resource;struct radeon_device *rdev; -struct radeon_bo *rbo;int r;if (new_mem->mem_type ==TTM_PL_TT ) {
@@ -210,7 +209,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,if (r)return r; - rbo = container_of(bo, struct radeon_bo, tbo); rdev =radeon_get_rdev (bo->bdev);if (!old_mem || (old_mem->mem_type ==TTM_PL_SYSTEM && bo->ttm ==NULL )) {
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
Re: [RESEND 14/15] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move()
This patch is no longer applicable.
Alex
Quoted 42 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_bo_move’:
drivers/gpu/drm/radeon/radeon_ttm.c:201:27: warning: variable ‘rbo’ set but not used [-Wunused-but-set-variable]Cc Alex Deucher <[email protected]>Cc "Christian König" <[email protected]>Cc "Pan, Xinhui" <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Cc Jerome Glisse <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/gpu/drm/radeon/radeon_ttm.c | 2 -- 1 file changed, 2 deletions(-)drivers/gpu/drm/radeon/radeon_ttm.c +0
-3@@ -197,7 +197,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict, {struct ttm_resource *old_mem = bo->resource;struct radeon_device *rdev; -struct radeon_bo *rbo;int r;if (new_mem->mem_type ==TTM_PL_TT ) {@@ -210,7 +209,6 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,if (r)return r; - rbo = container_of(bo, struct radeon_bo, tbo); rdev =radeon_get_rdev (bo->bdev);if (!old_mem || (old_mem->mem_type ==TTM_PL_SYSTEM && bo->ttm ==NULL )) { --2.41.0.162.gfafddb0af9-goog
PATCH RESEND 15/15 drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers
In reply to Lee JonesFixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'job' not described in 'sdma_v6_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'flags' not described in 'sdma_v6_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:945: warning: Function parameter or member 'timeout' not described in 'sdma_v6_0_ring_test_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1124: warning: Function parameter or member 'ring' not described in 'sdma_v6_0_ring_pad_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'vmid' not described in 'sdma_v6_0_ring_emit_vm_flush' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'pd_addr' not described in 'sdma_v6_0_ring_emit_vm_flush'
--- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c +4 -4
@@ -233,7 +233,7 @@ static void sdma_v6_0_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count)amdgpu_ring_write (ring, ring->funcs->nop); } -/** +/* * sdma_v6_0_ring_emit_ib - Schedule an IB on the DMA engine * * @ring: amdgpu ring pointer
@@ -936,7 +936,7 @@ static int sdma_v6_0_ring_test_ring(struct amdgpu_ring *ring)return r; } -/** +/* * sdma_v6_0_ring_test_ib - test an IB on the DMA engine * * @ring: amdgpu_ring structure holding ring information
@@ -1118,7 +1118,7 @@ static void sdma_v6_0_vm_set_pte_pde(struct amdgpu_ib *ib, ib->ptr[ib->length_dw++] = count -1 ;/* number of entries */ } -/** +/* * sdma_v6_0_ring_pad_ib - pad the IB * @ib: indirect buffer to fill with padding * @ring: amdgpu ring pointer
@@ -1167,7 +1167,7 @@ static void sdma_v6_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring) SDMA_PKT_POLL_REGMEM_DW5_INTERVAL(4)); /* retry count, poll interval */ } -/** +/* * sdma_v6_0_ring_emit_vm_flush - vm flush using sDMA * * @ring: amdgpu_ring pointer
Signature · 1 line
2.41.0.162.gfafddb0af9-goog
Re: [RESEND 15/15] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers
These have already been fixed up.
Thanks!
Alex
Quoted 69 lines · Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'job' not described in 'sdma_v6_0_ring_emit_ib'drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'flags' not described in 'sdma_v6_0_ring_emit_ib'drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:945: warning: Function parameter or member 'timeout' not described in 'sdma_v6_0_ring_test_ib'drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1124: warning: Function parameter or member 'ring' not described in 'sdma_v6_0_ring_pad_ib'drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'vmid' not described in 'sdma_v6_0_ring_emit_vm_flush'drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'pd_addr' not described in 'sdma_v6_0_ring_emit_vm_flush'Cc Alex Deucher <[email protected]>Cc "Christian König" <[email protected]>Cc "Pan, Xinhui" <[email protected]>Cc David Airlie <[email protected]>Cc Daniel Vetter <[email protected]>Cc Sumit Semwal <[email protected]>Cc Stanley Yang <[email protected]>Signed-off-by Lee Jones <[email protected]>--- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c +4
-5@@ -233,7 +233,7 @@ static void sdma_v6_0_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count)amdgpu_ring_write (ring, ring->funcs->nop); } -/** +/* * sdma_v6_0_ring_emit_ib - Schedule an IB on the DMA engine * * @ring: amdgpu ring pointer @@ -936,7 +936,7 @@ static int sdma_v6_0_ring_test_ring(struct amdgpu_ring *ring)return r; } -/** +/* * sdma_v6_0_ring_test_ib - test an IB on the DMA engine * * @ring: amdgpu_ring structure holding ring information @@ -1118,7 +1118,7 @@ static void sdma_v6_0_vm_set_pte_pde(struct amdgpu_ib *ib, ib->ptr[ib->length_dw++] = count -1 ;/* number of entries */ } -/** +/* * sdma_v6_0_ring_pad_ib - pad the IB * @ib: indirect buffer to fill with padding * @ring: amdgpu ring pointer @@ -1167,7 +1167,7 @@ static void sdma_v6_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring) SDMA_PKT_POLL_REGMEM_DW5_INTERVAL(4)); /* retry count, poll interval */ } -/** +/* * sdma_v6_0_ring_emit_vm_flush - vm flush using sDMA * * @ring: amdgpu_ring pointer -- 2.41.0.162.gfafddb0af9-goog