Skip to contentSkip to conversation

tools: ynl: Remove duplicated include in devlink-user.c

PATCH In review Yang Li 4 participants 6 messages Jun 9, 2023

Subsystems (5)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 3/3 tools: ynl: Remove duplicated include in devlink-user.c

./tools/net/ynl/generated/devlink-user.c: stdlib.h is included more than once.

---
 tools/net/ynl/generated/devlink-user.c | 1 -
 1 file changed, 1 deletion(-)
tools/net/ynl/generated/devlink-user.c +0 -1
index c3204e20b971..18157afd7c73 100644
@@ -8,7 +8,6 @@
 #include "ynl.h"
 #include <linux/devlink.h>
 
-#include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
 #include <libmnl/libmnl.h>
Signature · 1 line
2.20.1.7.g153144c
author
#1 lore raw

PATCH 1/3 net: hv_netvsc: Remove duplicated include in rndis_filter.c

./drivers/net/hyperv/rndis_filter.c: linux/slab.h is included more than once.

---
 drivers/net/hyperv/rndis_filter.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/hyperv/rndis_filter.c +0 -1
index af95947a87c5..ecc2128ca9b7 100644
@@ -21,7 +21,6 @@
 #include <linux/rtnetlink.h>
 #include <linux/ucs2_string.h>
 #include <linux/string.h>
-#include <linux/slab.h>
 
 #include "hyperv_net.h"
 #include "netvsc_trace.h"
Signature · 1 line
2.20.1.7.g153144c
author
#2 lore raw

PATCH 2/3 tools: ynl: Remove duplicated include in handshake-user.c

In reply to Yang Li

./tools/net/ynl/generated/handshake-user.c: stdlib.h is included more than once.

---
 tools/net/ynl/generated/handshake-user.c | 1 -
 1 file changed, 1 deletion(-)
tools/net/ynl/generated/handshake-user.c +0 -1
index fe99c4ef7373..7a1f0364b88f 100644
@@ -8,7 +8,6 @@
 #include "ynl.h"
 #include <linux/handshake.h>
 
-#include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
 #include <libmnl/libmnl.h>
Signature · 1 line
2.20.1.7.g153144c
#3 lore raw
In reply to Yang Li
This series was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:

Hello:

This series was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:

Quoted 8 lines · On Fri, 9 Jun 2023 16:52:47 +0800 you wrote:

./tools/net/ynl/generated/devlink-user.c: stdlib.h is included more than once.

---
 tools/net/ynl/generated/devlink-user.c | 1 -
 1 file changed, 1 deletion(-)

Here is the summary with links:
- [net-next,3/3] tools: ynl: Remove duplicated include in devlink-user.c (no matching commit)
- [net-next,2/3] tools: ynl: Remove duplicated include in handshake-user.c

    https://git.kernel.org/netdev/net-next/c/e7c5433c5aaa

- [net-next,1/3] net: hv_netvsc: Remove duplicated include in rndis_filter.c (no matching commit)

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#4 lore raw
In reply to Yang Li

tools/net/ynl/generated/devlink-user.c

Quoted 13 lines · Fri, Jun 09, 2023 at 10:52:47AM CEST, [email protected] wrote:

./tools/net/ynl/generated/devlink-user.c: stdlib.h is included more than once.

---
tools/net/ynl/generated/devlink-user.c | 1 -

1 file changed, 1 deletion(-)
tools/net/ynl/generated/devlink-user.c +0 -0
index c3204e20b971..18157afd7c73 100644

You are patching generated file, as the path suggests. See what the file header says:
/* Do not edit directly, auto-generated from: */
/* Documentation/netlink/specs/devlink.yaml */

Quoted 12 lines
tools/net/ynl/generated/devlink-user.c +0 -1
@@ -8,7 +8,6 @@
 #include "ynl.h"
 #include <linux/devlink.h>
 
-#include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
 #include <libmnl/libmnl.h>
Signature · 1 line
2.20.1.7.g153144c
maintainer
#5 lore raw
Quoted 4 lines · On Fri, 9 Jun 2023 13:38:21 +0200 Jiri Pirko wrote:

You are patching generated file, as the path suggests. See what the file header says:
/* Do not edit directly, auto-generated from: */
/* Documentation/netlink/specs/devlink.yaml */

And the full fix is already on the list :(
https://lore.kernel.org/all/[email protected]/
Reverted...