Skip to contentSkip to conversation

net: cpsw: increase a delay before reading the ALIVE register

PATCH Applied [email protected] 2 participants 2 messages Jun 9, 2023 – Jun 12, 2023 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: cpsw: increase a delay before reading the ALIVE register

From: Yegor Yefremov <[email protected]>

At leasr am335x, the delay is not enough to reliably detect all PHYs. Hence, increase the timeout.

Tested with the followings PHYs:

- MotorComm YT8511
- Atheros AT8035
- CPlus IP101A

---
 drivers/net/cpsw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/cpsw.c +1 -1
index 0449240f98..fdf6ff1e8e 100644
@@ -620,7 +620,7 @@ static int cpsw_mdio_probe(struct device *dev)
 	 * silicon.  Since the effect of (b) was found to be largely
 	 * negligible, we keep things simple here.
 	 */
-	udelay(1000);
+	udelay(2000);
 
 	start = get_time_ns();
 	while (1) {
Signature · 1 line
2.34.1
Applied
#1 lore raw
Quoted 7 lines · On Fri, Jun 09, 2023 at 11:02:17AM +0200, [email protected] wrote:

From: Yegor Yefremov <[email protected]>

At leasr am335x, the delay is not enough to reliably detect all PHYs. Hence, increase the timeout.

Tested with the followings PHYs:

Quoted 8 lines

- MotorComm YT8511
- Atheros AT8035
- CPlus IP101A

---
 drivers/net/cpsw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

Quoted 19 lines
drivers/net/cpsw.c +1 -1
index 0449240f98..fdf6ff1e8e 100644
@@ -620,7 +620,7 @@ static int cpsw_mdio_probe(struct device *dev)
 	 * silicon.  Since the effect of (b) was found to be largely
 	 * negligible, we keep things simple here.
 	 */
-	udelay(1000);
+	udelay(2000);
 
 	start = get_time_ns();
 	while (1) {
Signature · 1 line
2.34.1
Signature · 4 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |